| bryceh | would someone mind looking at this MP? https://code.edge.launchpad.net/~bryceharrington/launchpad/lp-253509/+merge/25655 | 02:08 |
|---|---|---|
| mwhudson | bryceh: the format of the docstring you've changed is wrong and there are no tests | 02:09 |
| bryceh | hrm, nevermind I guess | 02:22 |
| === Ursinha is now known as Ursinha-afk | ||
| === jelmer changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === noodles775 changed the topic of #launchpad-reviews to: On Call: jelmer, noodles || reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| thumper | jml: up for a relatively simple review | 10:15 |
| thumper | ? | 10:15 |
| thumper | jml: package branch related | 10:15 |
| jml | thumper: sure. | 10:15 |
| thumper | https://code.edge.launchpad.net/~thumper/launchpad/package-branch-edit-owner/+merge/25291 | 10:15 |
| jml | thumper: we should delete 'make_erics_fooix_project' some time :) | 10:16 |
| thumper | jml: I think it is used in a test somewhere | 10:17 |
| thumper | jml: it was also useful in make harness | 10:17 |
| thumper | to get some more sample data | 10:17 |
| thumper | although... | 10:17 |
| thumper | we chould just update the sample data that is used interactively | 10:18 |
| jml | thumper: that second case feels like it should be something separate | 10:18 |
| jml | thumper: reviewed | 10:28 |
| jml | thumper: sorry it took so long – I'm getting rusty | 10:28 |
| thumper | jml: thanks | 10:28 |
| henninge | danilos, danilo_: https://code.edge.launchpad.net/~henninge/launchpad/bug-581746-serialization-error/+merge/25623 | 12:26 |
| danilo_ | henninge, henninge_: thanks | 12:31 |
| danilo_ | henninge, r=danilo | 12:32 |
| === mrevell is now known as mrevell-lunch | ||
| === jelmer is now known as Guest38382 | ||
| === Guest38382 is now known as jelmer | ||
| === mrevell-lunch is now known as mrevell | ||
| === Ursinha-afk is now known as Ursinha | ||
| adiroiban | henninge: hi. have you sent my branch to landing, or is there something I need to do? | 14:04 |
| adiroiban | I had the same problems with the branch for bug 561586, which was only about moving some files. | 14:04 |
| mup | Bug #561586: Move javascript code to lp.app directories <javascript> <qa-ok> <tech-debt> <Launchpad Foundations:Triaged> <Launchpad Registry:Fix Committed by bac> <Launchpad Bugs:Triaged> <Launchpad Translations:Fix Committed by adiroiban> <Soyuz:Triaged> <https://launchpad.net/bugs/561586> | 14:04 |
| adiroiban | Windmill test were randomly failing on my test machine but it look like it passed the official landing test | 14:05 |
| EdwinGrubbs | BjornT, do you have any further comments for https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part1/+merge/25359 | 14:52 |
| BjornT | EdwinGrubbs: well, i guess the db patch is fine. you should have a talk with deryck, as to whether include private bugs in the count, since that might not be desired. also talk to him about how to keep the bug heat values up-to-date | 14:54 |
| BjornT | EdwinGrubbs: doing it in addTask() only won't be enough | 14:55 |
| EdwinGrubbs | ok, will do | 14:55 |
| EdwinGrubbs | stub, can you review this db patch? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part1/+merge/25359 | 14:56 |
| EdwinGrubbs | deryck, ping | 14:57 |
| deryck | Hi EdwinGrubbs | 14:57 |
| deryck | EdwinGrubbs, I can look at the MP in about 5 minutes or so (if your ping is related to BjornT's comments) :-) | 14:58 |
| EdwinGrubbs | deryck, yes, that's it. I'll wait. | 14:58 |
| stub | EdwinGrubbs: done. Its annoying having all these max_bug_heat columns everywhere, but I can't come up with a saner model at the moment. | 15:04 |
| === noodles775 changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | thanks | 15:11 |
| === adiroiban changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: || queue: [adiroiban(bug-561586-take-2)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: adiroiban(bug-561586-take-2) || queue: || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: || queue: || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| deryck | EdwinGrubbs, looking at your mp.... max_bug_heat didn't exist on distributionsourcepackage initially? | 15:46 |
| deryck | EdwinGrubbs, need to break for eating before last half of day starts. Will catch up after that. | 15:59 |
| === deryck is now known as deryck[lunch] | ||
| EdwinGrubbs | deryck[lunch], max_bug_heat did exist before on DSP. It's already used in HasBugHeatMixin.setMaxBugHeat(). | 16:01 |
| deryck[lunch] | EdwinGrubbs, ah, didn't see that schema was commented out. I see now. Will follow up more shortly. Was just curious about that. | 16:03 |
| adiroiban | jelmer: thanks for the review. Can you please send the branch to ec2-test ? | 16:05 |
| jelmer | adiroiban: noodles has sent it off to ec2 | 16:05 |
| adiroiban | thanks! | 16:05 |
| === deryck[lunch] is now known as deryck | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: || queue: || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado-lunch is now known as salgado | ||
| === gary_poster is now known as gary-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === gary-lunch is now known as gary_poster | ||
| salgado | bac, around? | 20:02 |
| bac | hi salgado | 20:02 |
| salgado | hi there | 20:02 |
| salgado | I've talked to my new manager and we've agreed that it's not a good idea for me to keep my OCR duties on this new position. is that ok with you? | 20:03 |
| salgado | I'll try to do reviews when I can, but right now I don't think I can commit one day a week to it | 20:04 |
| bac | salgado: i've already removed you from the schedule...just assumed you would not be reviewing | 20:04 |
| bac | salgado: thanks for bringing it up | 20:04 |
| salgado | oh, cool. didn't notice you'd removed me. thanks. :) | 20:04 |
| salgado | bac, if you notice people overloaded in a specific day, please let me know and I'll arrange to give them some help | 20:05 |
| bac | wow, thanks a lot salgado. i'll keep that in mind but sure try not to abuse it. | 20:05 |
| salgado | bac, please do (keep it in mind, I mean). we expect to still be doing some Launchpad work, and everyone seems to agree it's a good idea to keep doing some reviews as well. :) | 20:07 |
| bac | nice | 20:07 |
| bac | hi rockstar, time for a quick review? | 20:10 |
| bac | sinzui, rockstar must be out to lunch, would you mind doing the review for https://code.edge.launchpad.net/~bac/launchpad/bug-520476/+merge/25713 | 20:12 |
| sinzui | I'll take it | 20:12 |
| bac | thx | 20:12 |
| bac | i don't think you'll break a sweat | 20:12 |
| rockstar | bac, sorry, was eating food out the back of a truck... | 20:40 |
| bac | rockstar: food from a truck should always take precedence | 20:40 |
| bac | rockstar: in durham there is now a korean BBQ truck. i may have to take an extra long lunch some day soon | 20:41 |
| bac | rockstar: weren't you anti-food-truck not long ago? | 20:41 |
| rockstar | bac, no, not at all. | 20:41 |
| bac | i seem to recall you making fun of my love of taco trucks | 20:42 |
| rockstar | bac, there are two things I LOVE out the back of a truck: mexican food and bbq. | 20:42 |
| bac | i want to hire one for a party | 20:42 |
| bac | can't decide between a taco truck and the crepe truck | 20:42 |
| rockstar | I especially like the ones that run out of food. I feel like I'm getting something rare. | 20:43 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === matsubara is now known as matsubara-afk | ||
| adiroiban | rockstar: Hi. Do you have time for an UI pre-implementation review for bug 512133 ? It is not urgent. | 22:29 |
| mup | Bug #512133: Make template description visible to translators <Launchpad Translations:Triaged> <https://launchpad.net/bugs/512133> | 22:29 |
| rockstar | adiroiban, I'm on the phone now, but I can look at it afterwards. | 22:29 |
| adiroiban | ok | 22:29 |
| thumper | flacoste: https://code.edge.launchpad.net/~thumper/launchpad/bug-linkification/+merge/25488 | 23:19 |
| thumper | flacoste: can I get a general approval? | 23:19 |
| thumper | flacoste: and I'll fix the conflicts | 23:19 |
| === salgado is now known as salgado-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!