=== matsubara-afk is now known as matsubara
=== matsubara is now known as matsubara-afk
[05:06] <rockstar>  thumper around?
[05:06] <thumper> aye
[05:06] <rockstar> thumper, can I get a code review for https://code.edge.launchpad.net/~rockstar/launchpad/remove-sourcepackage-from-recipe/+merge/25809 ?
[05:06] <rockstar> It has it's two db reviews
[05:07] <thumper> ok
[05:23] <thumper> rockstar: done
=== mrevell is now known as mrevell-lunch
=== henninge changed the topic of #launchpad-reviews to: On Call: henninge  || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell-lunch is now known as mrevell
=== gmb changed the topic of #launchpad-reviews to: On Call: henninge, gmb  || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:01] <gmb> Hi henninge.
[14:01]  * gmb keeps forgetting he's on the rota again 
[14:02] <henninge> Hi gmb! ;)
[14:02] <henninge> bac and I never finished that conversation about changing my slot, so I am still here ;-)
[14:07] <gmb> :)
=== sinzui changed the topic of #launchpad-reviews to: On Call: henninge, gmb  || reviewing: sinzui || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:37] <sinzui> henninge, gmb, I just added a trivial branch the to review queue
[15:38] <gmb> sinzui, I'll take a look shortly; otp atm
=== gmb changed the topic of #launchpad-reviews to: On Call: henninge, gmb  || reviewing: sinzui, sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:47] <gmb> sinzui, The over-and-over branch, right?
[15:50] <sinzui> gmb, yes
[15:54] <gmb> sinzui, r=me
=== gmb changed the topic of #launchpad-reviews to: On Call: henninge, gmb  || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:55] <sinzui> fab
=== salgado is now known as salgado-lunch
[16:47] <adeuring> gmb, henninge: could you please review this MP: https://code.edge.launchpad.net/~adeuring/launchpad/bug-511269/+merge/25971 ? (sorry, more than 900 lines...)
[16:47] <gmb> adeuring, Sure, I'll take a look
[16:47] <adeuring> gmb: thanks!
=== gmb changed the topic of #launchpad-reviews to: On Call: henninge, gmb  || reviewing: sinzui, adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
=== Ursinha is now known as Ursinha-lunch
[17:30] <henninge> sinzui: review sent
[17:30] <sinzui> thank
=== henninge changed the topic of #launchpad-reviews to: On Call: gmb  || reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:34] <gmb> adeuring, r=me; nice work!
[17:34] <adeuring> gmb: thanks!
=== gmb changed the topic of #launchpad-reviews to: On Call: -  || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:45] <adeuring> gmb: could you please update the MP?
[17:47] <gmb> adeuring, Bugger. Yes, sorry.
[17:47] <adeuring> gmb: ;) thanks!
[17:47] <gmb> adeuring, Done.
=== salgado-lunch is now known as salgado
[18:06] <adiroiban> danilos: did you have time to take another look at the POTemplate API branch and send it to ec2-test?
[18:06] <danilos> adiroiban, sorry, no
[18:09] <adiroiban> danilos: ok. and will you have time to discuss the pre-implementation details for bug 583934 and bug 583979 ? Not now, but before the start of June :)
[18:09] <mup> Bug #583934: API for POFile attributes <api> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/583934>
[18:13] <danilos> adiroiban, yeah, I should have some time later this week
[18:14] <adiroiban> danilos: ok. just poke me when you have time . For both bugs I have added comments or pushed/attached a branch containing some ideas of how I see this can be done.
[18:14] <mars> abentley, ping
[18:16] <danilos> adiroiban, sure
[18:18] <mars> abentley, unping
=== Ursinha-lunch is now known as Ursinha
=== ajmitch_ is now known as ajmitch
=== kiko is now known as kiko-afk
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
=== kiko-afk is now known as kiko