[07:48] <jtv> good morning adeuring!  Any chance I could bother you for a review that didn't make it through the queue last night?  https://code.launchpad.net/~jtv/launchpad/bug-409686/+merge/26179
[07:48] <adeuring> jtv: sure
[07:48] <jtv> adeuring: wonderful, thanks!
[08:37] <adeuring> jtv: r=me
[08:37] <jtv> adeuring: thanks!
[08:38] <jtv> adeuring: good point on the LOGIN... how about USERNAME?
[08:38] <adeuring> jtv: right, that looks much nicer!
[08:38] <jtv> Oh
[08:38] <jtv> idea
[08:39] <jtv> No wait, no idea.
[08:39] <jtv> Capital letters are the only good way I can think of there to say "this isn't literal"
[08:39] <jtv> I thought of using quotes, but that may be confusing because the instructions do contain a quoted string.  So the quotes would have different meanings.
[08:40] <adeuring> right. BTW, how do we handle these "placeholders" elsewhere?
[08:45] <jtv> Well ideally, it'd be nice if I could fill in the real username there.  But the message may be going out to teams.
[08:51] <adeuring> jtv: We know the LP user when we generate the email, don't we? So, can't we simply insert his login name?
[08:52] <jtv> Hmm...  I'd have to iterate over the team if there was one, I guess.
[08:53] <jtv> How about I file a bug for it as a separate job?
[08:53] <adeuring> jtv: Ah, OK. So, let's leave it as it is
[09:02] <jtv> hey danilos
[09:02] <danilos> jtv, hey
[10:21] <adeuring> StevenK: I can review your branch if you show me where I can find it
[10:21] <StevenK> adeuring: Sure -- https://code.edge.launchpad.net/~stevenk/launchpad/poppy-sftp-updates/+merge/26279
[10:22] <StevenK> Wow. Was it that bad ...
[10:46] <adeuring> StevenK: your branch screams for a few tests ;) For example, it is great that you added the missing "import FileIsADirectory" but the fact that this was not spotted earlier is a clear indication that SFTPFile.writeChunk(9 is not properly tested.
[10:53] <StevenK> adeuring: Right, I'm writing a test for that now.
[10:53] <adeuring> StevenK: great, thanks!
[10:54] <adeuring> StevenK: similary, would you mind to add tests for the constructor of class Hooks?
[10:57] <adeuring> StevenK: well, actually, you are testing that Hooks() accepts the prefix parameter, but could you add a test thats ensures that it is used in the filename?
[10:59]  * adeuring needs a better mental OCR algorithm
[10:59] <adeuring> I misread "twisted" for 2test"....
[13:31] <StevenK> adeuring: If you're still here, I'll be pushing the test fixes to my branch in a few minutes.
[13:31] <adeuring> StevenK: sure, go ahaed
[13:38] <StevenK> adeuring: Pushed.
[13:38]  * adeuring is looking
[13:48] <adeuring> StevenK: thanks for the new tests! r=me
[13:50] <StevenK> adeuring: Thanks for the review :-)
[13:55] <sinzui> StevenK, what are the consequences of landing after the release?
[14:32] <StevenK> sinzui: You'd prefer to have this land as a CP?
[14:32] <sinzui> I just want to understand the urgency.
[14:33] <StevenK> sinzui: It has a feature that Julian thinks is fairly important, but if you'd rather it was CP'd, that's okay too.
[14:35] <sinzui> okay, you have my RC on contingent you update the XXX comment
[14:36] <StevenK> Which one?
[14:37] <sinzui> 51 # XXX: Eww bug=586695
[14:37] <StevenK> Ah. You'd prefer something more descriptive? :-)
[14:40] <StevenK> sinzui: Done, and pushed.
[14:40] <sinzui> thanks
[14:43] <StevenK> sinzui: Fixed harder, based on your XXX style comment. Anyway, throwing it through ec2
[14:44] <sinzui> well. I have no confidence in ec2 in the moment. I think your changes are isolated so your own testing gives me more confidence.
[14:45] <StevenK> Poor ec2. What did it ever do to deserve such .... Oh. Never mind. :-P
[14:45] <StevenK> sinzui: I'm happy to pqm-submit, but I have not run the entire test suite over the code.
[14:45] <sinzui> lets use ec2
[14:48] <StevenK> sinzui: Mind you, I share your vote of no confidence.
[15:05] <adeuring> sinzui: i tried this morning to find an MP from you but couldn't find any
[15:06] <sinzui> adeuring, there was confusion yesterday and my name appears to have been added back. I have no branches thanks.
[15:06] <adeuring> sinzui: ah, ok