=== matsubara-afk is now known as matsubara
=== matsubara is now known as matsubara-afk
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:37] <adeuring> gmb: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-586808/+merge/26480 ?
[11:37] <gmb> adeuring, Sure
[11:37] <adeuring> thanks!
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb || reviewing: adeuring || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:43] <gmb> adeuring, I think the description of the new status could be rephrased. How about something like: "The bug remains open for discussion only. This status is usually used where there is disagreement over whether the bug is relevant to the current target and whether it should be fixed."
[11:44] <gmb> adeuring, I'm also assuming that the work for ACL'ing the OPINION status so that it can't be unset except by the bug supervisor is going to happen in another branch (or not at all; I haven't been keeping up with the LEP on this)
[11:49] <adeuring> gmb: thanks for the suggestion for the description! In a discussion with deryck we decided to _not_ ACL the status
[11:50] <gmb> adeuring, Righto. r=me with that change, then.
[11:50] <adeuring> we think it is better to see if people will really accep the new status when everybody can change it.
[11:50] <adeuring> gmb: thanks!
[11:50] <gmb> Agreed.
=== matsubara-afk is now known as matsubara
=== Ursinha_ is now known as Ursinha
[13:53] <matsubara> gmb, hi
[13:53] <matsubara> gmb, can you review a RC candidate for me: https://code.launchpad.net/~matsubara/launchpad/bug-504124-oops-handling-email/+merge/26457?
[13:59] <gmb> matsubara, Sure
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb || reviewing: matsubara || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:00] <matsubara> thanks gmb
=== NCommand1r is now known as mcasadevall
[14:04] <gmb> matsubara, r=me
[14:04] <matsubara> gmb, thank you!
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: On Call: gmb, bac || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:30] <bac> good morning gmb.  just like old times!
[14:31] <gmb> bac, Indeed :)
=== henninge_ is now known as henninge
=== mcasadevall is now known as NCommander
=== noodles775 changed the topic of #launchpad-reviews to: On Call: gmb, bac || reviewing: - || queue: [noodles] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:35] <noodles775> Hi guys... not an RC, but when you've time: https://code.edge.launchpad.net/~michael.nelson/launchpad/588288-log-parser-dont-read-entire-file/+merge/26498
[15:44] <noodles775> gmb, bac: I'll be around for another hr if you want ask any questions, otherwise, do you mind doing it non-interactive?
[15:45] <gmb> noodles775, Sure, no problem. I'll take a look presently.
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb, bac || reviewing: noodles775, - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:45] <noodles775> Thanks gmb.
[15:59] <gmb> noodles775, Is 10000 an arbitrary value? (I'm assuming that won't cause any problems, but it's worth asking)
[16:02] <noodles775> gmb: yes, it's arbitrary - it won't even be set in lp-production-configs initially (we'll add it for one machine, germanium).
[16:02] <gmb> noodles775, Fair enough. r=me
[16:02] <noodles775> Thanks gmb.
=== deryck is now known as deryck[lunch]
[16:27] <abentley> rockstar, would you mind doing some reviews for me?
=== Ursinha is now known as Ursinha-lunch
=== gary_poster is now known as gary-lunch
=== deryck[lunch] is now known as deryck
[17:12] <leonardr> gmb, bac, a non-urgent branch for you to review
[17:12] <leonardr> https://code.edge.launchpad.net/~leonardr/launchpad/test-representation-cache/+merge/26513
=== gmb changed the topic of #launchpad-reviews to: On Call: gmb, bac || reviewing: -, - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:13] <gmb> bac, Fancy taking leonardr's branch? It's quite close to EOD for me now.
[17:15] <rockstar> abentley, shoot, didn't see your pings. Yes, yes I an.
=== salgado is now known as salgado-lunch
=== gmb changed the topic of #launchpad-reviews to: On Call: bac || reviewing:  - || queue: [leonardr] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:20] <gmb> leonardr, I've put your branch in the queue for when bac returns.
[17:20] <leonardr> gmb, tx
=== matsubara is now known as matsubara-lunch
=== gary-lunch is now known as gary_poster
=== matsubara-lunch is now known as matsubara
[18:50] <bac> hi leonardr, i'll look at your branch now.
=== bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: leonardr || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[18:51] <leonardr> bac, thanks
=== salgado-lunch is now known as salgado
[19:07] <abentley> rockstar, could you review https://code.edge.launchpad.net/~abentley/launchpad/daily-builds/+merge/26232 ?
[19:08] <rockstar> abentley, ack. On it.
[19:08] <abentley> rockstar, thanks.
=== leonardr is now known as leonardr-afk
=== Ursinha-lunch is now known as Ursinha
[20:02] <abentley> bac, could you review https://code.launchpad.net/~abentley/launchpad/poppy-isolation/+merge/26531 please?
[20:03] <bac> abentley: sure
=== abentley changed the topic of #launchpad-reviews to: On Call: bac || reviewing: leonardr || queue: [abentley] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[20:05] <bac> abentley: done
=== bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: - || queue: [-] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[20:11] <abentley> bac, thanks.
=== leonardr-afk is now known as leonardr
[21:42] <abentley> bac, could you please review https://code.launchpad.net/~abentley/launchpad/binary-to-recipe/+merge/26537 ?
=== matsubara is now known as matsubara-afk
=== bac changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [-] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-afk