| === Ursinha is now known as Ursinha-afk | ||
| === jtv changed the topic of #launchpad-reviews to: On Call: jtv || reviewing: - || queue: [-] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jtv is now known as jtv-eat | ||
| === jtv-eat is now known as jtv | ||
| === matsubara-afk is now known as matsubara | ||
| === henninge_ is now known as henninge | ||
| === Ursinha-afk is now known as Ursinha | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On Call: jtv, Edwin || reviewing: - || queue: [-] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === Ursinha is now known as Ursinha-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado-lunch is now known as salgado | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === matsubara-lunch is now known as matsubara | ||
| === jtv changed the topic of #launchpad-reviews to: On Call: Edwin || reviewing: - || queue: [-] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | Quiet day! | 18:00 |
|---|---|---|
| leonardr | gary, when you get back, take a look at my tiny testfix branch https://code.edge.launchpad.net/~leonardr/lazr.restful/disable-cache/+merge/26612 | 18:05 |
| === leonardr is now known as leonardr-afk | ||
| === deryck[lunch] is now known as deryck | ||
| gary_poster | leonardr-afk: looking | 18:41 |
| gary_poster | leonardr-afk: I'm concerned about the ForbiddenAttribute. Generally, that shouldn't happen, and its presence suggests a programming or configuration error. Ping me when you return and let's talk about it. | 18:43 |
| === leonardr-afk is now known as leonardr | ||
| leonardr | gary, i'm back | 18:45 |
| gary_poster | ok cool | 18:45 |
| leonardr | it's quite possible there's a programming error in that example service | 18:45 |
| leonardr | i'll give you details in a bit | 18:45 |
| gary_poster | ok | 18:45 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| leonardr | gary: it's the example in src/lazr/restful/examples/multiversion | 18:51 |
| gary_poster | k | 18:51 |
| leonardr | gary: no, wait | 18:51 |
| leonardr | it's actually the example defined entirely within src/lazr/restful/doc/multiversion.txt | 18:52 |
| gary_poster | k, updating for a look | 18:52 |
| leonardr | hmm.. it may not be permission related at all, feel free to do something else while i hash this out | 18:52 |
| leonardr | gary: yes, the problem is that the underlying field is 'phone_number' but the name for it in one version is 'phone' | 19:06 |
| gary_poster | leonardr: ok...is this fixable in some reasonable way then, other than adding ForbiddenAttribute to the list of caught exceptions? | 19:09 |
| leonardr | well, i can catch the exception and fall back to getattr | 19:09 |
| leonardr | or i can add the 'original_name' tag to the appropriate field in multiversion.txt | 19:10 |
| leonardr | i don't know which one makes more sense. if people were going around all the time writing their own custom Entry classes, then catching the exception would make more sense | 19:10 |
| gary_poster | leonardr: Is it reasonable to add original_name? Will it always be around? | 19:11 |
| gary_poster | I would prefer that solution | 19:11 |
| leonardr | that's just the thing--if you write your own entry class, it won't be around | 19:11 |
| gary_poster | if it...makes sense in reality | 19:11 |
| gary_poster | Should we make that a requirement for your own entry class? | 19:11 |
| leonardr | maybe. let me hack it in and see how difficult it is | 19:12 |
| gary_poster | ok | 19:12 |
| abentley | rockstar, the other reviews I'd like you to do are: https://code.edge.launchpad.net/~abentley/launchpad/daily-builds-score/+merge/26247, https://code.edge.launchpad.net/~abentley/launchpad/daily-builds-ui/+merge/26334 and https://code.edge.launchpad.net/~abentley/launchpad/daily-builds-api/+merge/26335 | 19:51 |
| rockstar | abentley, cool. OTP right now, will get to them when I'm off. | 19:51 |
| abentley | rockstar, ty. | 19:51 |
| abentley | rockstar, I took your advice and merged db-devel. This has probably ruined the diffs. | 19:52 |
| rockstar | abentley, oh shite, I didn't even think about that. | 19:52 |
| rockstar | abentley, I guess I'll merge into db-devel and look at the patch there. | 19:53 |
| abentley | Edwin-lunch, could you please review https://code.edge.launchpad.net/~abentley/launchpad/binary-to-recipe/+merge/26537 ? | 20:27 |
| Edwin-lunch | abentley, sure | 20:29 |
| abentley | Edwin-lunch, thanks. | 20:29 |
| === abentley changed the topic of #launchpad-reviews to: On Call: Edwin || reviewing: - || queue: [abentley] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On Call: Edwin || reviewing: abentley || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | abentley, r=me | 21:38 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On Call: Edwin || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!