| === Ursinha is now known as Ursinha-afk | ||
| === jelmer_ changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | jelmer, Hi. Could you review https://code.edge.launchpad.net/~gmb/launchpad/remove-calculatebugheatjob-bug-588186/+merge/26684 for me? It's a branch made entirely of removals. | 11:55 |
|---|---|---|
| jelmer_ | gmb: yeah, np | 11:57 |
| === gmb changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: - || queue: [gmb] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | jelmer_, Thanks | 11:57 |
| === jelmer_ changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: gmb || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer_ changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: abentley || queue: [abentley*3] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jelmer_ is now known as jelmer-lunch | ||
| === jtv1 is now known as jtv | ||
| abentley | jelmer, do you really want to re-review https://code.launchpad.net/~abentley/launchpad/daily-builds-api/+merge/26335 after I make those corrections? | 15:46 |
| jelmer | abentley: no, there's no need for that - did I vote Needs Fixing? | 15:47 |
| abentley | jelmer, no, you didn't vote. | 15:47 |
| jelmer | abentley: ah, I remember now - I was going to look at the other mps first since it seemed to depend on those | 15:47 |
| abentley | jelmer, ah. You'll want to start with daily-builds-score, then. | 15:48 |
| abentley | jelmer, but it's based on daily-builds, which is already approved. | 15:48 |
| leonardr | jelmer, can you add https://code.edge.launchpad.net/~leonardr/lazr.restful/disable-cache/+merge/26713 to your abentley-ful queue? | 15:51 |
| jelmer | leonardr: yeah, np. I'm almost done with Aaron's branches anyway. | 15:52 |
| leonardr | ok | 15:52 |
| === jelmer changed the topic of #launchpad-reviews to: On Call: jelmer || reviewing: abentley || queue: [abentley*3,leonardr] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | jelmer: and don't worry about requesting the mentor review. I'll bring up the fact that you're now graduated at the next reviewers meeting :) | 16:13 |
| jelmer | noodles775: thanks :-) | 16:24 |
| deryck | Hi jelmer. I have a branch for review. Should I add to the queue or cast about for someone else? | 16:34 |
| jelmer | deryck: Hi; it's probably best to check with the next reviewer | 16:51 |
| deryck | jelmer, ok, cool. will do. thanks | 16:56 |
| abentley | jelmer, you and rockstar seem to be racing. | 16:58 |
| rockstar | abentley, I didn't grab that last one because I saw jelmer had claimed it. | 16:59 |
| rockstar | abentley, the diffs I had made were horrible... | 16:59 |
| abentley | rockstar, jelmer wanted to look at the other ones first. | 16:59 |
| rockstar | abentley, ah, okay. | 16:59 |
| rockstar | abentley, I think that's a good idea. | 16:59 |
| abentley | jelmer, ping? | 17:00 |
| jelmer-lunch | abentley: pong | 17:03 |
| === jelmer-lunch is now known as jelmer_ | ||
| jelmer_ | argh, obviously I was long back from lunch :-) | 17:03 |
| abentley | jelmer, rockstar has reviewed all the other proposals. Do you want to do the API branch or should he? | 17:03 |
| jelmer_ | abentley: I'll approve, one sec | 17:04 |
| jelmer_ | deryck: Looks like I'll have time to look at your branch after all. | 17:07 |
| deryck | jelmer_, thanks! https://code.edge.launchpad.net/~deryck/launchpad/too-much-dupe-email-noise-418659/+merge/26716 | 17:09 |
| === gary_poster is now known as gary_lunch | ||
| rockstar | jelmer, does the queue reflect reality? | 17:37 |
| rockstar | On Call: jelmer, rockstar || reviewing: abentley, - || queue: [abentley*3,leonardr] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | 17:37 |
| === jelmer_ changed the topic of #launchpad-reviews to: On Call: || reviewing: deryckh || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jelmer_ | rockstar: sorry, should be up to date now | 17:40 |
| rockstar | jelmer_, thanks. | 17:40 |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: deryckh || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | deryck, your branch, I am reviewin' it. | 17:40 |
| rockstar | jelmer_, wait, are you doing deryck's review? | 17:41 |
| jelmer | rockstar: yes, I'm reviewing it | 17:42 |
| rockstar | jelmer, okay. | 17:43 |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | jelmer, are you doing my lazr.restful review or should i ask rockstar? | 17:50 |
| leonardr | rockstar, i also have a launchpad branch based on that lazr.restful branch that needs review | 17:53 |
| leonardr | https://code.edge.launchpad.net/~leonardr/launchpad/toggle-representation-cache/+merge/26725 | 17:53 |
| jelmer | leonardr: I thought rockstar already reviewed it | 17:53 |
| leonardr | https://code.edge.launchpad.net/~leonardr/lazr.restful/disable-cache/+merge/26713 is still pending | 17:53 |
| leonardr | earlier i may have given you the wrong url, to a branch that was already reviewed, or something | 17:54 |
| jelmer | leonardr: I didn't see it on the +activereviews page anymore | 17:54 |
| jelmer | leonardr: I'm reviewing it now. | 17:54 |
| leonardr | thanks | 17:54 |
| === gary_lunch is now known as gary_poster | ||
| deryck | thanks for the review jelmer! I agree the param in the docstring would be nice and will add that. | 18:04 |
| === deryck is now known as deryck[lunch] | ||
| jelmer | leonardr: r=me | 18:20 |
| leonardr | great | 18:20 |
| gary_poster | jelmer: hey. I'm on CHR, but will try to get your reviews in too. Why didn't your Launchpad branch actually remove canonical.uuid instead of the .THIS thing? | 18:36 |
| jelmer | gary_poster: Thanks | 18:37 |
| jelmer | gary_poster: Let me have a look, I think something might've gone wrong there | 18:37 |
| gary_poster | ok | 18:37 |
| === salgado is now known as salgado-afk | ||
| leonardr | jelmer, i'm happy that you reviewed my launchpad branch but the one i asked you to review was the lazr.restful branch it uses https://code.edge.launchpad.net/~leonardr/lazr.restful/disable-cache | 19:13 |
| leonardr | compounding the confusion, i merged that branch after you said r=me because i thought you'd reviewed that one | 19:13 |
| leonardr | but if you or rockstar could take a look the damage should be minimal | 19:13 |
| === deryck[lunch] is now known as deryck | ||
| leonardr | rockstar, i've also put up a couple new revisions of https://code.edge.launchpad.net/~leonardr/launchpad/toggle-representation-cache/+merge/26725 that need review | 19:38 |
| rockstar | leonardr, great, looking now | 20:17 |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: leonardr || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | leonardr, what's __storm_flushed__ ? | 20:44 |
| leonardr | rockstar, that's a hook method called whenever a storm object is written to the database | 20:44 |
| rockstar | leonardr, neato. | 20:44 |
| rockstar | leonardr, so, it looks like jelmer has already Approved this. | 20:45 |
| leonardr | rockstar: yes, what i need is reviews of the post-jelmer revisions | 20:46 |
| leonardr | i can paste a diff if you want | 20:46 |
| rockstar | leonardr, oh, is there that much difference? | 20:46 |
| leonardr | i added a minor new feature | 20:46 |
| leonardr | see my last comment on https://code.edge.launchpad.net/~leonardr/launchpad/toggle-representation-cache/+merge/26725 | 20:47 |
| rockstar | leonardr, I'll just look at the whole diff. | 20:47 |
| leonardr | ok, cool | 20:47 |
| rockstar | leonardr, I think gary/mars is better to ask about Memcache. I think there's actually a MemcacheLayer | 20:58 |
| gary_poster | yeah, there is | 20:59 |
| leonardr | rockstar: the test runs in the memcache layer | 21:01 |
| rockstar | leonardr, yeah, I see that. | 21:02 |
| leonardr | you relaly don't need to review that whole diff unless you want to. it's already been reviewed (in different parts) by jelmer, stub, and bac | 21:02 |
| leonardr | i just need a review of the expiration time thing | 21:02 |
| rockstar | leonardr, done. | 21:04 |
| leonardr | thanks | 21:04 |
| === rockstar changed the topic of #launchpad-reviews to: On Call: - || reviewing: || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | thumper, https://code.edge.launchpad.net/~rockstar/launchpad/fix-broken-recipes/+merge/26757 | 23:49 |
| thumper | done | 23:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!