| === stub1 is now known as stub | ||
| === stub1 is now known as stub | ||
| === adeuring changed the topic of #launchpad-reviews to: On Call: adeuring || reviewing: || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | hi adeuring | 14:37 |
|---|---|---|
| adeuring | hi bac! | 14:37 |
| bac | adeuring: how much longer are you around here today? | 14:37 |
| adeuring | until 1700UTC or so | 14:38 |
| adeuring | bac doy ou need an urgent review later toady? | 14:38 |
| bac | adeuring: ok. would you mind pinging me just before checking out? i'm OCR and CHR today so i'm juggling | 14:38 |
| adeuring | bac: OK | 14:38 |
| bac | thanks abel | 14:38 |
| noodles775 | Hi adeuring, do you have time for another? https://code.edge.launchpad.net/~michael.nelson/launchpad/588684-builders-timeout/+merge/26818 | 16:28 |
| noodles775 | 280 lines. | 16:28 |
| adeuring | noodles775: sure | 16:28 |
| noodles775 | Thanks! | 16:28 |
| === noodles775 changed the topic of #launchpad-reviews to: On Call: adeuring || reviewing: || queue: [noodles] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === adeuring changed the topic of #launchpad-reviews to: On Call: adeuring || reviewing: noodles || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | adeuring: I need to run, but will check back (or reply to emails) later, if that's ok. | 16:51 |
| noodles775 | adeuring: also, I updated the bug with some local testing of the sql performance. | 16:52 |
| adeuring | noodles775: sure, np | 16:52 |
| adiroiban | ls | 17:20 |
| === adeuring changed the topic of #launchpad-reviews to: On Call: adeuring || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| adeuring | bac: I'll leave soon and I'm now declaring myself to be no longer on call. | 18:01 |
| === adeuring changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | ok, adeuring. thanks for the reviewing. | 18:02 |
| === bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | adeuring: have a nice weekend | 18:02 |
| adeuring | bac: thanks, a nice weekend to you too! | 18:02 |
| abentley | rockstar, could you review https://code.edge.launchpad.net/~abentley/launchpad/build-quota/+merge/26821 ? | 19:26 |
| EdwinGrubbs | bac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part2/+merge/26830 | 19:48 |
| bac | EdwinGrubbs: yep | 19:48 |
| === sinzui changed the topic of #launchpad-reviews to: On Call: bac || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | bac: I have a trivial branch for review if you have time today: https://code.launchpad.net/~sinzui/launchpad/mental-health-0/+merge/26832 | 20:25 |
| === bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: Edwin || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | rt, sinzui | 20:26 |
| rockstar | abentley, looking now. | 20:32 |
| bac | hi EdwinGrubbs | 21:19 |
| EdwinGrubbs | bac: hi | 21:20 |
| bac | EdwinGrubbs: why did the bug reporting guidelines stuff get deleted from DSP? | 21:20 |
| * EdwinGrubbs looks | 21:20 | |
| EdwinGrubbs | bac: I believe you're looking at the DistributionSourcePackage class. The bug_reporting_guidelines were converted to a DistributionSourcePackageProperty on line 428 of the diff in the mp. | 21:23 |
| bac | EdwinGrubbs: hey, i glazed right over that. and i had double checked! sorry . | 21:24 |
| bac | nm | 21:24 |
| bac | EdwinGrubbs: i approved the code review. you need to add bjorn and/or stub for db now. (stating the obvious) | 21:27 |
| === bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | bac: they reviewed the schema changes already, but I guess I still need them for the security.cfg changes. | 21:31 |
| bac | a million thank yous sinzui. a lovely branch. | 21:35 |
| === bac changed the topic of #launchpad-reviews to: On Call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | I still have no brain | 21:36 |
| sinzui | I am seriously thinking of setting a 4 hour timebox a and redesigning the team participation page to be useful | 21:37 |
| === bac changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| rockstar | abentley, so, I've got a question for you about your branch. | 21:44 |
| abentley | rockstar, okay, shall we mumble? | 21:44 |
| rockstar | (It took me this long to formulate the question itself) | 21:44 |
| rockstar | abentley, sure. | 21:44 |
| gary_poster | ...If anyone wanted to review https://code.edge.launchpad.net/~gary/launchpad/bug589010/+merge/26842 that would be nice. | 22:15 |
| sinzui | gary_poster, I'll take it | 22:17 |
| gary_poster | thank you muchly sinzui | 22:21 |
| sinzui | gary_poster, approved with some trivial remarks | 22:31 |
| sinzui | gary_poster, are you aware that we wanted to remove launchpad.conf from our configs? | 22:31 |
| gary_poster | sinzui, thank you! | 22:32 |
| gary_poster | no, I was not | 22:32 |
| sinzui | gary_poster, it defines servers and logs. We wanted to use lazr.config. but we needed to hook our config into zope startup | 22:32 |
| gary_poster | sinzui: I'm afraid I don't know where launchpad.conf is hooked in now, but I'm trying to educate myself... | 22:34 |
| gary_poster | do we/you already have a plan on how to do this? | 22:34 |
| sinzui | We did, but this was not as important as application config. | 22:34 |
| gary_poster | gotcha | 22:35 |
| sinzui | launchapd.conf is essentially site.zcml to define the address or servers and where the logs are | 22:35 |
| gary_poster | OK, makes sense. | 22:36 |
| sinzui | I wonder if initialization.py or lp_sitecustomize run at the right time for us to register a handler that will read lazr.config to setup the servers and logs | 22:37 |
| gary_poster | It would be lovely if we could settle on some standards, yes. So it looks like importing canonical.config makes the parsing happen now, right? So presumably it effectively happens during zcml processing as a side effect? Or is there some other mechanism? | 22:39 |
| gary_poster | AFAICT, you set up this configuration object without any ZCML registration. If that's true, then lp_sitecustomize might be a great place | 22:40 |
| gary_poster | sinzui: ^^^ | 22:42 |
| sinzui | gary_poster, yes, thanks. It is effectively python created on import. I did not/and do not understand when those the zcml style conf files are read and how to register something to handle servers and logs. Monkey patches are not allowed | 22:46 |
| gary_poster | Yeah, I don't think the zcml machinery allows you get in there (other than defining your own markup, of course, which would certainly be another option--a zcml tag which specifies that a file be parsed using lazr.config, with the data stored somewhere or other) | 22:48 |
| gary_poster | But, yeah, lp_sitecustomize looks promising | 22:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!