/srv/irclogs.ubuntu.com/2010/06/07/#ubuntu-reviews.txt

dholbachgood morning07:59
hyperairdholbach: i think you could benefit from a script that sends "good morning" to every channel you've joined just after you've connected ;-)08:00
dholbachhaha08:01
dholbachhey hyperair08:01
hyperairhi dholbach =)08:01
dholbachnigelbabu: meet bobbo09:17
dholbachbobbo: meet nigelbabu09:17
dholbach:)09:17
nigelbabuhello bobbo :)09:17
bobbohello nigelbabu :)09:18
dholbachbobbo: basically we don't want to expect patch submitters to do all the leg work, but give them a good experience of getting their patch somewhere09:19
dholbachbobbo: we might have submitters there who know about upstream, debian and all the rest of it already and they'll surely help out if they can09:19
dholbachbut I wouldn't expect that to be the majorit09:20
dholbachy09:20
bobboyeah, it took me a while to understand that when I first started contributing09:20
nigelbabusince you're fairly new to the process, you can perhaps look at our docs and give us feedback on what's missing09:21
dholbachit's tough, particularly with all the different upstream bug trackers and all the rest of it09:21
nigelbabuor what's confusing -  it helps a *lot*09:21
bobbonigelbabu, okay, I'm reading over them now, I'll say if I see anything :)09:22
nigelbabubobbo: awesome! thanks :)09:22
nigelbabuI'm at work, so I may respond a bit late09:22
bobbonigelbabu, ping09:28
nigelbabubobbo: yes?09:28
bobbonigelbabu, those docs are pretty good, there seems to be enough there to fully explain the process to a newbie and get them ready to start reviewing :)09:29
nigelbabubobbo: awesome :)09:29
dholbachbobbo: these are the plans for this cycle for the patch reviewers team:09:30
dholbachhttps://blueprints.edge.launchpad.net/ubuntu/+spec/community-m-patch-review-initiative/09:30
dholbachhttps://blueprints.edge.launchpad.net/ubuntu/+spec/community-m-patch-review-process09:30
dholbachmaybe you can see if there's anything on there you'd like to help with that looks particularly good or important to you?09:30
bobbodholbach, looking now :)09:31
dholbachcool :)09:31
bobbodholbach, maybe one of the more "technical" ones, I'm not the greatest documentation writer, the edit-patch feature (Bug #586787) was one that immediately stood out09:36
ubot4Launchpad bug 586787 in ubuntu-dev-tools (Ubuntu) "edit-patch should take an existing patch as an argument and apply it (affects: 1)" [Undecided,New] https://launchpad.net/bugs/58678709:36
dholbachbobbo: sure, if you want to have a look at it, that'd be awesome09:37
dholbachbobbo: mvo wrote most of edit-patch so it'd might be worth talking to him09:37
dholbachbobbo: also there's james_w who wrote some kind of "test patches from bug X for sponsoring" tool, stefanlsd was interested in that task too09:38
dholbachthat's all the info I can dump on you :)09:38
bobbodholbach, so I should take a look at edit-patch and report in if I hit any brick walls?09:40
dholbachbobbo: sure, just try having a chat with the others if they have an immediate idea or a piece of code you can use and see how far you get with the tool :)09:41
dholbachgood luck :)09:42
bobbodholbach, great :D09:42
dholbachnigelbabu: http://daniel.holba.ch/blog/?p=68910:58
* nigelbabu hugs dholbach10:59
* dholbach hugs nigelbabu back11:00
dholbachif you all can blog about it too, that'd be sweet11:00
dholbachALL: ^11:00
nigelbabudholbach: Also, I'm writing a script all report-debian, takes an LP bug as input and forwards that bug through report-debian to debian!11:00
nigelbabus/all/called11:00
dholbachnigelbabu: isn't the LP team working on something like that?11:01
nigelbabudholbach: I haven't heard of them working on that11:01
nigelbabuI heard bryce working on a pedro button11:01
dholbachalso it might be worth wrapping it around submittodebian (from ubuntu-dev-tools)11:02
nigelbabubut submittodebian is when we have a patch already in a package and want to forward it11:04
nigelbabuat least thats the impression I got when I tried it last11:04
dholbachnigelbabu: yes, so you just want to forward bugs to debian?11:23
nigelbabudholbach: yep, seb128 asked if we had something for it and I started writing11:23
dholbachnigelbabu: I'd have a chat with the LP folks first11:23
nigelbabuI already talked to bryce, he helped me a bit when I got stuck11:24
dholbachjust in case they're working on it so we don't duplicate work :)11:25
nigelbabuhm, I should perhaps talk to jml today11:26
BlackZhey dholbach11:41
dholbachhi BlackZ11:52
nigelbabuBlackZ: btw, you guys should think of taking a class at developer week ( when it happens )11:56
BlackZdholbach: I'm following up your e-mail11:57
BlackZnigelbabu: will be done12:00
nigelbabu:)12:00
BlackZcurrently we're re-working to the program12:01
vishdholbach: hmm , whats up with the countdown meter? [on the blog]  it just shows a black strip with red patch on the side13:35
vishor is it a progress bar?13:35
vishoops , it is a progress bar :D  , for some reason i was expecting a number there ;)13:36
dholbachvish: progress bar13:42
dholbachvish: if you can improve the script to make it prettier… :-)13:43
vishdholbach: yeah , i'm trying to find a pretty progress bar , we used it for the -manual13:43
dholbachI use python-imaging13:44
dholbachit's very primitive13:44
vishdholbach: hmm , the guy who did the progressbar for the manual site isnt around right now. I'll hook you up with the good stuff soon ;p13:50
dholbachawesome13:54
dholbachbobbo: how are things looking? do you think the process will be easy enough for my mom and dad to make use of? ;-)14:53
bobbodholbach, yeah, the instructions are pretty good, I've worked through quite a few of the bugs and not really hit any problems14:54
dholbachcool, that's how we like it14:55
bobboone thing I'm not sure about though is that the instructions tell you to remove the "patch" tag whenever we add "patch-forwarded-upstream" etc.14:55
dholbachnigelb, bdmurray: ^?14:55
* dholbach doesn't know about the state of the discussions and I don't particularly care either way14:55
bobbohaha, I struggled with that when I was forwarding a patch to gwibber because I know they use the patch tag to identify patches in their bugs and didn't want to trample all over their project14:56
bobbodholbach, should I just keep working through these bugs or is there anything else you'd like me to do?15:00
dholbachlet me have a look at the blueprints again and see if there's something15:04
dholbachbobbo: what do you think about "add documentation about how to turn a patch into a merge proposal if it's a project maintained in Launchpad"? it might be interesting for cases like gwibber and I wrote up a few bits for that already15:06
dholbachbobbo: if you have a look at https://wiki.ubuntu.com/Bugs/HowToFix - there's a few reusable bits15:06
bobbodholbach, branch merge proposal?15:06
dholbachyep15:06
bobboI could have a look at it, basically grabbing the project's trunk, applying the patch, (testing it?), then committing, pushing and merge requesting?15:08
dholbachyep, there might be something on help.launchpad.net too15:08
dholbachI don't think you need to write a lot of docs yourself15:09
dholbachjust string those bits nicely together, so people can work on that if they hit such a case15:09
bobbosure I'll give that a go, you say you've already written up some stuff for it?15:09
dholbachhttps://wiki.ubuntu.com/Bugs/HowToFix15:09
bobbogreat, thanks :)15:10
dholbachif you could blog about the operation cleansweep some time this week that'd be nice too15:10
dholbachso we keep the message on everybody's radar15:10
dholbachbobbo: where do you think we should post the message too?15:10
bobbomy domain name has just expired :( too poor to buy it again :D15:10
dholbachI think right now we just covered planet ubuntu, maybe ubuntu-devel@15:11
bobbotwitter/identi.ca covered?15:11
dholbachbobbo: nevermind - that's fine - I just saw you were listed on planet15:11
dholbachmight be worth mentioning it there too15:11
dholbachbobbo: do you think we have enough examples in the docs and stuff that explains when to forward upstream and when not to?15:12
dholbachbobbo: somehow I get the feeling that's what's probably most complicated to newcomers15:12
dholbachnigelb, stefanlsd and I agreed to have a look at the docs again and I already did a few bits15:13
bobbodholbach, actually yeah, I think that could be expanded, I can imagine people not knowing when to send it up (and whether to go to Debian or straight to upstream)15:14
dholbachbobbo: if you have an idea what else to add there in terms of indication or documentation, that'd be nice15:15
dholbachbobbo: some times it's just 2 or 3 bullet points that make a difference15:15
dholbach… when you're new15:15
bobbodholbach, cool, I'll give it a think :)15:16
dholbachthanks muchly :)15:16
bobbodholbach, how does https://wiki.ubuntu.com/DavidFutcher/PatchMergeRequests look?15:54
dholbachbobbo: I'll take a look in a sec15:55
bobbodholbach, it's just a "first draft", I've never written any (decent) technical docs before :)15:56
dholbachbobbo: it's great15:56
dholbachbobbo: I'd probably add a link to general bzr docs somewhere and put "bzr lp-open" somewhere too, because I like it so much15:57
dholbachbobbo: other than that it's in a perfectly mergable state15:57
dholbachmaybe Mr nigelb can take another look15:57
dholbachbobbo: very awesome15:57
bobbodholbach, great, thanks alot, I'd never head of lp-open before15:57
dholbachbobbo: opens the lp page of the branch15:59
dholbachbobbo: so you just need to click on "submit for merge" or whatever it's called15:59
bobbodholbach, yeah, it's awesome, don't know why more people don't use it :D15:59
dholbachbobbo: you're there to improve things: you documented it :-D16:00
bobboheh :D16:00
nigelbbobbo: yes, there should only be one tag at a time patch or patch-*16:02
bobbonigelb, what if the upstream actively uses the patch tag to identify bugs with patches? Or should we tell them to just use the "Bugs with patches" filter instead?16:04
nigelbbobbo: upstream using LP?16:04
nigelbthen its a mess :p16:04
bobbohehe :D16:04
bobboare the LP team going to implement a patch status system or are we stuck using tags for a long time?16:05
nigelbbobbo: in that case, you can have both.  I see no other way, sadly :(16:05
dholbachbobbo: I think we'll get it at some stage, people should be using branches :-D16:05
bobboawesome :)16:05
dholbachbobbo: or we should auto-reflow-patches-into-branches16:05
dholbachpatches, interdiffs, .diff.gz, tarballs *SHUDDER*16:06
bobbohehe :P16:06
bobboI've added some more links in my merge request docs (one to BZR's own docs site and one to help.lp's code review page :)16:07
nigelbdholbach: I think there was some talk of having the code review workflow for patches too16:07
dholbachnigelb: yep16:07
nigelbthat would rock!16:08
bobbothat'd be awesome :D16:08
dholbachbobbo: awesome - are you going to merge it into the guide?16:08
dholbachnigelb: you happy with that?16:08
nigelbdholbach: what? where?16:09
bobbo:D16:09
dholbachnigelb: the document bobbo wrote16:09
bobbonigelb, https://wiki.ubuntu.com/DavidFutcher/PatchMergeRequests16:09
dholbachnigelb: bobbo is totally rocking it16:10
nigelbI got busy with work and missed what was happening here16:11
dholbachno worries - take it easy :)16:11
nigelbbobbo: ROCK!16:11
dholbachseems we're all a pretty excitable bunch :-)16:11
nigelbyou can make it part of the knowledge base16:11
nigelbdholbach: there is a low hanging task for anyone intrested16:12
dholbachmake it part of the ReviewersTeam namespace and link it from the reviewguide and the knowledge base?16:12
nigelbhunt through the linux packaging that we're subscribed, confirm that kernel patch is required and unsubscribe the team16:12
nigelbdholbach: yep16:12
nigelbbobbo: so, it would be ReviewersTeam/PatchMergeRequests and you can link both to review guide and knowledge base :)16:13
bobbonigelb, great, I'm on it now :)16:14
dholbachnigelb: hemanth wants to get involved too16:15
nigelbdholbach: get in and get participating :)16:15
hemanth:)16:16
dholbachnigelb: eh?16:16
nigelbah, I did see him join16:16
hemanthnigelb, hi16:17
nigelbhemanth: hello, thanks for helping out!16:19
hemanthnigelb, my pleasure, was blogging the same, wanted more info on involvement, more related info rather, i went through the wiki16:20
bobbookay, that's the merge proposals guide linked from the Knowledge Base and review Guide and prettied up a bit :)16:30
* hemanth going through the Workflow16:41
bobbodholbach, any more jobs to offload to me today? I'm working through some more patch bugs but if there're any other things you'd like me to do?16:41
dholbachbobbo: is there anything in the patch review blueprint work items that's glaring at you?16:42
bobbodholbach, documentation to help make the decision whether to go upstream or Debian looks do-able?16:43
dholbachbobbo: sure, if you have some additional thoughts for it, that'd be fantastic16:43
bobbodholbach, okay, I'll give it a closer look, first idea is a subsection of the page linked to from the workflow that explains it in more detail but won't bulk up the workflow paragraph, maybe gives some example bug reports etc16:44
dholbachthat sounds like music to my ears16:45
bobbohaha, I'll get looking at it then :D16:45
dholbachbobbo: https://blueprints.edge.launchpad.net/ubuntu/+spec/community-m-patch-review-process has your name on it twice now :)16:46
dholbachyou just went and took over for somebody else :)16:46
bobbowooot :D16:46
bobbodholbach, is there an official Canonical time to stop working?16:47
dholbachbobbo: I guess that depends on what your contract is ;-)16:48
=== yofel_ is now known as yofel
nigelbbobbo: how much of coding do you do?17:40
nigelbif you'd like to code, I have a task you might want to take over17:41
dholbachnigelb: bobbo's gone for today I think17:42
dholbachand I'm just about to leave too so I'll make it home before the rain starts17:43
dholbachsee you tomorrow17:43
bobbonigelb, ping17:56
=== nhandler_ is now known as nhandler
ajmitchgreetings23:43

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!