| dholbach | good morning | 07:53 |
|---|---|---|
| nigelbabu | morning dholbach | 07:55 |
| nigelbabu | if you notice, the numbers are less than 1700 today | 07:55 |
| dholbach | nigelbabu: I just had the thought that we should probably try to avoid to create the perception that "all the patches were integrated" | 07:55 |
| nigelbabu | I did some review last night | 07:55 |
| nigelbabu | didn't get you | 07:55 |
| nigelbabu | you mean the feeling that if something is not in the review queue, its integrated? | 07:55 |
| dholbach | nigelbabu: eh? | 07:55 |
| dholbach | instead I think we should say in bold letters XYZ patches were reviewed, and then list individually how many patches are forwarded to upstream, to debian, etc etc | 07:56 |
| dholbach | if you see what I mean | 07:56 |
| nigelbabu | yep, agreed. Next time i ask someone to blog, I'll mention that | 07:57 |
| dholbach | I'll do it too | 07:58 |
| dholbach | nigelbabu: what do you think about picking a day each week or maybe every two weeks where we blog the "stats"? | 07:58 |
| nigelbabu | dholbach: hahaha, I already thought of doing that every monday with alternating folks doing it | 07:59 |
| nigelbabu | I think I even talked about it in the channel | 07:59 |
| nigelbabu | dholbach: Great minds think alike :D | 07:59 |
| dholbach | ok, I'll do monday then | 08:00 |
| dholbach | maybe we should also do the stats comparing with last week | 08:00 |
| dholbach | still in the queue: 1789 (-250) | 08:01 |
| dholbach | or something | 08:01 |
| nigelbabu | dholbach: yep, I'm also thinking of asking the UWN folks to publish patch stats (not of cleansweep though), just overall ubuntu patches | 08:03 |
| dholbach | that might work - with a link to the patch reviewers team | 08:04 |
| nigelbabu | yep, so we can ask to add a line "As always Bug Squad and Reviewers Team need help" | 08:05 |
| dholbach | yeah | 08:05 |
| dholbach | nigelbabu: you know what, I'll write a script that'll run every monday and it'll write up what changed since the last run | 08:06 |
| nigelbabu | dholbach: that works too. if they can look at a page for stats like people.dholbach.com/patch-weekly-report.txt, would be great! | 08:07 |
| dholbach | that makes it easier to copy and paste | 08:07 |
| nigelbabu | You are so full of awesome :) | 08:07 |
| dholbach | I try :) | 08:07 |
| dholbach | nigelbabu: https://code.edge.launchpad.net/ubuntu-review-overview/+activereviews | 08:08 |
| dholbach | vish: did you manage to have a chat with daker? | 08:08 |
| nigelbabu | dholbach: oh yeah, forgot | 08:08 |
| dholbach | vish: about http://daniel.holba.ch/review/example.html and http://daniel.holba.ch/review/meter.css | 08:08 |
| nigelbabu | dholbach: can I say ack and will you merge it in? I'm at work and away from my ssh keys for another 7 hours | 08:10 |
| dholbach | sure | 08:10 |
| vish | dholbach: hi.. he was on here for a few mins , and this was what he had come up with > http://imagebin.org/100680 | 08:11 |
| nigelbabu | dholbach: ok, ack :D | 08:11 |
| vish | dholbach: still needs work | 08:11 |
| vish | dholbach: also , i told him you prefer it to be a css | 08:11 |
| dholbach | thanks nigelbabu | 08:11 |
| vish | why is the world round :( | 08:12 |
| vish | timezones suck! | 08:12 |
| dholbach | vish: the problem is that we want people to just have html that doesn't change - we can't have them update the html with actual percentage values if you see what I mean | 08:12 |
| dholbach | vish: however it's done and which technology is used, I don't care much TBH :) | 08:13 |
| nigelbabu | dholbach: if you can give changing css, then it works | 08:14 |
| dholbach | that's what the current branch does | 08:14 |
| dholbach | if I need to put other changes in there, I'm happy to do that | 08:14 |
| nigelbabu | then tats all is needed I suppose, since the code in the html doesn't change. what needs to be done,however, is to correct the html to be a snippet instead of a page | 08:15 |
| dholbach | vish: but http://imagebin.org/100680 looks GREAT | 08:15 |
| vish | dholbach: yeah. i'll try to get him here at the same time you are here , would be easier to get it done quick | 08:15 |
| dholbach | or we do it over mail | 08:16 |
| vish | dholbach: yeah , it looks nice , we could probably use a little less icons and add counter there | 08:16 |
| dholbach | dholbach at ubuntu dot com | 08:16 |
| vish | will send him that | 08:17 |
| * dholbach hugs you all | 08:17 | |
| bobbo | morning all :) | 09:00 |
| ansgar | Good afternood :) | 09:02 |
| dholbach | heya bobbo | 09:05 |
| bobbo | hey dholbach :) | 09:06 |
| bobbo | dholbach, I wrote up a progress bog update, like Jono asked | 09:07 |
| dholbach | yeah, I saw it! | 09:07 |
| dholbach | good work! | 09:08 |
| ansgar | The first two days more patches per day have been reviewed than required to reach the goal of having all reviewed by the next Ubuntu release? | 09:08 |
| dholbach | bobbo: nigelb and I just talked about writing a small script that basically just gets stats and compares them with the stats since the last run, so we can easier keep track of what happened between weeks | 09:08 |
| dholbach | bobbo: and get that into UWN, etc. | 09:08 |
| ansgar | If you finish too soon, you could do the same for Debian's BTS ;-) | 09:08 |
| dholbach | haha | 09:09 |
| bobbo | dholbach, could it keep it's data in a csv file or similar then just compare it? That sounds do-able | 09:10 |
| dholbach | bobbo: that's exactly what I'm working on right now :) | 09:10 |
| * dholbach hugs bobbo | 09:10 | |
| bobbo | dholbach, if you wanna offload it to someone else, I'd gladly help | 09:11 |
| dholbach | bobbo: I'll poke it just a bit longer and see where I can get it to | 09:11 |
| bobbo | dholbach, awesome, in that case, off to launchpad for more patches :D | 09:12 |
| dholbach | ROCK ON | 09:12 |
| bobbo | dholbach, if I temporarily disappear at any point, I'm not trying to avoid work, I'm getting an insane memory leak in policykit so have to reboot every now and then :) | 09:13 |
| dholbach | man, that's nuts | 09:13 |
| dholbach | you should have used maverick only in a VM! :) | 09:13 |
| dholbach | is there a bug report about it? | 09:13 |
| bobbo | dholbach, I should probably look for one | 09:14 |
| bobbo | dholbach, you're too sensible, first bug report I find has a workaround :D | 09:16 |
| dholbach | bobbo: I lived through a lot of development release pain already :) | 09:16 |
| dholbach | bobbo, nigelbabu: http://daniel.holba.ch/review/report | 09:54 |
| dholbach | and less interestingly http://daniel.holba.ch/review/stats.csv | 09:55 |
| dholbach | nigelbabu: it'll get updated every monday | 09:55 |
| bobbo | dholbach, that's awesome :D | 09:55 |
| dholbach | now we just need to tell the UWN team about it | 09:55 |
| * dholbach goes back to writing talks | 09:56 | |
| dholbach | I'll update it on sunday, that's where the uwn is released | 09:59 |
| bobbo | woot, just uploaded a patch that went patch-needswork yesterday and the authors responded, the system works :D | 10:11 |
| * BlackZ hugs bobbo | 10:12 | |
| vish | @patchcount | 10:26 |
| vish | oh , no patchbot :p | 10:27 |
| bobbo | @patchcount | 10:27 |
| patchbot | bobbo: Total: 2289 Left in Queue: 2059 10.0% complete | 10:27 |
| bobbo | vish, ^ | 10:27 |
| vish | bad patchbot ;p | 10:28 |
| hyperair | lol | 10:28 |
| bobbo | vish, haha, must have closed the terminal window he was running in | 10:28 |
| hyperair | why no daemonize it? | 10:29 |
| dholbach | bobbo: did you upload the patch? | 10:42 |
| bobbo | dholbach, yeah, but I'm forwarding it to Debian too, just a lot of the Debian bugs have been sitting there for years so I wasn't too hopeful for it getting uploaded any time soon | 10:43 |
| * dholbach nods | 10:43 | |
| dholbach | good work | 10:43 |
| bobbo | dholbach, when is our training session starting? | 10:43 |
| dholbach | bobbo: 12 utc | 10:44 |
| ajmitch | hi people | 10:45 |
| bobbo | dholbach, okay, so that'll be 1pm my time, I can never get the hang of UTC :D | 10:45 |
| seb128 | could somebody unscribed the reviewers from bug #588772? | 10:45 |
| ubot4 | Launchpad bug 588772 in ubiquity (Ubuntu) "installer crashes when configuring user (affects: 1) (heat: 421)" [Undecided,New] https://launchpad.net/bugs/588772 | 10:45 |
| seb128 | unsubscribe | 10:45 |
| ajmitch | sure | 10:45 |
| seb128 | thanks | 10:45 |
| dholbach | bobbo: date; date -u | 10:45 |
| * dholbach adds seb128 to ubuntu-reviewers | 10:46 | |
| ajmitch | removed the subscription now | 10:46 |
| bobbo | dholbach, thanks :D | 10:46 |
| seb128 | dholbach, yet another team for me now?! ;-) | 10:46 |
| * ajmitch just adds 12 :) | 10:46 | |
| ajmitch | seb128: you needed another badge on LP | 10:46 |
| dholbach | seb128: ce n'est pas une équipe ennuyeuse, c'est L'ÉQUIPE | 10:48 |
| BlackZ | seb128: hey, welcome aboard! | 10:49 |
| * ajmitch finally expired from ubuntu-{main,universe}-sponsors | 10:49 | |
| BlackZ | \o | 10:49 |
| seb128 | lol | 10:49 |
| seb128 | it's my fault, I should have learnt that every time you touch something around you get tricked into new work | 10:49 |
| seb128 | or responsabilities | 10:50 |
| seb128 | ;-) | 10:50 |
| ajmitch | especially with dholbach around | 10:50 |
| dholbach | ajmitch: no no, I make the same mistakes as seb128 | 10:50 |
| BlackZ | lol | 10:50 |
| dholbach | still didn't learn my lesson either | 10:50 |
| nigelbabu | dholbach: interesting report! | 10:50 |
| nigelbabu | seb128: that's how I got sucked into reviewers team in the first place | 10:50 |
| ajmitch | dholbach: worse, I got convinced to change some code in LP earlier from a discussion in -motu | 10:50 |
| nigelbabu | made the mistake of saying "I'm bored" in #ubuntu-motu | 10:51 |
| BlackZ | dholbach: once I have finished to update the mentors documentation, do you want to check the docs for PTC? | 10:51 |
| seb128 | ok, so bug #558841, what do I do with it? | 10:51 |
| ubot4 | Launchpad bug 558841 in indicator-application (Ubuntu Lucid) (and 5 other projects) "bluetooth "devices" menu item not working in bluetooth indicator (affects: 13) (dups: 3) (heat: 78)" [Low,Triaged] https://launchpad.net/bugs/558841 | 10:51 |
| seb128 | the patch there is in maverick | 10:51 |
| dholbach | BlackZ: I'm afraid I don't have the time for that | 10:51 |
| BlackZ | dholbach: OK | 10:51 |
| dholbach | BlackZ: I'm not part of the mentoring team any more | 10:51 |
| seb128 | but there is another task on the bug which is open | 10:52 |
| seb128 | should I just drop the patch tag? | 10:52 |
| seb128 | is somebody going to add it back because there is a patch on the bug? | 10:52 |
| nigelbabu | seb128: just unsubscribe | 10:52 |
| nigelbabu | if you remove the patch tag, we will get unsubscribed again | 10:52 |
| seb128 | it's still tagged patch | 10:52 |
| seb128 | but that's not really correct | 10:52 |
| seb128 | since that patch has been uploaded | 10:53 |
| nigelbabu | true, but unsubscribing gets it out of review queue - our work pool | 10:53 |
| seb128 | well, it will come back | 10:53 |
| nigelbabu | you can add a comment "patch in this bug is accepted, unsubscribing reviewers team" | 10:53 |
| seb128 | when somebody notice it's a bug with a patch and reviewers are not subscribed | 10:53 |
| seb128 | ok | 10:54 |
| ajmitch | depends if the mass-susbscription script was smart or not | 10:54 |
| nigelbabu | ajmitch: it is | 10:54 |
| nigelbabu | brian wrote it, dholbach and I have gone through it with a fine comb, but if you want, you can take a peek. Its in the ubuntu-qa-tools project on LP | 10:55 |
| ajmitch | I'll pass, I trust that it'll DTRT :) | 10:55 |
| * ajmitch has enough other things to fix up | 10:56 | |
| nigelbabu | if it doesn't, you can always propose a merge LD | 10:56 |
| nigelbabu | :D | 10:56 |
| bobbo | Bug #150205 <-- How do we deal with that bug? | 11:14 |
| ubot4 | Launchpad bug 150205 in baltix (and 17 other projects) "Make menu items labels more consistent and clear (heat: 10)" [Undecided,Invalid] https://launchpad.net/bugs/150205 | 11:14 |
| daker | hey dholbach http://imagebin.org/100680 | 11:15 |
| dholbach | hey daker | 11:15 |
| dholbach | daker: yeah, vish showed it to me already - it's great | 11:15 |
| dholbach | daker: I'm happy to update the css file with the script and everything | 11:15 |
| dholbach | daker: is there a way so that people can just include it in a webpage and not update the html themselves? | 11:16 |
| dholbach | http://daniel.holba.ch/review/example.html is what I have right now | 11:16 |
| dholbach | and http://daniel.holba.ch/review/meter.css (which is automatically generated) | 11:16 |
| daker | yes there is | 11:17 |
| daker | give me a minutes | 11:18 |
| nigelbabu | daker: basically, can we have it as a snippet that people can put up on a website :) | 11:18 |
| daker | yes | 11:18 |
| dholbach | awesome | 11:18 |
| dholbach | take your time :) | 11:18 |
| daker | dholbach, creat a new .js file | 11:21 |
| daker | and paste that : | 11:21 |
| daker | var gadget =\'<style type="text/css" media="all">@import "meter.css";</style>\'+ | 11:21 |
| daker | \'<div class="progress-bar"><div id="sample" class="bar">.</div>\'+ | 11:21 |
| daker | document.write(gadget); | 11:21 |
| daker | then people have to just to put the js file any where they want like that | 11:22 |
| dholbach | daker: that's cool - can we get the text in there somehow too? :D | 11:23 |
| daker | <script type="text/javascript" src="http://daniel.holba.ch/review/widget.js"></script> | 11:23 |
| daker | you can test | 11:24 |
| nigelbabu | BlackZ: quite a storm you brewed there on debian-mentors. Actually, there are a few ubuntu devs who are DDs whom you can poke | 11:24 |
| nigelbabu | daker: testing | 11:25 |
| ajmitch | and getting more by the day, it seems | 11:25 |
| dholbach | daker: http://imagebin.org/100680 has percentage - how do we get that into there? :) | 11:26 |
| nigelbabu | dholbach: did you create that js file yet? | 11:26 |
| dholbach | nigelbabu: no | 11:26 |
| BlackZ | nigelbabu: I don't think they have always the time to sponsor | 11:26 |
| nigelbabu | dholbach: figures, I get blank page here ;) | 11:26 |
| BlackZ | also, I know | 11:26 |
| nigelbabu | BlackZ: I don't remember who it is, but there a few who're always willing to sponsor | 11:27 |
| nigelbabu | dholbach: can poke me when you do, I'll test here | 11:27 |
| ajmitch | finding time to sponsor can be a challenge for most of us, I think | 11:27 |
| dholbach | nigelbabu: daker and I are still figuring something else out | 11:27 |
| BlackZ | heh ajmitch that's true | 11:27 |
| nigelbabu | ajmitch: I agree. Finding time to package is a challenge, so sponsoring can be more time consuming | 11:27 |
| nigelbabu | dholbach: ah, ok | 11:27 |
| nigelbabu | dholbach: oh, the %! ok! | 11:28 |
| daker | dholbach, take a look a here https://code.launchpad.net/~adnane002/+junk/ubuntu-reviews | 11:28 |
| BlackZ | ajmitch: generally you want to sponsor packages which you're familiar, am I wrong? | 11:29 |
| dholbach | daker: ok, so I write the .js file like at the end of http://bazaar.launchpad.net/~adnane002/+junk/ubuntu-reviews/annotate/head:/gadget.js.php ? | 11:29 |
| ajmitch | BlackZ: generally yes, especially when there's specific bits of policy to be familiar with | 11:29 |
| dholbach | BlackZ: generally it's preferrable if sponsors sponsor stuff they feel comfortable with | 11:29 |
| daker | dholbach, are you going to do all the stuff with python ? | 11:30 |
| dholbach | daker: yes | 11:30 |
| daker | why ? explain | 11:30 |
| BlackZ | dholbach: and I'm agree with that, the reason why I send that e-mail is because there are 20+ pending packages (but I mean just who requested sponsor on debian-mentors) | 11:30 |
| dholbach | daker: because it's very easy for me to use | 11:31 |
| daker | oki | 11:31 |
| dholbach | BlackZ: unfortunately that happens | 11:31 |
| dholbach | daker: is that a problem? | 11:31 |
| daker | no :) | 11:31 |
| dholbach | ok, good :) | 11:31 |
| dholbach | I thought I was missing something | 11:32 |
| BlackZ | dholbach: I don't want that as a flame as I said in the ml | 11:32 |
| BlackZ | some DDs thought so | 11:32 |
| BlackZ | (but I hope not) | 11:32 |
| dholbach | BlackZ: what are you suggesting should change? | 11:32 |
| daker | dholbach, file_total = 'http://daniel.holba.ch/review/total.txt'; | 11:32 |
| daker | file_inqeue = 'http://daniel.holba.ch/review/in-the-queue.txt'; | 11:32 |
| BlackZ | dholbach: http://lists.debian.org/debian-mentors/2010/06/msg00160.html | 11:32 |
| daker | dholbach, you have to read the content of those files | 11:33 |
| dholbach | daker: I'll create the .js file from where those values are generated | 11:33 |
| dholbach | daker: that means I can make the .css static? | 11:33 |
| daker | no that your python code have to do that | 11:34 |
| dholbach | ok | 11:34 |
| dholbach | no problem :) | 11:34 |
| daker | you have also to regenerate the js file | 11:34 |
| dholbach | yep | 11:35 |
| dholbach | will do | 11:35 |
| dholbach | just a few mins | 11:35 |
| daker | the js file should like that : | 11:36 |
| daker | var gadget =\'<style type="text/css" media="all">@import "meter.css";</style>\'+ | 11:36 |
| daker | \'<div class="progress-bar"><div id="sample" class="bar">.</div>\'+ | 11:36 |
| daker | \'<div id="percentage">the value of the percentage generated with python here %</div>\'+ | 11:36 |
| daker | document.write(gadget); | 11:36 |
| daker | just to tell you that the widget i made is working & we don't have to write any | 11:38 |
| daker | just call the js file & it's done | 11:38 |
| dholbach | cool | 11:48 |
| dholbach | just a few more ticks | 11:48 |
| daker | oki | 11:51 |
| dholbach | daker: http://daniel.holba.ch/review/example.html - good? | 12:04 |
| dholbach | I wrote my changes to https://code.edge.launchpad.net/~dholbach/ubuntu-review-overview/js | 12:05 |
| dholbach | and will need to step out for a bit | 12:05 |
| dholbach | bobbo: I'll be back in time for our session | 12:05 |
| dholbach | bbl | 12:05 |
| bobbo | dholbach, okay, I'll go grab some lunch then :) | 12:08 |
| daker | hey dholbach | 12:26 |
| daker | open default.css | 12:26 |
| daker | and change all the "../images/" by "images/" | 12:27 |
| dholbach | daker: ah ok, will do - thanks | 12:38 |
| dholbach | daker: you're a rockstar | 12:39 |
| dholbach | this is great! | 12:39 |
| dholbach | daker: beautiful | 12:41 |
| daker | Oh | 12:41 |
| dholbach | everybody: http://daniel.holba.ch/review/example.html | 12:41 |
| dholbach | look at the source of the .html - it's tiny | 12:41 |
| daker | everyone how want to put the widget on his website | 12:41 |
| daker | just put that : | 12:41 |
| daker | <script type="text/javascript" src="http://daniel.holba.ch/review/gadget.js"></script> | 12:42 |
| bobbo | that's awesome :D | 12:42 |
| dholbach | daker's the wizard | 12:42 |
| daker | thanks :) | 12:43 |
| bobbo | I can't get it to workon my site, I'm not getting any images ... | 12:44 |
| daker | put your site here | 12:44 |
| bobbo | maybe the urls in gadget.js have to be absolute so people can link to them | 12:44 |
| * dholbach just microblogged about the session in a few | 12:44 | |
| bobbo | http://www.bobbo.me.uk <-- On the right hand side | 12:44 |
| daker | Oh i know :) | 12:45 |
| dholbach | Packaging Training Session in 15m in #ubuntu-classroom: Operation Cleansweep and the Patch Reviewers Team! | 12:45 |
| daker | dholbach, we should make some changes | 12:45 |
| dholbach | daker: ok… what do you have in mind? | 12:46 |
| daker | you should add everywhere : 'http://daniel.holba.ch/review' | 12:46 |
| daker | ----------------------------------------- | 12:47 |
| dholbach | daker: do we need to hardcode everything? | 12:47 |
| daker | yes | 12:48 |
| daker | here is the js file: | 12:48 |
| daker | var gadget ='<link rel="stylesheet" href="http://daniel.holba.ch/review/default.css" type="text/css" media="screen">'+ | 12:48 |
| daker | '<div id="badge">'+ | 12:48 |
| daker | '<div id="ubuntu-reviewers-logo"></div>'+ | 12:48 |
| daker | '<div id="ubuntu-logo"></div>'+ | 12:48 |
| daker | '<div id="progress-bar"><div id="bar" style="width:10%">10%</div></div>'+ | 12:48 |
| daker | '<div id="percentage">10%</div>'+ | 12:49 |
| daker | '<div id="ubuntu-review-team"><img src="http://daniel.holba.ch/review/images/3.png"><a href="http://launchpad.net/ubuntu-review" target="_blank">Powered by Ubuntu Review Gadget</a></div>'+ | 12:49 |
| daker | '</div>'; | 12:49 |
| daker | document.write(gadget); | 12:49 |
| daker | and in the default.css you should replace all the "images/" by "http://daniel.holba.ch/review/images/" | 12:49 |
| daker | that's all :) | 12:51 |
| dholbach | that's unfortunate - I thought there was a way to keep it dynamic somehow | 12:51 |
| daker | ????!!!! | 12:52 |
| dholbach | so other folks could run the script too and use it on their sites | 12:53 |
| dholbach | but I have no clue, so I better shut up :) | 12:53 |
| kazade | dholbach, I've come in halfway through the conversation, but you could try replacing "images/" with "/review/images" to prevent depending on the hostname if I understand correctly | 12:53 |
| kazade | paths starting with a / are relative to the hostname... | 12:53 |
| kazade | ignore me if I've misunderstood what's going on :p | 12:54 |
| dholbach | kazade: I could try that | 12:54 |
| daker | dholbach, just do what i say then we will see :) | 12:54 |
| kazade | where is this js file located? | 12:54 |
| dholbach | kazade: | 12:55 |
| dholbach | <script type="text/javascript" src="http://daniel.holba.ch/review/gadget.js"></script> | 12:55 |
| kazade | ok, so yeah, if you remove the "http://daniel.holba.ch" from every link and retain the leading slash, it will work on any host | 12:56 |
| daker | kazade, it will not work :) | 12:56 |
| kazade | how so? | 12:57 |
| daker | because we don't want people to host the files | 12:57 |
| kazade | oh right! | 12:57 |
| kazade | this is what I get for entering a conversation midway | 12:57 |
| dholbach | daker: why not? :) | 12:58 |
| kazade | yes, you are right, in that case you need absolute links | 12:58 |
| bobbo | dholbach, don't want to force people to host the files to show the gadget | 12:58 |
| dholbach | daker: if people host it when my machine is offline or somebody else runs the script as well I absolutely don't ming | 12:58 |
| dholbach | bobbo: sure | 12:58 |
| dholbach | whatever, I can hardcode it too | 12:58 |
| dholbach | no big deal | 12:58 |
| kazade | well... I guess you could publish the resources (images, js etc.) on #ubuntuone ... and link to those files... | 12:59 |
| dholbach | I just thought it'd be nice not to | 12:59 |
| kazade | then anyone can access it | 12:59 |
| bobbo | what about sticking a hostname var at the top so it's really easy to modify if anyone else wants to host it? | 12:59 |
| daker | kazade, in that case yes | 12:59 |
| dholbach | I'll think about it later on | 12:59 |
| dholbach | there's a session to be given now | 12:59 |
| daker | oki | 13:00 |
| nigelbabu | dholbach, bobbo: good going! | 13:10 |
| dholbach | bobbo's rocking | 13:11 |
| nigelbabu | dholbach: we should have a bobbo huggers team now :D | 13:11 |
| dholbach | totally | 13:11 |
| nigelbabu | dholbach: ouch, the how to fix docs I intended to write with the whole pbuilder etc is not yet ready :/ sorry. | 13:15 |
| dholbach | we need to integrate edit-patch in there | 13:15 |
| dholbach | now that bobbo fixed it up | 13:15 |
| nigelbabu | dholbach: we can rewrite the whole How to fix to gear towards us. I'll do it tonight | 13:17 |
| dholbach | nigelbabu: I think we can probably have a general guide that suits us all | 13:18 |
| nigelbabu | Lets see what i can come up with :) | 13:18 |
| dholbach | nigelbabu: have a look at the HowToFix page first - I'm sure it's in there already and just need a few small fixes | 13:24 |
| dholbach | bobbo: we'll extend edit-patch to just apply the patch and created debian/applied-patches and put it there | 13:25 |
| bobbo | dholbach, awesome, I'll get that done after the session | 13:25 |
| dholbach | super | 13:26 |
| * bobbo waves at karyo | 13:59 | |
| karyo | how do I do that? | 14:00 |
| bobbo | "/me" | 14:00 |
| * karyo waves | 14:00 | |
| * karyo thanks bobbo | 14:01 | |
| nigelbabu | bobbo, dholbach: Awesome session! | 14:03 |
| dholbach | it's all bobbo's doing :) | 14:04 |
| nigelbabu | With that, the number of patches hit 1650! | 14:04 |
| nigelbabu | I should review some patches today to make it < 1600 today | 14:04 |
| bobbo | nigelb, 1600 is easily possible :P | 14:04 |
| bobbo | nigelbabu, if we can do it before I go to sleep I can stick it in my daily progress blog, that'd look pretty awesome | 14:06 |
| nigelbabu | nigelbabu: gimme a few hours to get home and start reviewing | 14:06 |
| nigelbabu | Also, you'll be around after you're 1 week in canonical too right? | 14:06 |
| bobbo | nigelbabu, should be, I'll be in school but I don't have any exams or anything so I'll have a ton of free time | 14:06 |
| nigelbabu | \o/ | 14:07 |
| dholbach | log is up at: https://wiki.ubuntu.com/Packaging/Training/Logs | 14:08 |
| * dholbach now needs to take care of a few other things | 14:09 | |
| dholbach | bbiab | 14:09 |
| nigelbabu | later folks, leaving for home | 14:09 |
| karyo | https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/547225 | 14:19 |
| ubot4 | Launchpad bug 547225 in poppler (Ubuntu) (and 1 other project) "Evince fails to properly display this "type" of pdf (affects: 2) (heat: 16)" [Low,Fix committed] | 14:19 |
| karyo | what tag should I apply? | 14:19 |
| karyo | seems like the fix originates from upstream | 14:20 |
| \vish | !test | 14:25 |
| ubot4 | hrm? | 14:25 |
| === \vish is now known as vish | ||
| bobbo | argh why is it when I'm testing a feature that requires a patchsys I can never find a package that uses one and when I'm testing a feature that requires no patchsys, I can never find one without one | 14:31 |
| bobbo | dholbach, http://bazaar.launchpad.net/~ubuntu-dev/ubuntu-dev-tools/trunk/revision/657 | 15:13 |
| dholbach | bobbo: awesome - that looks great - you should add a changelog entry | 15:15 |
| bobbo | dholbach, to debian/changelog? | 15:15 |
| dholbach | yep | 15:15 |
| bobbo | it's basically included by what mvo wrote on Monday | 15:15 |
| dholbach | ah ok | 15:15 |
| bobbo | he put "support adding existing patches (e.g. from launchpad)" | 15:15 |
| dholbach | is debian/applied-patches going to be used even if I don't use a patch system at all and don't have an existing patch? | 15:16 |
| bobbo | no, it's only touched when edit-patch is give an existing patch | 15:16 |
| dholbach | ah ok | 15:17 |
| dholbach | wonder if it'd make sense to also do it when there's no patch given | 15:17 |
| dholbach | probably not | 15:17 |
| dholbach | … although | 15:17 |
| dholbach | it might make sense if people care enough to add the patch tagging guidelines | 15:17 |
| dholbach | but anyway | 15:17 |
| dholbach | we should probably be good now :D | 15:18 |
| bobbo | yeah, that seems to be it working pretty well, there's probably some minor stuff I could sort but bash fries my brain :D | 15:18 |
| dholbach | yeah :) | 15:18 |
| dholbach | mvo chose it so we could maybe get it into devscripts at some stage | 15:19 |
| dholbach | I started it in python | 15:19 |
| dholbach | and he did it all the legwork to get it into shell | 15:19 |
| bobbo | I've not worked in shell for a long time, I'm a total Python man at heart :D | 15:20 |
| dholbach | yeah | 15:20 |
| dholbach | everything else is a bit of a pain :) | 15:20 |
| daker | dholbach, i want to see the result :) | 15:41 |
| dholbach | daker: sorry, I was in what felt like 50000 conversations since we talked | 15:42 |
| dholbach | I'll have a look at it now | 15:42 |
| daker | :) oki take your time | 15:45 |
| dholbach | daker: I hardcoded all of them | 15:46 |
| dholbach | daker: bobbo.me.uk still doesn't work | 15:46 |
| daker | well there is something wrong here : | 15:48 |
| daker | i/* Ubuntu Reviews Gadget */ | 15:48 |
| daker | remove the "i" | 15:48 |
| dholbach | ugh | 15:49 |
| dholbach | done, still broken :) | 15:50 |
| bobbo | I get the same results in a plain test HTML file, so it's not my stylesheets killing it | 15:51 |
| daker | no dholbach rehardcod all of them | 15:53 |
| bobbo | dholbach, http://pastebin.com/5nbcV8v6 | 15:53 |
| bobbo | that's them all hardcoded and it works on my system | 15:54 |
| daker | <daker> var gadget ='<link rel="stylesheet" href="http://daniel.holba.ch/review/default.css" type="text/css" media="screen">'+ | 15:54 |
| daker | <daker> '<div id="badge">'+ | 15:54 |
| daker | <daker> '<div id="ubuntu-reviewers-logo"></div>'+ | 15:54 |
| daker | <daker> '<div id="ubuntu-logo"></div>'+ | 15:54 |
| daker | <daker> '<div id="progress-bar"><div id="bar" style="width:10%">10%</div></div>'+ | 15:54 |
| daker | <daker> '<div id="percentage">10%</div>'+ | 15:54 |
| daker | <daker> '<div id="ubuntu-review-team"><img src="http://daniel.holba.ch/review/images/3.png"><a href="http://launchpad.net/ubuntu-review" target="_blank">Powered by Ubuntu Review Gadget</a></div>'+ | 15:54 |
| daker | <daker> '</div>'; | 15:54 |
| daker | <daker> document.write(gadget); | 15:54 |
| daker | <daker> and in the default.css you should replace all the "images/" by "http://daniel.holba.ch/review/images/" | 15:54 |
| daker | <daker> that's all :) | 15:54 |
| dholbach | (script ran in the meantime) | 15:54 |
| bobbo | 11% wooot | 15:54 |
| daker | listen | 15:55 |
| daker | put that line : | 15:55 |
| daker | v | 15:55 |
| daker | <link rel="stylesheet" href="http://daniel.holba.ch/review/default.css" type="text/css" media="screen"> | 15:55 |
| dholbach | yeeehaw | 15:57 |
| bobbo | got it working on my site | 15:58 |
| bobbo | daker and the uber-bar of review awesomeness get a mention in the daily update blog | 15:58 |
| dholbach | bobbo: *I* got it working on your site - your 0wned! | 15:58 |
| dholbach | ;-) | 15:58 |
| * dholbach shuts up - it's 30°C in here, I can't think straight | 15:59 | |
| daker | '<div id="ubuntu-review-team"><img src="http://daniel.holba.ch/review/images/3.png"><a href="http://launchpad.net/~ubuntu-review" target="_blank">Powered by Ubuntu Review Gadget</a></div>'+ | 15:59 |
| dholbach | thanks a bunch daker and bobbo | 15:59 |
| daker | add this | 15:59 |
| daker | missing the '~' | 16:00 |
| bobbo | dholbach, do you want me to put it in the wiki for you? | 16:01 |
| dholbach | daker: maybe link to https://wiki.ubuntu.com/ReviewersTeam instead? | 16:02 |
| dholbach | bobbo: that'd be sweet | 16:02 |
| daker | oki as you like | 16:02 |
| dholbach | super | 16:02 |
| daker | just to correct the link | 16:02 |
| dholbach | yep | 16:02 |
| daker | other thing we can add later is to put on the left the number of patches or something like that | 16:04 |
| dholbach | fixed now | 16:04 |
| dholbach | at least on http://daniel.holba.ch/review/example.html | 16:04 |
| dholbach | on bobbo's site it's cached | 16:04 |
| dholbach | this looks GREAT | 16:04 |
| dholbach | thanks a bunch daker | 16:04 |
| dholbach | thanks bobbo | 16:04 |
| * bobbo isn't using dholbach's code yet, still using my own to grab it | 16:05 | |
| dholbach | ah ok | 16:05 |
| daker | \o/ | 16:05 |
| daker | no problem :) | 16:05 |
| bobbo | woot, using dholbach's code works :D | 16:06 |
| bobbo | dholbach, for the wiki, how often will that script run to update the numbers? | 16:06 |
| dholbach | every 20 minutes | 16:07 |
| bobbo | epic | 16:07 |
| vish | woot! daker | 16:13 |
| daker | \o/ | 16:14 |
| bobbo | that's it on the wiki, too | 16:14 |
| vish | bobbo: dholbach: what do you think of having the "patches reviewed" as in done on the top left ? | 16:15 |
| dholbach | vish: I have no opinion - if you want to change and think it looks better: sure | 16:15 |
| bobbo | vish, if it could fit in without making it look too full/messy, sounds awesome | 16:15 |
| vish | the number would keep rising and look insane :D | 16:15 |
| vish | daker: ^ probably the same font size as the % would do ..? "XXX Reviewed" | 16:16 |
| daker | bobbo, where ? | 16:17 |
| daker | yes | 16:17 |
| bobbo | daker, https://wiki.ubuntu.com/OperationCleansweep | 16:17 |
| daker | reviews = total - in queue ? | 16:19 |
| vish | daker: what are all the numbers we are getting now? | 16:20 |
| vish | from the scripts | 16:20 |
| vish | daker: nvm , the total - in queue == done was what i meant :D | 16:21 |
| dholbach | well done guys | 16:21 |
| daker | dholbach, the .js file is generated with python ? | 16:23 |
| dholbach | daker: yes | 16:23 |
| dholbach | let me show you | 16:24 |
| dholbach | http://bazaar.launchpad.net/~ubuntu-reviewers/ubuntu-review-overview/trunk/annotate/head:/countdown.py | 16:24 |
| dholbach | line 9 to 23 | 16:24 |
| dholbach | ok my friends - I call it a day - see you tomorrow! | 16:26 |
| nigelb | cyphermox: poke | 16:41 |
| bobbo | @patchcount | 16:58 |
| patchbot | bobbo: Total: 2280 Left in Queue: 2016 11.6% complete | 16:58 |
| seb128 | the count is weird | 16:59 |
| nigelb | ugh, I didn't go through dholbach's code | 16:59 |
| nigelb | its higher than what it should be | 16:59 |
| seb128 | or it doesn't match the path to be reviewed list in the topic | 16:59 |
| nigelb | seb128: working on it now :) | 16:59 |
| seb128 | ok | 17:00 |
| cyphermox | nigelb: poke | 17:00 |
| nigelb | cyphermox: I was wondering if you'd like to take a class at ubuntu user days | 17:01 |
| bobbo | I'm going to call it a day here, have a good evening everyone :) | 17:02 |
| nigelb | bobbo: night | 17:03 |
| cyphermox | nigelb: did you already have a specific subject in mind? | 17:03 |
| nigelb | cyphermox: " Choosing hardware that works with Ubuntu | 17:03 |
| cyphermox | oooh | 17:03 |
| nigelb | cyphermox: like it? ;) | 17:04 |
| cyphermox | yep | 17:04 |
| cyphermox | how did you know I'd be interested? | 17:04 |
| nigelb | I know you're working on hardware certification at canonical ;) | 17:04 |
| nigelb | You did tell me last time I talked to you. I remember things. :) | 17:05 |
| * cyphermox is starting to wonder just how much nigelb knows about him ;) | 17:05 | |
| cyphermox | ah, i see ;) | 17:05 |
| * nigelb just has good memory :) | 17:05 | |
| nigelb | ok, so the schedule is here https://wiki.ubuntu.com/UserDaysTeam/lucid | 17:05 |
| nigelb | is 0200 UTC okay with you? or do you want to go in between? | 17:05 |
| cyphermox | let me translate that | 17:06 |
| cyphermox | 0200 UTC is reasonable | 17:07 |
| nigelb | ok, I'll put you down for 0200 :) | 17:07 |
| nigelb | thanks for helping out, the event is on 10th July | 17:07 |
| cyphermox | that time ends up being on July 11th though, no? | 17:07 |
| cyphermox | (UTC) | 17:08 |
| nigelb | yeah | 17:08 |
| nigelb | but it should still be 12th for you | 17:08 |
| cyphermox | yes, still the 10th | 17:08 |
| nigelb | err 10th, yeah | 17:09 |
| bobbo | http://bobbo.me.uk/index.php/planet-ubuntu/operation-cleansweep-day-four-update <-- Day 4 update | 17:27 |
| daker | \o/ | 17:53 |
| nigelb | \o/ | 17:56 |
| === daker_ is now known as daker | ||
| nigelb | @patchcount | 18:01 |
| patchbot | nigelb: Total: 2279 Left in Queue: 2014 11.6% complete | 18:01 |
| === yofel_ is now known as yofel | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
