\'+ [11:21] document.write(gadget); [11:22] then people have to just to put the js file any where they want like that [11:23] daker: that's cool - can we get the text in there somehow too? :D [11:23] [11:24] you can test [11:24] BlackZ: quite a storm you brewed there on debian-mentors. Actually, there are a few ubuntu devs who are DDs whom you can poke [11:25] daker: testing [11:25] and getting more by the day, it seems [11:26] daker: http://imagebin.org/100680 has percentage - how do we get that into there? :) [11:26] dholbach: did you create that js file yet? [11:26] nigelbabu: no [11:26] nigelbabu: I don't think they have always the time to sponsor [11:26] dholbach: figures, I get blank page here ;) [11:26] also, I know [11:27] BlackZ: I don't remember who it is, but there a few who're always willing to sponsor [11:27] dholbach: can poke me when you do, I'll test here [11:27] finding time to sponsor can be a challenge for most of us, I think [11:27] nigelbabu: daker and I are still figuring something else out [11:27] heh ajmitch that's true [11:27] ajmitch: I agree. Finding time to package is a challenge, so sponsoring can be more time consuming [11:27] dholbach: ah, ok [11:28] dholbach: oh, the %! ok! [11:28] dholbach, take a look a here https://code.launchpad.net/~adnane002/+junk/ubuntu-reviews [11:29] ajmitch: generally you want to sponsor packages which you're familiar, am I wrong? [11:29] daker: ok, so I write the .js file like at the end of http://bazaar.launchpad.net/~adnane002/+junk/ubuntu-reviews/annotate/head:/gadget.js.php ? [11:29] BlackZ: generally yes, especially when there's specific bits of policy to be familiar with [11:29] BlackZ: generally it's preferrable if sponsors sponsor stuff they feel comfortable with [11:30] dholbach, are you going to do all the stuff with python ? [11:30] daker: yes [11:30] why ? explain [11:30] dholbach: and I'm agree with that, the reason why I send that e-mail is because there are 20+ pending packages (but I mean just who requested sponsor on debian-mentors) [11:31] daker: because it's very easy for me to use [11:31] oki [11:31] BlackZ: unfortunately that happens [11:31] daker: is that a problem? [11:31] no :) [11:31] ok, good :) [11:32] I thought I was missing something [11:32] dholbach: I don't want that as a flame as I said in the ml [11:32] some DDs thought so [11:32] (but I hope not) [11:32] BlackZ: what are you suggesting should change? [11:32] dholbach, file_total = 'http://daniel.holba.ch/review/total.txt'; [11:32] file_inqeue = 'http://daniel.holba.ch/review/in-the-queue.txt'; [11:32] dholbach: http://lists.debian.org/debian-mentors/2010/06/msg00160.html [11:33] dholbach, you have to read the content of those files [11:33] daker: I'll create the .js file from where those values are generated [11:33] daker: that means I can make the .css static? [11:34] no that your python code have to do that [11:34] ok [11:34] no problem :) [11:34] you have also to regenerate the js file [11:35] yep [11:35] will do [11:35] just a few mins [11:36] the js file should like that : [11:36] var gadget =\'\'+ [11:36] \'

\'+ [11:36] \'

the value of the percentage generated with python here %

\'+ [11:36] document.write(gadget); [11:38] just to tell you that the widget i made is working & we don't have to write any [11:38] just call the js file & it's done [11:48] cool [11:48] just a few more ticks [11:51] oki [12:04] daker: http://daniel.holba.ch/review/example.html - good? [12:05] I wrote my changes to https://code.edge.launchpad.net/~dholbach/ubuntu-review-overview/js [12:05] and will need to step out for a bit [12:05] bobbo: I'll be back in time for our session [12:05] bbl [12:08] dholbach, okay, I'll go grab some lunch then :) [12:26] hey dholbach [12:26] open default.css [12:27] and change all the "../images/" by "images/" [12:38] daker: ah ok, will do - thanks [12:39] daker: you're a rockstar [12:39] this is great! [12:41] daker: beautiful [12:41] Oh [12:41] everybody: http://daniel.holba.ch/review/example.html [12:41] look at the source of the .html - it's tiny [12:41] everyone how want to put the widget on his website [12:41] just put that : [12:42] [12:42] that's awesome :D [12:42] daker's the wizard [12:43] thanks :) [12:44] I can't get it to workon my site, I'm not getting any images ... [12:44] put your site here [12:44] maybe the urls in gadget.js have to be absolute so people can link to them [12:44] * dholbach just microblogged about the session in a few [12:44] http://www.bobbo.me.uk <-- On the right hand side [12:45] Oh i know :) [12:45] Packaging Training Session in 15m in #ubuntu-classroom: Operation Cleansweep and the Patch Reviewers Team! [12:45] dholbach, we should make some changes [12:46] daker: ok… what do you have in mind? [12:46] you should add everywhere : 'http://daniel.holba.ch/review' [12:47] ----------------------------------------- [12:47] daker: do we need to hardcode everything? [12:48] yes [12:48] here is the js file: [12:48] var gadget =''+ [12:48] '

'+ [12:48] '

10%

'+ [12:49] '

10%

'+ [12:49] '

'; [12:49] document.write(gadget); [12:49] and in the default.css you should replace all the "images/" by "http://daniel.holba.ch/review/images/" [12:51] that's all :) [12:51] that's unfortunate - I thought there was a way to keep it dynamic somehow [12:52] ????!!!! [12:53] so other folks could run the script too and use it on their sites [12:53] but I have no clue, so I better shut up :) [12:53] dholbach, I've come in halfway through the conversation, but you could try replacing "images/" with "/review/images" to prevent depending on the hostname if I understand correctly [12:53] paths starting with a / are relative to the hostname... [12:54] ignore me if I've misunderstood what's going on :p [12:54] kazade: I could try that [12:54] dholbach, just do what i say then we will see :) [12:54] where is this js file located? [12:55] kazade: [12:55] [12:56] ok, so yeah, if you remove the "http://daniel.holba.ch" from every link and retain the leading slash, it will work on any host [12:56] kazade, it will not work :) [12:57] how so? [12:57] because we don't want people to host the files [12:57] oh right! [12:57] this is what I get for entering a conversation midway [12:58] daker: why not? :) [12:58] yes, you are right, in that case you need absolute links [12:58] dholbach, don't want to force people to host the files to show the gadget [12:58] daker: if people host it when my machine is offline or somebody else runs the script as well I absolutely don't ming [12:58] bobbo: sure [12:58] whatever, I can hardcode it too [12:58] no big deal [12:59] well... I guess you could publish the resources (images, js etc.) on #ubuntuone ... and link to those files... [12:59] I just thought it'd be nice not to [12:59] then anyone can access it [12:59] what about sticking a hostname var at the top so it's really easy to modify if anyone else wants to host it? [12:59] kazade, in that case yes [12:59] I'll think about it later on [12:59] there's a session to be given now [13:00] oki [13:10] dholbach, bobbo: good going! [13:11] bobbo's rocking [13:11] dholbach: we should have a bobbo huggers team now :D [13:11] totally [13:15] dholbach: ouch, the how to fix docs I intended to write with the whole pbuilder etc is not yet ready :/ sorry. [13:15] we need to integrate edit-patch in there [13:15] now that bobbo fixed it up [13:17] dholbach: we can rewrite the whole How to fix to gear towards us. I'll do it tonight [13:18] nigelbabu: I think we can probably have a general guide that suits us all [13:18] Lets see what i can come up with :) [13:24] nigelbabu: have a look at the HowToFix page first - I'm sure it's in there already and just need a few small fixes [13:25] bobbo: we'll extend edit-patch to just apply the patch and created debian/applied-patches and put it there [13:25] dholbach, awesome, I'll get that done after the session [13:26] super [13:59] * bobbo waves at karyo [14:00] how do I do that? [14:00] "/me" [14:00] * karyo waves [14:01] * karyo thanks bobbo [14:03] bobbo, dholbach: Awesome session! [14:04] it's all bobbo's doing :) [14:04] With that, the number of patches hit 1650! [14:04] I should review some patches today to make it < 1600 today [14:04] nigelb, 1600 is easily possible :P [14:06] nigelbabu, if we can do it before I go to sleep I can stick it in my daily progress blog, that'd look pretty awesome [14:06] nigelbabu: gimme a few hours to get home and start reviewing [14:06] Also, you'll be around after you're 1 week in canonical too right? [14:06] nigelbabu, should be, I'll be in school but I don't have any exams or anything so I'll have a ton of free time [14:07] \o/ [14:08] log is up at: https://wiki.ubuntu.com/Packaging/Training/Logs [14:09] * dholbach now needs to take care of a few other things [14:09] bbiab [14:09] later folks, leaving for home [14:19] https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/547225 [14:19] Launchpad bug 547225 in poppler (Ubuntu) (and 1 other project) "Evince fails to properly display this "type" of pdf (affects: 2) (heat: 16)" [Low,Fix committed] [14:19] what tag should I apply? [14:20] seems like the fix originates from upstream [14:25] <\vish> !test [14:25] hrm? === \vish is now known as vish [14:31] argh why is it when I'm testing a feature that requires a patchsys I can never find a package that uses one and when I'm testing a feature that requires no patchsys, I can never find one without one [15:13] dholbach, http://bazaar.launchpad.net/~ubuntu-dev/ubuntu-dev-tools/trunk/revision/657 [15:15] bobbo: awesome - that looks great - you should add a changelog entry [15:15] dholbach, to debian/changelog? [15:15] yep [15:15] it's basically included by what mvo wrote on Monday [15:15] ah ok [15:15] he put "support adding existing patches (e.g. from launchpad)" [15:16] is debian/applied-patches going to be used even if I don't use a patch system at all and don't have an existing patch? [15:16] no, it's only touched when edit-patch is give an existing patch [15:17] ah ok [15:17] wonder if it'd make sense to also do it when there's no patch given [15:17] probably not [15:17] … although [15:17] it might make sense if people care enough to add the patch tagging guidelines [15:17] but anyway [15:18] we should probably be good now :D [15:18] yeah, that seems to be it working pretty well, there's probably some minor stuff I could sort but bash fries my brain :D [15:18] yeah :) [15:19] mvo chose it so we could maybe get it into devscripts at some stage [15:19] I started it in python [15:19] and he did it all the legwork to get it into shell [15:20] I've not worked in shell for a long time, I'm a total Python man at heart :D [15:20] yeah [15:20] everything else is a bit of a pain :) [15:41] dholbach, i want to see the result :) [15:42] daker: sorry, I was in what felt like 50000 conversations since we talked [15:42] I'll have a look at it now [15:45] :) oki take your time [15:46] daker: I hardcoded all of them [15:46] daker: bobbo.me.uk still doesn't work [15:48] well there is something wrong here : [15:48] i/* Ubuntu Reviews Gadget */ [15:48] remove the "i" [15:49] ugh [15:50] done, still broken :) [15:51] I get the same results in a plain test HTML file, so it's not my stylesheets killing it [15:53] no dholbach rehardcod all of them [15:53] dholbach, http://pastebin.com/5nbcV8v6 [15:54] that's them all hardcoded and it works on my system [15:54] var gadget =''+ [15:54] '

'+ [15:54] '

10%

'+ [15:54] '

10%

'+ [15:54] '

'; [15:54] document.write(gadget); [15:54] and in the default.css you should replace all the "images/" by "http://daniel.holba.ch/review/images/" [15:54] that's all :) [15:54] (script ran in the meantime) [15:54] 11% wooot [15:55] listen [15:55] put that line : [15:55] v [15:55] [15:57] yeeehaw [15:58] got it working on my site [15:58] daker and the uber-bar of review awesomeness get a mention in the daily update blog [15:58] bobbo: *I* got it working on your site - your 0wned! [15:58] ;-) [15:59] * dholbach shuts up - it's 30°C in here, I can't think straight [15:59] '

'+ [15:59] thanks a bunch daker and bobbo [15:59] add this [16:00] missing the '~' [16:01] dholbach, do you want me to put it in the wiki for you? [16:02] daker: maybe link to https://wiki.ubuntu.com/ReviewersTeam instead? [16:02] bobbo: that'd be sweet [16:02] oki as you like [16:02] super [16:02] just to correct the link [16:02] yep [16:04] other thing we can add later is to put on the left the number of patches or something like that [16:04] fixed now [16:04] at least on http://daniel.holba.ch/review/example.html [16:04] on bobbo's site it's cached [16:04] this looks GREAT [16:04] thanks a bunch daker [16:04] thanks bobbo [16:05] * bobbo isn't using dholbach's code yet, still using my own to grab it [16:05] ah ok [16:05] \o/ [16:05] no problem :) [16:06] woot, using dholbach's code works :D [16:06] dholbach, for the wiki, how often will that script run to update the numbers? [16:07] every 20 minutes [16:07] epic [16:13] woot! daker [16:14] \o/ [16:14] that's it on the wiki, too [16:15] bobbo: dholbach: what do you think of having the "patches reviewed" as in done on the top left ? [16:15] vish: I have no opinion - if you want to change and think it looks better: sure [16:15] vish, if it could fit in without making it look too full/messy, sounds awesome [16:15] the number would keep rising and look insane :D [16:16] daker: ^ probably the same font size as the % would do ..? "XXX Reviewed" [16:17] bobbo, where ? [16:17] yes [16:17] daker, https://wiki.ubuntu.com/OperationCleansweep [16:19] reviews = total - in queue ? [16:20] daker: what are all the numbers we are getting now? [16:20] from the scripts [16:21] daker: nvm , the total - in queue == done was what i meant :D [16:21] well done guys [16:23] dholbach, the .js file is generated with python ? [16:23] daker: yes [16:24] let me show you [16:24] http://bazaar.launchpad.net/~ubuntu-reviewers/ubuntu-review-overview/trunk/annotate/head:/countdown.py [16:24] line 9 to 23 [16:26] ok my friends - I call it a day - see you tomorrow! [16:41] cyphermox: poke [16:58] @patchcount [16:58] bobbo: Total: 2280 Left in Queue: 2016 11.6% complete [16:59] the count is weird [16:59] ugh, I didn't go through dholbach's code [16:59] its higher than what it should be [16:59] or it doesn't match the path to be reviewed list in the topic [16:59] seb128: working on it now :) [17:00] ok [17:00] nigelb: poke [17:01] cyphermox: I was wondering if you'd like to take a class at ubuntu user days [17:02] I'm going to call it a day here, have a good evening everyone :) [17:03] bobbo: night [17:03] nigelb: did you already have a specific subject in mind? [17:03] cyphermox: " Choosing hardware that works with Ubuntu [17:03] oooh [17:04] cyphermox: like it? ;) [17:04] yep [17:04] how did you know I'd be interested? [17:04] I know you're working on hardware certification at canonical ;) [17:05] You did tell me last time I talked to you. I remember things. :) [17:05] * cyphermox is starting to wonder just how much nigelb knows about him ;) [17:05] ah, i see ;) [17:05] * nigelb just has good memory :) [17:05] ok, so the schedule is here https://wiki.ubuntu.com/UserDaysTeam/lucid [17:05] is 0200 UTC okay with you? or do you want to go in between? [17:06] let me translate that [17:07] 0200 UTC is reasonable [17:07] ok, I'll put you down for 0200 :) [17:07] thanks for helping out, the event is on 10th July [17:07] that time ends up being on July 11th though, no? [17:08] (UTC) [17:08] yeah [17:08] but it should still be 12th for you [17:08] yes, still the 10th [17:09] err 10th, yeah [17:27] http://bobbo.me.uk/index.php/planet-ubuntu/operation-cleansweep-day-four-update <-- Day 4 update [17:53] \o/ [17:56] \o/ === daker_ is now known as daker [18:01] @patchcount [18:01] nigelb: Total: 2279 Left in Queue: 2014 11.6% complete === yofel_ is now known as yofel