| === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Hi adeuring, when you've time, can you please take a look at: https://code.edge.launchpad.net/~michael.nelson/launchpad/588288-log-parser-dont-read-entire-file-qa/+merge/27849 | 09:08 |
|---|---|---|
| adeuring | noodles775: sure | 09:08 |
| === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad | ||
| adeuring | noodles775: r=me, but with some complaints about the error haindling in parse_file() | 09:44 |
| === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad | ||
| noodles775 | Thanks adeuring, I'll take a look. | 09:47 |
| adeuring | noodles775: I'm just writung ione more comment ;) | 09:47 |
| === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado is now known as salgado-brb | ||
| === salgado-brb is now known as salgado | ||
| === sinzui changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | adeuring, I have a short branch for review. Are you available? | 16:18 |
| adeuring | sinzui: sure | 16:18 |
| adeuring | sinzui: r=me | 16:37 |
| sinzui | that adeuring | 16:37 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === kiko is now known as kiko-afk | ||
| krkhan | gmb: hello | 17:33 |
| gmb | krkhan, Hello. Still haven't had chance to do your review; will definitely do it within the next hour though. | 17:34 |
| gmb | Apologies | 17:34 |
| gmb | Crazy busy | 17:34 |
| krkhan | gmb: np. i'll just keep my fingers crossed ;) tyt | 17:38 |
| gmb | krkhan, Thanks :). Trying to get UI mockups done before the weekend. | 17:38 |
| === salgado-lunch is now known as salgado | ||
| sinzui | bac: are you on call after adeuring? | 18:37 |
| === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | sinzui: man i forgot all about it | 18:59 |
| bac | sinzui: yes, i'm supposed to be OCR today | 18:59 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | and so i am | 18:59 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || omThis channel is logged: http://irclogs.ubuntu.c/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| sinzui | thanks bac | 19:07 |
| bac | sinzui: not used to this friday shift | 19:07 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | sinzui: done | 19:15 |
| abentley | bac, could you please review https://code.edge.launchpad.net/~abentley/launchpad/skip-repeat-builds/+merge/27954 ? | 19:41 |
| bac | abentley: sure | 19:43 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: abentley || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | bac, thanks. | 19:43 |
| bac | abentley: done | 20:30 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | bac, thanks for your review. | 20:33 |
| bac | np | 20:33 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!