=== adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [09:08] Hi adeuring, when you've time, can you please take a look at: https://code.edge.launchpad.net/~michael.nelson/launchpad/588288-log-parser-dont-read-entire-file-qa/+merge/27849 [09:08] noodles775: sure === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad [09:44] noodles775: r=me, but with some complaints about the error haindling in parse_file() === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad [09:47] Thanks adeuring, I'll take a look. [09:47] noodles775: I'm just writung ione more comment ;) === adeuring changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews === mrevell is now known as mrevell-lunch === matsubara-afk is now known as matsubara === mrevell-lunch is now known as mrevell === salgado is now known as salgado-brb === salgado-brb is now known as salgado === sinzui changed the topic of #launchpad-reviews to: on-call: adeuring || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [16:18] adeuring, I have a short branch for review. Are you available? [16:18] sinzui: sure [16:37] sinzui: r=me [16:37] that adeuring === EdwinGrubbs is now known as Edwin-lunch === matsubara is now known as matsubara-lunch === salgado is now known as salgado-lunch === kiko is now known as kiko-afk [17:33] gmb: hello [17:34] krkhan, Hello. Still haven't had chance to do your review; will definitely do it within the next hour though. [17:34] Apologies [17:34] Crazy busy [17:38] gmb: np. i'll just keep my fingers crossed ;) tyt [17:38] krkhan, Thanks :). Trying to get UI mockups done before the weekend. === salgado-lunch is now known as salgado [18:37] bac: are you on call after adeuring? === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [18:59] sinzui: man i forgot all about it [18:59] sinzui: yes, i'm supposed to be OCR today === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [18:59] and so i am === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || omThis channel is logged: http://irclogs.ubuntu.c/ || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad/+activereviews === matsubara-lunch is now known as matsubara [19:07] thanks bac [19:07] sinzui: not used to this friday shift === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/+activereviews === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [19:15] sinzui: done [19:41] bac, could you please review https://code.edge.launchpad.net/~abentley/launchpad/skip-repeat-builds/+merge/27954 ? [19:43] abentley: sure === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: abentley || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [19:43] bac, thanks. [20:30] abentley: done === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews [20:33] bac, thanks for your review. [20:33] np === matsubara is now known as matsubara-afk