EdwinGrubbs | stub: I'm available for a little bit if you have questions regarding my merge proposal that fixes the branch that got reverted. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part3/+merge/28240 | 05:42 |
---|---|---|
stub | k | 05:44 |
=== EdwinGrubbs is now known as Edwin-zzzz | ||
=== jelmer_ changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
=== matsubara-afk is now known as matsubara | ||
=== mrevell is now known as mrevell-lunch | ||
=== salgado-afk is now known as salgado | ||
=== mrevell-lunch is now known as mrevell | ||
bac | hi mrevell | 13:50 |
mrevell | hi bac | 13:51 |
bac | mrevell: hey did you see my request for review? | 13:51 |
bac | part of it you've already seen. | 13:51 |
mrevell | Sorry, yes, I've been catching up from a day at Millbank. I'll get to it now. | 13:52 |
bac | mrevell: thanks. | 13:52 |
Edwin-zzzz | BjornT: can you do a db review of this branch, please. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part3/+merge/28240 | 14:12 |
=== Edwin-zzzz is now known as EdwinGrubbs | ||
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
bdmurray | EdwinGrubbs: could I get https://code.edge.launchpad.net/~brian-murray/launchpad/bug-130902/+merge/28246 reviewed? | 15:56 |
EdwinGrubbs | bdmurray: sure | 15:59 |
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: bdmurray || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
=== salgado is now known as salgado-lunch | ||
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
EdwinGrubbs | BjornT: ping | 16:46 |
=== matsubara is now known as matsubara-lunch | ||
=== salgado-lunch is now known as salgado | ||
jelmer_ | EdwinGrubbs: hi | 17:46 |
EdwinGrubbs | jelmer_: hi | 17:46 |
jelmer_ | EdwinGrubbs: Could you review a relatively simple soyuz branch? | 17:47 |
jelmer_ | EdwinGrubbs: Never mind, you already did. Sorry! | 17:47 |
=== jelmer_ changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
EdwinGrubbs | awesome, I love not having more work | 17:49 |
=== matsubara-lunch is now known as matsubara | ||
bac | hi mar | 19:23 |
bac | hi mars | 19:23 |
mars | hi bac, I've got a few minutes - what's up? | 19:47 |
bac | mars: not much. just wanted to chat about your review. the question is moot, though, as i've incorporated the changes | 19:48 |
mars | ok. Did you get a proper UI review yet? | 19:48 |
bac | yeah, curtis did it | 19:48 |
mars | Alright, just read the mail thread | 19:49 |
mars | bac, ok, so all is well then? | 19:50 |
bac | yeah | 19:50 |
=== matsubara is now known as matsubara-afk | ||
=== salgado is now known as salgado-afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!