| === matsubara-afk is now known as matsubara | ||
| === matsubara is now known as matsubara-afk | ||
| === jtv-afk is now known as jtv | ||
| === henninge_ is now known as henninge | ||
| jtv | henninge: do you want this one? https://code.launchpad.net/~jtv/launchpad/recife-another-testfix/+merge/29262 | 10:35 |
|---|---|---|
| henninge | jtv: anything to get this merge done ... ;) | 10:35 |
| jtv | henninge: the fix should work equally with or without the merge, so should be easy. | 10:35 |
| jtv | hi danilos | 10:39 |
| danilos | jtv, hi | 10:39 |
| henninge | danilos: hi ;) | 10:47 |
| henninge | jtv: you are talking "product series" but the change is about "distro series". Why is that? | 10:47 |
| jtv | henninge: probably a simple slipup... where exactly? | 10:48 |
| henninge | jtv: in the mp description | 10:48 |
| jtv | henninge: oh, then it's definitely a typo. Finger memory. | 10:49 |
| henninge | ok | 10:49 |
| henninge | let me just verify that htis helps ... ;) | 10:49 |
| jtv | As you would have guessed from factory.makeProductSeries(distribution=ubuntu) :-) | 10:49 |
| henninge | jtv: great. it works! | 10:58 |
| henninge | jtv: r=me | 10:58 |
| jtv | henninge: dankeschön! | 10:58 |
| henninge | jtv: will you merge it into recife right away? | 11:14 |
| jtv | henninge: it's currently pushing | 11:14 |
| henninge | great! :-D | 11:15 |
| jtv | It Is Pushed™ | 11:16 |
| henninge | I just remembered that there were also windmill tests failing. | 11:17 |
| jtv | henninge: got a log? | 11:19 |
| henninge | jtv: yes, it's in the same | 11:20 |
| henninge | http://people.canonical.com/~henninge/merged-lp.translations.tests.log | 11:20 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: lunch || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-luncheon | ||
| === matsubara-afk is now known as matsubara | ||
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === bigjools changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [bigjools] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| * bigjools waves at gmb | 13:19 | |
| gmb | Hullo | 13:19 |
| gmb | bigjools, Diff me. | 13:19 |
| bigjools | I just 'bzr send'ed the MP, it should appear shortly | 13:20 |
| gmb | RIghto | 13:20 |
| bigjools | https://code.edge.launchpad.net/~julian-edwards/launchpad/oops-dspr-page-bug-592417/+merge/29273 | 13:20 |
| gmb | bigjools, r=me | 13:38 |
| === gmb changed the topic of #launchpad-reviews to: On call: gmb || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bigjools | thanks gmb. And see yer next week. | 13:39 |
| gmb | Would've been quicker but I had a tea-based emergency | 13:39 |
| gmb | bigjools, Welcome. And likewise, unless I go blind in the interim. | 13:39 |
| bigjools | as in you needed more | 13:39 |
| bigjools | or as in you spilt it | 13:39 |
| gmb | bigjools, It had gone cold. | 13:39 |
| bigjools | oh disaster | 13:40 |
| gmb | Indeed. Calamity, oh woe is me, etc. | 13:40 |
| gmb | Thankfully, it has now been refreshed. Hurrah, etc. Let joy be unconfined. | 13:40 |
| bigjools | and on that note I need coffee. Some Finca el Fany awaits. | 13:40 |
| noodles775 | bigjools: I've marked the mp as ui=me, but with a small suggestion - see what you think. | 13:44 |
| bigjools | noodles775: ok cheers | 13:45 |
| bigjools | noodles775: see https://dogfood.launchpad.net/ubuntu/+source/uex/1.0.0.9-1/+index | 13:47 |
| bigjools | with that listing change | 13:47 |
| bigjools | I agree that the old way looks a bit odd, but this way looks more odderer :) | 13:48 |
| bigjools | noodles775: a third option to add to your suggestions would be to centre the data across the three <td>s | 13:50 |
| noodles775 | bigjools: there are other class (and class combinations) for tables in the stylesheet(s)... I'd recommend going with one of those (as they're what have been developed for consistency). | 13:54 |
| noodles775 | I think centering the data inside the td's would be odderer still ;) | 13:54 |
| bigjools | true | 13:54 |
| bigjools | :) | 13:54 |
| bigjools | noodles775: remind me where the css files live .... | 13:55 |
| === mrevell-luncheon is now known as mrevell | ||
| bigjools | ah found 'em | 13:56 |
| noodles775 | Great. | 14:01 |
| bigjools | noodles775: unfortunately nothing looks that good | 14:01 |
| * noodles775 has a look at product and other pages. | 14:02 | |
| noodles775 | bigjools: every table I can find is using the listing class? | 14:03 |
| noodles775 | That doesn't mean it looks good ;), but does mean that it would be best to use it and if we later improve the look of table.listing, they'll all be improved together... or is it something particular about this instance that you didn't like? | 14:04 |
| bigjools | noodles775: ok what about now? | 14:04 |
| noodles775 | What don't you like about it? (and definitely not if you're going to land this RC ;) 0. | 14:05 |
| bigjools | interestingly FF doesn't render the end of the "Size" heading cell marker | 14:05 |
| bigjools | it's too wide | 14:05 |
| bigjools | it only needs to fill the space it needs | 14:05 |
| bigjools | IMO | 14:06 |
| noodles775 | That's what the 'narrow' class is for in the stylesheet... not sure why it's not doing anything though. | 14:08 |
| bigjools | there's a "compressed" as well but it doesn't do anything either | 14:08 |
| bigjools | noodles775: aha, check it now | 14:09 |
| bigjools | not sure about the "-" characters | 14:09 |
| bigjools | maybe just leave it blank | 14:10 |
| noodles775 | hmm... it's still wide for me (I've shift-refreshed). What classes did you add? | 14:10 |
| bigjools | noodles775: it renders differently on Chrome and FF :/ | 14:11 |
| noodles775 | According to the chromium inspector, the 'narrow' isn't doing anything... | 14:11 |
| bigjools | "narrow listing" | 14:11 |
| noodles775 | ah. | 14:11 |
| * noodles775 looks in FF | 14:11 | |
| * bigjools shakes fist at browsers | 14:11 | |
| noodles775 | bigjools: so right, I think you've found the right classes, and up to you whether you leave the '-' in or not. | 14:12 |
| noodles775 | Might be worth checking with sinzui or creating a bug about the 'narrow' class seemingly being ignored on chromium. | 14:13 |
| noodles775 | (just in case he already is aware of it). | 14:13 |
| bigjools | yeah, I'll stick with "narrow" then and file the bug | 14:13 |
| bigjools | cheers | 14:13 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === sinzui changed the topic of #launchpad-reviews to: On call: gmb, mars || reviewing: - || queue: [sinzui] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | gmb, mars: I have a branch that removes lots of crufty lint checking | 14:55 |
| mars | sinzui, I'll take it | 14:56 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || reviewing: -,sinzui || queue: [sinzui] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| mars | sinzui, out of curiosity, does pylint have a test suite? | 15:00 |
| mars | specifically, a test suite with sample data | 15:00 |
| sinzui | I do not think it does | 15:01 |
| sinzui | It does not have a public bug tracker | 15:02 |
| mars | sinzui, does your linter choke on conflict markers? '<<<' and '>>>' | 15:03 |
| sinzui | no | 15:03 |
| mars | does it flag them? :) | 15:03 |
| sinzui | It looks for 7 start or close, which is better than what we had | 15:03 |
| mars | 7 start or close? | 15:04 |
| sinzui | mars: our linter reports the start of a conflict marker. pocketlint report the start and the end | 15:04 |
| mars | ah, ok | 15:04 |
| mars | sinzui, why was jslint was removed from the list of checks? Do we have a backup? | 15:06 |
| sinzui | pocket-lint uses spider-monkey too | 15:06 |
| sinzui | it however reports problems consistently with all the other linters | 15:07 |
| mars | sinzui, a simple test should verify that - remove a semicolon from a JS file, see if it catches it | 15:08 |
| sinzui | yep | 15:08 |
| mars | I did not even know we had this lp-verbose.py stuff | 15:09 |
| sinzui | I do | 15:09 |
| mars | it's like rummaging through an attic | 15:09 |
| sinzui | You could run lint.sh manually to do a serious analysis of modules to locate duplicate code | 15:09 |
| mars | sinzui, reviewed | 15:23 |
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || reviewing: -,- || queue: [sinzui] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mars changed the topic of #launchpad-reviews to: On call: gmb, mars || reviewing: -,- || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | thanks | 15:24 |
| sinzui | mars, python-pocket-lint is a launchpad-developer-dependency. Did you update today and do you see that we guarantee the file? | 15:38 |
| mars | update-manager died with a system crash, so no, I missed that :p | 15:39 |
| mars | How ironic is it that change that come from our PPA are not "a source that supports changelogs" | 15:41 |
| mars | sinzui, ok, got it, thanks. You may want to tell the lp-dev list after this lands. | 15:41 |
| bigjools | mars: hysterical raisins | 15:42 |
| sinzui | mars, I certainly will. I get to end two action items from the reviewers and team lead meetings | 15:43 |
| mars | nice | 15:43 |
| === matsubara is now known as matsubara-lunch | ||
| === gmb changed the topic of #launchpad-reviews to: On call: mars || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| adeuring | gary_poster: fancy a review of my branch "make LFA.restricted changable"? https://code.edge.launchpad.net/~adeuring/launchpad/bug-39674-lfa-editable/+merge/29314 | 17:31 |
| gary_poster | adeuring: what could you possibly be talking about? ;-) Sure, looking | 17:31 |
| adeuring | gary_poster: thanks! | 17:31 |
| === matsubara-lunch is now known as matsubara | ||
| === jtv is now known as jtv-afk | ||
| === benji is now known as benji-lunch | ||
| gary_poster | approved, adeuring | 17:55 |
| adeuring | gary_poster: thanks! | 17:56 |
| gary_poster | np :-) | 17:56 |
| adeuring | gary_poster: thanks for your suggestion to use assertRaises(setarr...) | 18:04 |
| gary_poster | adeuring: welcome, glad you like it | 18:04 |
| === salgado is now known as salgado-lunch | ||
| === benji-lunch is now known as benji | ||
| === salgado-lunch is now known as salgado | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| bac | mars are you around much longer for another review? | 22:29 |
| mars | bac, gah, no, sorry, being burned by the release now :( | 22:29 |
| === mars changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| bac | ah right | 22:29 |
| bac | no problem | 22:30 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!