/srv/irclogs.ubuntu.com/2010/07/07/#bzr.txt

gregcoithi.  how do I undo a "bzr rm"?  no other commands have been run since then (like "bzr ci").00:02
maxbbzr revert pathname should do it00:06
gregcoitmaxb: ty - that worked!00:06
lifelessmgz: deryck00:33
pooliegood morning00:50
pooliehi lifeless00:50
lifelesshi poo00:50
lifelesshi poolie00:51
pooliesnort00:52
mgzyou really want those last three letters00:53
mgzlifeless: should I bug him on irc or subscribe him to the bug or what?00:54
lifelessmgz: overloaded word that00:55
lifelessI'd discuss with him00:55
lifelessand see if he wants a unique bug or what have you00:55
mgzthanks.00:55
=== jam changed the topic of #bzr to: Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: poolie | bzr 2.1.1 is out | bzr 2.1.2 is having binaries built for it | Launchpad down/read-only from 23:00 - 00:30 UTC for a code update
spivGood morning.01:04
lifelesshola01:06
=== Chex changed the topic of #bzr to: Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: poolie | bzr 2.1.1 is out | bzr 2.1.2 is having binaries built for it
pooliehi there spiv02:25
thumperin the bzrlib source02:37
thumperis there a method to do interdiffs?02:37
pooliethumper: i don't think so-02:38
lifelessmmm02:38
lifelessdepends on what you mean02:38
thumperI'd really like to not to have to shell out to interdiff binary02:38
lifelessok, that, no - we haven't done that yet.02:38
thumperI have an old review diff, and a new review diff generated from newer commits02:39
thumperI want to see the difference between them02:39
thumper(and email it out)02:39
lifelessright, lp mp incremental changes ?02:39
thumperyep02:39
lifelessif I can suggest a different way02:39
lifelessyou have the old tip O and the new tip N02:40
lifelessdo a preview-merge with O and get a tree - not a diff02:40
lifelessdo a preview-merge with N and get the tree.02:40
lifelessthen do diff between the two preview trees02:40
lifelessI'd expect that to be more useful, and its not going to be an interdiff, so its easier to read.02:41
thumperare preview trees up to that yet02:42
thumper?02:42
lifelessIf they aren't it will be straight forward to fix I suspect02:42
lifelessif they aren't I'd really like to know anyhow :)02:42
poolielifeless: re ease of reading, the output of interdiff is not a diff of diffs02:54
poolieiirc02:54
poolieit's just a diff02:55
lifelessah yes02:55
lifelessI'm thinking debdiff02:55
lifelesswhich is interdiff02:55
lifelessof patches02:55
lifelessand known to blow up spectacularly with some packages02:56
pooliejam (if any), lifeless, we need a way to get debug info for out of memory errors02:56
lifelesspoolie: nevertheless the failure modes in two previews seem better to me, IMBW.02:57
lifelesspoolie: yes, agreed.02:57
lifelesshmm, -Derror should give us something02:58
pooliecan anyone confidently answer about bzr-svn in https://answers.edge.launchpad.net/bzr/+question/11686803:00
pooliethere is a bug for this03:00
pooliemay need jam jam03:00
lifelessjam jam ?03:01
jamlifeless, poolie: you rang?04:08
lifelessI didn't; poolie may have04:08
jampoolie: what sort of mem info do you want?04:08
lifelessjam: there is an OOM error occuring on a 30MB file according to some guy in some bug report.04:09
pooliejam, when bzr crashes with MemoryError i'd like us to get some useful debugging info back from the user04:09
lifelessbe nice to be able to see whats really oging on.04:09
pooliethere's a bug asking for this04:09
jampoolie: I remember chatting with you about this a bit. One of the problems is that stuff like 'str' objects aren't in the gc list04:12
jamstrs and ints/floats/etc being the most obvious not present04:13
jamand now StaticTuple :)04:13
poolieso i guess the question is:04:15
poolieif there is any data we could easily report we should do it04:16
poolieeven if it's not 100% complete or if it's useful in only a subset of cases04:16
jampoolie: well, you can certainlly call trace.debug_memory()04:16
jamwhich would at least tell you vmpeak and vmsize, etc04:17
=== poolie changed the topic of #bzr to: Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: poolie | bzr 2.1.2 is out
pooliemm, we should put that into the apport file ,if we don't already04:17
pooliei don't know if that will tell us _why_ we ran out though04:18
poolieperhaps the traceback may give some clue04:18
pooliecan we take the question that you'd ask the user experiencing an oom problem04:18
poolieand automatically answer it when they first hit the bug?04:18
jampoolie: I'd have to think about what the first questions would be. Things I would usually ask are stuff like "what action were you taking" which should already be in the log file04:58
jamwhat the size of files are you working with04:58
jamI think that would be a bit hard to automatically answer04:58
jamknowing the sizes of objects in the frames on the stack could be useful05:00
pooliejam i guess we could walk up the stack and print either the actual contents of the locals, or some data about them05:12
pooliesuch as their estimated size05:12
jampoolie: I think contents is risky, but size could be reasonable05:12
pooliesome risk of leaking private data there05:12
jamwell, I'm thinking more about 100MB files05:13
pooliethat too05:14
pooliethere is a cgitb module that does some of this05:14
poolieincluding trimming large values05:15
poolieso there's a function (in meliae?) that estimates the size of an object?05:15
jampoolie: in python 2.6 you can use sys.getsizeof()05:30
jammeliae also exposes something like this05:30
poolieok05:30
poolieso this won't tell us if we're using lots of memory in a global not referenced by the stack05:31
poolieand it would probably be too noisy to print all the globals05:31
pooliebut that may be an unusual condition05:31
pooliei guess we could print globals using a lot of memory05:31
jamwe could walk gc.get_referents() at a cost of 1 pointer per object05:34
pooliecost in terms of needing to allocate more memory to do that?05:37
jamyeah05:53
jamfor the list that holds it05:53
jamit could be a problem if we are already oom05:54
lifelessjam: for when you awake.06:21
lifelesshttps://bugs.edge.launchpad.net/bzr-builddeb/+bug/55295006:22
ubot5Launchpad bug 552950 in bzr-builddeb "Additional changelog entries are modified when merging another branch (affected: 1, heat: 10)" [Medium,Triaged]06:22
lifelessplease comment06:22
yaoif I commit 10 times, from rev 1 to rev 10, in my local branch, and didn't push them to remote branch yet,06:57
yaoI want to uncommit commit #5, what should I do?06:57
yao'bzr uncommit' doesn't help,06:57
poolieyao: it depends on exactly what you want07:05
pooliedo you want to pretend #5 never happened, or do you want to just reverse it's effect?07:05
yaopoolie: former, I think,07:06
* yao is wondering whether it is possible to pretend #5 never happened07:06
aidalgolGoogle is turning up nothing on this: is it safe to edit .bzrignore?07:45
spivYep.07:49
aidalgolOK, good.07:52
aidalgolWhy might this line (in a .bzrignore) have *two* stars?07:53
aidalgollisp/**/loaddefs.el07:53
spivaidalgol: see 'bzr help ignore', it explains the patterns08:00
spiv(Also, 'bzr help patterns')08:00
spivTo answer your specific query: "/**/ - Matches 0 or more directories in a path"08:01
pooliehi there spiv, vila08:59
vilahey poolie08:59
pooliesorry yao i missed you there09:00
poolieare you still here?09:00
pooliehave a look at the bzr-09:00
pooliehave a look at the bzr-rewrite plugin09:00
yaopoolie: I am here...09:00
pooliedo you want to keep the later commits as distinct commits?09:01
poolieor are you happy to fold them into just one?09:01
yaopoolie: I want to keep later commits as distinct ones...09:03
* yao is looking at https://launchpad.net/bzr-rewrite09:03
poolietry bzr help rebase09:05
pooliewe should document that specific case09:22
yoroyHow do I find where bzr is intalled on OS X? Trying to get the Eclipse plugin working.10:36
C-Keenyoroy: which bzr will tell you on a Terminal10:45
yoroyC-Keen: forgot to mention I don't want to use a Terminal10:46
yoroy:)10:46
yoroybut I could handle it if I knew the command10:46
C-KeenI don't understand10:46
GaryvdMmgz: Ping10:47
yoroyC-Keen: the eclips plugin asks me for the path to the bzr executable. I don't know how to find that path10:47
C-Keenyoroy: well type 'which bzr' on a Terminal and you know10:47
yoroyC-Keen: thank you10:48
mgzpong garyvdm, but I'm leaving in five minutes, hopefully be around a bit later though10:52
GaryvdMHi mgz10:52
GaryvdMThe .pyo in the installer were fine10:52
GaryvdMfor plugins10:53
GaryvdMbut the .pyo that were created for plugins that I had in BZR_PLUGIN_PATH got doc strings removed10:53
mgzdid you see the log?10:54
GaryvdMSo if we could get the files in library.zip to be -OO10:54
mgzyou've not got the final part of my don't-recompile-plugin-pyo-files fix10:54
GaryvdMbut leave the exe as -O10:54
GaryvdMOh - were is that?10:55
mgzyou need the recent change to bzr setup.py and/or the third rev in the bzr-windows-installer merge proposal10:55
mgz<GaryvdM> but leave the exe as -O <- if one of us can work out how to do this, it would also be good.10:55
GaryvdMOk - I find that an try a build...10:55
mgzI saw the bug with recompilation and stopped investigating there, but getting the exe as -O would be good.10:56
GaryvdMmgz: maybe build the library.zip ourselfs10:56
GaryvdMOk cool.10:57
mgzthere's probably a neater way, just didn't get as far as looking for it.10:57
GaryvdMThanks10:57
mgzokay, leaving now.10:58
bobsleehi, does bzr explorer install without a glitch on mac osx?14:02
GaryvdMbobslee: The installer works well14:12
GaryvdMbobslee: There are some polish issues on mac though - like the app name in the menu shows as "python".14:15
GaryvdMbobslee: I'm also not sure if it installs a app icon, so either run "bzr explorer" from a terminal, or create a shortcut icon.14:17
bobsleeGaryvdM: ok thanx for info. But it requires a bunch of dependencies Qt, QBzr.. takes a while to install?14:24
GaryvdMbobslee: Maybe you are reading a old info. The latest installers have every thing you need.14:26
GaryvdMbobslee: http://wiki.bazaar.canonical.com/MacOSXBundle/SnowLeopard14:27
GaryvdMbobslee: What version of Mac OS do you have14:27
bobslee10.5 (leopard)14:28
GaryvdMbobslee: The 10.6 installer has everything, but for the 10.5 installer, you have to install Qt14:28
bobsleeGaryvdM: allrighty, thanx I'll give it a try14:29
GaryvdMbobslee: http://wiki.bazaar.canonical.com/MacOSXBundle14:29
bobsleeGaryvdM: do you whether bzr supports reverse merging (like i.e. in svn: merge -r1000:993) ?14:31
GaryvdMbobslee: yes14:31
bobsleeGaryvdM: I prefer to install bzr (explorer) via macports. Is that a good choice? - because I want to prevent dependency/upgrade nightmares..14:34
GaryvdMbobslee: my experience no, but I don't use a mac much, so I would say investigate yourself.14:35
GaryvdMbobslee: check if they have the latest versions...14:35
bobsleeGaryvdM: thanx again14:56
detrituxhi all. I've been trying to push my local modification to my launchpad project for a while but never succeeded: Transport operation not possible: readonly transport15:43
detrituxI added my ssh keys to launchpad and logged into launchpad from my bazaar explorer as described in one of the tuto15:43
detrituxany ideas?15:43
GaryvdMdetritux: Have you done 'bzr launchpad-login'?15:51
detrituxyes I did that in the bazaar explorer15:51
detrituxif I run it without any arguments it prints my login so I assume it worked15:51
GaryvdMdetritux: What is the url that you are pusing to.15:52
detrituxbzr+ssh://bazaar.launchpad.net/~ugocupcic/sr-ros-interface/trunk/15:53
GaryvdMdetritux: That's odd.15:53
detritux:S yeah, I only found tutorials / forums and it seemed quite straightforward each time15:54
GaryvdMdetritux: could you please pastbin the relevant entry from ~/.bzr.log15:54
detritux0.173  bazaar version: 2.1.115:57
detritux0.173  bzr arguments: [u'commit', u'-m', u'added dependency to robot_state_publisher for easier build.', u'shadow_robot/sr_hand/manifest.xml']15:57
detritux0.175  encoding stdout as osutils.get_user_encoding() 'UTF-8'15:57
detritux0.210  ssh implementation is OpenSSH15:57
detritux8.869  opening working tree '/home/genugo/Projects/st-ros-interface'15:57
detritux8.934  Traceback (most recent call last):15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 853, in exception_to_return_code15:57
detritux    return the_callable(*args, **kwargs)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1055, in run_bzr15:57
detritux    ret = run(*run_argv)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 661, in run_argv_aliases15:57
detritux    return self.run_direct(**all_cmd_args)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 665, in run_direct15:57
detritux    return self._operation.run_simple(*args, **kwargs)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 122, in run_simple15:57
detritux    self.cleanups, self.func, *args, **kwargs)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups15:57
detritux    result = func(*args, **kwargs)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/commands.py", line 788, in run15:57
detritux    return run_subprocess_command(cmd, bencoded)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/subprocess.py", line 789, in run_subprocess_command15:57
detritux    return commands.run_bzr(argv)15:57
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1055, in run_bzr15:58
detritux    ret = run(*run_argv)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 661, in run_argv_aliases15:58
detritux    return self.run_direct(**all_cmd_args)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 665, in run_direct15:58
detritux    return self._operation.run_simple(*args, **kwargs)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 122, in run_simple15:58
detritux    self.cleanups, self.func, *args, **kwargs)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups15:58
detritux    result = func(*args, **kwargs)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 3138, in run15:58
detritux    exclude=safe_relpath_files(tree, exclude))15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 192, in write_locked15:58
detritux    self.lock_write()15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/workingtree_4.py", line 618, in lock_write15:58
detritux    self.branch.lock_write()15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 2377, in lock_write15:58
detritux    remote_tokens = self._remote_lock_write(token)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 2367, in _remote_lock_write15:58
detritux    repo_token or '', **err_context)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 52, in _call15:58
detritux    return self._client.call(method, *args)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/client.py", line 132, in call15:58
detritux    result, protocol = self.call_expecting_body(method, *args)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/client.py", line 145, in call_expecting_body15:58
GaryvdMdetritux: Next time, please use something like http://pastebin.org/ when you paste :-)15:58
detritux    method, args, expect_response_body=True)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/client.py", line 81, in _call_and_read_response15:58
detritux    expect_body=expect_response_body),15:58
mwhudsondetritux: paaaaaaaaaaaste bin15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/message.py", line 306, in read_response_tuple15:58
detritux    _translate_error(self.args)15:58
detritux  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/message.py", line 355, in _translate_error15:59
detritux    raise errors.LockFailed(*error_args[:2])15:59
detrituxLockFailed: Cannot lock LockDir(lp-70455952:///~ugocupcic/sr-ros-interface/trunk/.bzr/branchlock): Transport operation not possible: readonly transport15:59
detritux8.934  Transferred: 1KiB (0.1K/s r:1K w:1K)15:59
detritux8.934  return code 315:59
detritux411.969  Traceback (most recent call last):15:59
detritux  File "_dirstate_helpers_pyx.pyx", line 1852, in bzrlib._dirstate_helpers_pyx._loop_one_block15:59
detrituxStopIteration15:59
iocoroh my lord15:59
detritux417.318  return code 115:59
detrituxa bit long, sorry :S15:59
detrituxsorry guys, I'll use pastebin next time15:59
mgzis your launchpad username *not* ugocupcic?16:00
mgzbecause you can't push to other people's branches.16:00
GaryvdMmgz: /whois detritux = "Ugo Cupcic"16:01
GaryvdMSeems like that is his user :-)16:01
detrituxyeah16:02
mgzokay, that's me out. anyone else?16:02
GaryvdMdetritux: I just want to make sure about something. Please will you pastebin 'bzr info'.16:06
mgzon his local branch rather than the lp one?16:06
GaryvdMYes16:06
GaryvdMAh - maybe bug 41265716:07
ubot5Error: Could not parse data returned by Launchpad: The read operation timed out (https://launchpad.net/bugs/412657)16:07
detrituxhttp://pastebin.org/38532216:07
GaryvdMhttps://bugs.edge.launchpad.net/bzr/+bug/41265716:07
ubot5Launchpad bug 412657 in Bazaar "update fails when trying to lock master branch (in a readonly checkout) (dup-of: 412223)" [Undecided,New]16:07
ubot5Launchpad bug 412223 in Bazaar "bzr up locks master branch (affected: 2, heat: 4)" [High,Confirmed]16:07
mgzthat bug doesn't seem to have anything for cause or workaround...16:08
detrituxhm unbind / rebind I can try that16:09
mgzoh, wait, bind/unbind/redo16:09
detrituxhow do you unbind ?16:09
mgzbzr unbind && bzr bind16:09
detritux:D16:10
mgzif that fixes it for you I'd wham an "affects me to" on that bug.16:11
GaryvdMmgz: Can we chat re installer -OO?16:11
GaryvdMtime ok?16:12
mgzyup, I'm back and lunched now16:12
GaryvdMCool - so I was building with all your patches16:12
mgz^or rather, affectsmetoo on the bug that one is duped against I guess16:13
* GaryvdM get branch urls to prove16:13
detrituxyeah I'll do that if it fixes it16:13
mgzand... stuff still breaks?16:13
GaryvdMYes.16:13
mgzmeh, my timestamp checking lines are scrolled out of buffer16:14
mgzI think I pasted them in here though...16:14
GaryvdMmgz: The issues was that a plugin that was allready installed on disk from source in a manually set BZR_PLUGIN_PATH got compiled with -OO when bzr.exe ran.16:15
mgzbasically, need see if the mtime of the py file which complains is the same as the stamp in the packaged pyo file16:15
mgzoh, that's possibly expected16:16
mgzif it was never actually installed with optimize16:16
GaryvdMmgz: when I did "set BZR_PLUGIN_PATH=" then it worked...16:16
mgzone of the things I wanted to find out with that patch is if it's common to use from-source plugins with bundled installers16:16
mgzwhich strikes me as dodgy compared to installing into the right plugin dir, but if non-devs actually do it...16:17
GaryvdMmgz: So the only way that I see -OO viable is if we can get it so that library.zip is compiled as -OO but the .exe is not .16:18
mgzif people actually do that, I agree (for the moment, a future way is just to mark up plugin cmd objects as well)16:19
GaryvdMmgz: Your patches to prevent pyo recompile are still valuable though...16:19
mgzI'll poke around in py2exe16:19
GaryvdMmgz: How much difference does -OO make compared to -O?16:20
GaryvdMmgz: I think it would be good to try measure.16:20
mgznot much, a couple of megs to library.zip and a fractional cold startup improvement16:20
mgzAlexander did a couple of tests at UDS for me when we were merging it16:21
mgzhttps://code.launchpad.net/~gz/bzr/support_OO_flag_installer/+merge/2448416:22
GaryvdMmgz: the branches that I built with: lp:~garyvdm/bzr-windows-installers/maybe and lp:~garyvdm/bzr/2.2b3+packing16:23
GaryvdMThe latter now has the org -OO patch reverted.16:23
mgzdod you know if there'll be a 2.2b4 from the current trunk?16:23
GaryvdMBla - lp is sloooow at the moment.16:25
GaryvdMmgz: according to https://edge.launchpad.net/bzr/2.2 - yes16:25
mgzis that lp's fault or your undersea cable's?16:26
GaryvdMOh yeah - I forgot about that.16:26
mgzokay, reading py2exe source, doesn't seem to be a configurable way of doing it, but could easily chop it in16:34
GaryvdMmgz: 7.7% faster cold start - Ok - that makes it worth it ...16:39
GaryvdMmgz: We could also maybe look at which plugins we can do a -OO on, and which not...16:40
mgzwell, it's not a big job to just fix them all16:40
mgzbut messing with py2exe looks amusing16:41
GaryvdMmgz: Would it work  if we ran byte_compile(optimize=2) for everything going it to library.zip, and then did py2exe with optimize=1 .16:46
GaryvdMmgz: or does it compile from scratch?16:47
mgznope.16:47
mgzsec, I'll give you a diff to try16:47
mgzhttp://paste.ubuntu.com/460272/ < how about that for a horrible hack16:52
GaryvdMNot to bad.16:54
detrituxGaryvdM: ah I found my real problem in fact. You can't commit on a branch that's being pulled from a svn. That's logical... thanks for your help16:54
GaryvdMmgz: Suggestion: In build_executable, remember what optimize was, and then restore it.16:56
mgzI started writing that, then I looked at the diff context and decided it was silly16:56
mgzreally that's a sensible setting we want to keep, so would be best to get a proper version upstream16:57
GaryvdMmgz: +1 for upstream.16:57
mgz...last release was 200816:58
mgzI've got theller to look at patches before though so can probably get it in svn at least17:00
GaryvdMVery useful: http://pastebin.org/38536117:01
mgzyeah, methods are bound late, get a different object back each time17:03
* GaryvdM goes to find food.17:03
lifelessvila: hi19:15
lifelessvila: Is it true, a fix for the locking thing is in 2.1 branch? if so, we should get it into the LP tree19:16
elmoblah, what's the bzr push trick to push to where I just branched from?20:02
elmoI thought it was bzr push --parent, but it's not that20:02
james_wpush :parent20:04
elmojames_w: thanks20:04
lifelessjames_w: hi20:30
james_whi lifeless20:30
lifelessI've pushed up a test20:31
lifelessI'm going to try and get some more love in place today and tomorrow20:31
lifelessI can has review? [or is it buried in my email overnight?)20:31
james_wlifeless: I'm in the middle of looking at it20:31
james_wit looks broadly fine20:31
lifeless\o/20:32
lifelessthanks20:32
lifelessI realise the test style is a fresh one20:32
lifelessits not quite -right- but its broadly where I want things to be20:32
lifelessI think its fairly readable ?20:32
james_wI don't think you need to use dh-make, but I can understand that working out the needed steps might be a bit much20:32
lifelessjames_w: if you want to give me a recipe to slot into that fixture, great.20:32
james_wyeah, it's fairly readable20:33
lifelessI was fighting a bit of an uphill battle at the time ;)20:33
james_wit's not what I would expect fixtures to be used for really20:33
lifelessthats interesting20:33
james_wwell, at least say the FileMovedReplacedUpstream part20:33
james_wI would expect to have something like BranchBuilder, where you call methods, rather than compose fixtures20:34
james_wI'm happy to see how this develops though20:34
lifelessgreat20:37
lifelessI'll use these as a basis for the next patch too then20:37
lifelessits why I wanted to get this one seen to rapidly, to avoid a big pile of 'nooo' from you :)20:37
james_wheh20:43
james_wI just think that the method calls would make reading the intent of the test easier, but let's find out20:44
lifelessit would be nice20:44
lifeless(perhaps)20:44
lifelessto do @with_fixture(fixture_description_here)20:45
lifelessthats kindof the philosophic reason for making it all declarable rather than procedural20:45
lifelessone of the .. reasons20:45
lifelessanother is to be able to switch out implementations very easily, a BranchBuilder is more monolithic, so you would switch out all at once rather than granularly.20:46
=== davidstrauss_ is now known as davidstrauss
davidstraussHow can I make Loggerhead only bind to localhost?22:46
davidstraussnvm22:47
=== oubiwann is now known as oubiwann-away
=== oubiwann-away is now known as oubiwann

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!