[12:41] <jtv> On call: jtv || reviewing: foxxtrot || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[18:13] <EdwinGrubbs> jtv: are you not reviewing today?
[18:13] <jtv> EdwinGrubbs: yes, but done.
[18:13] <jtv> Well, done accepting new reviews.
[18:13] <EdwinGrubbs> ok, nm.
[18:15] <EdwinGrubbs> bac: according to the kanban board, you're waiting for a review. Do you want me to take it? I have one if your bored?
[19:52] <bac> hi Edwin-lunch
[19:53] <bac> the kanban is not exactly right.  the branch has been reviewed but i'm making the suggested changes.
[21:49] <leonardr> Edwin, can you review https://code.edge.launchpad.net/~leonardr/launchpad/grant-permissions-oauth/+merge/29425 ?
[21:49] <leonardr> gary: i'd also like your opinion on the naming of the new access level and the wording of its description
[21:49] <gary_poster> leonardr: ack
[21:50] <leonardr> f'rinstance, manage_permissions might be better than grant_permissions?
[21:52] <jml> hey, I'm not around
[21:52]  * leonardr ponders that
[21:52] <jml> but if I were, I'd be asking whether this is relevant to the gpg/ssh key discussion on the mailing list
[21:52] <EdwinGrubbs> leonardr: sure
[21:53] <jml> as it is, I'm not.
[21:53] <leonardr> jml, let me take a stab at it without knowing the exact details of the current discussion, based on past discussions
[21:54] <leonardr> there is a solution to this problem that involves gpg keys and digital signatures. however, that solution is more confusing to the unskilled end-user than the 'open a web browser' solution
[21:56] <jml> hey look, lifeless and wgrant are talking about it :)
[21:56] <leonardr> all right, i'll go over there
[21:56] <jml> leonardr, I'm going to wish you the best of luck while I fetch myself a digestiv, open a novel and retire for the evening.
[22:08] <gary_poster> leonardr: From an end user perspective, Grant Permissions is a much better title because it reflects the common action (and the danger); and let's keep the code name matching it, even though "manage" is more complete and accurate.
[22:08] <gary_poster> User description wordsmithing: WDYT of changing "Not only will the application will be able to access Launchpad on your behalf, it will be able to grant access to your Launchpad account to any other application." to "The application will be able to grant access to your Launchpad account to any other application "
[22:08] <gary_poster> IOW, get rid of "Not only will the application will be able to access Launchpad on your behalf,"
[22:09] <leonardr> makes sense
[22:13] <gary_poster> cool.  Otherwise, looks good.  Thank you.
[22:42] <EdwinGrubbs> leonardr: review sent
[22:42] <leonardr> thanks