=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
=== salgado-afk is now known as salgado
=== stub1 is now known as stub
[14:46] <EdwinGrubbs> noodles785: are you reviewing today?
[14:48] <noodles785> EdwinGrubbs: I haven't been no (I'm currently working on an ISD project), but if you've something urgent I can take a look.
[14:48] <EdwinGrubbs> no, it's not urgent
[14:48] <EdwinGrubbs> nevermind
=== deryck is now known as deryck[lunch]
[16:02] <EdwinGrubbs> rockstar: are you reviewing today?
[16:13] <rockstar> EdwinGrubbs, indeed I am, as soon as I get my shit together for the morning.
[16:13] <rockstar> EdwinGrubbs, go ahead and throw yourself on queue.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [Edwin] || RC branches jump the queue || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[16:14] <EdwinGrubbs> here's the mp: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-568390-cyclic-membership-error/+merge/29407
=== rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: Edwin || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck[lunch] is now known as deryck
=== matsubara is now known as matsubara-lunch
[17:35] <rockstar> EdwinGrubbs, maybe validateOwner's abstract method should return False or raise NotImplementedError.
[17:37] <EdwinGrubbs> rockstar: it's not required that validateOwner() be overridden. The vocabulary normally does a good enough job. This is the only subclass that actually does override it.
[17:37] <EdwinGrubbs> so raising NotImplementedError isn't necessary, and returning false would be meaningless.
[17:38] <rockstar> EdwinGrubbs, pass seems like it's very unopinionated
[17:39] <EdwinGrubbs> rockstar: it's no different than LaunchpadFormView.validate().
[17:44] <rockstar> EdwinGrubbs, okay.
=== matsubara-lunch is now known as matsubara
=== rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-dr
=== matsubara is now known as matsubara-afk
=== rockstar changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gary_poster is now known as gary-afk