| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === adeuring1 is now known as adeuring | ||
| noodles785 | Hi adeuring, I've got some small cleanups to some branches you looked at last week (it didn't get to land before pqm closed). I've merged them into devel and removed some unnecessary code. Can you take a look when you've time? | 10:46 |
|---|---|---|
| noodles785 | https://code.edge.launchpad.net/~michael.nelson/launchpad/598464-get-or-create-in-devel/+merge/29442 | 10:46 |
| adeuring | noodles785: ok, I'll look | 10:46 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: noodles785 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles785 | It's not really 853 lines, the diff from what you've already reviewed is 100 lines (as on the MP) | 10:46 |
| noodles785 | Thanks. | 10:46 |
| === noodles785 is now known as noodles775 | ||
| adeuring | noodles775: so, I should look at the diff between r11095 and 11098? | 10:48 |
| noodles775 | adeuring: yep, which I've pasted there for you (well, except for r11098 adds the __future__ import). | 10:49 |
| adeuring | noodles775: r=me | 11:16 |
| noodles775 | Thanks adeuring | 11:17 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado-dr is now known as salgado | ||
| === gary-afk is now known as gary_poster | ||
| bac | hi adeuring | 14:39 |
| adeuring | hi bac! | 14:39 |
| bac | doesn't look to be too busy today | 14:39 |
| adeuring | bac: yeah, I did just review. | 14:40 |
| === deryck is now known as deryck[lunch] | ||
| === salgado is now known as salgado-lunch | ||
| === adeuring changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === deryck[lunch] is now known as deryck | ||
| === salgado-lunch is now known as salgado | ||
| === gary_poster is now known as gary-afk | ||
| === salgado is now known as salgado-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!