[00:56] a private team can apparently not review merge-proposals [02:02] I hate doctests. [02:03] 3 words. so much ... emotion unsaid yet understood. [02:05] See, I want to fix a trivial ordering edge case (bug #604842). But the only tests for the method are doctests where I can't really fit a retry. If only they were unit tests :( [02:05] <_mup_> Bug #604842: BinaryPackageBuildSet.getBuildsByArchIds orders inconsistently [04:19] what do I need to do to make a branch private? [04:19] sorry - wrong channel [04:30] wgrant: change em to unit tests ;) [04:31] lifeless_: I was going to ask if it was impolite to bloat a one-line branch into a few hundred lines by rewriting tests, but I presumed everyone would be asleep. === lifeless_ is now known as lifeless [04:32] wgrant: I'd spin a new branch for it [04:33] lifeless: One branch to redo the tests, and a followup with the one-line change plus new test? Perhaps. [04:44] yes [04:44] its a little more work but - JFDI [04:44] its not a lot more [04:44] Yep. [04:44] I replaced several hundred lines of doctests yesterday. It seems to be becoming a bit common. [04:45] Nasty things. [05:23] the meme has caught on [05:23] Oh? [05:23] and muhaha, its now my job to start memes ;) [05:23] wgrant: that doctests are actively harmful [05:23] The anti-doctest meme? [05:23] Right. [05:23] I now hate them with a passion. [05:23] \o/ [05:23] A few months ago I merely mildly disliked them. [06:23] * cody-somerville has slowly been seeding an SOA meme. [06:24] Has it caught on yet? [06:24] Seem to be [06:24] Excellent. [06:24] Although I think lifeless might extinguish my efforts :/ [06:24] :( [06:24] Why? [06:25] I remember briefly skimming minutes for a meeting I missed that noted that lifeless thought splitting launchpad up into smaller, discrete services was a distraction. [06:26] It is a distraction. But probably a beneficial distraction. [06:26] Indeed. Which is why I hold out hope that the comment isn't as fatal sounding as it does. [06:39] cody-somerville: fwiw, I support your interest in splitting [06:39] :) [06:40] of course, I have ZAROO vote [06:40] but smaller discrete units is pretty much a best practice, especially when you want to scale (hi facebook) [06:41] or hello amazon [06:42] or really anyone === almaisan-away is now known as al-maisan [07:06] mtaylor: morning [07:06] mtaylor: how's your summit going? [07:27] thumper: we have a project that has been renamed. we're trying to reset the lp: alias; but that failed. now, whenever we try and re-create 'trunk' we keep getting 'you are being stacked on ' which is painful. suggestions? [07:28] hmm... [07:28] I'm just relocating, back in a few minutes [07:28] pastebin more details please [07:28] kk [07:57] rockstar, https://dev.launchpad.net/LEP/DynamicConfiguration [07:58] poolie, thanks === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [08:43] bigjools: where did you go? [08:45] mwhudson: haydn [08:45] bigjools: want to talk about buildd-manager now, or busy with other things? [08:45] we're talking about derived distros, might be useful for you? [08:45] ah sure [08:45] be along in a sec [08:45] but yes I'd like to talk about that too :) [08:46] bigjools.fork() [09:56] jml: We still can't renew our memberships. Maybe you could reset everyone to not expire? [09:56] (you just changed the default for new members, it appears) [10:18] gmb, https://code.edge.launchpad.net/~deryck/launchpad/move-bugs-js-files-again/+merge/29776 [10:29] wgrant, there isn't a control for that [10:30] jml: It's not exposed through the API? [10:30] wgrant, I don't know. [11:09] hi wgrant [11:09] Hi poolie. === al-maisan is now known as almaisan-away [11:36] benji, leonardr: https://bugs.edge.launchpad.net/launchpadlib/+bug/604963 for this issue [11:36] <_mup_> Bug #604963: shouldn't need to close window and press enter after authenticating [11:38] lifeless, noodles775: btw, if you want to see some tests that use fake objects rather than the database, lp.code.xmlrpc.tests.test_codehosting (tests for the fake & real implementations); lp.codehosting.vfs.tests (tests that use the fake); lp.codehosting.inmemory (the fake itself) [11:39] running the test_codehosting tests makes the database overhead for testing really obvious [11:40] leonardr, http://sourcefrog.net/tmp/1y/closeme.html [11:42] jml: will do, thanks. === Ursinha is now known as Ursinha-afk === almaisan-away is now known as al-maisan === Ursinha-afk is now known as Ursinha [14:21] jam: hi! Partial work on dropping BranchRevision.id: http://paste.ubuntu.com/462977/ Still failing these tests or a subset thereof: http://paste.ubuntu.com/462978/ [14:21] jtv: thanks for the headsup === mpt_ is now known as mpt [16:40] mars, src/lazr/restful/tales.py:from epydoc.markup import DocstringLinker === beuno is now known as beuno-lunch === al-maisan is now known as almaisan-away === zyga is now known as zyga_ === beuno-lunch is now known as beuno === Ursinha is now known as Ursinha-afk [19:32] morning all === zyga is now known as zyga_ [20:29] mtaylor: hai [20:29] mtaylor: I'd like to suggest a warm up task for you, in lp stuff,if I may. [20:32] lifeless: yes! [20:32] make it fast [20:33] can you see http://people.canonical.com/~stub/ppr_test.html? [20:33] lifeless: ok [20:33] hi mtaylor [20:33] lifeless: I would like lp to be fast [20:33] hi thumper [20:33] thumper: did you see the bug I just filed? :) [20:33] um... [20:33] which one? [20:34] bug#605130 [20:34] <_mup_> Bug #605130: subscribed team cannot view private branch [20:34] mtaylor: probably because the branch is owned by a private team [20:34] thumper: probably [20:34] thumper: but bzr branching it works [20:35] heh... [20:35] thumper: I probably won't care anymore by the time you have time for it - but I thought I'd point it out :) [20:35] so [20:35] this is the same as PPPA access [20:35] that's because the code path for accessing the branch over bzr doesn't look at the team [20:35] we're going to be adding a 'Traversal' permission. [20:36] which will be used to make sure such pages can render reasonably. granting read access to something with a url path containing private things will imply access to traverse them [20:36] and traversing means 'show the url and a human name for the thing' === zyga__ is now known as zyga [21:06] mtaylor: so, can you see that page? [21:23] lifeless: yup [21:24] cool [21:25] mtaylor: and see how its got blueprint bits in it ? [21:26] mtaylor: and see how 99% of blueprint pages complete within 200 sql statements ?!??!1 [21:26] and 3.2 seconds ? [21:26] thats pretty slow ;) [21:27] mtaylor: and with that, gnight [21:27] lifeless: mk [21:28] lifeless: I will fix [21:28] mtaylor: mean is 50 sql statements, which is still pretty terrible. [21:28] mtaylor: yeah, if its fixed, be in a good position to add features. [21:28] gnight. === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk