wgrant | lifeless: Ah, I'm glad you have a better solution than granting launchpad.View on private teams just because of a PPA subscription. | 06:55 |
---|---|---|
=== almaisan-away is now known as al-maisan | ||
lifeless | wgrant: I try | 07:11 |
=== al-maisan is now known as almaisan-away | ||
=== Ursinha-afk is now known as Ursinha | ||
mwhudson | morning | 08:45 |
wgrant | Evening. | 08:46 |
lifeless | day. | 08:48 |
StevenK | G'Tag | 08:50 |
wgrant | That's not very Czech. | 08:51 |
StevenK | Oh, sorry. DzieĆ dobry | 08:52 |
=== almaisan-away is now known as al-maisan | ||
poolie | leonardr, wbn to extract whatever groundcontrol uses for this and make it sit on top of a generic authenticate mechanism, and be the default gtk impl | 10:02 |
leonardr | poolie, i don't think it's worth it, given that the common case will be to use the credentials manager packaged with ubuntu | 10:03 |
poolie | jml wow ec2 test is pretty classy | 10:17 |
lifeless | poolie: you've seen bzr selftest --parallel=ec2 ? | 10:36 |
poolie | heard of it | 10:36 |
lifeless | :P | 10:36 |
poolie | i think i tried it and hit some snags | 10:36 |
poolie | i think for me it looked like a bad latency/throughput tradeoff :) | 10:37 |
poolie | maybe i should try it | 10:37 |
wgrant | But with LP it's different, since the test suite is damn slow? | 10:37 |
poolie | lifeless, i'd actually like a variation that runs remotely on my desktop | 10:37 |
poolie | yeah basically | 10:37 |
leonardr | poolie, want to review the launchpadlib branch we talked about yesterday? | 10:47 |
leonardr | https://code.edge.launchpad.net/~leonardr/launchpadlib/improve-workflow/+merge/29849 | 10:47 |
poolie | i'd be delighted | 10:48 |
leonardr | poolie: the reason there are no automated tests is we don't have the framework for them | 10:49 |
poolie | leonardr, you know when i said 'rhinos' i meant the internal mailing list about this? not the animals? | 10:50 |
leonardr | poolie: i thought you meant the o'reilly book (after whom the list is presumably named) | 10:50 |
mwhudson | the problem with launchpad for ec2 is that instance setup is quite slow of course | 10:51 |
mwhudson | we could have an instance with the results of 'make schema' baked into it, that would help a bit | 10:51 |
poolie | nice cover letter | 10:51 |
poolie | leonardr, reviewed, very nice but i have some tweaks | 11:05 |
leonardr | ok | 11:05 |
=== Ursinha is now known as Ursinha-afk | ||
leonardr | poolie, maybe you can help me understand how os.open works | 11:48 |
poolie | leonardr, maybe i can :) | 11:48 |
* poolie waves | 11:48 | |
wgrant | Is ShipIt still a Launchpad parasite? | 12:02 |
wgrant | Ah, lunch, I guess. | 12:03 |
mwhudson | wgrant: yes | 12:03 |
mwhudson | wgrant: to both bits | 12:04 |
wgrant | mwhudson: :( | 12:04 |
mwhudson | wgrant: although there was talk of not rolling out launchpad to shipit app servers any more | 12:04 |
=== Ursinha-afk is now known as Ursinha | ||
mwhudson | gary_poster: it seems our VirtualHostRequestPublicationFactory doesn't really implement IRequestPublicationFactory, because __call__ returns a request *factory*, not a request | 13:36 |
mwhudson | gary_poster: does this ring any bells? | 13:36 |
mwhudson | or hm | 13:39 |
mwhudson | maybe the docs are just broken | 13:39 |
mwhudson | yeah, i think so | 13:41 |
gary_poster | mwhudson: (Sorry no reply before) That sounds likely to me, fwiw. If it works with the rest of the Zope machinery, then that sounds like a good argument. | 13:50 |
mwhudson | gary_poster: np | 13:50 |
=== Ursinha is now known as Ursinha-afk | ||
=== Ursinha-afk is now known as Ursinha | ||
maxb | I appears there is one or more Git imports in the Reviewed state which somehow I am Forbidden to see | 14:37 |
maxb | This manifests as a Forbidden error when I try to page through the list of them, on one particular page | 14:37 |
maxb | It appears to be number 459 in the list | 14:39 |
maxb | and mumber 498 too | 14:40 |
mwhudson | maxb: hmm | 14:41 |
mwhudson | maxb: sounds worth of bug filing | 14:41 |
maxb | https://code.edge.launchpad.net/+code-imports/+index?field.rcs_type=GIT&field.rcs_type-empty-marker=1&field.review_status=REVIEWED&field.review_status-empty-marker=1&submit=Submit+Query&start=497&batch=1 | 14:42 |
maxb | Can you view that? | 14:42 |
maxb | https://code.edge.launchpad.net/+code-imports/+index?field.rcs_type=GIT&field.rcs_type-empty-marker=1&field.review_status=REVIEWED&field.review_status-empty-marker=1&submit=Submit+Query&start=458&batch=1 | 14:43 |
maxb | or that? | 14:43 |
maxb | hoping to find someone to figure out which ones are the problem, so I can say something more definite than an index in search results which will change | 14:43 |
mwhudson | maxb: i can't see that | 14:45 |
maxb | hmm. I guess we'll need a losa | 14:45 |
mwhudson | but i can see the branch name in the traceback | 14:45 |
mwhudson | i assume it's a private branch-only project | 14:46 |
maxb | makes sense | 14:46 |
james_w | leonardr: hi, is there a solution for using launchpadlib.load in (launchpad) tests that doesn't involve hardcoding the root uri or accessing a private attribute? I thought I had seen a branch from you to make load work with relative URIs. | 14:51 |
leonardr | james_w: yes, in the latest version of launchpadlib you can pass a relative url to load() | 14:58 |
leonardr | or, actually, in the latest lazr.restful | 14:58 |
james_w | leonardr: is that landed in launchpad yet? | 14:58 |
leonardr | lazr.restfulclient | 14:58 |
leonardr | yeah, it's lazr.restfulclient 0.9.20, revno 102 | 14:58 |
james_w | grep restfulclient versions.cfg | 14:59 |
james_w | lazr.restfulclient = 0.9.14 | 14:59 |
leonardr | oh, i see what you mean | 15:00 |
leonardr | is it part of the launchpad application, not is it on the launchpad site | 15:00 |
james_w | I'll try an upgrade branch | 15:00 |
leonardr | i'll do a branch upgrading the packages later this month | 15:01 |
leonardr | remind me to do it, if you would | 15:01 |
james_w | leonardr: you don't want me to do it now? | 15:04 |
james_w | leonardr: is there some way that I can mark the place in the code where I will put the ugliness for replacement at that point? | 15:05 |
leonardr | james_w: sure, if you want to take care of it i'd be very happy | 15:05 |
leonardr | i didn't know that was what you meant by 'upgrade branch' | 15:06 |
james_w | leonardr: latest versions of lazr.restfulclient, launchpadlib and lazr.restful? | 15:06 |
leonardr | let me double check, but yes | 15:06 |
james_w | i.e. should I upgrade all of them? | 15:06 |
leonardr | james_w: yes. send me the mp, but if the ec2 test passes, it's fine | 15:07 |
james_w | leonardr: any gotchas you can think of that would save me time? | 15:08 |
james_w | any dependencies that should be upgraded or anything? | 15:08 |
leonardr | james_w: the only thing i'm worried about is whether 'make' will generate a reasonable-looking apidoc | 15:08 |
leonardr | wait, actually it doesn't matter, because i didn't release that launchpadlib revision as a new version of launchpadlib | 15:09 |
leonardr | so it should be fine | 15:09 |
james_w | ok | 15:09 |
poolie | hi james_w | 15:10 |
james_w | hi poolie | 15:10 |
poolie | new post: http://blog.launchpad.net/api/three-tips-for-faster-launchpadlib-api-clients | 15:10 |
poolie | lifeless, one nice thing about having everything in debs would be less crap about 'please run link-external-sourcecode' etc | 15:11 |
james_w | I'm actually starting to like the approach taken by buildout etc. for development | 15:12 |
benji | poolie: utilities/link-external-sourcecode -p ~/launchpad/lp-sourcedeps/ | 15:12 |
james_w | poolie: co-located branches would make that less of an issue too :-) | 15:13 |
poolie | true | 15:14 |
poolie | hm, though you'd still need to rebuild them etc | 15:15 |
mwhudson | writing unit tests for publication details makes me want to stab things | 15:23 |
mwhudson | ILaunchBag needs to die | 15:26 |
poolie | ILaunchBagBiter | 15:27 |
mwhudson | ILaunchPoo | 15:29 |
kiko | flacoste, mwhudson: who currently runs our mootbot? | 16:02 |
mwhudson | kiko: no idea | 16:03 |
leonardr | poolie, https://bugs.edge.launchpad.net/launchpadlib/+bug/605462 | 16:20 |
mwhudson | gary_poster: this diff adds a vostok layer: http://pastebin.ubuntu.com/463574/ | 16:22 |
gary_poster | looking | 16:22 |
mwhudson | gary_poster: this one adds a very simple new view for the root http://pastebin.ubuntu.com/463575/ | 16:22 |
gary_poster | mwhudson: for first patch, I don't understand change to lib/lp/code/xmlrpc/tests/test_codehosting.py : why did it say "vostok" in the first place? | 16:26 |
mwhudson | gary_poster: the scripts used to be run on a machine called that, i guess i went for 'realistic' test data | 16:27 |
gary_poster | heh, what a coincidence | 16:27 |
mwhudson | yeah | 16:28 |
mwhudson | i changed it because i want grep -ir vostok to only find this stuff :) | 16:28 |
gary_poster | heh, cool, makes sense | 16:28 |
gary_poster | mwhudson: oooh, I like your root template | 16:33 |
mwhudson | gary_poster: :) | 16:33 |
gary_poster | mwhudson: a 50% review: looks good to me. It is sad that it requires so much machinery, though we do this so infrequently I suppose it is not worth thinking about | 16:38 |
mwhudson | gary_poster: thanks | 16:41 |
james_w | you know, it might be useful for us to have vostok.launchpad.net as an "unsupported" interface to launchpad.net. | 16:42 |
mwhudson | james_w: i guess you looked at the diffs | 16:45 |
james_w | I did | 16:46 |
mwhudson | cool | 16:46 |
mtaylor | thumper: around? | 16:48 |
mwhudson | mtaylor: sorta | 16:49 |
mwhudson | mtaylor: if you say stuff he'll see it i imagine | 16:49 |
mtaylor | mwhudson: heh. something seems to be quite off with merge proposal diff | 16:49 |
mtaylor | diffs | 16:49 |
mwhudson | mtaylor: in what way? | 16:50 |
mtaylor | I've got three up: https://code.edge.launchpad.net/swift/+activereviews (from pipeline, depend on each other) and the unmerged revision list for each is off | 16:50 |
mtaylor | as is the diff that was emailed and the one that is displayed in the UI | 16:50 |
mtaylor | mwhudson: if you don't have super-launchpad perms, I'll have to add you to a team so you can see it | 16:51 |
mwhudson | mtaylor: i don't have the perms any more | 16:51 |
mtaylor | mwhudson: ok. lemme add you real quick | 16:51 |
mtaylor | mwhudson: if you look at https://code.edge.launchpad.net/~mordred/swift/add-doc-package/+merge/29896 | 16:52 |
mtaylor | mwhudson: that merge should contain revs 16 and 17 - but even if it just contained rev 17 the diff still should not be empty | 16:52 |
mwhudson | mtaylor: bah, i can't see that | 16:52 |
mwhudson | Unauthorized: (<Branch u'~mordred/swift/add-doc-package' (361880)>, 'landing_targets', 'launchpad.View')<br /> | 16:52 |
mtaylor | hrm. lemme add you somewhere else... | 16:53 |
mtaylor | mwhudson: try again | 16:53 |
mwhudson | success | 16:53 |
mtaylor | woot | 16:54 |
mwhudson | mtaylor: i think the unmerged revisions list being too big has been like that always | 16:55 |
mtaylor | mwhudson: no - that's not the problem ... | 16:55 |
mtaylor | mwhudson: sorry, I didn't mean unmerged revs... | 16:55 |
mtaylor | mwhudson: if you look at the grey list of revs under "Add a review or comment" ... it should be listing 16 as well... and then the diff should be quite different/larger | 16:56 |
mwhudson | mtaylor: thumper agrees that it's ****ed | 16:56 |
mtaylor | yay | 16:56 |
mwhudson | (he's now sitting next to me) | 16:56 |
* mtaylor cries a bit | 16:56 | |
* mtaylor was going to teach new people how to work with merge requests and why they're wonderful today... | 16:57 | |
mtaylor | is it possible that is's ****ed because of all the private nonsense? | 16:57 |
mwhudson | mtaylor: trying to reproduce something | 16:59 |
mwhudson | mtaylor: very unlikely | 16:59 |
mtaylor | ok | 16:59 |
mwhudson | mtaylor: can you delete the problem proposal and try again? | 17:00 |
mtaylor | mwhudson: sure | 17:00 |
mtaylor | mwhudson: there are two problematic ones... shall I delete bothj? | 17:00 |
mwhudson | mtaylor: which is the other problem one? | 17:01 |
mwhudson | but no, just delete one for now | 17:01 |
mtaylor | https://code.edge.launchpad.net/~mordred/swift/rework-dh-install | 17:03 |
mtaylor | ok | 17:03 |
mwhudson | mtaylor: yeah, the diff on https://code.edge.launchpad.net/~mordred/swift/rework-dh-install/+merge/29891 is just the diff from r13 isn't it? | 17:04 |
thumper | mtaylor: hi | 17:05 |
thumper | mtaylor: I've opened my laptop again | 17:05 |
mwhudson | mtaylor: same empty diff again | 17:05 |
mtaylor | thumper: hi! | 17:05 |
mtaylor | mwhudson: bleh | 17:05 |
mwhudson | mtaylor: yes | 17:05 |
thumper | mtaylor: I'm sitting next to abentley discussing your diff | 17:07 |
thumper | or lack thereof | 17:07 |
mtaylor | thumper: did I break somethignm | 17:07 |
mtaylor | ? | 17:07 |
thumper | mtaylor: maybe | 17:07 |
thumper | mtaylor: I seem to recall something like this happening before | 17:07 |
thumper | but I don't remember why | 17:07 |
thumper | or what we did about it | 17:07 |
mtaylor | yay! | 17:09 |
mtaylor | thumper: I did push the first branch (~mordred/swift/bzr-builddeb) ... then I reconfigured to pipeline | 17:09 |
mtaylor | then I re-pushed it | 17:09 |
mtaylor | not sure if it's relevant | 17:10 |
mwhudson | mtaylor: you should probably remove me from those teams | 17:10 |
mtaylor | mwhudson: I will | 17:12 |
mtaylor | mwhudson: do you not need it to see things anymore? | 17:13 |
mwhudson | mtaylor: i'm letting thumper and abentley worry about it :-) | 17:13 |
mtaylor | mwhudson: cool | 17:13 |
thumper | mtaylor: bad news | 17:13 |
thumper | mtaylor: when we manually do what the script should be doing | 17:13 |
thumper | we get a diff | 17:13 |
thumper | so... | 17:13 |
thumper | sounds like a bug in our diff generation | 17:13 |
mtaylor | yay! | 17:14 |
thumper | please demonstrate with a different project | 17:14 |
mtaylor | thumper: should I try deleting an recreating all three merge props? | 17:14 |
mtaylor | mwhudson: done | 17:14 |
mwhudson | mtaylor: cool | 17:14 |
=== beuno is now known as beuno-lunch | ||
thumper | mtaylor: you could try adding a rev to the source branch of the one with the bad diff | 17:15 |
thumper | this would force a new diff to be generated | 17:15 |
thumper | alternatively, try merging the prerequisite into the source | 17:15 |
thumper | if the tip isn't already | 17:15 |
thumper | it may be an edge case | 17:15 |
=== beuno-lunch is now known as beuno | ||
=== al-maisan is now known as almaisan-away | ||
james_w | no ec2test mail makes james_w a sad panda | 19:58 |
james_w | phew, there it is, just really slow | 19:58 |
=== almaisan-away is now known as al-maisan | ||
=== al-maisan is now known as almaisan-away | ||
=== flacoste is now known as flacoste_afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!