| jtv | flacoste: say, would you mind having a look at this suggested change? https://code.edge.launchpad.net/~jtv/launchpad/decruft-test-template/+merge/30080 | 11:15 |
|---|---|---|
| lifeless | jtv: its huge | 11:34 |
| lifeless | jtv: huger than your description implies. | 11:34 |
| jtv | lifeless: whoops... forgot to select "devel" instead of "launchpad" | 11:35 |
| jtv | I'll re-do. Thanks for noticing. | 11:35 |
| jtv | lifeless, flacoste: better diff here... https://code.edge.launchpad.net/~jtv/launchpad/decruft-test-template/+merge/30083 | 11:38 |
| gary_poster | salgado: Looks good generally. I have some small naming niggles. "orig_interface" -> "callable"? or "interface"? or "adaptation"? "orig" doesn't make much sense to me inherently. | 11:55 |
| gary_poster | Similar naming concern: "class Adapter(object):" Maybe name should be "Adaptable"? or just "Demo" or "Example"? | 11:55 |
| gary_poster | Also...will come by. :-) | 11:55 |
| james_w | Hello friendly launchpad reviewers, could someone take a look at my branches? | 13:12 |
| james_w | https://code.edge.launchpad.net/~james-w/launchpadlib/fix-default-version-in-test/+merge/29943 | 13:12 |
| james_w | https://code.edge.launchpad.net/~james-w/launchpad/expose-blueprints/+merge/30026 | 13:12 |
| james_w | sinzui: I export a whiteboard in the latter, and I believe you may have an opinion on that? | 13:13 |
| james_w | thanks for the review leonardr, I have replied with some questions | 14:39 |
| leonardr | james_w, great | 14:39 |
| leonardr | james_w: some of your questions i can answer right away. others i will need to get feedback from someoen who knows more about launchpad | 14:42 |
| james_w | ok | 14:43 |
| leonardr | sinzui, i'm going to refer some of the questions about james_w's blueprint web service branch to you. | 14:49 |
| leonardr | if you think someone else can do it, let me know | 14:49 |
| leonardr | https://code.edge.launchpad.net/~james-w/launchpad/expose-blueprints/+merge/30026 | 14:49 |
| leonardr | i'll reply to his most recent comments specifically calling out some questions to you | 14:49 |
| === adiroiban changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [adiroiban(bug-532239)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| leonardr | poolie, i requested one review from you which you said 'needs fixing' (and i've responded to your comments). the other two i hadn't requested a review, but i have now | 15:30 |
| deryck | mrevell, incoming.... https://code.edge.launchpad.net/~deryck/launchpad/fix-heat-help-link/+merge/29856 | 15:51 |
| deryck | sinzui, see ^^ for a code review ack :-) Thanks! | 15:51 |
| === flacoste is now known as flacoste_lunch | ||
| jtv | danilos: https://code.edge.launchpad.net/~jtv/launchpad/translationtemplatescollection-test/+merge/30114 | 17:35 |
| === flacoste_lunch is now known as flacoste | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!