| === kubotu_ is now known as kubotu | ||
| ScottL | can anyone help test this bug so we can get it backported? https://bugs.edge.launchpad.net/ubuntu/+source/qjackctl/+bug/607914 | 17:54 |
|---|---|---|
| ubottu | Launchpad bug 607914 in qjackctl (Ubuntu) "Backport qjackctl 0.3.6-1 from Maverick" [Undecided,New] | 17:54 |
| ScottL | s/bug/fix | 17:55 |
| ScottL | good instructions included in the bug report for testing | 17:58 |
| crimsun_ | ScottL: nice test case | 21:07 |
| crimsun_ | I'm a bit concerned that this is going into lucid-backports instead of lucid-proposed, though | 21:07 |
| crimsun_ | are the changes from 0.3.4 -> 0.3.6 _that_ invasive that the fixes can't be cherry-picked onto our 0.3.4 package? | 21:08 |
| ScottL | crimsun_, thanks, i would rather this go into -proposed as well but i was told i needed a patch and since this was handled upstream by a new release i wasn't sure a patch even existed | 21:12 |
| ScottL | if you could point me in the right direction i would love to dig further into it though :) | 21:13 |
| crimsun_ | yeah, let me see if I can isolate a smaller patch | 21:16 |
| crimsun_ | are you going to be around (not 100% attention necessary, of course) for an hour? | 21:16 |
| ScottL | yes i will, i'll be back and forth in front of the computer | 21:17 |
| crimsun_ | sounds good | 21:17 |
| ScottL | today, i'm also hoping to submit a patch for the gnome-network-admin bug (disabled interface) in maverick, so hopefully this will resolve the bug going forward | 21:20 |
| ScottL | i had hoped to get a patch for lucid as well, but alas, i cannot get the package to build when removing 10_disable_interfaces.patch | 21:21 |
| crimsun_ | do you have a build log with the FTBFS (with the patch unapplied)? | 21:23 |
| ScottL | crimsun_, https://launchpad.net/~slavender/+archive/lucid/+build/1888652/+files/buildlog_ubuntu-lucid-i386.gnome-system-tools_2.30.0-0ubuntu3~ppa4_FAILEDTOBUILD.txt.gz | 21:24 |
| crimsun_ | thanks, will look later | 21:24 |
| ScottL | no,thank you :) | 21:27 |
| crimsun_ | looks pretty straightforward: | 21:36 |
| crimsun_ | --- src/qjackctlJackConnect.cpp (revision 541) | 21:36 |
| crimsun_ | +++ src/qjackctlJackConnect.cpp (revision 542) | 21:36 |
| crimsun_ | @@ -228,7 +228,7 @@ | 21:36 |
| crimsun_ | QString sPortName = sClientPort.right(sClientPort.length() - iColon - 1); | 21:36 |
| crimsun_ | pClient = static_cast<qjackctlJackClient *> (findClient(sClientName)); | 21:36 |
| crimsun_ | if (pClient) | 21:36 |
| crimsun_ | - pPort = pClient->findJackPort(pJackPort); | 21:36 |
| crimsun_ | + pPort = static_cast<qjackctlJackPort *> (pClient->findPort(sPortName)); | 21:36 |
| crimsun_ | if (pClient == 0) { | 21:36 |
| crimsun_ | pClient = new qjackctlJackClient(this, sClientName); | 21:36 |
| crimsun_ | iDirtyCount++; | 21:36 |
| crimsun_ | I think that's a nice SRU candidate :-) | 21:36 |
| crimsun_ | fixed silly lintian error while I'm at it, too | 21:50 |
| crimsun_ | ScottL: please try http://kernel.ubuntu.com/~dtchen/qjackctl_0.3.4-0ubuntu4.1.debdiff against pristine lucid | 21:53 |
| ScottL | crimsun_, i'll do that this evening when family things settle down a bit | 22:16 |
| ScottL | but i can start a clean lucid install now though :) | 22:20 |
| ScottL | crimsum, how did you fin that? was it in the qjackctl cvs? | 22:20 |
| ScottL | did you just look for a description on one of the revisions with port renaming? | 22:21 |
| crimsun_ | ScottL: I searched the source | 22:30 |
| astraljava | Ahh... superb, crimsun_! Much better than a backport. | 23:41 |
| astraljava | Thanks! | 23:41 |
| * astraljava goes to bed | 23:41 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!