| thumper | https://code.edge.launchpad.net/~thumper/launchpad/no-sample-data-doctest/+merge/30913 | 05:52 |
|---|---|---|
| thumper | mwhudson: diff is there | 05:53 |
| adeuring | moin henninge, fancy a 180 lines diff review? https://code.edge.launchpad.net/~adeuring/launchpad/security-guarded-test-object-factory-3/+merge/30917 | 09:42 |
| * flacoste is away: Gone away for now | 09:58 | |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: adeuring || queue: [jtv³] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| malaria | Hi, | 10:06 |
| malaria | Some feedback about bug #608631 ? | 10:06 |
| _mup_ | Bug #608631: Visual tag to represent narrow non-breaking spaces <Launchpad Translations:New> <https://launchpad.net/bugs/608631> | 10:06 |
| malaria | henninge perhaps? | 10:07 |
| henninge | malaria: I cannot comment on the matter, I am sorry. But as the bug is still new, it will be picked up and triaged these days and you should get a comment. | 11:20 |
| malaria | ok, thanks ;-) | 11:21 |
| henninge | adeuring: Hi! | 11:32 |
| adeuring | hi henninge | 11:32 |
| henninge | Argh! I was looking at the wrong MP ... :( | 11:33 |
| adeuring | henninge: sorry if I screwed the links... | 11:34 |
| henninge | adeuring: no, no, I had gone back to the first branch to see what remove_security_proxy_and_shout_at_engineer and such do. | 11:34 |
| henninge | Too many tabs open ... ;) | 11:34 |
| adeuring | ah, OK | 11:34 |
| henninge | adeuring: so you branch is about mechanically adding ProxyFactory and remove_security_proxy_and_shout_at_engineer, right? | 11:35 |
| adeuring | henninge: right. BTW, see also the iscussion on the mailing list | 11:35 |
| adeuring | lifeless has some objections to the concept ;) | 11:36 |
| henninge | adeuring: oh, I was away last week. What's the subject? | 11:36 |
| adeuring | henninge: [Launchpad-dev] warning: we will soon have much noise in the test results... | 11:36 |
| adeuring | henninge: so, I would not mind if you put the review on hold | 11:37 |
| henninge | adeuring: let me read that discussion first. | 11:37 |
| adeuring | sure. (and sorry for the mess... lifless responded after I wrote the MP) | 11:38 |
| === henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: lunch || queue: [adeuring, jtv³] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === mrevell is now known as mrevell-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| === mrevell-lunch is now known as mrevell | ||
| wgrant | win 3 | 14:43 |
| wgrant | Argh. | 14:43 |
| gary_poster | anyone available for a review of https://code.launchpad.net/~gary/launchpad/apidoc/+merge/30849 ? | 15:05 |
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch || queue: [adeuring, jtv³, gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | gary_poster, I'm look at it, but I think I should try the rest of the queue first. | 15:18 |
| gary_poster | abentley: fair enough, thank you | 15:19 |
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch || queue: [jtv³, gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | jtv, around? | 15:27 |
| jtv | abentley: no | 15:27 |
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, gary_poster || queue: [gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, gary_poster || queue: [] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jtv | abentley: one of my branches got reviewed over the weekend | 15:28 |
| * flacoste is back. | 15:42 | |
| === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, - || queue: [] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| mars | abentley, ping, do you have time for a mostly mechanical review of the windmill test suite and lazr-js 1.0 upgrade? https://code.edge.launchpad.net/~mars/launchpad/update-lazr-js-to-1.0/+merge/30972 | 18:37 |
| mars | abentley, I also included your xvfb-run testr fix :) | 18:37 |
| abentley | mars, lunching, but soonish. | 18:37 |
| mars | I'll add it to the queue then | 18:37 |
| mars | thanks | 18:37 |
| === mars changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, - || queue: [mars] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | henninge, done for the day? | 18:48 |
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || reviewing: mars || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| abentley | mars, the xvfb-run invocation is different from test-on-merge. Is there a good reason for this? | 18:59 |
| abentley | mars, it seems like it would be ideal to isolate the code for running the test suite under xvb to one location, e.g. the test runner. | 19:00 |
| abentley | mars, then you could turn it off and on with a switch. | 19:00 |
| mars | abentley, that takes a bit of work | 19:01 |
| mars | you could try adding bin/test --headless, but most of the time that would be the default | 19:01 |
| mars | bin/test --show-browser ? | 19:02 |
| mars | nah | 19:02 |
| mars | well, maybe | 19:02 |
| abentley | mars, especially when you consider testr -- --show-browser | 19:02 |
| mars | abentley, I would have to pull the xvfb-run code up and out of test_on_merge.py and into bin/test, then add the new command-line switches | 19:03 |
| mars | and probably refactor bin/test along the way :( | 19:03 |
| abentley | mars, I'm not saying we must do it right now, but we use xvfb-run a lot, so it seems worth doing. | 19:04 |
| mars | yes, definitely. I did that already with test_on_merge.py, so I guess it can't hurt to move it elsewhere | 19:04 |
| mars | also a site-wide xvfb-run seems a bit overkill to do during every test startup | 19:05 |
| abentley | mars, what about the invocation difference? test-on-merge supplies "-s -screen - 1024x768x24" and testr won't. | 19:05 |
| mars | For our code, doesn't matter unless you are planning to debug the Xvfb display directly (Which I do when I need to fix buildbot) | 19:06 |
| abentley | mars, okay. | 19:06 |
| abentley | mars, is there a bug for better xvfb integration? | 19:07 |
| mars | abentley, nope | 19:08 |
| abentley | mars, okay, I'll do one. | 19:08 |
| mars | cool, thank you | 19:08 |
| mars | toss it back to Foundations using the 'build-infrastructure' tag | 19:08 |
| abentley | mars, can you avoid repeating the VISIBLE_PICKER xpath definition? | 19:09 |
| mars | doing that right now in another branch | 19:10 |
| abentley | cool. r=me. | 19:10 |
| mars | thanks! | 19:10 |
| henninge | abentley: yes, thanks for removing my name from the topic ... ;-) | 19:20 |
| abentley | mars, bug #610172 | 19:21 |
| _mup_ | Bug #610172: xvfb-run should be integrated better <build-infrastructure> <Launchpad Foundations:New> <https://launchpad.net/bugs/610172> | 19:21 |
| mars | cool | 19:21 |
| === abentley changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| rockstar | thumper, https://code.edge.launchpad.net/~rockstar/launchpad/junk-recipe-listings/+merge/30990 | 22:32 |
| * flacoste is away: Gone away for now | 22:45 | |
| === matsubara is now known as matsubara-afk | ||
| rockstar | thumper, my code review plz? | 23:22 |
| thumper | rockstar: ack | 23:22 |
| thumper | rockstar: done | 23:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!