[05:52] https://code.edge.launchpad.net/~thumper/launchpad/no-sample-data-doctest/+merge/30913 [05:53] mwhudson: diff is there [09:42] moin henninge, fancy a 180 lines diff review? https://code.edge.launchpad.net/~adeuring/launchpad/security-guarded-test-object-factory-3/+merge/30917 [09:58] * flacoste is away: Gone away for now === henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: adeuring || queue: [jtv³] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:06] Hi, [10:06] Some feedback about bug #608631 ? [10:06] <_mup_> Bug #608631: Visual tag to represent narrow non-breaking spaces [10:07] henninge perhaps? [11:20] malaria: I cannot comment on the matter, I am sorry. But as the bug is still new, it will be picked up and triaged these days and you should get a comment. [11:21] ok, thanks ;-) [11:32] adeuring: Hi! [11:32] hi henninge [11:33] Argh! I was looking at the wrong MP ... :( [11:34] henninge: sorry if I screwed the links... [11:34] adeuring: no, no, I had gone back to the first branch to see what remove_security_proxy_and_shout_at_engineer and such do. [11:34] Too many tabs open ... ;) [11:34] ah, OK [11:35] adeuring: so you branch is about mechanically adding ProxyFactory and remove_security_proxy_and_shout_at_engineer, right? [11:35] henninge: right. BTW, see also the iscussion on the mailing list [11:36] lifeless has some objections to the concept ;) [11:36] adeuring: oh, I was away last week. What's the subject? [11:36] henninge: [Launchpad-dev] warning: we will soon have much noise in the test results... [11:37] henninge: so, I would not mind if you put the review on hold [11:37] adeuring: let me read that discussion first. [11:38] sure. (and sorry for the mess... lifless responded after I wrote the MP) === henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: lunch || queue: [adeuring, jtv³] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === mrevell is now known as mrevell-lunch === matsubara-afk is now known as matsubara === mrevell-lunch is now known as mrevell [14:43] win 3 [14:43] Argh. [15:05] anyone available for a review of https://code.launchpad.net/~gary/launchpad/apidoc/+merge/30849 ? === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch || queue: [adeuring, jtv³, gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:18] gary_poster, I'm look at it, but I think I should try the rest of the queue first. [15:19] abentley: fair enough, thank you === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch || queue: [jtv³, gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:27] jtv, around? [15:27] abentley: no === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, gary_poster || queue: [gary_poster] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, gary_poster || queue: [] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:28] abentley: one of my branches got reviewed over the weekend [15:42] * flacoste is back. === abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, - || queue: [] ] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === matsubara is now known as matsubara-lunch === matsubara-lunch is now known as matsubara [18:37] abentley, ping, do you have time for a mostly mechanical review of the windmill test suite and lazr-js 1.0 upgrade? https://code.edge.launchpad.net/~mars/launchpad/update-lazr-js-to-1.0/+merge/30972 [18:37] abentley, I also included your xvfb-run testr fix :) [18:37] mars, lunching, but soonish. [18:37] I'll add it to the queue then [18:37] thanks === mars changed the topic of #launchpad-reviews to: On call: henninge, abentley || reviewing: lunch, - || queue: [mars] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:48] henninge, done for the day? === abentley changed the topic of #launchpad-reviews to: On call: abentley || reviewing: mars || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:59] mars, the xvfb-run invocation is different from test-on-merge. Is there a good reason for this? [19:00] mars, it seems like it would be ideal to isolate the code for running the test suite under xvb to one location, e.g. the test runner. [19:00] mars, then you could turn it off and on with a switch. [19:01] abentley, that takes a bit of work [19:01] you could try adding bin/test --headless, but most of the time that would be the default [19:02] bin/test --show-browser ? [19:02] nah [19:02] well, maybe [19:02] mars, especially when you consider testr -- --show-browser [19:03] abentley, I would have to pull the xvfb-run code up and out of test_on_merge.py and into bin/test, then add the new command-line switches [19:03] and probably refactor bin/test along the way :( [19:04] mars, I'm not saying we must do it right now, but we use xvfb-run a lot, so it seems worth doing. [19:04] yes, definitely. I did that already with test_on_merge.py, so I guess it can't hurt to move it elsewhere [19:05] also a site-wide xvfb-run seems a bit overkill to do during every test startup [19:05] mars, what about the invocation difference? test-on-merge supplies "-s -screen - 1024x768x24" and testr won't. [19:06] For our code, doesn't matter unless you are planning to debug the Xvfb display directly (Which I do when I need to fix buildbot) [19:06] mars, okay. [19:07] mars, is there a bug for better xvfb integration? [19:08] abentley, nope [19:08] mars, okay, I'll do one. [19:08] cool, thank you [19:08] toss it back to Foundations using the 'build-infrastructure' tag [19:09] mars, can you avoid repeating the VISIBLE_PICKER xpath definition? [19:10] doing that right now in another branch [19:10] cool. r=me. [19:10] thanks! [19:20] abentley: yes, thanks for removing my name from the topic ... ;-) [19:21] mars, bug #610172 [19:21] <_mup_> Bug #610172: xvfb-run should be integrated better [19:21] cool === abentley changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [22:32] thumper, https://code.edge.launchpad.net/~rockstar/launchpad/junk-recipe-listings/+merge/30990 [22:45] * flacoste is away: Gone away for now === matsubara is now known as matsubara-afk [23:22] thumper, my code review plz? [23:22] rockstar: ack [23:24] rockstar: done