| Cimi | bratsche: what do I need to do for murrine+rgba? | 01:07 |
|---|---|---|
| === wgrant_ is now known as wgrnat | ||
| === wgrnat is now known as wgrant | ||
| === DanRabbit_ is now known as DanRabbit | ||
| Cimi_ | bratsche: ping | 08:40 |
| Cimi_ | davidbarth: ping | 09:04 |
| === Cimi_ is now known as Cimi | ||
| davidbarth | Cimi: png | 09:27 |
| davidbarth | Cimi: hey, what is creating issues in the PPA? gtk itself or the connman or zeitgeist packages? | 09:27 |
| Cimi | gtk | 09:33 |
| Cimi | my maverick installation is totally destroyed | 09:33 |
| Cimi | I have just a terminal :) | 09:33 |
| Cimi | argh I hate that | 09:36 |
| Cimi | safuck | 09:40 |
| davidbarth | let me check | 09:41 |
| Cimi | I guess I'll need to reinstall everything | 09:42 |
| Cimi | davidbarth: help me :( | 09:48 |
| davidbarth | Cimi: you may have to | 09:53 |
| davidbarth | Cimi: do you have a lucid machine somewhere for the other changes | 09:54 |
| davidbarth | Cimi: i can work with you on the dbusmenu changes for example | 09:54 |
| Cimi | davidbarth: I have a lucid installation | 09:54 |
| davidbarth | while you re-install your maverick system | 09:54 |
| davidbarth | ok cool | 09:54 |
| Cimi | no | 09:54 |
| Cimi | it's in my netbook :( | 09:54 |
| Cimi | maverick or lucid | 09:55 |
| Cimi | for the dbusmenu change, I've tried patching genericmenuitem_Set_icon | 09:55 |
| davidbarth | oh dual boot | 09:55 |
| davidbarth | ok | 09:55 |
| Cimi | with gtk_menu_item_set_image ... | 09:55 |
| Cimi | (something like that) | 09:55 |
| * davidbarth looks into the code | 09:56 | |
| Cimi | but it doesn't display anythink | 09:56 |
| davidbarth | hmm | 09:57 |
| davidbarth | it should be similar to the one ted added for the messaging menu | 09:58 |
| Cimi | restarting to lucid | 09:58 |
| davidbarth | there is this get_hpadding helper | 09:59 |
| davidbarth | Cimi: ok, see you in a minute | 09:59 |
| Cimi | in lucid ;) | 10:01 |
| davidbarth | Cimi: ok, checked the package; the dependencies are broken or something | 10:42 |
| davidbarth | Cimi: let's put that argb on hold until bratsche and kenvandine are back | 10:43 |
| davidbarth | Cimi: on dbusmenu, did you see the get_hpadding funciton? | 10:43 |
| Cimi | davidbarth: it's not padding the main issue | 10:44 |
| Cimi | if we don't have the icons | 10:44 |
| davidbarth | Cimi: so what's the thing to fix to match the mockups? icon positioning | 11:04 |
| davidbarth | Cimi: or the hbox container itself? | 11:04 |
| davidbarth | (looking at your msg-menu patch in the meantime) | 11:05 |
| davidbarth | Cimi: i don't have the part of the patch where you adjusted the layout, just the triangle | 11:10 |
| davidbarth | Cimi: but actually the triangle could go directly into the genericmenuitem part | 11:11 |
| Cimi | davidbarth: sorry I detached the irc sreen session :) | 11:17 |
| Cimi | so | 11:17 |
| klattimer | davidbarth: can you make sure you assign the gsd bug to me asap | 11:17 |
| davidbarth | klattimer: hi | 11:17 |
| Cimi | davidbarth: basically, the previous layour in the indicator-mexxage was | 11:17 |
| davidbarth | klattimer: gsd bug? you mean the porting task? | 11:17 |
| klattimer | yeah | 11:17 |
| Cimi | | triangle (in the space assigned to the menuitem icon) | HBOX with icon and label | 11:18 |
| Cimi | with my patch is | 11:18 |
| Cimi | | icon | label | | 11:18 |
| Cimi | and triangle is drawn in the meuitem expose event | 11:19 |
| Cimi | I thought that if we wanted to align dbusmenuitem on the left we need to move set the menuitem icon to the application icon | 11:19 |
| Cimi | and remove the hbox | 11:19 |
| davidbarth | klattimer: https://bugs.launchpad.net/ayatana-ubuntu/+bug/599844 is all yours now | 11:21 |
| ubot5 | Launchpad bug 599844 in Ayatana Ubuntu "Port the keyboard indicator in gsd to use the app. indicator protocol (affected: 1, heat: 8)" [Medium,Incomplete] | 11:21 |
| klattimer | cool | 11:22 |
| klattimer | :) | 11:22 |
| davidbarth | Cimi: ok | 11:24 |
| davidbarth | Cimi: so. in genericmenuitem terms | 11:27 |
| Cimi | yes | 11:27 |
| davidbarth | the hbox would be suppressed | 11:27 |
| davidbarth | but that sounds wrong to me | 11:28 |
| Cimi | not suppressed | 11:28 |
| Cimi | just remove the icon from the hbox | 11:28 |
| Cimi | if you remove the icon from the hbox, the hbox will continue to work and be available | 11:28 |
| davidbarth | Cimi: can you send me back the msg-menu mockup btw? it is still not clear whether we cover all cases in this case | 11:30 |
| davidbarth | Cimi: because the left column is only supposed to contain checkboxes or radioboxes, but not generic menuitem icons | 11:31 |
| Cimi | in fact | 11:32 |
| davidbarth | Cimi: but still, the msg menu design calls for having a small triangle very close to the Broadcast icon for example, and that would take the place of the checkboxes for axample | 11:32 |
| Cimi | that's why I thought to overriding dbusmenu in indicator-messages | 11:32 |
| Cimi | davidbarth: email sent | 11:33 |
| davidbarth | Cimi: ok, thanks | 11:35 |
| davidbarth | Cimi: so the mockup is wrong, or doesn't match mpt's definition | 11:35 |
| davidbarth | Cimi: let's try to secure the rounded counter then, because that can go independently of the rest | 11:36 |
| davidbarth | Cimi: can you make a branch with just this change first | 11:36 |
| davidbarth | Cimi: upload the branch, and propose it for merging into indicator-messages | 11:37 |
| Cimi | ok | 11:37 |
| Cimi | so | 11:37 |
| Cimi | triangle on the left | 11:37 |
| davidbarth | Cimi: i'm calling otto to try to re-clarify that with him | 11:37 |
| Cimi | plus rounded counter? | 11:37 |
| davidbarth | Cimi: not even the triangle, just the nice rounded corner you added | 11:37 |
| Cimi | will do but just reading the code | 11:37 |
| davidbarth | Cimi: the rounded counter is on an expose handler, right? | 11:37 |
| Cimi | I can't test it because of no maverick installation working | 11:38 |
| davidbarth | so to land the triangle rendering, it's just a question of adding more to the handler that will already be in trunk | 11:38 |
| Cimi | I'll do in lucid | 11:38 |
| davidbarth | Cimi: i'll test it when doing the code review anyway | 11:38 |
| davidbarth | cool | 11:38 |
| davidbarth | Cimi: do you have mpt's wireframe paper with you btw? could you make a snapshot with your phone and send that to me as well? | 11:39 |
| Cimi | it's in the haydn room I guess :D | 11:39 |
| Cimi | davidbarth: done | 11:57 |
| Cimi | davidbarth: another idea | 12:04 |
| Cimi | instead using cairo to draw the triangle | 12:04 |
| Cimi | I could use cairo+expose event to place the icon on the left | 12:04 |
| Cimi | so that the icon can be fully themed with the icon theme | 12:05 |
| davidbarth | Cimi: can you ping me to test the menu rendering please? | 12:22 |
| Cimi | davidbarth: ? | 12:23 |
| davidbarth | i didn't get your name rendered next to the rounded counter | 12:24 |
| Cimi | mmm | 12:25 |
| Cimi | did you restarted the panel? | 12:25 |
| Cimi | davidbarth: | 12:25 |
| davidbarth | Cimi: i did | 12:26 |
| Cimi | something may be wrong in my patch then | 12:27 |
| davidbarth | Cimi: and that new ping was rendered without your name on the line, just the counter, left aligned btw | 12:27 |
| Cimi | sshot? | 12:27 |
| davidbarth | Cimi: doing that now | 12:27 |
| Cimi | looks like I removed the label :) | 12:29 |
| davidbarth | Cimi: yeah, gtk_label_new | 12:30 |
| Cimi | davidbarth: pushed :) | 12:31 |
| davidbarth | Cimi: https://code.launchpad.net/~cimi/indicator-messages/right-rounded-numbers/+merge/31262 | 12:31 |
| davidbarth | see comments on argument checks to add too | 12:31 |
| Cimi | it's the first time I write callbacks so I'm completely new on them | 12:32 |
| davidbarth | Cimi: great, now it works | 12:33 |
| Cimi | davidbarth: if you could patch and push the right version I can learn ;) | 12:33 |
| davidbarth | well, they will be evaled at run time only, so don't use g_return_if_fail, but rather simple checks like if (x == NULL) return | 12:34 |
| davidbarth | or better, do some typechecking on gobjects, so that even a dirty pointer can be controled a bit more thoroughly | 12:34 |
| davidbarth | Cimi: ok, i'll give that a try | 12:34 |
| davidbarth | Cimi: ok, i commented on the code review page with a patch you can add and push | 12:37 |
| davidbarth | Cimi: i can't push to this branch directly | 12:38 |
| Cimi | ok | 12:39 |
| Cimi | davidbarth: pushed | 12:41 |
| davidbarth | Cimi: great | 12:41 |
| * Cimi eating | 12:55 | |
| * Cimi food finished :D | 13:24 | |
| davidbarth | Cimi: i should have a call with otto at 3pm (CET) to clarify what we can already land for a3 | 13:52 |
| Cimi | nice | 13:53 |
| Cimi | davidbarth: do you want to setup a conference? | 13:53 |
| davidbarth | Cimi: once the time is set, yes, to have you on the call as well | 13:57 |
| Cimi | davidbarth: 3pm is in 2 minutes? | 13:58 |
| davidbarth | Cimi: it's postponed for a bit, i'll ping you back on that in particular | 14:01 |
| davidbarth | Cimi: hey can you take a look at the updated drawing (on the right)? | 14:16 |
| davidbarth | Cimi: the triangle code you have should already do exactly that | 14:17 |
| Cimi | davidbarth: what do you mean? | 14:17 |
| Cimi | kind of | 14:17 |
| davidbarth | Cimi: maybe the triangle should be enlarged a bit | 14:17 |
| davidbarth | but mostly, that would work | 14:17 |
| Cimi | as I said, we could have two different solutions | 14:18 |
| davidbarth | and not require further re-alignment of either the msg-menu items or dbusmenu at the same time | 14:18 |
| Cimi | 1) drawing with cairo | 14:18 |
| Cimi | 2) using cairo to place the icon on the left | 14:18 |
| Cimi | with icon I mean the current triangle icon | 14:18 |
| davidbarth | how would option 2) work? | 14:19 |
| davidbarth | you move the current "cursor" | 14:19 |
| davidbarth | and let the icon drawing code render from here? | 14:19 |
| Cimi | I draw using cairo | 14:20 |
| Cimi | but | 14:20 |
| Cimi | instead drawing with the vectorial api | 14:20 |
| Cimi | I will get the pixbuf and place it on a surface | 14:20 |
| Cimi | the advantage is that it is themeable | 14:21 |
| Cimi | the downside is that you might have problems with different colors in themes | 14:21 |
| Cimi | another downside is that it won't scale maybe with different font dimensions (or yes, it could scale but not like a pure vectorial code) | 14:22 |
| davidbarth | Cimi: the version you have implements option #1 right? | 14:22 |
| Cimi | y | 14:23 |
| davidbarth | Cimi: to make it more themeable, you could also retrieve some properties (if you don't already) to at least use some theme colors | 14:23 |
| davidbarth | for the rest i'm not sure i see which benefits option #2 would bring wrt to themability | 14:24 |
| Cimi | davidbarth: I'm already checking he colors | 14:24 |
| davidbarth | Cimi: then that sounds fine to me | 14:24 |
| Cimi | ok I'll open a new branch | 14:24 |
| Cimi | just for the triangle | 14:24 |
| davidbarth | Cimi: i think the last step is to get some signoff from design on that rendering | 14:24 |
| davidbarth | Cimi: right | 14:24 |
| davidbarth | Cimi: maybe that'll require some adjustment for the size of the triangle, but apart from that, that should be fine for landing today too | 14:25 |
| davidbarth | Cimi: one note: there should be a way to have the triangle have either a normal (gray) color, or an active/highlighted color (green, to go with the green envelope) | 14:32 |
| davidbarth | Cimi: are there style properties you'd recommend to use to have that stylable in a way consistent with the rest of the style property hiearchy? | 14:32 |
| Cimi | mmm | 14:35 |
| Cimi | (davidbarth pushed anyway the first version) | 14:35 |
| Cimi | davidbarth: maybe not, I don't know | 14:35 |
| Cimi | we can't use selected color | 14:36 |
| Cimi | because it is already used for the selected menuitem | 14:36 |
| Cimi | please test the branch, can't test here | 14:36 |
| Cimi | and tell me if the dimension is ok | 14:36 |
| Cimi | otto liked it | 14:36 |
| davidbarth | Cimi: ok, doing that now | 14:43 |
| davidbarth | Cimi: ok it renders the triangle | 14:51 |
| davidbarth | Cimi: the returns must return a FALSE or the compiler cries | 14:51 |
| davidbarth | Cimi: the other icon is still thre | 14:52 |
| davidbarth | Cimi: and so utlimately it means we need to de-construct what ted did with the hboxes and so on | 14:52 |
| davidbarth | Cimi: because they would not be needed anymore, as the triangle is an overlay | 14:52 |
| davidbarth | Cimi: let me try the removal of the hbox code, that is tied to the specific menu item | 14:53 |
| Cimi | davidbarth: yeah that's true | 15:00 |
| Cimi | I forgot it | 15:00 |
| Cimi | davidbarth: which return must return fals? | 15:03 |
| Cimi | davidbarth: and what about the conference call | 15:12 |
| Cimi | ? | 15:12 |
| davidbarth | Cimi: no ping yet on the call | 15:17 |
| davidbarth | Cimi: i have fiddled a bit with the icon size to bring that closer to otto's design | 15:17 |
| Cimi | davidbarth: ok | 15:17 |
| davidbarth | Cimi: no ping yet on the call | 15:17 |
| davidbarth | Cimi: i have fiddled a bit with the icon size to bring that closer to otto's design | 15:17 |
| Cimi | i received it | 15:17 |
| davidbarth | (in case that didn't pass, ah good) | 15:18 |
| davidbarth | Cimi: the horizontal-padding property that is used for the icon + label layout | 15:18 |
| davidbarth | Cimi: is that something that can be adjusted as well? | 15:18 |
| davidbarth | Cimi: ie, if we were to not add padding to the left side of the icon, that would bring it closer to the left border (and the triangle) | 15:19 |
| davidbarth | and still align with entries with only text or? | 15:19 |
| Cimi | one sec | 15:20 |
| Cimi | I'm tired, need to re-read it :) | 15:20 |
| Cimi | I did not understand | 15:21 |
| Cimi | mainly because I don't have the app running so I can't know what's wrong | 15:21 |
| davidbarth | Cimi: hmm, sory, not that's not a good idea | 15:22 |
| davidbarth | Cimi: we need to add the same padding to both text or icon + text entries, or that won't align of course | 15:22 |
| Cimi | davidbarth: sshot? | 15:23 |
| * Cimi needs to sleep 10 mins or his mind will blow up | 15:25 | |
| davidbarth | Cimi: hang on, coming back in ~20min after an internal meeting | 15:29 |
| davidbarth | Cimi: (not on design) | 15:29 |
| Cimi | davidbarth: updates? | 16:08 |
| Cimi | davidbarth: received | 16:13 |
| davidbarth | Cimi: kenvandine updated the gtk package if you want to try again | 16:29 |
| davidbarth | Cimi: see the steps with ken if you want to recover from the past change maybe | 16:29 |
| kenvandine | i think just install ubuntu-desktop should do it | 16:30 |
| davidbarth | Cimi: chaotic is saying the changes are ok to go in, i'm adjusting a variable with him and will push the changes bakc for you to resubmit | 16:30 |
| kenvandine | but i think njpatel found installing fresh was easier | 16:30 |
| Cimi | will do tomorrow | 16:37 |
| Cimi | davidbarth: ok, i'm here | 16:37 |
| Cimi | what about the conference call? | 16:37 |
| Cimi | not needed anymore? | 16:38 |
| Cimi | davidbarth: lol, you don't read me just because you need the nice rounded counter on the right :P | 16:43 |
| davidbarth | Cimi: ok sweet, chaotic is happy with the triangle, we adjusted that a bit to accomodate for the gap between them and the icon | 16:43 |
| davidbarth | Cimi: sort of yes ;) | 16:43 |
| Cimi | lol | 16:43 |
| davidbarth | Cimi: on the rounded counters | 16:43 |
| Cimi | yep | 16:44 |
| davidbarth | Cimi: could you try to have the font 1 or 2 points smaller? | 16:44 |
| davidbarth | i guess it takes a few gtk calls to adjust that | 16:44 |
| Cimi | it should | 16:44 |
| Cimi | but i did not reach it | 16:44 |
| davidbarth | would you know where to hit in the right spot? | 16:44 |
| Cimi | davidbarth: read lines 567-569 | 16:45 |
| davidbarth | Cimi: i'm there | 16:45 |
| Cimi | sorry 567-568 | 16:45 |
| Cimi | it didn't work | 16:45 |
| davidbarth | just trying to find out where to attack | 16:45 |
| davidbarth | oh, sorry the pango calls | 16:45 |
| davidbarth | Cimi: what about something like gtk_widget_modify_style? | 16:50 |
| Cimi | for what? | 16:50 |
| Cimi | the only idea I have in my mind is using cairo_scale | 16:50 |
| Cimi | and try to see if it will work | 16:51 |
| davidbarth | Cimi: can you ping me again, please? | 16:53 |
| Cimi | davidbarth: no :P | 16:55 |
| davidbarth | thanks | 16:57 |
| Cimi | davidbarth: does cairo_scale work? | 16:58 |
| davidbarth | Cimi: dunno, where? | 16:58 |
| Cimi | in numbers_draw_cb | 16:58 |
| Cimi | before drawing everything | 16:59 |
| Cimi | you should try a transformation | 16:59 |
| davidbarth | Cimi: oh i see | 16:59 |
| Cimi | davidbarth: like cairo_scale (cr, 0.8, 0.8); | 17:00 |
| Cimi | not sure if we need 1.2 or 0.8 :) | 17:01 |
| davidbarth | Cimi: well, i'd rather stabilize the code for the release today and note the optimizations for later next week | 17:01 |
| davidbarth | Cimi: during your sprint in London | 17:01 |
| davidbarth | Cimi: atm i'm just trying to see if there is an easy way to get the font size different, but that may take a while, so i'll just push back my branch and please re-submit it once received | 17:02 |
| davidbarth | Cimi: then i'll roll a few tarballs for the desktop folks to get something better into A3 for now | 17:02 |
| Cimi | ok | 17:02 |
| davidbarth | Cimi: lp:~dbarth/indicator-messages/style-rehash-for-cimi | 17:05 |
| davidbarth | Cimi: just merge back in your existing branch and i'll finish validating the merge proposal | 17:06 |
| Cimi | davidbarth: pushed | 17:10 |
| davidbarth | Cimi: merged in, thanks | 17:21 |
| Cimi | chaotic: did you take the latest theme? | 17:31 |
| Cimi | I have seen you removed the snapshot of the 28 from the shared folder | 17:31 |
| chaotic | I've been looking at it today - it's getting there :) | 17:35 |
| Cimi | chaotic: why you removed it? | 17:36 |
| chaotic | hmmm weird - didn't mean to remove it - one second | 17:36 |
| chaotic | it's back - I thought I'd copied it, but I had moved it by accident, sorry | 17:38 |
| Cimi | chaotic: is the theme ok? | 17:41 |
| chaotic | cimi: it's looking good and I'm looking forward to refining it further next week | 17:42 |
| Cimi | chaotic: will it go in alpha3? | 17:44 |
| chaotic | Cimi: no | 17:44 |
| chaotic | Cimi: we need to do a bit more to it plus we still need to create the radiance equivalent | 17:44 |
| Cimi | ok | 17:44 |
| chaotic | Cimi: shouldn't take long though | 17:44 |
| Cimi | no | 17:45 |
| Cimi | we must refine the window borders for example | 17:45 |
| Cimi | for me they look out of place | 17:45 |
| chaotic | Cimi: they may change slightly but not much | 17:46 |
| chaotic | Cimi: not sure if we should go more with the newer idea I had | 17:46 |
| chaotic | Cimi: have to go to a team meeting and I am on holiday tomorrow but I look forward to seeing you next week | 17:48 |
| Cimi | chaotic: see you on monday for lunch | 18:01 |
| Cimi | chaotic: get food for me :) | 18:01 |
| Cimi | I will arrive at 12:30-13 of monday | 18:01 |
| davidbarth | Cimi: going out, but let me know if you managed to get the argb package running, we'll continue tomorrow | 18:54 |
| davidbarth | cheers | 18:54 |
| === DanRabbit_ is now known as DanRabbit | ||
| === DanRabbit_ is now known as DanRabbit | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!