| === Ursinha is now known as Ursinha-afk | ||
| === wgrant_ is now known as wgrnat | ||
| === wgrnat is now known as wgrant | ||
| === matsubara-afk is now known as matsubara | ||
| === salgado is now known as salgado-dr | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === salgado-dr is now known as salgado | ||
| bdmurray | Is there anybody reviewing now? | 16:33 |
|---|---|---|
| jelmer | bdmurray: I don't think there is an on call reviewer at the moment, though I can do a review if you have something non-huge. | 16:38 |
| bdmurray | jelmer: I think it counts as non-huge - https://code.edge.launchpad.net/~brian-murray/launchpad/bug-605340/+merge/31221 | 16:39 |
| jelmer | bdmurray: That's fine, I'll review. | 16:42 |
| bdmurray | jelmer: great, thanks! | 16:42 |
| jelmer | bdmurray: Is there any particular reason you're setting the event_creator attribute? It doesn't appear to be used somewhere. | 16:53 |
| bdmurray | jelmer: its used to add the header for X-Launchpad-Bug-Modifier in bugnotificationbuilder | 16:56 |
| jelmer | bdmurray: That's done from the argument to the constructor, not using the attribute. | 16:59 |
| bdmurray | jelmer: are you referring to setting it to None? | 17:02 |
| jelmer | bdmurray: No, to line 46 of your patch. You set self.event_creator to event_creator (the argument) there but don't use the attribute afterwards as far as I can tell. | 17:03 |
| === matsubara is now known as matsubara-lunch | ||
| === Ursinha is now known as Ursinha-lunch | ||
| bdmurray | jelmer: got it now - thanks. I was on a call. | 17:31 |
| === deryck is now known as deryck[lunch] | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === matsubara-lunch is now known as matsubara | ||
| === deryck[lunch] is now known as deryck | ||
| mwhudson | gary_poster: hey, want to review some of my vostok-* branches? :-) | 21:33 |
| mwhudson | you've seen most of it before i think | 21:34 |
| gary_poster | mwhudson: :-) I'm happy to do it tomorrow if you like. booked today | 21:34 |
| mwhudson | gary_poster: ok, no real hurry | 21:34 |
| mwhudson | gary_poster: happy to chase someone else if you can think of someone to review this sort of thing | 21:34 |
| mwhudson | i guess thumper knows the code after battling to write test_traverse... | 21:35 |
| gary_poster | ok cool, mwhudson. send me a note with the branches and I'll look at em. Well, benji would be a good choice once he is a reviewer, but no help yet. yeah, thumper might be good, or sinzui. | 21:35 |
| mwhudson | gary_poster: ok | 21:36 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| rockstar | thumper, https://code.edge.launchpad.net/~rockstar/launchpad/recipe-no-signer/+merge/31339 | 23:56 |
| * thumper looks | 23:57 | |
| rockstar | thumper, no diff yet. :( | 23:57 |
| rockstar | I can has RabbitMQ? | 23:57 |
| thumper | yes | 23:57 |
| thumper | yes you can | 23:57 |
| thumper | one day | 23:58 |
| rockstar | Oh, if only that one day could have been yesterday. | 23:58 |
| rockstar | Diff! | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!