[16:33] <bdmurray> Is there anybody reviewing now?
[16:38] <jelmer> bdmurray: I don't think there is an on call reviewer at the moment, though I can do a review if you have something non-huge.
[16:39] <bdmurray> jelmer: I think it counts as non-huge - https://code.edge.launchpad.net/~brian-murray/launchpad/bug-605340/+merge/31221
[16:42] <jelmer> bdmurray: That's fine, I'll review.
[16:42] <bdmurray> jelmer: great, thanks!
[16:53] <jelmer> bdmurray: Is there any particular reason you're setting the event_creator attribute? It doesn't appear to be used somewhere.
[16:56] <bdmurray> jelmer: its used to add the header for X-Launchpad-Bug-Modifier in bugnotificationbuilder
[16:59] <jelmer> bdmurray: That's done from the argument to the constructor, not using the attribute.
[17:02] <bdmurray> jelmer: are you referring to setting it to None?
[17:03] <jelmer> bdmurray: No, to line 46 of your patch. You set self.event_creator to event_creator (the argument) there but don't use the attribute afterwards as far as I can tell.
[17:31] <bdmurray> jelmer: got it now - thanks. I was on a call.
[21:33] <mwhudson> gary_poster: hey, want to review some of my vostok-* branches? :-)
[21:34] <mwhudson> you've seen most of it before i think
[21:34] <gary_poster> mwhudson: :-) I'm happy to do it tomorrow if you like.  booked today
[21:34] <mwhudson> gary_poster: ok, no real hurry
[21:34] <mwhudson> gary_poster: happy to chase someone else if you can think of someone to review this sort of thing
[21:35] <mwhudson> i guess thumper knows the code after battling to write test_traverse...
[21:35] <gary_poster> ok cool, mwhudson.  send me a note with the branches and I'll look at em.  Well, benji would be a good choice once he is a reviewer, but no help yet.  yeah, thumper might be good, or sinzui.
[21:36] <mwhudson> gary_poster: ok
[23:56] <rockstar> thumper, https://code.edge.launchpad.net/~rockstar/launchpad/recipe-no-signer/+merge/31339
[23:57]  * thumper looks
[23:57] <rockstar> thumper, no diff yet.  :(
[23:57] <rockstar> I can has RabbitMQ?
[23:57] <thumper> yes
[23:57] <thumper> yes you can
[23:58] <thumper> one day
[23:58] <rockstar> Oh, if only that one day could have been yesterday.
[23:58] <rockstar> Diff!