/srv/irclogs.ubuntu.com/2010/07/31/#launchpad-reviews.txt

EdwinGrubbsabentley, bac, jml, rockstar, mars: are any of you around to review a one-line buildbot testfix? https://lpbuildbot.canonical.com/builders/lp/builds/1113/steps/shell_7/logs/summary16:19
rockstarEdwinGrubbs, fire away16:19
bacEdwinGrubbs: lost by a hair16:19
bacbetter reviewer coverage than most weekdays...16:19
abentleyrockstar, enjoy :-P16:20
rockstarMan, look at all yous guys that ain't out enjoyin' your weekends!  :)16:20
EdwinGrubbsrockstar: oops, I didn't realize I pasted the wrong url. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/need_from_future_import_with_statement/+merge/3145816:22
rockstarEdwinGrubbs, r=me, but please file a bug and send out an email about this.  abentley broke the build, but it's not really his fault...16:23
rockstarI can't believe we're running buildbot in a different version of python than we're running on production.16:24
EdwinGrubbsrockstar: ok, thanks16:24
abentleyrockstar, oh geez, really?  I thought we were all switched over.16:24
rockstarabentley, not according to the test failure.  EdwinGrubbs had to do "from future import with_statement"16:24
abentleyrockstar, I couldn't understand what was going on in the test failure.16:25
marsrockstar, everything in the build system *except* developer boxes is still on Python 2.516:53
rockstarmars, expand "developer boxes" because technically, my machine is a developer box.16:54
marsAnd it is really really easy to use awesome 2.6 features and forget that "you can't land that"16:54
rockstarDoes that mean all our boxes in the datacenter?16:54
marsrockstar, nope, just your local machine I believe16:54
marsIn the data center we have one buildbot slave running 2.6/lucid16:55
marsthe others are all 2.5/hardy16:55
marsdevpad is 2.5/hardy16:55
rockstarmars, but production is running 2.6, right?16:55
marsrockstar, hmm, I don't know, but I would think not.  The next "big thing" is to get staging ported to Lucid/2.6.  IIRC then the app servers were next in line.16:56
rockstarmars, okay, so the buildbots prevent us from deploying code that can't be run.  That makes a bit more sense.16:57
rockstarStill kinda hairy, but makes sense.16:57
marshehe16:57
marsyeah, I thought about putting a Py2.5 pyflakes check in the linter, but the changeover is happening16:58
marsa pyflakes-2.5 check would have caught this, but I think it is only the second time this has happened16:59
marsand people aren't using things like namedtuple yet16:59
marsthe 2.5 feature set appears to be very heavily ingrained in our minds17:00

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!