| thumper | lifeless: want to eyeball a boring as crap branch which just moves errors from canonical.launchpad.webapp.interfaces into lp.app.errors? | 03:25 |
|---|---|---|
| lifeless | no | 03:25 |
| lifeless | +1 | 03:25 |
| thumper | rs? | 03:26 |
| lifeless | yes | 03:26 |
| lifeless | you break it you bought it | 03:26 |
| thumper | ack | 03:26 |
| thumper | lifeless: 2542 lines (+256/-235) 147 files modified :-) | 03:32 |
| lifeless | not that app.errors is really any better, but I get the psych value of it ;) | 03:32 |
| thumper | lifeless: well, lp.app is where much of canonical.launchpad.webapp is going | 03:37 |
| lifeless | yeah, I know | 03:37 |
| lifeless | just saying that A.bigbag == B.bigbag :) | 03:37 |
| thumper | actually... | 03:37 |
| thumper | we are breaking up a general interfaces big bag into two | 03:37 |
| thumper | errors and interfaces | 03:37 |
| thumper | so in a way, it is being a lot broken up | 03:37 |
| lifeless | \o/ | 03:38 |
| lifeless | http://bazaar.launchpad.net/~lifeless/launchpad/malone/revision/11225 | 03:38 |
| lifeless | thats an incremental patch on my make-search-faster branch | 03:38 |
| lifeless | anyone care to ok it ? | 03:38 |
| thumper | lifeless: where is the merge proposal? | 03:39 |
| lifeless | https://code.edge.launchpad.net/~lifeless/launchpad/malone/+merge/30904 | 03:39 |
| lifeless | the proposal is approved | 03:39 |
| lifeless | but ec2land told me I was foolishly hopeful | 03:39 |
| thumper | lifeless: why tweak sample data instead of adding a bug with the factory | 03:42 |
| thumper | ? | 03:42 |
| thumper | it raises my ick factor | 03:42 |
| lifeless | thumper: minimal change to work in with the existing test | 03:43 |
| lifeless | thumper: adding a new bug causes the rest of the entire doctest to go boom | 03:43 |
| thumper | :( | 03:43 |
| lifeless | indeed | 03:43 |
| thumper | lifeless: commented. | 03:44 |
| lifeless | thanks | 03:45 |
| wgrant | lifeless: Nice easy DB review for you: https://code.edge.launchpad.net/~wgrant/launchpad/per-archive-build-debug-symbols/+merge/29671 | 05:59 |
| lifeless | mmm | 06:03 |
| lifeless | is archive really the right scope for this ? | 06:03 |
| lifeless | its a bit of a shame all our config knobs are spread all over | 06:04 |
| * lifeless tries not to use flags for everything | 06:04 | |
| wgrant | lifeless: What would be a better scope? | 06:06 |
| lifeless | packageset-in-archive ? | 06:07 |
| lifeless | I dunno, it just seems rather coarse, or something. | 06:07 |
| wgrant | It is coarse, yes. | 06:07 |
| wgrant | Packagesets are an interesting idea, but they're not workable yet. | 06:07 |
| lifeless | wgrant: dbgsyms is an unnecessary abbreviation in at least one place in the patch | 06:09 |
| lifeless | its also a redundant comment in that place too | 06:10 |
| wgrant | True. | 06:10 |
| lifeless | given the variable name is pretty clear | 06:10 |
| wgrant | This branch is a year old, and the terminology throughout the rest of the branches has changed since then. | 06:10 |
| wgrant | It is probably removable indeed. | 06:10 |
| lifeless | please don't use the string literal there | 06:11 |
| lifeless | for commercial-admins | 06:11 |
| lifeless | rather use the sampledata module | 06:11 |
| wgrant | Hm. Does it really only have one value at the moment? | 06:12 |
| wgrant | Or is there another one I'm missing somewhere? | 06:12 |
| lifeless | its pretty small right now | 06:12 |
| === wgrant changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [wgrant(http://bit.ly/dvBcHk)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === stub1 is now known as stub | ||
| jml | I'm reviewing james_w's sampledata-0 branch btw, | 12:30 |
| === mrevell is now known as mrevell-lunch | ||
| === matsubara-afk is now known as matsubara | ||
| jml | bigjools, getting to your branch now. sorry about the delay. | 13:32 |
| jml | bigjools, done. | 14:14 |
| bigjools | jml: you rock, thanks | 14:14 |
| jml | bigjools, my pleasure. | 14:15 |
| bigjools | jml: the next branch will clean up these damn tests I hope | 14:15 |
| bigjools | the "if in doubt return a Deferred" approach is a good one | 14:16 |
| bigjools | jml: BTW there's nowhere in the guidelines that says we use US spelling in code | 14:18 |
| === mrevell-lunch is now known as mrevell | ||
| jml | :( | 14:18 |
| bigjools | you mean: :) | 14:18 |
| jml | bigjools, no, I don't. | 14:18 |
| bigjools | lol | 14:18 |
| jml | I hate having to think unnecessarily when reading code | 14:19 |
| bigjools | I prefer "international English" | 14:19 |
| bigjools | me too | 14:19 |
| jml | color | 14:19 |
| bigjools | that's why I go out of my way to make the English agnostic | 14:19 |
| jml | color, never ever ever colour | 14:19 |
| bigjools | the mighty British Empire says otherwise | 14:19 |
| jml | what a pity they didn't invent C | 14:20 |
| bigjools | ha | 14:20 |
| bigjools | FWIW "dialog" to me means a popup. | 14:20 |
| bigjools | a dialogue is a conversation | 14:20 |
| jml | if you spell it slaveDialogueEnded in the code it's going to look weird to lots of people and eventually someone is going to change it to be slaveDialogEnded | 14:21 |
| * bigjools sighs heavily | 14:22 | |
| jml | feel sorry for the French | 14:23 |
| jml | I bet they have discussions about whether it should be self.ordinateur or self.la_ordinateur | 14:24 |
| bigjools | jml: ok, so slavePowowEnded it is | 14:27 |
| james_w | thanks jml. Just a couple of questions in https://code.edge.launchpad.net/~james-w/launchpad/no-more-sampledata-0/+merge/31470 | 14:29 |
| james_w | jml: plus there's a nice juicy Collection branch sitting there :-) | 14:29 |
| jml | bigjools, "prefer the standard to the offbeat", also, the OED spells it powwow or pow-wow :P | 14:40 |
| bigjools | jml: grumble...smartarse :) | 14:43 |
| bigjools | does the OED carry US spelling? | 14:44 |
| benji | I need a review of a small patch to lazr.restful: https://code.edge.launchpad.net/~benji/lazr.restful/nail-versions/+merge/31421 | 14:44 |
| benji | it just nails some versions so the tests pass again | 14:44 |
| jml | bigjools, yes. main articles are in real English, but it is always explicit when there are regional spelling variations. | 14:45 |
| bigjools | jml: so if I use slaveConversationEnded will that satisfy your reviewing juices? | 14:46 |
| jml | bigjools, yes. | 14:46 |
| bigjools | hurray | 14:46 |
| === abentley changed the topic of #launchpad-reviews to: On call: abentley || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| jml | james_w: replied. I might look at the archive-collection thing. | 14:56 |
| james_w | jml: no rush | 14:57 |
| bigjools | jml: reply incoming | 15:26 |
| bigjools | jml: btw thanks for the collections explanation. I think I get it, but since I'm more of a JFDI than a theoretical kind of man I think more concrete examples will help. In due course. | 15:27 |
| jml | bigjools, np. | 15:30 |
| james_w | bigjools: have you seen https://code.edge.launchpad.net/~james-w/launchpad/archive-collection/+merge/31499 ? | 15:30 |
| james_w | I did it because I wanted something very similar to getArchivesForDistribution in the deletion branch, but with one more collection. While you can continue to add more methods to ArchiveSet with the requirements of every caller, letting them construct their query is more flexible. | 15:32 |
| bigjools | james_w: yes, right. Does it build up the same query or issue multiple queries? | 15:43 |
| james_w | one query | 15:43 |
| james_w | the shape of that query may not be optimal, but that's the case with any new or modified queries | 15:44 |
| === deryck is now known as deryck[lunch] | ||
| === Ursinha is now known as Ursinha-lunch | ||
| bigjools | jml: I don't understand why you want IBuilder.getActiveBuild | 16:15 |
| bigjools | oh scratch that | 16:16 |
| bigjools | I can't fucking read | 16:16 |
| jml | bigjools, np. otp right now :) | 16:16 |
| bigjools | jml: FWIW it also returns a proxied object and that is force of habit for me :) anyway ... | 16:20 |
| james_w | jml: just to clarify, when you say "test_returnsAll... style rather than testReturnsAll style" do you mean "test_returnsAll_does_something" or "test_returnsAllDoesSomething" ? | 16:38 |
| jml | james_w, test_properName_does_a_thing | 16:39 |
| james_w | jml: ok | 16:39 |
| jml | james_w, archivecollection reviewed. | 17:01 |
| === salgado is now known as salgado-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| benji | I need a review of a small patch to lazr.restful: https://code.edge.launchpad.net/~benji/lazr.restful/nail-versions/+merge/31421 | 17:20 |
| === Ursinha-lunch is now known as Ursinha | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| === matsubara is now known as matsubara-afk | ||
| === mwhudson_ is now known as mwhudson | ||
| === abentley changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!