=== Ursinha is now known as Ursinha-afk [08:34] say henninge, aren't you ocr today? [08:35] No, it's gmb [08:35] * StevenK already checked === henninge_ is now known as henninge [08:57] henninge: I just put that API simplification branch up for review. [08:58] lemme look [09:03] jtv: looks good. Shouldn't it have a bug? [09:04] henninge: well, it's a feature-branch task so I'm not sure we need to go to those lengths. And it's just split off from, depending on your point of view, yesterday's branch or the job I'm working on now. [09:04] ok [09:14] gmb: O hai, Mr OCR! [09:24] StevenK, Morning. If you've got something that needs review bung it in the queue and I'll take a look in about an hour's time. Still catching up on emails. [09:24] gmb: hey [09:24] gmb: I have an _easy_ fix for you [09:25] https://bugs.edge.launchpad.net/malone/+bug/615644 [09:25] <_mup_> Bug #615644: BugTask:+distrotask timeout on HEAT lookup [09:26] lifeless, Easy fix for me to create a branch for, or is there already a branch that needs reviewing? [09:27] gmb: easy fix for a sparkling young fella like you to make a branch for [09:29] lifeless, Righto, I shall take care of it presently. [09:29] gmb: Maybe you should suggest lifeless reviews the branch :-) [09:31] gmb: just needs a ordered.first() turned into a .max() [09:31] lifeless, Ah, even better. [09:53] lifeless, Do you know, or can you point me to a way of finding out, whereabouts that query is getting issued? I'm struggling to find it (though this may be a case of E_NOT_ENOUGH_CAFFEINE). [09:54] gmb: well, have a look at the linked oops [09:54] gmb: as for trapping it, uhm, I've been strugglying with that too [09:54] putting a hook in the thing tha tappaends to get_request_statements might be best [09:54] lifeless, Ah, I think I may have found it. I was looking for Storm but maybe the query is pure SQL. [09:56] lifeless, Yep, it's HasBugHeatMixin.recalculateBugHeatCache() that's the culprit. lib/lp/bugs/model/bugtarget.py:239 [10:12] lifeless, https://code.edge.launchpad.net/~gmb/launchpad/bug-615644/+merge/32175 if you're interested. === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === StevenK changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: - || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:18] gmb: *cough* :-) [10:19] StevenK, Righto. Good job you put it in the queue otherwise (/me looks at +activereviews) jelmer was first up :) [10:22] StevenK, That could have done with a more detailed cover letter. See https://dev.launchpad.net/CoverLetters for templates. So, expect questions. [10:23] (Although I'm kidding a bit because of the nature of the branch) [10:23] \0/ for killing doctests [10:23] gmb: I seriously tried three times to write a better cover letter and come up with writers block. [10:24] StevenK, Understandable. === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:31] gmb: I'm starting to cook dinner, so I'll be afk and such like [10:33] StevenK, Okidoke. [10:34] jtv1: you mp is not emitting emails again. Could you investigate that or have it investigated, please? [10:35] henninge: grrr. OK. [10:35] gmb: Are you open to bribes of pasta bake? :-) [10:36] henninge: btw I did get the email where I requested the review [10:36] jtv1: but there is none on the list. [10:36] jtv1: also, when I claim it, I should get one... let me check. [10:37] StevenK, Pasta bake may or may not be sufficient for your branch to land without oversight (see extended reviewing guidlines, subsection 1, "Bribes of food, money or sundry electronic items") [10:38] Bwahaha [10:38] henninge: do you normally get them when you propose for merging into the recife branch? I mean, the emails to the list aren't tied to specific LP branches? [10:39] oh, I did not think about that ... [10:40] jtv1: I just remeber OCRs picking up on recife branches so I always thought they had been notified. [10:40] but maybe it's just because they appear in +activereviews. [10:40] henninge: sounds more likely… I don't think anyone follows the lp-reviews list for this anymore. [10:41] jtv1: just replying to it by makes it much more easier to comment on the diff, though ... [10:41] henninge: yes, it does… but for now I think I'll just say that I've investigated and found this as the most likely cause. :-) [10:55] jtv1: well done. [10:55] ;-) [10:55] * jtv1 salutes to the sound of heroic trumpets [10:55] jtv1: review about to be sent, r=me with a few suggestions. [10:55] henninge: great, thanks! [10:58] * henninge lunches === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:14] gmb: All of the checks in test_initialise() are ripped straight from the doctest, and are checking that source and binary publications were copied correctly. [11:25] StevenK, Okay, that's fine. Please add comments explaining that (you don't need to comment the individual asserts, though) [11:25] gmb: Yup, was going to do so tomorrow morning [11:26] Cool. === noodles775 changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:58] Hi gmb, when you've time: https://code.edge.launchpad.net/~michael.nelson/launchpad/561586-move-js-to-lp-app/+merge/32180 [11:58] I'll take a look at StevenK's branch now too. [12:00] noodles775, Thanks muchly. Looking at your MP now. === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:03] gmb: Hi. https://code.edge.launchpad.net/~wgrant/launchpad/bug-590708-getBuildsByArchIds-timeout/+merge/32181 is a nice simple RC branch, when you have time. === wgrant changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: noodles775 || queue: [wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:03] ^^^ can take priority over mine which is not RC. [12:11] noodles775, r=me. [12:11] wgrant, Looking now [12:11] Thanks gmb === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: wgrant || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:12] gmb, noodles775: Thanks. [12:13] wgrant, Nice solution :) [12:13] r=me [12:14] * gmb lunches before anything else comes up === gmb changed the topic of #launchpad-reviews to: Today's trained review ape: gmb || reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [12:14] gmb: Ahem. [12:14] Thanks. [12:15] Do I request an 'rc', or a 'release-critical'? [12:15] The latter [12:16] D: There are two Julian Edwardses, both with hidden email addresses. [12:17] I am julian-edwards [12:17] I guess I should expose my canonical one :) [12:17] bigjools: I know, but the UI doesn't tell me the username. [12:17] It just lists two 'Julian Edwards