=== mwhudson_ is now known as mwhudson === Ursinha is now known as Ursinha-afk === mrevell is now known as mrevell-lunch === Ursinha-afk is now known as Ursinha === mrevell-lunch is now known as mrevell [15:01] #startmeeting [15:01] Meeting started at 09:01. The chair is bac. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] hi who is here? [15:01] me [15:01] me [15:01] me [15:01] sinzui just wandered off [15:02] danilos: ping [15:02] me [15:02] gmb, EdwinGrubbs, leonardr, jelmer ping [15:02] me [15:02] bigjools: yo [15:02] me [15:03] me, too [15:03] me ish [15:03] flacoste, noodles775, mars: ping [15:03] here [15:03] me [15:04] me [15:04] me [15:04] [topic] agenda [15:04] New Topic: agenda [15:04] * Roll call [15:04] * Agenda [15:04] * Outstanding actions [15:04] * New topics [15:04] me [15:04] * Format import lists so they merge well and are clear to review. RobertCollins [15:04] * Call for new reviewers. [15:04] Sorry [15:04] * Removing enums and errors out of interfaces. TimPenhey [15:04] * Policy decisions: Reviewers Meeting or mailing list? RobertCollins [15:04] * Peanut gallery [15:04] [topic] outstanding issue [15:04] New Topic: outstanding issue [15:05] there is just the one, coop vs shared vs inter. that discussion has been happening on the mailing list so i don't see the need to bring it up here too. so i won't. [15:05] [topic] Format import lists so they merge well and are clear to review. RobertCollins [15:05] New Topic: Format import lists so they merge well and are clear to review. RobertCollins [15:06] lifeless brought this up on the list but i was quite confused by the discussion [15:06] this is the issue that came up a year (?) ago [15:06] we discussed it in the asiapac meeting last week and it turns out, he is advocating for the one-line-per-item in lists (as we do now) plus extending that to imports [15:06] which we discussed and rejected a year ago as bigjools said [15:07] robert and the code team are still very much in favor in this change. [15:07] bac, true, dat. [15:08] * henninge doesn't mind either way [15:08] Actually, I see both formatings in our code. [15:09] formats, formations, formatations ??? [15:09] ;-) [15:09] I'm not sure if I care which way it is, but I do care that the files are all the same [15:09] bigjools, +1 [15:09] bigjools +1 [15:09] Ouch, that is a lot of work. [15:09] That's the biggest bugbear. [15:09] me [15:10] surely we can write a tool to reformat them? [15:10] if we do decide to make the change it'll be a big, mechanical branch. [15:10] we may have such a tool [15:10] JFDI [15:10] people who do big apocalyptic branches report seeing lots of merge conflicts over imports...i personally don't see it often [15:10] the migrater has a script that rewrite imports. I think we need to update its formatter [15:11] bigjools: before we JFDI we have to decide if that's what we really want. [15:11] let's vote then. are there any strong arguments for or against first? [15:11] if we have a tool, we can try it out and revert it if we hate it [15:11] i don't like it [15:11] but only esthetics argument [15:12] Readability is surely on the one-liner side. [15:12] flacoste: what you gain on the editor you lose in the diff. [15:12] with lists being alphabetical! [15:12] bac, the arguments pro are fewer conflicts and clearer patches. [15:12] yep [15:12] bac, clearer patches because only the thing added/removed will show, not the whole import block for that module. [15:12] would a single import stay on one line but two or more become a list? [15:13] bac: I'd like that. [15:13] we should just fix the very long "one-line" imports as an alternative solution (i.e. be more specific about what you are importing from) [15:13] bac, that would be fine by me. [15:14] danilos, I'm not sure what you mean by 'very long "one-line" imports' [15:14] i think he means multi-line import [15:14] abentley, well, single-statement imports with lots of things being imported [15:14] from canonical.launchpad.interfaces import A, B, C, D... over 3 lines [15:14] if you import for more specific location most of them will fit on one line [15:15] but it doesn't solve the conflict problem [15:15] if you need to add a 3rd symbol [15:15] or a second one [15:15] or the readability of the patch [15:15] right, it does reduce the chances of it happening though (you are going to get conflicts with the proposal to split them up as well) [15:15] flacoste, I haven't noticed a lot of too-general imports lately, but maybe I'm not looking for them. [15:15] we don't add them [15:15] ok, let's vote [15:15] There are still a lot from c.l [15:16] [vote] Change our coding standards to require one line per item for imports [15:16] Please vote on: Change our coding standards to require one line per item for imports. [15:16] Public votes can be registered by saying +1/-1/+0 in the channel, private votes by messaging the channel followed by +1/-1/+0 to MootBot [15:16] E.g. /msg MootBot +1 #launchpad-meeting [15:16] -1 [15:16] -1 received from danilos. 0 for, 1 against. 0 have abstained. Count is now -1 [15:16] +1 [15:16] +1 received from abentley. 1 for, 1 against. 0 have abstained. Count is now 0 [15:16] +1 because I fancy a change :) [15:16] +1 received from bigjools. 2 for, 1 against. 0 have abstained. Count is now 1 [15:16] -1 [15:16] -1 received from adeuring. 2 for, 2 against. 0 have abstained. Count is now 0 [15:16] +1 [15:16] +1 received from gmb. 3 for, 2 against. 0 have abstained. Count is now 1 [15:16] +1 for readability [15:16] +1 received from henninge. 4 for, 2 against. 0 have abstained. Count is now 2 [15:16] +0 [15:16] Abstention received from noodles775. 4 for, 2 against. 1 have abstained. Count is now 2 [15:16] +1 [15:16] +1 received from sinzui. 5 for, 2 against. 1 have abstained. Count is now 3 [15:16] +0 [15:16] Abstention received from mars. 5 for, 2 against. 2 have abstained. Count is now 3 [15:16] -0 [15:16] * bigjools spies a fence-sitter [15:16] :) [15:17] bac: -0 doesn't work [15:17] -1 [15:17] -1 received from flacoste. 5 for, 3 against. 2 have abstained. Count is now 2 [15:17] -1 [15:17] -1 received from bac. 5 for, 4 against. 2 have abstained. Count is now 1 [15:17] +1 [15:17] +1 received from jelmer. 6 for, 4 against. 2 have abstained. Count is now 2 [15:17] fascinating :) [15:17] (this seems like the most interesting vote so far :) [15:17] voting to close in ten seconds [15:17] +1 [15:17] +1 received from deryck. 7 for, 4 against. 2 have abstained. Count is now 3 [15:17] -1 [15:17] -1 received from EdwinGrubbs. 7 for, 5 against. 2 have abstained. Count is now 2 [15:18] Democracy in action, folks. [15:18] #endvote [15:18] [endvote] [15:18] Final result is 7 for, 5 against. 2 abstained. Total: 2 [15:18] plus the code team and Rob [15:18] ok, so the voting in AsiaPac will be perfunctory. the motion will carry as they all favor it. [15:19] they haven't had the chance to listen to our wonderfully founded arguments, though :) [15:19] danilos: yeah,i don't think that's going to sway them [15:19] :) [15:19] i'll seek an asiapac volunteer to update the wikis [15:19] bac, perhaps some beating or bribing then? :) anyway, thanks all for the vote [15:20] s/vote/voting/ [15:20] [topic] call for new reviewers [15:20] New Topic: call for new reviewers [15:20] Any team leads want to nominate new mentats? [15:20] bigjools: ??? [15:20] * bigjools got distracted [15:21] * bigjools is nominating SteveK [15:21] you have mentor? [15:22] hey bigjools, how about tim? [15:22] yes, thumper agreed to mentor him [15:22] i'll send an email to steve and invite him to the asiapac meeting [15:22] thanks bac [15:22] thanks bigjools for nominating him [15:22] my pleasure :) [15:23] [topic] Removing enums and errors out of interfaces. TimPenhey [15:23] New Topic: Removing enums and errors out of interfaces. TimPenhey [15:23] tim sent out email about this topic last week but there was no discussion. he asked me to bring it up here [15:23] +1 million to that [15:23] +1 [15:23] yep, that's a JFDI case [15:23] +1 [15:23] A thousand times +1 [15:24] +1 here as well :) [15:24] +1 too. Just to be sure, that means moving them to the model code? [15:24] +1 [15:24] so create lp/app/enums.py and errors.py [15:24] err, lp//enums.py i mean [15:25] [topic] Policy decisions: Reviewers Meeting or mailing list? RobertCollins [15:25] New Topic: Policy decisions: Reviewers Meeting or mailing list? RobertCollins [15:25] meeting! [15:25] lifeless brought this up last week and wanted to discuss it here [15:26] his thought is having this meeting make policy as one of its goals drags out decisions [15:26] ML discussions can lead to quicker decision making, he argues [15:26] thoughts? [15:27] meeting are good for a sync point [15:27] making policy decision on mailing list is confusing [15:27] Having a meeting focuses discussion. It may increase latency, but the actual decision-making is faster, and the results are clearer. [15:27] I don't agree. This meeting is prove of that re the decission on import formating. [15:27] well, not confusing [15:27] but requires art [15:27] it's often not clear when the decision is reached [15:27] I strongly disagree with his assertion that meetings lead to slower decision making; if anything, they lead to faster decision making imho [15:28] i think we get more opinions in this meeting and it is easier to catch confusion and eliminate them [15:28] danilos: +1 [15:28] i think his impression might come from the AsiaPac/Ameu split [15:28] Also, it is the only place left were we regularly meet as developers and discuss developing - sort of. [15:28] where the bullk of the devs are in Ameu [15:28] danilos, agreed. ML threads tend to wander, and don't necessarily reach a conclusion. [15:28] decisions in meetings, discussions about decisions on the ML, unless there's an obvious early consensus on the ML. [15:28] I [15:29] I favor the meeting, too. Seems quicker to me, and you know when it's over. :-) [15:29] I did suggest him to move to Europe, was what I was trying to say :) [15:29] henninge: that is true and it makes this meeting sometimes be broader than the original intent. i'm not saying that is bad, though. [15:29] bigjools: +1 [15:29] bigjools, +1, and it seems most others who voice their opinion are in agreement [15:30] however, flacoste does point a valid thing: how do we involve our dear AsiaPac developers in the decision making better [15:30] danilos, hold their meeting before ours? :-) [15:31] if it's a simple vote we just tally votes [15:31] bigjools, I seriously believe that the discussions we have are useful, so just tallying the votes is not always a true measure imho [15:31] well, i try to bring the items from here to their meeting. and votes continue there. really it's the best we can do. [15:31] (i.e. I've been swayed before to a different opinion) [15:31] like we did today for a couple of items [15:31] bac, right [15:32] good feedback. thanks. [15:32] anyway, I think we should keep the format, but look into other opportunities to improve it [15:32] danilos: that's why I said long discussions need to be on the ML [15:32] [topic] other items? [15:32] New Topic: other items? [15:33] i guess not. [15:33] bigjools, sometimes they are short discussions ;) [15:33] thanks for coming [15:33] thanks all [15:33] #endmeeting [15:33] Meeting finished at 09:33. [15:33] thanks bac [15:33] danilos: short is fine for meetings, long needs to go to ML. Simple :) [15:34] bac, sinzui: btw, is it worthwhile to do import lines migration per-app? we've got a big branch in progress and would like to avoid having conflicts until that lands [15:34] danilos: that is a good idea [15:35] danilos: we didn't really talk about the D part of JFDI. [15:35] it is more tech-debt [15:35] bac, I can imagine sinzui already hacking away at a script to do it, which is why I am saying that :) [15:36] danilos: he is not. his fingers are idle at the moment. [15:36] bac, hopefully we don't end up with JFI :) [15:36] that's not to say he isn't thinking about it... [15:36] bac, heh, thanks :) [15:36] danilos, I have my own agenda of removing imports from c.l and any tool that make it easier for me to do will probably help you. [15:37] danilos, I am hacking on codehosting at the moment. rosetta will be next week maybe [15:38] sinzui, rosetta should be completely glob-import free, so I expect it to be a much easier job :) anyway, thanks for working on that [15:38] yes, code is clean too. answers and blueprints had a lot but, they were small apps [15:38] I dread the registry-soyuz apps [15:39] danilos: JFI - lol === Ursinha is now known as Ursinha-lunch === salgado is now known as salgado-lunch === Ursinha-lunch is now known as Ursinha-brb === salgado-lunch is now known as salgado === Ursinha-brb is now known as Ursinha === EdwinGrubbs is now known as Edwin-lunch === Edwin-lunch is now known as EdwinGrubbs [22:29] oh hai? [22:30] hey [22:30] bac: are we doing this now? [22:30] bac: or do you want to wait for StevenK? [22:31] bac: is trying to talk [22:31] thumper: i cannot tonight [22:31] #startmeeting [22:31] Meeting started at 16:31. The chair is bac. [22:31] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [22:31] i'm having connectivity problems too [22:32] thumper, mwhudson, rockstar, lifeless :ping [22:32] hi [22:32] hi [22:32] hi [22:32] mwhudson: i didn't know if you wanted to show up for these. you're welcome, of course! [22:32] bac: o [22:33] i'm still doing launchpad reviews occasionally, so i think it makes sense [22:33] ok, great [22:33] yeah, Ii'm here [22:33] also in a meeting with emo :P [22:33] elmo [22:34] so we had a lively meeting this morning. [22:34] elmo the emo? [22:34] that is an interesting picture [22:34] :) [22:34] we discussed the one-import-per-line issue [22:34] and voted [22:35] so let's vote here and make it official [22:35] [vote] Change our coding standards to require one line per item for imports [22:35] Please vote on: Change our coding standards to require one line per item for imports. [22:35] Public votes can be registered by saying +1/-1/+0 in the channel, private votes by messaging the channel followed by +1/-1/+0 to MootBot [22:35] E.g. /msg MootBot +1 #launchpad-meeting [22:35] bac: one line per item means "like bzr" ? [22:35] mwhudson: yep [22:35] +1 [22:35] +1 received from rockstar. 1 for, 0 against. 0 have abstained. Count is now 1 [22:35] benji had an interesting email [22:35] +1 [22:35] +1 received from mwhudson. 2 for, 0 against. 0 have abstained. Count is now 2 [22:35] +1 [22:35] +1 received from thumper. 3 for, 0 against. 0 have abstained. Count is now 3 [22:36] i wonder how lifeless would vote... [22:36] [endvote] [22:36] Final result is 3 for, 0 against. 0 abstained. Total: 3 [22:36] Wait, is wgrant around? Maybe he should have had a say too... [22:36] total: 10 for,5 against, 2 abstained [22:37] rockstar: you don't need him [22:37] Nice. [22:37] so we decided it makes sense to make the change one app at a time [22:37] hmm +1 [22:37] It really wasn't about need, but more that he contributes as well. [22:38] total: 11 for, 5 against, 2 abstain [22:38] +1, anyway. [22:38] 12 for [22:38] now you're all just rubbing it in === salgado is now known as salgado-afk [22:38] I'll start with code [22:38] bac, wait, the chad! It made my vote unreadable! :) [22:39] yeah, it's another tech-debt issue. so update your code as you have time. [22:39] thumper, of course code is going to be the first to make the change... :) [22:39] thanks for championing it lifeless and thumper [22:39] hooray for a definitively coloured bikeshed [22:39] Pink [22:39] \o/ [22:39] btw [22:39] coop [22:40] gah, not yet [22:40] :)( [22:40] that was :) [22:40] we also got the good news that bigjools has asked stevek to become a reviewer and that thumper will be mentoring [22:40] * thumper ndos [22:41] nods [22:41] as mentioned earlier it probably makes sense for him to go to the ameu meeting [22:41] ENOCAFFEINE [22:41] if not, we may need to move the time here to a few hours later [22:41] bac: when is that? [22:41] er, 14Z [22:41] bac: because AM of the AMEU meeting meens he won't be up [22:41] that is a midnight meeting for him [22:41] yuk [22:41] or 1 am [22:42] not really practical [22:42] ok. let me discuss with him [22:42] if we moved this meeting two hours later it would be his 930a and my 730p [22:42] not a problem, usually, as long as i don't forget [22:42] that might be better... [22:43] fine for me, obviously... [22:43] thumper: i brought up your idea about moving enums and errors and it was met with universal praise. [22:43] cool [22:43] I'm happy with that [22:44] lifeless: we also discussed your idea of moving policy decisions to the mailing list rather than discussion in the reviewers meeting [22:45] the feeling was that the meeting allows for decisions to be clarified and decided much more quickly than on mailing lists, where things tend to drag on and get muddled [22:45] Yes. [22:45] sure, I did mention it wasn't baked :) [22:45] also btw, policy decisions is overly broard [22:45] *broad* [22:45] There's value in IRC meetings, methinks. [22:45] i think we get more participation "in person" than on the ML [22:45] there are policy decisions about doing revisions [22:45] s/revisions/reviews/ [22:45] lifeless: sorry if i misrepresented your idea [22:46] and there are policy decisions about what the code should look like [22:46] I was only speculating about the second set [22:46] bac: I don't know if you did or didn't; I'm just being clear here-and-now [22:46] lifeless, well, yeah, that stuff contains bike shedding in both places, so it's better on the mailing list where I can ignore it if I want. [22:47] anyhow [22:47] like I said - unbaked; I will bring it up if I start to feel its baked [22:48] but please do think about how we can: [22:48] in reality, discussions on IRC need to be limited to about ten minutes. so if the topic has not been introduced before, some topics can be decided quickly while others will need to go to the ML [22:48] - bring in more community folk (not just wgrant, there are others :P) into code & design discussions [22:48] - get things that are easy to happen without waiting for a meeting [22:49] bac: asgreed [22:49] lifeless: thanks for bringing up the idea. you have fresh eyes and can see where we've become stodgy [22:49] * wgrant likes IRC for discussions, since it means you can't keep things on the iinternal list :P [22:50] wgrant: FTR I only use the internal list for actually confidential discussions, or if someone starts one there. [22:50] wgrant: we have internal channels too, you know :-) [22:50] wgrant: we've tried to be better about that [22:50] mwhudson: Shh. [22:51] any other topics for today? [22:51] ponies [22:51] lamont wants one [22:51] what happened to woody? [22:51] send him a picture of the storm trooper my little pony [22:51] he moved on, I don't remember the details [22:52] we're sprinting this week and the conference room came with a 3' inflatable tux as a mascot [22:52] \o/ [22:52] where are you? [22:52] my town [22:52] noice [22:52] carolina del norte [22:52] carrboro, specifically [22:53] ok, so if we've devolved into pony discussions i think we should call it a meeting [22:53] thanks for participating [22:53] +1 [22:53] thanks bac [22:53] thanks [22:53] i'll let you know if we have a time change [22:53] #endmeeting [22:53] Meeting finished at 16:53. === Ursinha is now known as Ursinha-bbl