=== mwhudson_ is now known as mwhudson === Ursinha is now known as Ursinha-afk === jtv changed the topic of #launchpad-reviews to: On call: jtv || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [06:21] thumper: "ICanHasLinkedBranch"…? All it needs is s/s/z/ === jtv changed the topic of #launchpad-reviews to: On call: jtv || reviewing: thumper || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [06:24] thumper, you there? === jtv changed the topic of #launchpad-reviews to: On call: jtv || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [07:20] jtv: kinda [07:20] thumper: nm it's reviewed now [07:22] thumper: bikeshed effect—I can't judge the merits of the branch without a lot more research (decadent I-don't-do-manual-labour grunt here) but I've got lots of little whiny pedantic points about what the code looks like. :) [07:22] is this for my branches? [07:23] * thumper reads mail [07:34] thumper: no, it was for your kite [09:34] gmb: O hai! [09:34] gmb: Mind looking at my MP from yesterday again? [09:35] StevenK, Is it RC? If not, I'll do it later on today as I've got a few tasks that need to be done this morning. [09:35] gmb: It isn't, that's cool [09:38] StevenK, Cool, thanks. === matsubara-afk is now known as matsubara === mrevell is now known as mrevell-lunch === Ursinha-afk is now known as Ursinha === mrevell-lunch is now known as mrevell === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: jtv, Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === jtv changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === deryck is now known as deryck[lunch] === matsubara is now known as matsubara-lunch [16:24] EdwinGrubbs, would you like to review https://code.edge.launchpad.net/~salgado/launchpad/request-to-base-template-adapter/+merge/31982 for me? === Ursinha is now known as Ursinha-lunch [16:25] salgado: it looks like mwhudson already reviewed it. do you need a ui review? [16:29] EdwinGrubbs, just code. I wanted somebody else to have a look as he suggested, but I could ask sinzui if you'd prefer [16:32] salgado: I can look at it, but will definitely have some questions about the intent. Is vostok for setting up onsite instances for Linaro? [16:32] EdwinGrubbs, yep, that's it [16:32] let's see if sinzui would like to take it... [16:32] sinzui, would you like to review that branch above? [16:40] back soon === salgado is now known as salgado-lunch [17:09] salgado-lunch: shouldn't there be a test for IMainTemplateFile() when the layer is not Vostok? [17:13] EdwinGrubbs, https://bugs.edge.launchpad.net/launchpad-registry/+bug/326384 [17:13] <_mup_> Bug #326384: Milestone dateexpected and release datereleased wrong type in db === Ursinha-lunch is now known as Ursinha-brb === matsubara-lunch is now known as matsubara [17:46] Edwin, i seek a review of https://code.edge.launchpad.net/~leonardr/launchpadlib/616055/+merge/32352 === noodles775 changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [leonardr, noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:17] Hi EdwinGrubbs, I've also got a critical LP branch ready, but won't be around. I'll check back later before going to bed though to fix any thing you find (and send it off for testing): [18:17] https://code.edge.launchpad.net/~michael.nelson/launchpad/616331-private-builds-in-builder-history/+merge/32355 [18:19] noodles775: I'll work on that. How soon do you need it? 2 hours? [18:19] EdwinGrubbs: thanks. 2 or 3 would be great, so I can have it tested for Julian in the morning. === salgado-lunch is now known as salgado === Ursinha-brb is now known as Ursinha [19:14] noodles775: review sent === EdwinGrubbs is now known as Edwin-lunch === Edwin-lunch is now known as EdwinGrubbs === matsubara is now known as matsubara-afk === salgado is now known as salgado-afk [22:42] flacoste: do you have a minute to evaluate an RC MP - basically whether I should land it on db-devel, or just test in and include it as part of the re-roll. There are comments from Julian in the irc log on the attached bug: https://code.edge.launchpad.net/~michael.nelson/launchpad/616331-private-builds-in-builder-history/+merge/32355 [22:43] (the branch name is misleading... it's just a query improvement for a timeout) [22:43] noodles775: we don't do re-roll anymore [22:43] noodles775: we'll cherry-pick after the release [22:43] flacoste: OK, so whether I should ec2 land it on db-devel, or do it as a cp... [22:44] OK. === _mup__ is now known as _mup_ === Ursinha is now known as Ursinha-bbl