[06:21] <jtv> thumper: "ICanHasLinkedBranch"…?  All it needs is s/s/z/
[06:24] <jtv> thumper, you there?
[07:20] <thumper> jtv: kinda
[07:20] <jtv> thumper: nm it's reviewed now
[07:22] <jtv> thumper: bikeshed effect—I can't judge the merits of the branch without a lot more research (decadent I-don't-do-manual-labour grunt here) but I've got lots of little whiny pedantic points about what the code looks like.  :)
[07:22] <thumper> is this for my branches?
[07:23]  * thumper reads mail
[07:34] <jtv> thumper: no, it was for your kite
[09:34] <StevenK> gmb: O hai!
[09:34] <StevenK> gmb: Mind looking at my MP from yesterday again?
[09:35] <gmb> StevenK, Is it RC? If not, I'll do it later on today as I've got a few tasks that need to be done this morning.
[09:35] <StevenK> gmb: It isn't, that's cool
[09:38] <gmb> StevenK, Cool, thanks.
[16:24] <salgado> EdwinGrubbs, would you like to review https://code.edge.launchpad.net/~salgado/launchpad/request-to-base-template-adapter/+merge/31982 for me?
[16:25] <EdwinGrubbs> salgado: it looks like mwhudson already reviewed it. do you need a ui review?
[16:29] <salgado> EdwinGrubbs, just code. I wanted somebody else to have a look as he suggested, but I could ask sinzui if you'd prefer
[16:32] <EdwinGrubbs> salgado: I can look at it, but will definitely have some questions about the intent. Is vostok for setting up onsite instances for Linaro?
[16:32] <salgado> EdwinGrubbs, yep, that's it
[16:32] <salgado> let's see if sinzui would like to take it...
[16:32] <salgado> sinzui, would you like to review that branch above?
[16:40] <salgado> back soon
[17:09] <EdwinGrubbs> salgado-lunch: shouldn't there be a test for IMainTemplateFile() when the layer is not Vostok?
[17:13] <sinzui> EdwinGrubbs, https://bugs.edge.launchpad.net/launchpad-registry/+bug/326384
[17:13] <_mup_> Bug #326384: Milestone dateexpected and release datereleased wrong type in db <tech-debt> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/326384>
[17:46] <leonardr> Edwin, i seek a review of https://code.edge.launchpad.net/~leonardr/launchpadlib/616055/+merge/32352
[18:17] <noodles775> Hi EdwinGrubbs, I've also got a critical LP branch ready, but won't be around. I'll check back later before going to bed though to fix any thing you find (and send it off for testing):
[18:17] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/616331-private-builds-in-builder-history/+merge/32355
[18:19] <EdwinGrubbs> noodles775: I'll work on that. How soon do you need it? 2 hours?
[18:19] <noodles775> EdwinGrubbs: thanks. 2 or 3 would be great, so I can have it tested for Julian in the morning.
[19:14] <EdwinGrubbs> noodles775: review sent
[22:42] <noodles775> flacoste: do you have a minute to evaluate an RC MP - basically whether I should land it on db-devel, or just test in and include it as part of the re-roll. There are comments from Julian in the irc log on the attached bug: https://code.edge.launchpad.net/~michael.nelson/launchpad/616331-private-builds-in-builder-history/+merge/32355
[22:43] <noodles775> (the branch name is misleading... it's just a query improvement for a timeout)
[22:43] <flacoste> noodles775: we don't do re-roll anymore
[22:43] <flacoste> noodles775: we'll cherry-pick after the release
[22:43] <noodles775> flacoste: OK, so whether I should ec2 land it on db-devel, or do it as a cp...
[22:44] <noodles775> OK.