=== mwhudson_ is now known as mwhudson [05:48] lifeless: So my branch had timeout as the timeout, and your branch has timeout as the goal time for the 99% calculations, and histogram_width as the timeout [05:49] yeah, my first branhc, as you said, was in poor shape [05:49] the incremental changes are twofold [05:49] firstly, there is an existing bug in the report: the stddev is being mangled by the clipping of the data [05:49] likewise the variange === Ursinha-bbl is now known as Ursinha [05:50] so I changed that, and having fixed that I then had the abilitity to do the histogram columns independently, and I figures that seeing the shape beyond the timeout would be useful [05:54] The logic was that if a page takes longer than the hard timeout, that is irrelevant. It doesn't render so ends up in the 'fail' column at the hard timeout, giving a nice 'kick' at the end. [05:55] I would have labelled the last column 'timeout' if the graphing tool let me. [05:56] I suspect the only correct answer though would be to report a timeout%, and have the stats calculated non-timeout pages. [05:58] stub: well, what I've done willso have a kick [05:58] and - we could do a kick at the exact timeout column if you wanted [05:58] but I wanted the stddev to be accurate, because that tells us the 99% figure [05:59] stub: perhaps you could give it a spin and we can see what it looks like ? [06:03] lifeless: I don't like that we are growing a separate list for capped request times. I think we want to create this on the fly using a generator, and use numpy.fromiter instead of numpy.asarray to construct the array. [06:04] stub: ok [06:04] stub: is that a memory overhead concern ? [06:04] We have nearly 500 of these things in ram containing over 10 million 32bit objects, so yeah [06:05] But I pulled out the spool-to-disk version, as it seemed to be better to hit swap than open 500 temporary files. That was implemented as I thought I was crashing devpad, but it was just hardware issues. [06:06] (monthly reports will get lots of requests, when devpad stays up long enough to actually generate one...) [06:07] I'll give it a run as is - memory shouldn't be an issue for a daily run. [06:09] I'm happy to change that for you [06:09] I considered doing it on the fly but it seemed slower ;P [06:19] It is slower, but that is a minor part of our runtime. Parsing the logs takes time. Generating the stats is pretty much instantaneous. [06:39] ok [06:39] so - lets see how it looks, and I'll look up fromiter [06:46] fromiter(iterable, numpy.float32, len(self.request_times)) - we know the length so can use the third parameter [06:47] and iterable is an adapter to call min ? [06:48] https://devpad.canonical.com/~stub/ppr/edge/latest-daily-timeout-candidates.html is done. lpnet still generating [06:48] lifeless: I imagine it is a generator that returns the time capped to the timeout [06:49] RIGHT [06:49] bah [06:49] Right [06:49] thats what I thought too [06:53] Bwaha... LibraryFileAlias:StreamOrRedirectLibraryFileAliasView is a mess without the cap ;) [06:53] But I guess that is the truth. [06:53] yup [06:54] do think these changes are ok then ? [06:56] I've pushed up a (hopefully working) fromiter version [07:04] That all looks good. I've kicked off another run with the new version [07:05] thanks === Ursinha is now known as Ursinha-zzz === henninge_ is now known as henninge === noodles775 changed the topic of #launchpad-reviews to: On call: noodles775 || reviewing: - || queue: [leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:56] noodles775: Could I add a branch to your queue? [10:56] jelmer: please do :) [10:57] noodles775: The MP is https://code.edge.launchpad.net/~jelmer/launchpad/613468-xb-ppa-db/+merge/32307 === jelmer changed the topic of #launchpad-reviews to: On call: noodles775 || reviewing: - || queue: [leonardr,jelmer] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [10:57] noodles775, thanks! [11:00] noodles775: O hai, can you re-re-review https://code.edge.launchpad.net/~stevenk/launchpad/switch-ifp-to-unittests/+merge/32073 ? [11:01] StevenK: indeed :) [11:33] StevenK: I'm not trying to make your life hard, and hate dragging this review on, but I don't understand why test_create_builds does so much more than what the name implies... do you have time to mumble and discuss it briefly? === noodles775 changed the topic of #launchpad-reviews to: On call: noodles775 || reviewing: jelmer || queue: [leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:44] noodles775: Yes, doing so in a sec [11:45] noodles775: But it doesn't? It asserts the *source* for 0.1-2 exists, and then creates a build for it? [12:15] noodles775: The diff does not appear to have been updated yet, but the MP is ready for your re-re-re-review. [12:15] Thanks StevenK [12:38] noodles775: No news is good news, or I'm in the queue? [12:42] StevenK: looking now (had to merge as the MP hadn't updated) [12:42] Yes, I'm not sure what is going on there [12:50] noodles775: Thanks for the review! [12:51] np [12:57] StevenK: looks good. I've just highlighted what seem to be a few inconsistencies in the comments, but otherwise r=me: http://pastebin.ubuntu.com/476903/ === salgado-afk is now known as salgado [13:07] jelmer: Hm, why are the extra fields JSON? [13:07] They're known to be string pairs. [13:08] It seems like an extra table would do fine, leave the table smaller, and make it possible to query them in future. [13:08] wgrant: consistency with other fields in the database, where we also use JSON. [13:08] Are there any, apart from on Job? [13:08] noodles775: Planning to commit http://pastebin.ubuntu.com/476907/ [13:09] wgrant: No, just job actually. [13:09] jelmer: And it's like that so that custom job types can store different data there. [13:09] I don't see why JSON should be used here, and not a separate table. [13:17] wgrant: simplicity; I don't see why we would need to query that field. if we would go the way of a separate table we might want to use it for some of the other control fields as well [13:17] which might not be a bad idea, just out of scope for me at the moment. [13:31] gmb: O hai! Given noodles775's has Approved the MP at https://code.edge.launchpad.net/~stevenk/launchpad/switch-ifp-to-unittests/+merge/32073; can haz moar review? [13:39] StevenK, If you stop asking in lolspeak, yes. ;) [13:40] In fact, I think noodles775's review is far more comprehensive than mine (hurrah for context) [13:40] So I'll just mark it approved. [13:40] gmb: Okay, cool === matsubara-afk is now known as matsubara === Ursinha-zzz is now known as Ursinha === StevenK changed the topic of #launchpad-reviews to: On call: noodles775 || reviewing: jelmer || queue: [leonardr,StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [15:19] jml: hi, would you be willing to do an incremental review of https://code.edge.launchpad.net/~james-w/launchpad/no-more-sampledata-2/+merge/31891 ? [15:19] james_w, yes. I'll look at it shortly [15:19] thanks === deryck is now known as deryck[lunch] === Ursinha is now known as Ursinha-lunch [16:41] can i get someone to review my really simple launchpadlib branch? i've been in the queue since yesterday [16:41] hey salgado, can you do a shipit review for me? [16:42] https://code.edge.launchpad.net/~leonardr/launchpadlib/616055/+merge/32352 [16:42] bac, sure! [16:42] salgado: https://code.edge.launchpad.net/~bac/shipit/bug-616059/+merge/32457 [16:42] bac, not allowed [16:43] salgado: try now [16:43] bac, while you subscribe me to your branch, subscribe launchpad-pqm as well, or else you won't be able to land it later [16:44] salgado: thanks for the tip! [16:44] bac, while you wait, will you review my branch please? [16:44] leonardr: sure [16:44] * bac looks [16:45] thanks [16:47] bac, did you consider doing that for canonical.* instead of canonical.launchpad.*? [16:48] salgado: yeah, sort of. i thought lp was sufficient. you think i chose wrong? [16:49] bac, I'd have done for canonical.* but lp.* and canonical.launchpad.* is certainly where we do most of our changes/refactorings, so it's no big deal [16:57] salgado: yeah, you would've...but you're smarter than me! === deryck[lunch] is now known as deryck === matsubara is now known as matsubara-lunch [17:02] bac, If that was the case I'd have done this change long ago. ;) === benji is now known as benji-lunch === benji-lunch is now known as benji [17:02] salgado: yeah, if you weren't such a slacker === benji is now known as benji-lunch [17:10] that is certainly the case [17:11] leonardr: r=bac. [17:11] bac, did you get my review? you might want to get someone from ISD to have a look as well, as they own shipit now [17:13] salgado: i see it now. did you mean to have it just be a comment? [17:13] no, just approved using the web UI, but it'd be good to at least let them know about the change before it lands [17:14] salgado: i'll talk to achuni or someone else [17:14] salgado: thanks for catching those issues [17:14] i renamed to sd_setUp b/c there is another setUp being imported in that file [17:15] np. thank you for doing this change [17:15] fair enough [17:15] sd is cryptic for 'systemdocs' === salgado is now known as salgado-lunch [17:44] benji-lunch, it looks like we're missing a review for lazr.restfulclient/total_size_link === Ursinha-lunch is now known as Ursinha === matsubara-lunch is now known as matsubara === benji-lunch is now known as benji [18:00] noodles775, the branch i'd like reviewed is https://code.edge.launchpad.net/~benji/lazr.restfulclient/total_size_link/+merge/32472 [18:01] it's benji's branch but most of the code is mine [18:01] just fyi, when you get to me [18:07] james_w, done === salgado-lunch is now known as salgado [18:25] thanks jml [18:26] np [18:42] noodles775, i'd also like to add this to the queue: https://code.edge.launchpad.net/~leonardr/launchpad/new-lazr.restful-and-friends/+merge/32474 [18:48] leonardr: I think Michael has signed off for the day. [18:48] well, damn [18:48] bac, are you in the mood to do more reviews? [18:49] leonardr: i can do one. [18:49] rockstar should be around later, or is he on leave? [18:49] * bac has a full day of reviews tomorrow [18:49] Oh snap, forgot it was Thursday. === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: leonardr || queue: [StevenK] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:50] bac: ok, rockstar will take care of these === leonardr changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: leonardr || queue: [StevenK, leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:51] thanks leonardr and rockstar [18:59] leonardr, apparently there are two review to do for you. Where's the other one? [18:59] (I already did new-lazr.restful-and-friends) [18:59] rockstar: ok, the other one is https://code.edge.launchpad.net/~benji/lazr.restfulclient/total_size_link/+merge/32472 === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: StevenK || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [19:05] rockstar may i add a small branch to your queue? [19:05] bac, sure. [19:07] bac, ftr, I'm going to clear out all the +activereviews today, so you won't have a huge queue tomorrow. [19:12] rockstar: that would be swell. do leave me some, though! [19:30] leonardr: what is the status of this branch: https://code.edge.launchpad.net/~leonardr/launchpad/grant-permissions-oauth/+merge/29425 [19:30] bac: i got sidetracked by an emergency project before i could land it, and i don't want to land it on its own because it's part of another large project [19:31] so, the status is "wait and see" [19:31] leonardr: ok === bac changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: StevenK || queue: [bac] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === bryceh changed the topic of #launchpad-reviews to: On call: rockstar || reviewing: StevenK || queue: [bac bryce] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [21:33] thanks for the review rockstar [22:25] rockstar: I've fixed the conflicts in my branch; any chance I could add it back into your queue? [22:26] jelmer, if it's in +activereviews, I'll get to it today. [22:26] * rockstar is firefighting currently. [22:26] rockstar: great, thanks [22:26] rockstar: oh, ok [22:43] jelmer: are you going to propose the bzr-git update branch? [22:44] thumper: yes, it should fix quite a few of the broken imports [22:44] cool [22:44] there is someone trying the chicken import every few days [22:45] thumper: yeah, he pinged me on IRC today about it. [22:45] thumper: How hard it is to get the new bzr-git deployed without waiting for the next lp release? [22:45] jelmer: very trivial [22:45] jelmer: we land it, test it on staging [22:46] jelmer: then CP it to the production branch [22:46] jelmer: and get it rolled out [22:46] so lag time is 3 x ec2 test run + staging rollout lag + production rollout lag [22:47] add in test time, and getting approval, both of which should be pretty short [22:47] ok === matsubara_ is now known as matsubara-afk [23:20] thumper: https://code.edge.launchpad.net/~jelmer/launchpad/update-bzr-git/+merge/32527 [23:35] jelmer: done [23:36] thumper: bug 497428 appears to be fixed, scilab's import is working. Can I mark it fixreleased in launchpad-code? [23:36] <_mup_> Bug #497428: Import on a large git repository is failing [23:36] jelmer: yep [23:47] thumper: perhaps we should increase the number of revisions imported per step with bzr-svn [23:47] jelmer: I'm up for that [23:47] jelmer: it is just a config change I think [23:47] thumper: the KDE branches appear to be working now, but they're spending 15 minutes trying to figure out what 1k revisions to fetch and then 2 minutes doing the actual work. [23:48] jelmer: 10k seem reasonable? [23:48] thumper: Yeah, definitely. [23:49] thumper: Could the git batch size also be increased perhaps? [23:49] jelmer: yep [23:49] I think it's at 10k now but we should be able to handle 30k at least [23:49] jelmer: sure, sounds reasonable [23:57] i still wonder if it should be time-limited not rev-count limited [23:59] mwhudson: time and memory limited in that case, but yeah, that sounds reasonable.