| vish | and471: hey , could you upload your patches to lp and subscribe the sponsors.. | 09:17 |
|---|---|---|
| vish | ? | 09:17 |
| and471 | vish, hey, which patches? | 09:18 |
| vish | and471: the patches you forwarded to debian.. | 09:18 |
| vish | or for those bugs.. | 09:18 |
| vish | and471: debdiffs rather, sponsors prefer debdiffs.. | 09:19 |
| and471 | vish, sure, I shall try to complete them today, I have just got back form holiday and I am working through a backlog :) | 09:20 |
| and471 | *from | 09:20 |
| vish | and471: doh! no wonder i couldnt find you on irc :) | 09:20 |
| vish | and471: was wondering how you kept changing the bug status but i always seemed to never catch you here. :) | 09:21 |
| vish | and471: sure not immediately , but we are nearing UIF, and translations need to be in by then.. :) | 09:22 |
| and471 | vish, hehe, yeah I did some bug stuff while I had some free time :) | 09:22 |
| and471 | vish, yup I am aware :) the shotwell guys are also bugging me as they watn to do a new release :) | 09:22 |
| and471 | *want | 09:22 |
| vish | and471: heh, that was gonna be my follow up, "what happened to shotwell icons" ;) | 09:23 |
| and471 | vish, I won't be able to finish the whole bug I think, but I have say 1/2 of it :) | 09:25 |
| vish | and471: redoing the icons? or not hardcoding them is 1/2? | 09:32 |
| and471 | vish, 1/2 redoing, 1/4 hardcoding | 09:33 |
| vish | and471: oh right , re-doing them is not easy.. do you have a list that need to be redone? make i can do a few as well? | 09:33 |
| vish | s/make/maybe | 09:34 |
| and471 | vish, sure, I shall publish them on the launchpad bug report when I get round to it :) | 09:34 |
| vish | and471: cool! thanks.. | 09:34 |
| and471 | vish, which icon is the spinner in Humanity? | 10:22 |
| vish | and471: which spinner? | 10:23 |
| and471 | vish, for example the one you get in nautilus when you open /usr/bin | 10:23 |
| vish | and471: are you using n-e? | 10:25 |
| and471 | vish, yup | 10:25 |
| vish | and471: yeah, that doesnt appear in nautilus, it was removed iirc :) | 10:25 |
| and471 | vish, ah, let me think of another example.. | 10:26 |
| vish | and471: there is a spinner in gnome icons, which might be from where the spinner is being pulled | 10:26 |
| and471 | vish, I'll show you a screenshot | 10:26 |
| and471 | vish, the image in the right tab in http://imgur.com/On2Uv.png | 10:27 |
| vish | and471: oh that! | 10:28 |
| vish | and471: i cant seem to find it.. not sure where that one if from :s | 10:32 |
| and471 | vish, hehe me neither :( | 10:42 |
| and471 | vish, don't worry it isn't vital | 10:43 |
| black_tears | hello | 12:20 |
| kiwinote | devildante: hi! | 16:37 |
| devildante | hi kiwinote :) | 16:37 |
| kiwinote | devildante: I adapted the appdetailsview to use package info lines rather than package info tables | 16:38 |
| kiwinote | devildante: you can use this for the total size info | 16:38 |
| devildante | kiwinote: thanks :) | 16:38 |
| kiwinote | devildante: code is in the getting-the-small-things-right branch | 16:38 |
| devildante | kiwinote: okay :) can I merge it? | 16:39 |
| kiwinote | devildante: sure | 16:39 |
| devildante | kiwinote: thanks :) | 16:40 |
| devildante | kiwinote: it worked, thanks again :) | 17:01 |
| kiwinote | devildante: great to hear! | 17:01 |
| kiwinote | devildante: I'll look at the navigation stuff tomorrow | 17:01 |
| devildante | kiwinote: thanks :) | 17:01 |
| devildante | kiwinote: I'm here all day, so if you want to talk, I'm available ;) | 17:05 |
| kiwinote | devildante: are you free-ish this week? | 17:05 |
| devildante | kiwinote: I'm a 16-year-old student who doesn't have school in summer, of course I'm free :p | 17:06 |
| kiwinote | devildante: ah, ok, fun :p | 17:06 |
| kiwinote | devildante: there are still a few things that need doing about that addons branch | 17:07 |
| devildante | kiwinote: order and I shall code :P | 17:07 |
| kiwinote | devildante: mostly just tidying up things and so | 17:07 |
| devildante | kiwinote: is there something interface-wise? | 17:07 |
| kiwinote | devildante: I think if you work on that say monday and tuesday, then by wednesday thursday it should be truly rocking ;) | 17:07 |
| devildante | kiwinote: yeah :) | 17:08 |
| kiwinote | devildante: yeah, a few things like the padding around the install bar | 17:08 |
| devildante | kiwinote: you mean the "apply changes" bar? | 17:08 |
| kiwinote | devildante: but also things that installing a normal package fails.. | 17:08 |
| kiwinote | devildante: yep | 17:08 |
| devildante | kiwinote: that one I done it right now :) | 17:09 |
| kiwinote | devildante: it's great work, it just needs a bit more polish and testing before it is ready for trunk | 17:09 |
| kiwinote | devildante: more so because feature freeze has passed | 17:09 |
| devildante | kiwinote: and about the pkg not installing, it's been a while I didn't test that, so I'll investigate :) | 17:09 |
| devildante | kiwinote: okay :) | 17:10 |
| kiwinote | devildante: don't worry too much about it all though, at the beginning of the summer I was just getting stuck into s-c code myself and facing these issues as well | 17:10 |
| devildante | kiwinote: okay :) | 17:10 |
| kiwinote | devildante: you already have the advantage that you are a few years younger when you start ;) | 17:11 |
| devildante | kiwinote: yeah :) | 17:11 |
| devildante | kiwinote: do you think there will be a problem with the ffe? | 17:18 |
| kiwinote | devildante: I think if we get it into really good shape this week, then there is a fair chance that we may get it | 17:21 |
| devildante | kiwinote: thank you for helping me :) | 17:22 |
| kiwinote | devildante: having said that, I aren't really too experienced with ffe's. I have seen more significant changes come later in the cycle though | 17:22 |
| kiwinote | devildante: no probs, it's great to see people actively working on s-c | 17:23 |
| devildante | kiwinote: argh, spotted a bug, and I don't know how to fix it | 17:26 |
| kiwinote | devildante: you can paste the error in the pastebin and post a link here | 17:26 |
| kiwinote | devildante: or if it isn't a crash, you can describe the bug here ;) | 17:26 |
| devildante | kiwinote: when removing an add-on, it is removed, but the "in progress" view doesn't show | 17:27 |
| kiwinote | devildante: yeah, i think that has to do with how you call the transaction | 17:27 |
| devildante | output: http://paste.ubuntu.com/478434/ | 17:28 |
| kiwinote | devildante: when i looked at the code I wondered why you wouldn't call install_multiple or remove_multiple rather than feeding the addons as a side thing of a real pkg | 17:29 |
| and471 | nessita, hey, how is the login dialog going? | 17:29 |
| devildante | kiwinote: it's just because remove_multiple wasn't there when I began to implement | 17:29 |
| kiwinote | devildante: but i haven't decided what the best way is, so don't change that behaviour until I've had time to think ;) | 17:30 |
| devildante | kiwinote: okay :) | 17:30 |
| nessita | and471: hey, you can try it on on latest maverick | 17:30 |
| kiwinote | devildante: ah, yes, that output looks familar. It's an aptdaemon bug most likely though | 17:30 |
| nessita | and471: you'd have to use the dbus service "by hand", but is already in main | 17:30 |
| kiwinote | devildante: don't think I'm comfortable enough with that code to fix it though | 17:31 |
| devildante | kiwinote: this is the exact line causing this: trans = aptdaemon.client.get_transaction(tid, | 17:31 |
| devildante | error_handler=lambda x: True) | 17:31 |
| devildante | kiwinote: pendingview.py in _on_transaction_changed | 17:31 |
| devildante | kiwinote: install_multiple and remove_multiple could fix this, you think? | 17:32 |
| kiwinote | devildante: i think the pending view stuff is a consequence of aptdaemon stuff though | 17:33 |
| kiwinote | devildante: it should bypass it, but the bug will need to be fixed at some stage anyway | 17:33 |
| devildante | so I just replace it with install_multiple/remove_multiple (in aptd.py) | 17:34 |
| devildante | ? | 17:34 |
| kiwinote | devildante: using install/remove multiple will mean that it sends each addon as a separate transaction, hence showing each in a separate tile in the pending view | 17:34 |
| devildante | kiwinote: I got some idea, lemme test | 17:34 |
| kiwinote | devildante: from memory it would need slightly more changes than that | 17:35 |
| kiwinote | devildante: the biggest question is when we select a pkg to install and select some addons to install, do we want say 5 entries in the pending view, or do we want one entry? | 17:35 |
| devildante | kiwinote: well my idea won't work :p | 17:35 |
| kiwinote | hm ;) | 17:36 |
| and471 | nessita, cool, might try it later :) | 17:36 |
| devildante | from the spec, it seems we want each add-on as a separate task! | 17:36 |
| devildante | but only when the app is installed | 17:37 |
| kiwinote | devildante: let me have a quick look | 17:37 |
| kiwinote | devildante: hm, and when the main app isn't installed we want it one transaction?? | 17:37 |
| devildante | kiwinote: yes | 17:37 |
| devildante | kiwinote: now it should be easy :p | 17:38 |
| kiwinote | hm, that makes it a bit messy in the code though, as we need to call install multiple if the pkg is not installed and we need to do what you're doing now for non installed apps | 17:39 |
| kiwinote | devildante: the nicest and cleanest solution would be to change your current code to use install/remove multiple in all cases | 17:40 |
| devildante | the "Apply changes" button won't show if the app isn't installed, though | 17:40 |
| devildante | kiwinote: it seems so | 17:40 |
| kiwinote | devildante: i think i need to think about it a bit, and we need to check with mpt before you should start changing the behaviour | 17:41 |
| kiwinote | devildante: so that's something for tomorrow ;) | 17:41 |
| devildante | kiwinote: okay, I'll do some tests though :p | 17:42 |
| kiwinote | devildante: nice | 17:42 |
| nessita | and471: let me know! :-) | 17:42 |
| kiwinote | devildante: mvo has recently added quite a few automated tests that check for regressions | 17:42 |
| devildante | kiwinote: oh yeah! | 17:43 |
| kiwinote | devildante: it may be interesting to look at what he has done and add some tests related to addons | 17:43 |
| devildante | kiwinote: though I don't know anything about tests :p | 17:43 |
| kiwinote | devildante: there are both backend tests and gui tests | 17:43 |
| kiwinote | devildante: heh, nor did I, but looking at what mvo has done you should be able to copy and modify some stuff ;) | 17:44 |
| devildante | kiwinote: okay :) | 17:44 |
| kiwinote | devildante: having tests may give bonus points for the ffe, so if you have heaps of spare time, then it may be a good thing to spend some time looking at ;) | 17:45 |
| devildante | kiwinote: all right :) | 17:45 |
| kiwinote | devildante: the most important part is making sure you cover all cases | 17:46 |
| kiwinote | devildante: anywayz, I'm going to have some dinner now | 17:46 |
| devildante | kiwinote: bye for now :) | 17:46 |
| kiwinote | devildante: not sure if I'll be back online this evening, we'll see ;) | 17:47 |
| devildante | kiwinote: np, take your time :) | 17:47 |
| kiwinote | devildante: enjoy your coding ;) cu | 17:48 |
| devildante | dammit kiwinote, I can't enjoy Coding :P | 17:48 |
| devildante | hi vish :) | 18:08 |
| vish | devildante: o/ | 18:09 |
| === JanC_ is now known as JanC | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === almaisan-away is now known as almaisan | ||
| === almaisan is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
