=== Ursinha-afk is now known as Ursinha
=== lifeless changed the topic of #launchpad-reviews to:  call:  - || reviewing: -  || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/milestones/+merge/32855] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== jelmer is now known as Guest99497
=== Guest99497 is now known as jelmer
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
[18:26] <jcsackett> anyone around to give a quick review on some changes since a branch was approved?
[18:26] <jcsackett> had to throw in a bit when ec2 found some tests i missed.
[18:27] <jcsackett> mp is here: https://code.edge.launchpad.net/~jcsackett/launchpad/plus-participation-additional-fixes/+merge/32820
[18:27] <jcsackett> diff from changes is : https://pastebin.canonical.com/36129/
[18:34] <jelmer> jcsackett: hi
[18:34] <jcsackett> jelmer: hi.
[18:44] <jelmer> jcsackett: what was the test failure exactly? You're including team memberships for which the user was still waiting for approval or memberships that had expired?
[18:44] <jcsackett> precisely: teams that shouldn't be showing up in participation (b/c they were pending) were showing up.
[18:45] <jcsackett> also: if you were going +participation for a team, you got an entry for the team itself.
[18:45] <jcsackett> which is sort of silly. :-P
[18:45] <jelmer> heh
[18:46] <jelmer> jcsackett: Are you going to do more work in this area? It seems like it would be nice to have a list of memberships statusses that mean the user should be considered a valid member of the team.
[18:47] <jelmer> jcsackett: Other than that, r=me
[18:48] <jcsackett> jelmer: you mean perhaps define "valid_status = (list of statuses); filter on valid_statuses" ?
[18:48] <jelmer> jcsackett: yeah, as there seems to be another place in the same file where you use that same condition.
[18:48] <jelmer> Anyway, that's just a thought. Not required for landing this change imo.
[18:49] <jcsackett> jelmer: it's a good thought, thanks. :-)
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha