[09:09] <klattimer> morning seb128
[09:09] <klattimer> do you have any new bugs for me?
[09:11] <seb128> hey klattimer
[09:12]  * klattimer is just starting on the rhythmbox bug
[09:12] <seb128> sorry I didn't reply to your email yesterday, I started trying to get some bugs but it was late and stopped
[09:12] <seb128> I think you can close this one since we dropped the indicator change
[09:12] <klattimer> heh, no worries dude
[09:12] <seb128> now the sound menu is used
[09:12] <klattimer> yeah, but it isn't about the indicator issue
[09:12] <klattimer> it's about the playing/not playing issue now
[09:12] <klattimer> so when it's not playing, rhythmbox should exit
[09:12] <seb128> oh, I though you were speaking about the ctrl-W one
[09:13] <klattimer> I can fix that I believe with a minimum change
[09:13] <klattimer> seb128: yeah I am, but if you look at mpt's comment #8
[09:13] <klattimer> it's no longer about the ctrl-w thing, as that bug is actually fixed
[09:13] <klattimer> the issue is with the behaviour of rhythmbox after the shortcut key is pressed
[09:13] <seb128> ok, makes sense
[09:14] <klattimer> The bug should have been renamed tbh
[09:14] <seb128> can you do that?
[09:14] <seb128> klattimer, while you are on rhythmbox, bug #618944
[09:15] <seb128> klattimer, I've assigned it to you
[09:15] <seb128> not sure if the bug is in rhythmbox or in the indicator stack
[09:15] <seb128> it seems to crash this way every time you close it
[09:16] <klattimer> seb128: is it reproducible? this might also be the cause of or a duplicate of https://bugs.launchpad.net/indicator-application/+bug/606052
[09:16] <seb128> klattimer, it happens every time I close rhythmbox there
[09:17] <seb128> can you try if you have the issue as well?
[09:18] <klattimer> i will once my box stops going insane :/
[09:19] <klattimer> grr looks like I've got a weird memory leak in gsd
[09:19] <klattimer> probably my fault :/
[09:19] <klattimer> shit
[09:20] <klattimer> 85% cpu and 40% memory
[09:21] <seb128> klattimer, oh, I noticed g-s-d tends to crash when removing the indicator applet
[09:21] <seb128> I guess if you could investigate the leak and that you have enough for today
[09:21] <klattimer> ok, I'll try and resolve these two issues before i move on to rhythmbox
[09:23] <klattimer> seb128: know of a way of getting print messages out of gsd
[09:23] <klattimer> I'm still coding it blind
[09:24] <seb128> gnome-settings-daemon --no-daemon --debug
[09:24] <seb128> stop the running instance before though
[09:25] <klattimer> k
[09:25] <klattimer> cheers
[09:26] <seb128> klattimer, bug #624477 could be due to your changes as well I'm not sure, it lacks details to be worked right now I think
[09:26] <klattimer> seb128: yeah I think that's my fault
[09:28] <klattimer> pretty sure I know the cause of it too
[09:28] <seb128> great ;-)
[09:31] <klattimer> xkl_engine_save_state triggers a state-changed signal, which then calls a function which xkl_engine_save_state's again, ad infinitum
[09:31] <klattimer> it's a relatively easy fix too
[09:31] <klattimer> and may also prevent the memory leak
[09:32] <klattimer> my biggest worry is that I might be triggering a leak in libgnomexkb
[09:57] <klattimer> hey seb128 you're unassigning my bugs?
[10:00] <seb128> klattimer, sorry, I was reviewing your assigned buglist and I figured you would probably not work on those now since we are after freeze and you have other things to keep you busy until the end of the week
[10:01] <klattimer> ok cool
[10:01] <seb128> klattimer, you still want to work on those?
[10:01] <klattimer> gajim was on my list after rhythmbox
[10:01] <seb128> oh ok
[10:01] <klattimer> and the keyboard layout sometimes changes is an interesting one I'd like to keep track of
[10:01] <seb128> I figured it would be better to do hplip since it's the default installation
[10:01] <seb128> where gajim is just yet another im client
[10:02] <klattimer> seb128: IIRC we're waiting on something in QT before I can do that
[10:02] <seb128> what about apport?
[10:02] <klattimer> yeah, I'll do that one
[10:02] <seb128> ok, excellent
[10:02] <klattimer> that's kinda important if we want people to help us track bugs
[10:02] <klattimer> because AFAIK we're removing the notification area soon
[10:03] <seb128> next cycle
[10:03] <klattimer> oh, right
[10:03] <klattimer> ok
[10:03] <seb128> we still have nm-applet there for this cycle at least so we can't drop it
[10:03] <klattimer> https://bugs.launchpad.net/bugs/627838 < pretty big usability fail
[10:03] <seb128> yes :-(
[10:04] <klattimer> from the specs I think it says we want to remove the right click menu from all applets in the end
[10:04] <klattimer> is that correct?
[10:04] <seb128> klattimer, apport is ui frozen though for maverick now, so if you want to do gajim maybe just do it
[10:04] <klattimer> k
[10:04] <seb128> I doubt we will do a lot on gnome-panel applets now
[10:05] <seb128> in the next cycle we will likely go for the new world
[10:05] <seb128> neither unity nor gnome-shell use applets
[10:05] <seb128> so that's an issue that will go away by itself
[10:22] <klattimer> seb128: https://bugs.launchpad.net/ayatana-ubuntu/+bug/599844
[10:23] <klattimer> new patch for fixing the cpu/mem issue
[10:23] <seb128> ok
[10:23] <seb128> it combines the previous change and the fix then?
[10:24] <klattimer> yeah
[10:24] <seb128> klattimer, hum, you added the wrong change
[10:24] <klattimer> ?
[10:25] <seb128> klattimer, the content doesn't seems to be g-s-d code
[10:25] <klattimer> oops :/ sorry
[10:25] <seb128> no worry ;-)
[10:25] <klattimer> one double click off by a few pixels
[10:26] <klattimer> the right one has been uploaded now
[10:26] <seb128> thanks
[10:26] <seb128> I will test that locally and get it in after the beta freeze
[10:26] <klattimer> excellent
[13:10] <klattimer> davidbarth: do you want me to draw these icons soon? or do you want me to concentrate on proper bugs?
[13:12] <davidbarth> klattimer: hi karl
[13:12] <davidbarth> klattimer: i just wanted to record that this icon story has been going for a while, but now it feels really late to me
[13:13] <davidbarth> klattimer: so to answer your question, yes, i'd rather have you concentrate on proper bugs
[13:13] <davidbarth> klattimer: that's what this part of the development cycle is for now ;)
[13:13] <klattimer> davidbarth: there are TWO icon stories
[13:13] <klattimer> the ibus one, which is the old one
[13:13] <klattimer> and the new g-s-d one
[13:15] <davidbarth> klattimer: oh, and the m17 icons are ibus?
[13:15] <klattimer> yep
[13:15] <davidbarth> ugh, i'll never get used to it
[13:15] <klattimer> heh
[13:15] <davidbarth> anyway, both are late
[13:16] <klattimer> for ibus, there's probably another 50 or so icons which aren't in m17n
[13:16] <klattimer> but m17n covers the majority of the icons which would be used
[13:16] <klattimer> davidbarth: I only just produced the patch to add flag support as a result of some community members kicking up a fuss about not having them anymore
[13:17] <klattimer> the g-s-d patch would need a little reworking to make it even better but as for now, the people who want flags, can have flags
[13:18] <davidbarth> klattimer: i don't think we'll want to land that patch; it's fine that it's available, but what we really want is the letter code solution mpt described
[13:18] <klattimer> davidbarth: the patch also fixes a CPU and memory bug now
[13:18] <klattimer> so it needs to be landed
[13:19] <klattimer> the show flags is not the default however
[13:19] <klattimer> as it's set in a hidden gconf key
[13:19] <davidbarth> i'd rather not had that key if we know we're not going to support it in the next version
[13:20] <klattimer> when we want to have the letter code/box solution mpt described all we need to do is slightly modify the patch and set the default key to on
[13:20] <davidbarth> as soon as you add a key, it means people will use it and be annoyed when it gets removed
[13:20] <klattimer> davidbarth: the key has existed for some time
[13:20] <klattimer> it's not something I've added
[13:20] <davidbarth> ah ok
[13:20] <klattimer> but having it, gives us a clear route to the solution we want
[13:21] <davidbarth> how?
[13:21] <davidbarth> because if brings back some dynamic icon code path?
[13:21] <klattimer> well, we have a way of displaying themed icons in the indicator right now
[13:21] <davidbarth> k
[13:22] <klattimer> davidbarth: also, I have a feeling that someone has already created symbolic icons which match mpt's spec
[13:23] <davidbarth> klattimer: technically, the new patch should be added to a new bug that explains the CPU and mem issue you fixed
[13:23] <klattimer> as per the icon in this screenshot
[13:23] <klattimer> http://img243.imageshack.us/img243/7358/screenshotnw.png
[13:23] <davidbarth> because of the freeze process now
[13:23] <davidbarth> sweet
[13:24] <klattimer> davidbarth: there is another bug for the cpu/mem issue
[13:25] <klattimer> the patch was added to the gsd bug because it seems more appropriate a place to put it
[13:25] <klattimer> as it doesn't just deal with the bug itself
[13:25] <klattimer> davidbarth: here's the cpu/mem bug https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/624477
[13:27] <davidbarth> seb128: ok, to keep the patch on the old bug? or would you prefer it to move to the cpu/mem issue one?
[13:27] <seb128> davidbarth, klattimer: let g-s-d things as they are bug wise, no need of extra comments on bugs
[13:27] <seb128> we will just get the updated patch in after beta, it adds support for something that was in lucid and not ported yet and which is not on by default
[13:28] <seb128> there is no need to bother asking exception for it, we will just update as a bug fix after beta rather
[14:46] <davidbarth> klattimer: btw, i'm reviewing your bugs quickly
[14:46] <davidbarth> klattimer: cleaing up the n-osd assignments in particular
[14:52] <klattimer> davidbarth: I think I only took on two notify osd bugs
[14:52] <klattimer> the ones I thought could be fixed fastest
[14:52] <klattimer> app-indicators took priority so I only managed a fix for one
[15:02] <davidbarth> ok
[15:34] <klattimer> seb128: I'm checking out this rhythmbox bug
[15:34] <klattimer> and I can confirm it happens
[15:34] <seb128> that's a start ;-)
[15:35] <klattimer> the only thing is, I can't find a patch which enables the sound menu indicator in rhythmbox
[15:35] <klattimer> any hints as to where the code lies would be most appreciated
[15:35] <seb128> 16_ubuntu_ayatana_register.patch
[15:35] <seb128> it's very simplist
[15:36] <klattimer> seb128: surely that can't be ALL of the code?
[15:36] <klattimer> i was looking at that exact file
[15:36] <seb128> it is, we don't have an appindicator
[15:36] <seb128> it's just doing registration
[15:36] <klattimer> yeah, I thought there'd be a plugin or something
[15:36] <seb128> then doing mpris over dbus
[15:36] <seb128> with indicator-sound
[15:37] <klattimer> oh, right now it's starting to click
[15:37] <klattimer> hmm, so this is a difficult bug to fix then, as it seems impossible that the ayatana patch could cause that crash to happen
[15:37] <seb128> that's why I assigned that to libindicate and not rhythmbox
[15:37] <seb128> tedg might have an idea there?
[15:38] <klattimer> oh, I thought it was assigned to rhythmbox
[15:38] <seb128> klattimer, if you think it's rather a ted bug feel free to bounce him back to him and focus on things you can do easily
[15:38] <seb128> -him
[15:38] <seb128> there is no point for you to dive into code you don't know for half a day to fix that
[15:38] <klattimer> seb128: in that case, it is a duplicate
[15:39] <seb128> of what bug?
[15:51] <klattimer> hang on I marked them the other way round
[15:52] <klattimer> seb128: bug 606052
[15:52] <klattimer> I checked the stack trace, they have slightly different causes, but they're the same bug
[15:53] <seb128> ok, nice catch
[15:53] <seb128> it's rather a bug for ted I guess, right?
[15:53] <klattimer> looks like it
[15:53] <klattimer> I can still work on it if tedg is busy?
[15:56] <seb128> tedg, ^
[15:56] <seb128> klattimer, do you know the concerned codebase or not?
[15:57] <seb128> klattimer, I think it would make sense to focus on things you know so you can some extra ones done rather than spending a day learning some new part of the stack to debug it
[15:57] <seb128> tedg, do you think you will have time to debug that one?
[15:57] <klattimer> seb128: have I known any codebase I've encountered so far? no... but it doesn't bother me much
[15:57] <klattimer> :)
[15:58] <seb128> right, it's just that efficiency might be better working on things you know
[15:59] <seb128> klattimer, maybe start on another until ted replies?
[15:59] <seb128> you can still investigate that one tomorrow if the has no time for it
[16:03] <klattimer> sure
[16:15] <kklimonda> hum, why there is no indicator-sound-dbgsym package?
[16:33] <klattimer> seb128: I added a slightly updated patch to the g-s-d bug
[16:33] <klattimer> this time to either/or the icon/label
[16:33] <seb128> ok
[16:34] <klattimer> I think this way is best, as it means one gconf change and a new set of icons added to the theme in order to display the [ GB ] or [ RU ] as mpt specified
[16:34] <klattimer> ... the question is, can something like that be done mid cycle if the code is identical, or do you prefer that it's left until the next cycle?
[16:37] <kklimonda> tedg: ping
[16:38] <seb128> klattimer, I doubt we will change that in stable update
[16:38] <seb128> but we will get it next cycle
[16:38] <klattimer> shame
[16:38] <klattimer> it would be nice in LTS
[16:39] <seb128> well the lts was 6 months ago
[16:39] <seb128> well not exactly yet, but last cycle
[16:39] <seb128> we don't have libappindicator supporting icons there etc
[16:42] <kklimonda> seb128: what is important at this stage? crash fixing or functionality fixing?
[16:43] <tedg> re
[16:43] <seb128> kklimonda, whatever is an issuer for the userexperience fixing
[16:43] <seb128> crashes being annoying issues and high on the list usually
[16:43] <seb128> wb tedg
[16:43] <seb128> ok, I'm away for an hour
[16:43] <seb128> bbl
[16:43] <kklimonda> seb128: tedg: indicator-sound crashes when rhythmbox is playing something mounted over gvfs, I can fix the crash easily but getting art to display may take more work
[16:43] <seb128> kklimonda, conor is working on that
[16:44] <seb128> it's the artwork fetching
[16:44] <kklimonda> yeah
[16:45] <ronoc> kklimonda: hi, I'm working on a fix right now for the remote arturl
[16:45] <ronoc> will be in tmrw's release
[16:46] <kklimonda> ronoc: thanks, I can't use sound menu since I've imported my library ;)
[16:46] <tedg> kklimonda, Okay, so is that the one that's a libindicate bug?  Do you have a fix for that?
[16:46] <ronoc> kklimonda: https://code.edge.launchpad.net/~cjcurran/indicator-sound/remote-art-handling
[16:46] <ronoc> have it working just need to tidy a few things
[16:48] <kklimonda> ronoc: hmm.. why do you check http:// ? that's not the only case :)
[16:49] <ronoc> kklimonda: true, I have more code to push this is just a first cut
[16:50] <kklimonda> ronoc: why not use Gvfs?
[16:50] <kklimonda> tedg: nah, ronoc is working on it - I can poke him now! :)
[16:51] <kklimonda> seb128: and in bug 626379, would it be enough to stop g-s-d from crashing? That's pretty simple fix for an edge case (that should never happen but obviously it does)
[16:51] <tedg> Ah, okay.  kklimonda you'd be surprised how much work I pass off on ronoc ;)
[16:51] <kklimonda> unfortunately I can't reproduce g-s-d crash so investigating it isn't simple..
[20:17] <ronoc> Cimi: ping !