| dfarning | lfaraone, what should we do next with https://bugs.launchpad.net/ubuntu/+source/sugar-0.88/+bug/617805 ? the debdiff looks good. | 01:10 |
|---|---|---|
| ubot2 | Launchpad bug 617805 in sugar-0.88 (Ubuntu) "Bar at the bottom of the window displays 'xephyr on' instead of sugar (affects: 2) (heat: 18)" [Low,In progress] | 01:10 |
| === bernie is now known as bernie_afk | ||
| lfaraone | dfarning: apologies, internet's been in and out. | 03:23 |
| lfaraone | dfarning: it should be forwarded to Sugar bugs and "r?" set as a tag on the Sugar Labs ticket. There should be no problem getting this merged. | 03:36 |
| kandarpk | manusheel sir: hello | 12:38 |
| manusheel | kandarpk: Hi Kandarp. Let us discuss the bugs to be assigned. Can you open http://bugs.sugarlabs.org? | 12:38 |
| kandarpk | manusheel sir: yes sir | 12:39 |
| manusheel | kandarpk: There is a sugar-love category on that page (bottom section). | 12:39 |
| kandarpk | manusheel sir: yes sir | 12:40 |
| satellit_ | I tried running from burned CD: ubuntu-10.10-beta-desktop-i386.iso then used software center to sownload sugar. Got sugar emulator sugar with only read. when will applications be included? | 12:40 |
| satellit_ | s/download and install while runnig live CD | 12:41 |
| manusheel | kandarpk: I would like you to pick up the activities related bugs. Let us discuss them one by one. | 12:41 |
| manusheel | satellit_ : Hi Thomas. | 12:41 |
| satellit_ | hi | 12:41 |
| manusheel | satellit_: Hope you are doing well. I'll check this with Neeraj and Luke and will soon get back to you. | 12:42 |
| satellit_ | when will activities be updated to beta 10.10 | 12:42 |
| satellit_ | thanks | 12:42 |
| manusheel | kandarpk: The first one is http://bugs.sugarlabs.org/ticket/2087 | 12:42 |
| kandarpk | manusheel sir: ok. | 12:43 |
| manusheel | kandarpk: Can you have a look at the patch for this issue? | 12:44 |
| kandarpk | manusheel sir: didnt the patch that has been submitted solved the issue ? | 12:44 |
| manusheel | kandarpk: We need to study and analyze the patch to see if it did. If it didn't solve the issue, we'll create one. | 12:47 |
| kandarpk | ok. | 12:47 |
| manusheel | kandarpk: Kindly study the patch, and let me know your analysis on it. | 12:47 |
| dfarning | kandarpk, does it make sense what the patch is doing? | 12:50 |
| kandarpk | dfarning: going through the comments right now | 12:51 |
| kandarpk | that might help | 12:51 |
| kandarpk | manusheel sir, dfarning: the patch.2 seems to remove the erase option for a protected activity | 13:10 |
| manusheel | kandarpk: Right. | 13:11 |
| kandarpk | manusheel sir: but I am not able to understand which activities are marked as protected | 13:12 |
| manusheel | kandarpk: We should have both the options - all activities marked as protected, or certain activities marked as protected. | 13:13 |
| dfarning | kandarpk, the activities would be marked by adding a entery to usr-settings(or something similar) | 13:13 |
| dfarning | kandarpk, which adds and entry to gconf -- this patch just provides the framework. | 13:14 |
| kandarpk | dfarning: ok. | 13:14 |
| dfarning | kandarpk, have you been following the threads on sugar-devel about patch reviews? | 13:15 |
| kandarpk | dfarning; we need to provide a option to add activity in protected list ? | 13:15 |
| kandarpk | dfarning: at times | 13:16 |
| dfarning | kandarpk, yes.... the problem is that kids delete activities to make room on the XOs for music and games:) smart kids! | 13:17 |
| dfarning | kandarpk, but that makes it hard for teacher when they want to use a activity in class.... and half the class has deleted it. | 13:17 |
| kandarpk | dfarning: hmmm :) | 13:17 |
| dfarning | kandarpk, this feature request allows schools and deployments set a list of activities which can not be deleted. | 13:19 |
| dfarning | kandarpk, does it make sense? | 13:20 |
| kandarpk | dfarning: I understand the purpose of this feature | 13:21 |
| dfarning | kandarpk, does the implementation make sense? | 13:22 |
| kandarpk | dfarning: yes | 13:22 |
| kandarpk | dfarning: as discussed at bugs.sl.o, cant we install protected activities in /usr instead of ~/ | 13:23 |
| dfarning | kandarpk, cool, the key idea is at line 95. | 13:24 |
| kandarpk | dfarning: hmmm. | 13:25 |
| kandarpk | dfarning: now I understand it clearly | 13:25 |
| kandarpk | dfarning: we need to add a patch by which we could add the activity in the protected activities list | 13:25 |
| kandarpk | dfarning: is that correct ? | 13:26 |
| dfarning | kandarpk, Rather than a patch we can just add a line to a 'settings file' such as USR-setting. | 13:27 |
| dfarning | kandarpk, have you looked at USR-settings? | 13:29 |
| kandarpk | dfarning: no. | 13:30 |
| kandarpk | dfarning: where is it located ? | 13:33 |
| dfarning | kandarpk, you uploaded it last:) https://launchpad.net/~sugarteam/+archive/ppa/+packages | 13:34 |
| kandarpk | dfarning: isn't it present on the system having USR so that it can be modified to change settings ? | 13:35 |
| dfarning | kandarpk, yes. The idea of the setting is to allow deployments and hardware vendors to tweak setting in one location. with out touching a bunch of differnt .deb files or .rpm files. | 13:38 |
| dfarning | kandarpk, are you familiar with gconf? | 13:39 |
| kandarpk | dfarning: somewhat. It manages keys and its value | 13:39 |
| dfarning | yes, it is like windows registery. but as a text file. | 13:40 |
| dfarning | kandarpk, user-setting mainly writes gconf setting and then patch like the one you looked at read those setting. | 13:41 |
| kandarpk | dfarning: ok. | 13:42 |
| dfarning | kandarpk, well those are the high lights. have you been following the patch review threads. | 13:43 |
| kandarpk | dfarning: not completely. | 13:44 |
| dfarning | kandarpk, to make a long story short. When every we have a patch we want to submit upstream we a) create a bug b) add the patch to the bugs c) mark the bug r? and d) send a post to sugar-devel requesting a review. | 13:46 |
| dfarning | kandarpk, in this case a,b, and c are done by tch. but we need to send a post to the mailing list to insure that the patch gets noticed. | 13:47 |
| kandarpk | dfarning: ok. | 13:48 |
| dfarning | kandarpk, can you send a review request to the list? (this is one of the annoying things that PMs need to keep on top of) | 13:49 |
| kandarpk | dfarning: np. | 13:50 |
| dfarning | kandarpk, I just forwarded you an example of a review request. thanks | 13:51 |
| kandarpk | dfarning: thank you. | 13:52 |
| dfarning | kandarpk, ping me when you are done and we will move onto the next issue:) | 13:52 |
| kandarpk | dfarning: ok. | 13:53 |
| dfarning | kandarpk, oops.... and please include a link on the review request back to the SL bug report. | 13:56 |
| kandarpk | dfarning, manusheel sir: I'll be back in 30min. | 13:58 |
| dfarning | kandarpk, +1 | 13:59 |
| manusheel | dipankar: Hi Dipankar. | 14:20 |
| dipankar | manusheel, hello sir | 14:21 |
| manusheel | dipankar: Can you make the patch for the register bug, and attach it for review? | 14:21 |
| dipankar | manusheel, Sir, I have made changes in the git repository of sugar-jhbuild | 14:22 |
| manusheel | dipankar: Great. Can you upload the patch at LP? | 14:22 |
| dipankar | manusheel, sir, just a minute | 14:23 |
| manusheel | dipankar: Sure. | 14:23 |
| dipankar | manusheel, sir, git status in jhbuild git repo shows no changes to commit. | 14:24 |
| dipankar | manusheel, Sir, this is unexpected | 14:25 |
| manusheel | dipankar: Yes, indeed. | 14:25 |
| manusheel | dipankar: Did you change the code, and had committed it already? | 14:30 |
| manusheel | Earlier, I mean. | 14:30 |
| dipankar | manusheel, no sir | 14:33 |
| manusheel | dipankar: Ok, can you do that on Neeraj's machine? | 14:35 |
| manusheel | dipankar: Creating a patch. | 14:35 |
| manusheel | Part. | 14:35 |
| dipankar | manusheel, sir, i am changing the source package itself | 14:36 |
| dipankar | manusheel, sir : let me create a patch from the package | 14:36 |
| manusheel | dipankar, sure. | 14:36 |
| dipankar | manusheel, sir: http://paste.ubuntu.com/488294/ | 14:48 |
| manusheel | Dipankar, the patch looks good. | 14:52 |
| manusheel | You can upload it at LP. | 14:52 |
| dipankar | manusheel, right away | 14:52 |
| manusheel | dipankar: Great. | 14:53 |
| * dipankar has uploaded patch for register bug : https://bugs.launchpad.net/ubuntu/+source/sugar-0.88/+bug/617813 | 14:54 | |
| ubot2 | Launchpad bug 617813 in sugar-0.88 (Ubuntu) "sugar freezes when register widget is clicked (affects: 1) (heat: 6)" [Critical,Confirmed] | 14:54 |
| manusheel | dipankar: What message are we displaying over there? | 14:54 |
| manusheel | Great. | 14:54 |
| manusheel | dipankar: When no network is present? | 14:54 |
| dipankar | manusheel, right now, we are only controlling the timeout | 14:55 |
| dipankar | the message part is still not covered yet | 14:55 |
| manusheel | dipankar: Ok. Can you do that too in a separate patch? | 14:58 |
| manusheel | dipankar: Simple message. | 14:58 |
| manusheel | Registration failed. No network found. or, something on these lines. | 14:59 |
| dipankar | manusheel, sir, let me check that out | 15:03 |
| manusheel | dipankar: Sure. | 15:05 |
| manusheel | kandarpk: Did you get my message? | 15:05 |
| kandarpk | manusheel sir: yes sir, sending the mail in a minute. | 15:06 |
| manusheel | kandarpk: Great. | 15:07 |
| * manusheel back in 15 mins. | 15:15 | |
| dipankar | manusheel, sir I think I made a small mistake on the patch | 15:15 |
| dipankar | manusheel, can we discard a patch from LP? | 15:15 |
| manusheel | sure. | 15:16 |
| manusheel | Upload a fresh patch. | 15:16 |
| dipankar | manusheel, ok sir | 15:16 |
| mukul | dfarning, hi | 15:24 |
| dfarning | mukul, hello | 15:29 |
| * dipankar is away: Be Right Back | 15:29 | |
| dfarning | mukul how is SL#2163 coming? | 15:31 |
| dfarning | kandarpk, great it looks good, what is next for you? | 15:32 |
| mukul | dfarning: I have been working on it for quite a while now. OIn sugar-jhbuild the bug is not present while on the emulator it is still there. | 15:33 |
| kandarpk | dfarning, http://bugs.sugarlabs.org/ticket/1858 | 15:34 |
| dfarning | mukul, so when you run jhbuild from the emulator it works as expected? | 15:35 |
| kandarpk | dfarning: or http://bugs.sugarlabs.org/ticket/1856 | 15:35 |
| mukul | dfarning, Yes it works as it should work | 15:35 |
| dfarning | kandarpk, #1858 looks good. Can you ping walter on #sugar for help he maintains TA. | 15:36 |
| mukul | dfarning, the file favoritesview.py imports some more files which too have been edited. I'm trying to figure out what changes are needed to be made. alsroot said that the code for centering the XO icon looked fine. The problem lies elsewhere. Can you guide me what steps should I take now? | 15:37 |
| dfarning | mukul, what about if you change the size or the emulator window to some thing other than 880X600? | 15:38 |
| kandarpk | dfarning: do we need to update TA to resolve #1858 ? | 15:38 |
| alsroot | mukul: if I got right you, problem was fixed in sugar-jbuild, right? | 15:38 |
| mukul | alsroot, Yes | 15:38 |
| alsroot | mukul: so, you ask bug submitter to try to reproduce issue in recent env and close the bug | 15:39 |
| alsroot | *you can | 15:39 |
| dfarning | kandarpk, yes. | 15:39 |
| kandarpk | dfarning: ok, that means TA has to check the font settings set by sugar and display text accordingly ? | 15:40 |
| satellit_ | dfarning I found adding "-i 832x624" to sugar -emulator fitted EeePC900 screen | 15:40 |
| dfarning | kandarpk, +1 | 15:40 |
| kandarpk | dfarning: ok. | 15:41 |
| dfarning | satellit_ what is the -i flag for? | 15:42 |
| satellit_ | -i si a variable setting for command like -f | 15:42 |
| satellit_ | s/is | 15:42 |
| satellit_ | sugar-emulator --help lists it | 15:43 |
| dfarning | satellit_ got it dimensions but -d was already taken | 15:44 |
| satellit_ | ok worked for me..... | 15:45 |
| satellit_ | correction 10" netbook not 9" EeePC 900 | 15:46 |
| kandarpk | alsroot: Hi | 15:46 |
| alsroot | kandarpk: hi | 15:46 |
| kandarpk | alsroot, can you help me in resolving http://bugs.sugarlabs.org/ticket/1858 ? | 15:47 |
| dfarning | mukul, what was the command for rotating the screen? | 15:47 |
| mukul | dfarning, xrandr -o 1 | 15:47 |
| kandarpk | alsroot, TA needs to read the font settings set by sugar and display text accordingly | 15:47 |
| mukul | dfarning, xrandr -o 1 for 90 degree rotation | 15:48 |
| alsroot | kandarpk: yup, but whats the question, if it relates to TA internals, you'd better to ask walterbender on #sugar he if TA developer | 15:49 |
| kandarpk | alsroot: sure. | 15:50 |
| dfarning | mukul, ok the bug is in sugar emulator on Ubuntu | 15:50 |
| mukul | dfarning, Yes | 15:51 |
| dfarning | mukul, I am updating sugar-jhbuild to test there. | 15:51 |
| kandarpk | alsroot: by the way, where should we look to check the font settings set by sugar ? | 15:51 |
| satellit_ | dfarning -i 880x520 fits 9" screen | 15:52 |
| alsroot | kandarpk: see sugar-toolkit/src/sugar/graphics/style.py, FONT_* constants | 15:52 |
| dfarning | kandarpk, I would start by poking around TA and trying to determine how the font size is set. | 15:52 |
| dfarning | kandarpk, then see how it scales... do a couple of tests. then ask walter about adding gconf configs. | 15:53 |
| kandarpk | dfarning: Ok. thanks | 15:54 |
| dfarning | kandarpk, add the configs will be exactly as you saw in the patch you reviewed this morning | 15:54 |
| kandarpk | dfarning: I wasn't very sure how to proceed. | 15:55 |
| kandarpk | dfarning: will start with TA now. | 15:55 |
| dfarning | kandarpk, the first thing is almost always grepping for the code in question. in this case alsroot probobly grepped for font.... or else he just has a really good memory | 15:56 |
| dfarning | alsroot, mukul yep it has been fixed in jhbuild:) | 16:05 |
| mukul | dfarning, So what next has to be done? | 16:06 |
| dfarning | mukul, lets see where it was fixed | 16:06 |
| mukul | dfarning, I was trying to figure out the changes in jhbuild that fixed the problem but it seems there were too many. | 16:07 |
| manusheel | mukul: Yes, using git diff might not be a good idea here. | 16:10 |
| manusheel | mukul: Let us see the file, where we have this code part, and look at the changes over there. | 16:10 |
| dfarning | mukul, have you tried git log? | 16:11 |
| mukul | dfarning, No but I saw the commits upstream | 16:12 |
| dfarning | mukul, go to sugar-jhbuild/source/sugar and run git log | 16:13 |
| mukul | manusheel sir: I looked at that. The code was very much similar. However there were some new variables as well as new imports. I made some of those changes and added the new imports too. But it seems the imports too had been edited | 16:13 |
| mukul | dfarning, Ok | 16:13 |
| mukul | dfarning, git log didn't provide me anything that could help me with this | 16:16 |
| dfarning | try googling a bit for git log ..... you can see the changes that affected a particular file. | 16:18 |
| dfarning | mukul, ^^ | 16:19 |
| mukul | dfarning, Ok | 16:19 |
| dfarning | kandarpk, did you see the review your patch submission just got? | 16:20 |
| kandarpk | dfarning: "Comment(by dsd)" ?? | 16:22 |
| kandarpk | this one ? | 16:22 |
| dfarning | kandarpk, sascha just sent a review to the sugar-devel mailing list. | 16:23 |
| kandarpk | dfarning: I think I haven't received that yet. | 16:24 |
| manusheel | dfarning, kandarpk: http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026544.html | 16:26 |
| kandarpk | manusheel sir: thank you sir. | 16:26 |
| manusheel | kandarpk: Please have a look at [1] http://en.wikipedia.org/wiki/Guard_(computing) [2] https://bugs.sugarlabs.org/ticket/1147 | 16:29 |
| manusheel | and let me know your analysis on it. | 16:30 |
| manusheel | dfarning: Fine, we'll reduce the indentation a bit. | 16:30 |
| kandarpk | manusheel sir: OK sir | 16:30 |
| dfarning | kandarpk, do you know how to create a branch in git and apply tch's patch? | 16:32 |
| kandarpk | dfarning: patch original patch ?? | 16:33 |
| kandarpk | dfarning, manusheel sir: I'll be back in 20 min. | 16:34 |
| dfarning | kandarpk go into sugar-jhbuild/source/sugar and create a branch. | 16:34 |
| dfarning | kandarpk, ok we will follow up then. | 16:34 |
| kandarpk | dinner... | 16:35 |
| === satellit_ is now known as satellit___ | ||
| manusheel | ishan: Hi Ishan. | 16:53 |
| manusheel | ishan: Around? | 16:54 |
| ishan | manusheel, yes sir | 16:59 |
| manusheel | ishan: Did we submit moon activity for review? | 17:00 |
| manusheel | Yesterday. | 17:00 |
| ishan | manusheel, yes sir i did that part yesterday | 17:01 |
| manusheel | ishan: Ok, so on Sugar/tasks page, it is r? | 17:01 |
| manusheel | right. | 17:01 |
| ishan | manusheel, yep | 17:02 |
| manusheel | ishan: Great. | 17:02 |
| dfarning | ishan, to be clearer you can remove the r- and just leave one r? | 17:03 |
| ishan | dfarning, hi | 17:03 |
| ishan | sure | 17:03 |
| dfarning | ishan, hey | 17:03 |
| ishan | dfarning, done | 17:05 |
| dfarning | ishan, +1 did you see the feed back you got on http://bugs.sugarlabs.org/ticket/2285 | 17:06 |
| ishan | dfarning, thanks for pointing to that | 17:07 |
| ishan | will just look into that | 17:07 |
| dfarning | ishan, they are acouple of good easy fixes. | 17:08 |
| ishan | dfarning, yes | 17:08 |
| ishan | dfarning, new patch added | 17:27 |
| dfarning | ishan, did you attach the new patch to the bug report. | 17:31 |
| ishan | dfarning, i have presently added the patch at Launchpad only | 17:32 |
| manusheel | ishan: Is it the updated patch? | 17:32 |
| ishan | manusheel, at launchpad it is the updated patch | 17:32 |
| dfarning | ishan, then can you attach the new patch to SL#2285 | 17:33 |
| manusheel | ishan: Ok. We need to attach it at bugs.sugarlabs.org and add r? | 17:33 |
| manusheel | Request for review. | 17:34 |
| ishan | manusheel, dfarning:okay | 17:34 |
| kandarpk | dfarning: what did you want me to do after applying the patch ? | 17:45 |
| dfarning | kandarpk, welcome back | 17:46 |
| dfarning | kandarpk, did you create a working branch before applying the patch. | 17:47 |
| kandarpk | dfarning: yes | 17:47 |
| dfarning | kandarpk, cool so git diff gets what you expect? | 17:48 |
| kandarpk | dfarning: yes | 17:49 |
| kandarpk | dfarning: do I need to correct the patch as pointed out by sascha ? | 17:49 |
| dfarning | kandarpk, yes please. | 17:49 |
| kandarpk | dfarning: ok | 17:50 |
| dfarning | ishan, how are you coming on the new patch for SL#2285? | 17:53 |
| manusheel | dfarning: There were a couple of issues on that front. Neeraj is helping Ishan on this part. | 17:55 |
| manusheel | dfarning: Ishan will upload the patch soon. | 17:56 |
| dfarning | manusheel, ok was just checking that he was not stuck. ishan after uploading the patch can you send an request for review to sugar-devel. kandarpk just did one a couple of hours ago so he can show you how. | 17:58 |
| mukul | dfarning, I retrieved some useful information from git log | 18:03 |
| mukul | dfarning, http://paste.ubuntu.com/488362/ | 18:03 |
| dfarning | mukul, yep commit fixed it c3f545beac96323a046ed68b0fdf6410299dfd41 | 18:04 |
| manusheel | dfarning: Sure. Definitely. | 18:05 |
| manusheel | ishan: Send an update to me and dfarning once you are done with this part. | 18:05 |
| ishan | manusheel, sure sir | 18:05 |
| dfarning | mukul, so you can close the bug with the message fixed upstream in sugar with commit c3f545beac96323a046ed68b0fdf6410299dfd41 | 18:06 |
| mukul | dfarning, Ok. By the way, how can i get the git diff of the respective commit | 18:07 |
| dfarning | try git show c3f545beac96323a046ed68b0fdf6410299dfd41 | 18:08 |
| kandarpk | dfarning, manusheel sir: sascha commented "I have a feeling this will break badly if the GConf value is not set." | 18:11 |
| manusheel | kandarpk: Yes. | 18:12 |
| mukul | dfarning, Shall I make the following changes and upload the patch or Should I close the bug with the message stated by you? | 18:12 |
| manusheel | mukul: Upload the patch. | 18:12 |
| manusheel | mukul: That is for jhbuild. | 18:12 |
| mukul | manusheel sir: Ok | 18:13 |
| manusheel | mukul: We need it for Sugar 0.88 | 18:13 |
| kandarpk | manusheel sir, dfarning: what would be the correct approach ? | 18:13 |
| dfarning | manusheel, if the fix is in jhbuild I don't think we need to update it for dextrose..... the bug has existed for years without anyone noticing. we will catch the fix downstream in a couple of months. | 18:14 |
| manusheel | dfarning: Ok. Sure. | 18:15 |
| dfarning | kandarpk, which bug number were you working on? I lost track. | 18:17 |
| kandarpk | dfarning: https://bugs.sugarlabs.org/ticket/2087 | 18:18 |
| kandarpk | dfarning: review here http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026544.html | 18:18 |
| dfarning | kandarpk, I'll be back in a minute | 18:21 |
| dfarning | kandarpk, ok | 18:29 |
| dfarning | kandarpk, you need to see what happens if the list is empty. | 18:33 |
| kandarpk | dfarning: would it be empty initially, ie right now ? | 18:35 |
| kandarpk | alsroot: around ? | 18:35 |
| alsroot | kandarpk: yup | 18:35 |
| dfarning | kandarpk, yes it should be. | 18:36 |
| kandarpk | alsroot: sascha refers to #1147 here http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026544.html | 18:37 |
| kandarpk | which was, as I understand it, fixed by you | 18:37 |
| kandarpk | alsroot: how should I fix a similar issue in #2087 | 18:38 |
| alsroot | kandarpk: hmm, not sure if I was fixing something related to protected activities, btw there are several patches propesed by tch | 18:41 |
| dfarning | kandarpk, see http://library.gnome.org/devel/gconf/stable/gconf-GConfClient.html#gconf-client-get-list | 18:42 |
| dfarning | kandarpk, if the list is empty get_list throws and error | 18:43 |
| dfarning | throws an error | 18:43 |
| kandarpk | dfarning: ok | 18:43 |
| dfarning | kandarpk, so you have to put the line in a try block | 18:44 |
| kandarpk | dfarning: ok | 18:45 |
| dfarning | kandarpk, then in the exception block set the list to empty | 18:45 |
| manusheel | neeraj_: Hi Neeraj. | 18:54 |
| neeraj_ | manusheel sir: hi :) | 18:55 |
| dfarning | neeraj_, how are you? | 18:55 |
| dfarning | neeraj_, and what are you working on? I am trying to keep track. | 18:55 |
| neeraj_ | dfarning, I am good. At present, I was helping ishan with patches. Was explaining him how patch format is different for ubuntu and bugs.sugarlabs. | 18:58 |
| dfarning | neeraj_, +1 do you have questions about https://bugs.edge.launchpad.net/ubuntu/+source/sugar-0.88/+bug/617582 | 18:59 |
| ubot2 | Launchpad bug 617582 in sugar-0.88 (Ubuntu) "When opening the control panel some icons are cut off . (affects: 2) (heat: 172)" [High,Confirmed] | 18:59 |
| neeraj_ | also, for control panel icon issue, as I had already told u that I have attached the patch on ubuntu Lp. I am ready with my patch for sugar upstream, | 18:59 |
| neeraj_ | I have already filed ny bug on bugs.sugarlabs. Will send the patch for review today on sugar-devel | 19:00 |
| dfarning | neeraj_, http://launchpadlibrarian.net/54640423/sugar-0.88_0.88.1-2ubuntu2.debdiff looks good | 19:02 |
| kandarpk | manusheel sir, dfarning: I've updated the patch and mailed it to you. Please see if it is ok. | 19:02 |
| neeraj_ | dfarning, yes, for ubuntu we are good :).. but luke has asked me to send the patch on sugar-devel also. | 19:03 |
| manusheel | kandarpk: Sure. | 19:03 |
| dfarning | neeraj_, +1 | 19:03 |
| dfarning | kandarpk, is self._protected_activities = () how to make and empty list? | 19:05 |
| kandarpk | dfarning: that is what I understand from http://docs.python.org/tutorial/datastructures.html#tuples-and-sequences | 19:07 |
| kandarpk | alsroot: am I correct in "self._protected_activities = ()" to assign an empty list ? | 19:08 |
| dfarning | kandarpk, a list is [] a touple is () | 19:09 |
| dfarning | kandarpk, i think..... | 19:09 |
| alsroot | kandarpk: dfarning is right, it is a tuple | 19:10 |
| kandarpk | dfarning, alsroot: ok | 19:10 |
| dfarning | kandarpk, then there is the reviewers comment This is getting convoluted. Please factor it out and turn your condition | 19:11 |
| dfarning | into one or several guards [1]. E.g.: | 19:11 |
| dfarning | kandarpk, I think this is a style thing..... there is nothing inherently evil about nested conditionals. | 19:13 |
| kandarpk | dfarning: see line 60-65 | 19:13 |
| kandarpk | dfarning: ok. | 19:14 |
| dfarning | kandarpk, I think he was talking about the nested conditionals in | 19:15 |
| dfarning | + if activity_info.is_user_activity() and \ | 19:15 |
| dfarning | > + not registry.is_activity_protected(self._bundle_id): | 19:15 |
| dfarning | > + menu_item = MenuItem(_('Erase'), 'list-remove') | 19:15 |
| dfarning | > + menu_item.connect('activate', self.__erase_activate_cb) | 19:15 |
| dfarning | > + self.menu.append(menu_item) | 19:15 |
| dfarning | > + menu_item.show() | 19:15 |
| dfarning | > + | 19:15 |
| dfarning | > + if not os.access(activity_info.get_path(), os.W_OK): | 19:15 |
| dfarning | > + menu_item.props.sensitive = False | 19:15 |
| kandarpk | dfarning: yes | 19:16 |
| kandarpk | you are right | 19:16 |
| kandarpk | dfarning: by adding | 19:17 |
| kandarpk | if not activity_info.is_user_activity(): | 19:17 |
| kandarpk | return | 19:17 |
| kandarpk | if registry.is_activity_protected(self._bundle_id): | 19:17 |
| kandarpk | return | 19:17 |
| kandarpk | 19:17 | |
| kandarpk | dfarning: the nested conditions are split into 2 | 19:18 |
| dfarning | kandarpk, some thing like that | 19:19 |
| mukul | dipankar, neeraj_ :Is there a way to press Alt+Tab utility for sugar-emulator apart from booting it up. I mean when I press Alt+Tab on on my emulator, it the ubuntu Alt+tab menu that I get. | 19:26 |
| mukul | ishan, ^^ | 19:26 |
| manusheel | kandarpk: I think we are good to go. | 19:29 |
| manusheel | You can send this at sugar-devel. | 19:29 |
| manusheel | Are you using git send mail command? | 19:29 |
| kandarpk | manusheel: will try that to send the patch to my id. | 19:29 |
| manusheel | kandarpk: Sure, please do. | 19:31 |
| kandarpk | dfarning: git: 'send-email' is not a git command. See 'git --help'. | 19:36 |
| manusheel | kandarpk: Right. | 19:36 |
| kandarpk | manusheel sir: but it is listed here http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html | 19:37 |
| manusheel | alsroot: Can you help Kandarpk on sending the patch to sugar-devel for review using git send-e-mail option? | 19:37 |
| manusheel | kandarpk: Is it working for you? | 19:37 |
| kandarpk | manusheel sir: same output for send-e-mail | 19:38 |
| alsroot | kandarpk: there is preliminary info for new patch workflow http://wiki.sugarlabs.org/go/Talk:Development_Team/Code_Review | 19:40 |
| alsroot | kandarpk: for getting help just call `git send-email --help` | 19:41 |
| kandarpk | alsroot, dfarning, manusheel sir: actually git-email wasn't installed on my system | 19:42 |
| manusheel | kandarpk: Ok. | 19:43 |
| alsroot | kandarpk: thats strange, send-email is not an optional component | 19:47 |
| kandarp_ | manusheel sir, dfarning, alsroot: did I miss anything ? | 19:48 |
| ishan | alsroot, i think its optional since it was missing at my system also | 19:49 |
| alsroot | kandarp_: how many packages returns your package manager for "git" request? | 19:49 |
| alsroot | ..what packages | 19:49 |
| kandarp_ | alsroot: the isntalled ones are git, git-buildpackage and git-email | 19:51 |
| === kandarp_ is now known as kandarpk | ||
| manusheel | kandarpk: Ok. | 19:52 |
| alsroot | kandarpk: so, "git-email" is installed? | 19:53 |
| kandarpk | alsroot: I installed that moments ago | 19:53 |
| kandarpk | alsroot, dfarning, manusheel sir: please see http://paste.ubuntu.com/488412/ | 19:56 |
| kandarpk | I am not able to send the email | 19:56 |
| manusheel | kandarpk: Ok, this is an odd error. alsroot, any pointers or workaround on it? | 19:57 |
| alsroot | kandarpk: do you have mta properly installed? | 19:58 |
| alsroot | kandarpk: if sendmail was failed, you should have error message in /var/spool/mail/<user> | 20:00 |
| kandarpk | alsroot: Mailing to remote domains not supported | 20:02 |
| alsroot | kandarpk: what mta do you have? | 20:02 |
| kandarpk | alsroot: I dont think I've configured one | 20:02 |
| alsroot | kandarpk: what package contain `which sendmail` file? | 20:03 |
| alsroot | *contains | 20:03 |
| kandarpk | alsroot: sendmail isnt installed | 20:03 |
| kandarpk | installing it | 20:04 |
| alsroot | kandarpk: `which sendmail` failed? | 20:04 |
| kandarpk | alsroot: returned nothing | 20:04 |
| alsroot | kandarpk: btw you don't need exactly sendmail | 20:04 |
| alsroot | kandarpk: all mta should provide /usr/sbin/sendmail command | 20:05 |
| * alsroot uses ssmtp which just sends emails to smpts servers | 20:05 | |
| manusheel | kandarpk: Does this help? | 20:08 |
| alsroot | kandarpk: sorry, I forgot that git can send emails on their own.. | 20:08 |
| kandarpk | manusheel sir, alsroot: just installed sendmail package | 20:08 |
| manusheel | kandarpk: Ok, great. | 20:08 |
| manusheel | kandarpk: Now, will it work? | 20:08 |
| alsroot | kandarpk: see sendemail.* options in man | 20:09 |
| alsroot | kandarpk: like smtpserver etc. | 20:09 |
| alsroot | kandarpk: btw if you think that configuring sendmail (exactly sendmail mta) is trivial thing, you are wrong :) | 20:10 |
| kandarpk | alsroot: :( | 20:11 |
| alsroot | kandarpk: use git w/o sendmain, `man git-config`, look for smtp | 20:12 |
| kandarpk | alsroot, No manual entry for git-cofig | 20:12 |
| alsroot | kandarpk: nor `man git-send-email` ? | 20:13 |
| kandarpk | alsroot: man git-send-email has a long description | 20:13 |
| alsroot | kandarpk: see for all *smtp* options | 20:14 |
| manusheel | kandarpk: Any help needed here? | 20:18 |
| kandarpk | manusheel sir: it is giving Mailing to remote domains not supported | 20:22 |
| kandarpk | as errr in /var/spool/mail | 20:23 |
| manusheel | kandarpk: Ok. That is very odd. | 20:23 |
| manusheel | kandarpk: Which version of Debian, Ubuntu is it? | 20:23 |
| manusheel | alsroot: Any workaround here? | 20:23 |
| kandarpk | manusheel sir: debian sid. | 20:24 |
| alsroot | manusheel: git can send email w/o mta | 20:24 |
| manusheel | alsroot: Ok. | 20:25 |
| kandarpk | command used : | 20:25 |
| kandarpk | $ git send-email --to kandarp@seeta.in 0001-Protected-Activities-Support.3.patch | 20:25 |
| manusheel | kandarpk: Ok, and it is not working? | 20:25 |
| kandarpk | manusheel sir: nope | 20:25 |
| manusheel | alsroot: Any help here? | 20:26 |
| manusheel | alsroot: Let us just focus on git and not mta. | 20:26 |
| alsroot | kandarpk: add this to your ~/.gitconfig file, http://pastebin.com/4t0PfX9u | 20:26 |
| kandarpk | alsroot: great :) | 20:29 |
| manusheel | kandarpk, alsroot: Neat. | 20:29 |
| kandarpk | alsroot: by the way, we do not need to specify the spmpass in the file | 20:30 |
| kandarpk | *smtppass | 20:30 |
| manusheel | kandarpk: What all did you add in ~/.gitconfig file? | 20:30 |
| kandarpk | alsroot: everything alsroot asked for http://pastebin.com/4t0PfX9u | 20:31 |
| kandarpk | except for the password | 20:31 |
| alsroot | kandarpk: dunno, you can try maybe git will ask password before sending | 20:33 |
| kandarpk | alsroot: exactly. | 20:33 |
| kandarpk | it does | 20:33 |
| manusheel | kandarpk: Ok. That is interesting. | 20:34 |
| manusheel | kandarpk: So, we did two steps. Installed the required package and made changes in the gitconfig file, right? | 20:34 |
| kandarpk | manusheel sir: yes sir. | 20:35 |
| manusheel | kandarpk: What was the name of the package that was missing? | 20:36 |
| kandarpk | manusheel sir: sendmail | 20:36 |
| kandarpk | manusheel sir: sent you the mail. Please have a look | 20:37 |
| manusheel | kandarpk: Excellent. | 20:37 |
| manusheel | kandarpk: Forwarding it to alsroot too for review. | 20:37 |
| manusheel | kandarpk: Let alsroot review it once. We'll send it to sugar-devel. | 20:38 |
| kandarpk | manusheel sir: OK. | 20:38 |
| kandarpk | manusheel sir: we shall continue tomorrow | 20:38 |
| manusheel | alsroot: Send you the e-mail. Can you please review the patch? | 20:38 |
| kandarpk | Its getting a bit late | 20:38 |
| manusheel | kandarpk: Let us just send the e-mail to sugar-devel? | 20:39 |
| kandarpk | manusheel sir: OK. | 20:39 |
| manusheel | kandarpk: Kindly send me an update once we have send the patch. | 20:52 |
| manusheel | And, uploaded it at bugs.sugarlabs.org with r? | 20:52 |
| kandarpk | manusheel sir: I've sent it to the mailing list | 20:52 |
| manusheel | Great. | 20:53 |
| kandarpk | http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026546.html | 20:53 |
| alsroot | kandarpk: btw get_lest has terrible string in its doc (at least in C++ binding) "Do not call this method on non-list Values" :) | 20:56 |
| * alsroot managed to coredump python for some of gconf.get_* combinations | 20:56 | |
| alsroot | kandarpk: not sure what silbe meant for the method to catch missed gconf value | 20:57 |
| alsroot | as I can see, all gconf get_* calls in sugar do get_string w/o any checks | 20:57 |
| dfarning | kandarpk, when you sent the patch did you create a commit message? There does not seems to be a description of what the patch does. | 21:03 |
| kandarpk | dfarning: the commit message translates into the name of the file when git format-patch is used | 21:04 |
| dfarning | kandarpk, I think there needs to be a one line summary, a blank line, and the a paragraph description for the commit message. | 21:05 |
| kandarpk | dfarning: ok, got it | 21:06 |
| kandarpk | I used git commit -m'comment' | 21:06 |
| dfarning | kandarpk, for something like this you need to go into the editor. | 21:08 |
| dfarning | kandarpk, but great job you took a decent patch and make it good enough to commit. | 21:09 |
| dfarning | kandarpk, do you have a bug to work on tomorrow? I am trying to get a handle on what people are doing so I can help when they ask question:) | 21:11 |
| manusheel | dfarning: Yes. | 21:11 |
| manusheel | dfarning: Kandarp will be working on the TA bugs. | 21:11 |
| dfarning | manusheel, SL#1856? | 21:13 |
| manusheel | http://bugs.sugarlabs.org/ticket/1858 | 21:14 |
| manusheel | dfarning: Yes, http://bugs.sugarlabs.org/ticket/1856 and http://bugs.sugarlabs.org/ticket/1858 | 21:19 |
| dfarning | manusheel, lets to SL#1858 first. it ties in better to todays bug | 21:20 |
| dfarning | lets do | 21:21 |
| manusheel | dfarning: Ok, sure. | 21:21 |
| dfarning | neeraj_, did you open a bug in SL to upstream https://bugs.edge.launchpad.net/ubuntu/+source/sugar-0.88/+bug/617582 | 21:22 |
| ubot2 | Launchpad bug 617582 in sugar-0.88 (Ubuntu) "When opening the control panel some icons are cut off . (affects: 2) (heat: 172)" [High,Confirmed] | 21:22 |
| dfarning | neeraj_, maybe I just can't find it. | 21:22 |
| manusheel | dfarning: http://bugs.sugarlabs.org/ticket/2280 | 21:23 |
| manusheel | Neeraj had opened the issue here. | 21:23 |
| kandarpk | dfarning: what all description do we need to add in the comment ? | 21:24 |
| kandarpk | while git commit | 21:24 |
| dfarning | manusheel, can you create the link in https://bugs.edge.launchpad.net/ubuntu/+source/sugar-0.88/+bug/617582 to SL#2280 | 21:25 |
| ubot2 | Launchpad bug 617582 in sugar-0.88 (Ubuntu) "When opening the control panel some icons are cut off . (affects: 2) (heat: 172)" [High,Confirmed] | 21:25 |
| dfarning | kandarpk, did you see you already have a review from sascha:) | 21:26 |
| dfarning | kandarpk, I would use the orginal commit message tch used at https://bugs.sugarlabs.org/attachment/ticket/2087/0001-Protected-activities-list.patch | 21:27 |
| manusheel | dfarning: Between, Kandarp didn't have the option to attach a file at SL bug tracker. His account has been kept under moderation. | 21:30 |
| manusheel | dfarning: Can you please check this up with Sascha? | 21:30 |
| manusheel | dfarning: I am able to attach the patch from my side. But, Kandarp cannot do that. | 21:31 |
| dfarning | bernie_afk, can you add me as an admin to track so I can approve kandarpk's trac account? | 21:32 |
| dfarning | manusheel, the ball is now rolling:) | 21:32 |
| manusheel | dfarning: Glad to hear. | 21:33 |
| manusheel | dfarning: Did that server issue get resolved? | 21:33 |
| manusheel | dfarning: We wasted quite a lot of time on not been able to do ssh. | 21:33 |
| manusheel | dfarning: Can you kindly review Kandarp's patch again? | 21:36 |
| manusheel | He has re-send it. | 21:37 |
| manusheel | dfarning: We need to send it to sugar-devel. | 21:37 |
| manusheel | kandarpk: It does not mention the ticket number? | 21:39 |
| manusheel | kandarpk: Are we missing on that front? | 21:40 |
| kandarpk | manusheel sir: I actually copied the commit message | 21:40 |
| manusheel | kandarpk: It didn't have any mention of the ticket number? | 21:40 |
| kandarpk | manusheel sir: the first one didnt have it | 21:41 |
| kandarpk | manusheel sir:https://bugs.sugarlabs.org/attachment/ticket/2087/0001-Protected-activities-list.patch | 21:41 |
| kandarpk | https://bugs.sugarlabs.org/attachment/ticket/2087/0001-Protected-activities-list.patch | 21:41 |
| manusheel | kandarpk: Sure. And, the second one? | 21:41 |
| kandarpk | manusheel sir: that has the URL mentioned | 21:42 |
| manusheel | Ok, let us mention the URL and send it across to sugar-devel. | 21:42 |
| manusheel | Rest is good. | 21:42 |
| manusheel | You can send it to sugar-devel with addition of URL and description as you did now. | 21:43 |
| kandarpk | manusheel sir: there's a syntax error | 21:43 |
| manusheel | Ok. | 21:43 |
| kandarpk | I am not able to find that | 21:43 |
| manusheel | What is the error? | 21:44 |
| kandarpk | manusheel sir: http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026548.html | 21:44 |
| manusheel | kandarpk: Do we have an idea on the syntax error? | 21:47 |
| kandarpk | manusheel sir: no sir. | 21:47 |
| manusheel | kandarpk: Ok, I don't think there is any syntax error in your revised e-mail. | 21:47 |
| manusheel | Did you send it with the URL and description? | 21:48 |
| kandarpk | manusheel sir: there should be. I didn't change the code. | 21:48 |
| manusheel | kandarpk: Ok. Let me check it again. | 21:48 |
| manusheel | kandarpk: Ok, Sascha can apply your patch. | 21:50 |
| manusheel | kandarpk: I don't think we should be sending it again. | 21:50 |
| manusheel | kandarpk: I'll touch base with silbe on his suggestion and syntax error. | 21:50 |
| manusheel | kandarpk: We did take care of the third recommendation right. | 21:51 |
| manusheel | kandarpk: fix the white space errors (I recommend using "git config --global color.diff auto" to enable diff coloring) - adjust the _add_erase_option() docstring: only "user" activities (i.e. those in ~/Activities) can be removed at all, so "user or unprotected activities" doesn't make sense. | 21:51 |
| kandarpk | manusheel sir: yes sir | 21:51 |
| manusheel | kandarpk: This was in the revised message that you send me now, or the one you had send to sugar-devel. | 21:52 |
| kandarpk | manusheel sir: I haven't mailed that yet | 21:52 |
| kandarpk | as I am not able to find the syntax error | 21:52 |
| kandarpk | + try: | 21:53 |
| kandarpk | + self._protected_activities = client.get_list('/desktop/sugar/protected_activities', | 21:53 |
| kandarpk | + gconf.VALUE_STRING) | 21:53 |
| kandarpk | + except Exception: | 21:53 |
| kandarpk | + self._protected_activities = [] | 21:53 |
| manusheel | kandarpk: Right. You can send it now. I don't think there is a syntax error. | 21:53 |
| kandarpk | alsroot: is there any syntax error in it ? | 21:53 |
| kandarpk | manusheel sir: ok. | 21:53 |
| manusheel | alsroot : http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026548.html | 21:54 |
| alsroot | kandarpk: you can easily check it, by running :) | 21:54 |
| manusheel | kandarpk: Yes, did we test the patch by running it? | 21:55 |
| kandarpk | alsroot: I cant. The sugar-jhbuild was installed on Ubuntu an I am working from Debian. | 21:56 |
| manusheel | kandarpk: So, we made the patch from Ubuntu, right? | 21:57 |
| kandarpk | manusheel sir: debian | 21:57 |
| manusheel | kandarpk: Ok. And, we don't have jhbuild on debian, right? | 21:57 |
| alsroot | kandarpk: well, but running your own code is essential requirement of proposing patches workflow, you need to setup dev env | 21:57 |
| manusheel | kandarpk: Then, let us take this up tomorrow. I thought you had jhbuild on your Debian machine too. | 21:58 |
| manusheel | kandarpk: Can you make the patch again tomorrow from your Ubuntu machine, and send it after testing it. | 21:58 |
| kandarpk | manusheel sir: sure | 21:59 |
| manusheel | kandarpk: We should be sending the patch only after reviewing it. | 21:59 |
| manusheel | kandarpk: And, testing it. | 21:59 |
| manusheel | kandarpk: Take rest now. We'll do it from the Ubuntu machine tomorrow. | 21:59 |
| manusheel | kandarpk: Neat progress. Keep it up. | 22:01 |
| manusheel | alsroot: Thanks a lot for your help and pointers. | 22:01 |
| manusheel | alsroot: Highly appreciate it. | 22:01 |
| alsroot | np | 22:01 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!