| poolie | hello bialix | 00:00 |
|---|---|---|
| bialix | poolie: do you have any specific plans for 2.2.1? | 00:00 |
| bialix | I mean a more or less precise date | 00:01 |
| bialix | because I need to release qbzr 0.19.1 | 00:01 |
| poolie | let's see | 00:05 |
| poolie | the actual freeze date for 2.2.0 is over a month ago now | 00:06 |
| poolie | we could do it pretty soon | 00:06 |
| poolie | when do you want to do 0.19.1? sooner, or later? | 00:06 |
| jelmer | 'morning poolie | 00:07 |
| poolie | hi there | 00:07 |
| poolie | i wonder what's in the 2.2 branch now? | 00:08 |
| bialix | poolie: I want to have 0.19.1 sooner or in time with 2.2, so GaryvdM can bundle it into installer | 00:08 |
| poolie | could you do it early next week and then we'll do 2.2.1 after that? | 00:09 |
| bialix | I'll do it this weekend then | 00:09 |
| poolie | my fixes for add are in there, plus some smaller fixes | 00:09 |
| poolie | and they had quite a few dupes and would be worth getting out= | 00:09 |
| bialix | ok | 00:11 |
| * bialix eods | 00:11 | |
| poolie | bye | 00:12 |
| poolie | gz, bialix, i'll resubmit the setlocale patch | 01:07 |
| poolie | oh apparently jam sent it, and it's working through pqm | 01:08 |
| mgz | poolie: what would a fixture for thread leaking entail? for the moment I've kept it all as-is but moved it to the test result (...and then poked various other unrelated things nearby that I probably should have filed seperate bugs on but kept breaking stuff) | 01:11 |
| poolie | basically just moving everything in to a self contained object that's notified when the test starts and finishes | 01:13 |
| mgz | I think this is pretty low-overhead though, and having to enable it per-testcase will probably mean we miss tests that aren't obviously using threads | 01:13 |
| poolie | i don't know if that's enough | 01:13 |
| poolie | it could be confined to a fixture even if the base bzr testcase always starts it | 01:13 |
| poolie | ie you don't need to do it per case | 01:13 |
| mgz | I'll wham what I've done up in a mp as it might be easier to discuss there | 01:14 |
| mgz | bah, this is so going to conflict with my other branch, should have thought of that | 01:16 |
| === mlh_ is now known as mlh | ||
| poolie | hi spiv | 02:12 |
| spiv | hi poolie | 03:04 |
| spiv | There's a regression in 2.2 I'm filing now that I'd like to have fixed in 2.2.1 | 03:05 |
| poolie | oh ok, thanks for filing it | 03:05 |
| spiv | bzr+ssh:// to pre-1.6 bzr smart servers fails :( | 03:06 |
| === zyga-kids is now known as zyga | ||
| spiv | poolie: https://bugs.edge.launchpad.net/bzr/+bug/633745 is the bug, btw | 03:39 |
| ubot5` | Launchpad bug 633745 in Bazaar "bzr+ssh to pre-1.6 server fails with AttributeError: 'NoneType' object has no attribute 'close' in close_ssh_proc (affected: 1, heat: 6)" [Critical,Confirmed] | 03:39 |
| lifeless | is that related to the spam we're getting from crontab I wonder? | 03:39 |
| poolie | thanks- | 03:39 |
| poolie | almost not critical, but worth fixing | 03:39 |
| spiv | It's pretty shallow, but it's disappointing that hpss to pre-1.6 servers was broken in 2.2, after we had a different bug breaking it in 2.1. | 03:40 |
| spiv | Oh, I forgot, I have a plugin users can install as a workaround (this bug originally came up IRC yesterday) | 03:41 |
| spiv | lifeless: yes, I expect my fix will assist with some noise from various scripts, not sure if it's the spam you're specifically thinking of... | 03:42 |
| lifeless | something about ssh and NoneTypes ;P | 03:42 |
| spiv | Probably the same, then :) | 03:43 |
| lifeless | please for the love of puppies fix it. | 03:45 |
| lifeless | its driving crontab mail for lp nuts ;) | 03:45 |
| spiv | lifeless: it seems the love of puppies isn't enough to inspire a bug report, though? | 03:46 |
| lifeless | spiv: pretty sure someone was doing one | 03:48 |
| lifeless | spiv: I didn't file one myself because of that | 03:48 |
| spiv | lifeless: yeah, I thought there would be too, but a few searches didn't find any. | 03:49 |
| lifeless | Exception AttributeError: "'NoneType' object has no attribute 'close'" in <bound method SmartSSHClientMedium.__del__ of SmartSSHClientMedium(bzr+ssh://lifeless@bazaar.launchpad.net/)> ignored | 03:49 |
| lifeless | Exception AttributeError: "'NoneType' object has no attribute 'close'" in <function terminate at 0x24490c8> ignored | 03:49 |
| lifeless | is what I see | 03:49 |
| lifeless | that case is ec2land, but it looks very similar in cron mails | 03:49 |
| spiv | Yeah, that's the bug. Until this manifestation I didn't know it was more harmful than occasional noise on stderr. | 03:51 |
| * spiv -> lunch | 04:33 | |
| === oubiwann is now known as oubiwann-away | ||
| === oubiwann-away is now known as oubiwann | ||
| lucidfox | Is there an equivalent of git merge --squash? I.e. merging several subsequent commits from a different branch into one? | 06:41 |
| dash | that's what merges _are_ :) | 06:41 |
| dash | so yes, 'bzr merge' | 06:42 |
| spiv | Well, if you really want to act like --squash, I think you'd also need to do 'bzr revert --forget-merges' after 'bzr merge'. | 06:45 |
| spiv | But I may be skimming the git docs too hastily. | 06:45 |
| lucidfox | Wait, then how do I do a merge the way git merge works - preserving commit history from the other branch? | 06:49 |
| spiv | That's just 'bzr merge'. | 06:49 |
| spiv | IIRC, 'git merge' with no args is roughly like 'bzr merge --pull && bzr commit' | 06:53 |
| spiv | Or if you prefer, 'bzr merge' with no args is roughly like 'git merge --no-commit --no-ff'. | 06:54 |
| lucidfox | That's great :) | 06:55 |
| lucidfox | So far I've actually found bzr having fewer gotchas and obscure corner cases than git | 06:55 |
| lucidfox | and more intuitive overall | 06:55 |
| spiv | That's what we're aiming for :) | 06:55 |
| FryGuy- | i think it's only confusing for people that deeply understand git, and can't see why anyone would want to do it differently | 06:56 |
| lucidfox | heh | 06:57 |
| lucidfox | Well, it has saner defaults | 06:57 |
| FryGuy- | i really like bazaar's "a branch is a path" over the whole repository thing git has.. having two semanticly different things that you have to deal with confuses me a lot | 06:58 |
| FryGuy- | that too | 06:58 |
| lucidfox | I actually miss parallel instantly switchable branches | 06:58 |
| FryGuy- | i have that | 06:58 |
| FryGuy- | it's not intuitive how to get it in bazaar though | 06:59 |
| FryGuy- | you can have a path for your working folder be a checkout of a branch, and then bzr switch between branches | 07:00 |
| spiv | lucidfox: I'm sure someone in here can walk you through how to set that up in bzr; short description is 'have a lightweight checkout that you bzr switch between (treeless) branches' | 07:00 |
| FryGuy- | and you can do things like bzr qlog \dev\branches\* | 07:01 |
| poolie | ok so after all that distraction i'm going back to prompting to break locks | 07:30 |
| vila | hi all ! | 07:49 |
| fullermd | Eek! ETOOMUCHENTHUSIASMINTHEMORNING | 07:51 |
| vila | fullermd: lol, catch e: drink more coffee | 08:06 |
| vila | enthusiasm is good, can't live without it. | 08:06 |
| lifeless | sure you can :P | 08:06 |
| lifeless | ^- not enthusiasm :) | 08:07 |
| vila | well I can... but... | 08:07 |
| lifeless | :> | 08:07 |
| fullermd | Coffee doesn't add to enthusiasm. | 08:07 |
| vila | the sky isn't always blue nor the sun shining, better rely on inside resources :) | 08:07 |
| poolie | vila how hard do you think it would be to write textuifactory tests against a scriptrunner? | 08:07 |
| vila | fullermd: being awake helps finding it back :-P | 08:08 |
| fullermd | Kinda the opposite, actually. It makes me more alert, so I better understand the !#&$*%@ my clients try to say, which makes me less enthusiastic about anything other than mass murder... | 08:08 |
| fullermd | But then, you can't spell "slaughter" without "laughter", so I guess it's not entirely unrelated. | 08:08 |
| vila | poolie: use '<' ? Oh no, you mean hooking a textuifactory into stdin ? | 08:08 |
| poolie | mm, hooking up the streams | 08:08 |
| poolie | probably not too hard? | 08:09 |
| vila | yup, if it's not, that's a bug | 08:09 |
| vila | fullermd: see ? Laughing is good, always. Do you think DEATH don't laugh at you ? | 08:11 |
| * vila shamefully recycles a Desproges's joke :) | 08:11 | |
| vila | err, shamelessly ? | 08:11 |
| poolie | yes | 08:11 |
| vila | if I start typoing shamefully as a portementeau between shame and fullermd where will I end... | 08:12 |
| fullermd | Mississippi, apparently. So try to avoid it :p | 08:13 |
| poolie | vila will it cope with input or output that's not a full line? | 08:15 |
| poolie | eg i want a script like | 08:15 |
| poolie | Break lock? | 08:15 |
| poolie | < y | 08:15 |
| vila | poolie: no idea, but your input will likely includes a new line. But char-based input... is tricky | 08:16 |
| poolie | that's ok, i don't need sub-line input | 08:17 |
| poolie | just for it to cope somehow with an output bit with no trailing \n | 08:17 |
| poolie | i might try it | 08:17 |
| vila | poolie: c.f. shelve input handling requires setup under emacs for example | 08:17 |
| vila | poolie: but I don't think textuifactory *allows* char-based input | 08:17 |
| poolie | to tell emacs to send it single keystrokes not lines | 08:18 |
| vila | shelve use a dedicated method for that (~90% sure) | 08:18 |
| vila | poolie: no, fully different subprocess handling | 08:18 |
| vila | I set it up once but it was... sub-optimal, so I'm back to 'shelve --all' only | 08:19 |
| poolie | :/ | 08:20 |
| poolie | iwbn for it to detect stdin couldn't do single characters, and then read lines | 08:20 |
| poolie | isn't there M-x terminal or something like that, that should send single chars? | 08:20 |
| poolie | oh maybe that's what you mean | 08:20 |
| vila | don't remember the exact mode, but yes, one that doesn't consider stdin to be line-based like the venerable shell-mode | 08:21 |
| vila | I think that's why I revert, not everything I needed was supported there or the interactions was too much different | 08:22 |
| === spm changed the topic of #bzr to: Launchpad down/read-only from 0800-1100 UTC for a code update | Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: poolie | Release Manager: jam | bzr 2.2.0 is officially out | ||
| vila | poolie: another way to fix the problem will be to have shelve use a uifactory that could be configured to requires that any input includes a <return> | 08:24 |
| poolie | that's what i meant | 08:24 |
| vila | oh, that would be really sweet ;) | 08:24 |
| poolie | if $TERM=emacs, or something a bit smarter | 08:24 |
| poolie | oh, again :/ | 08:25 |
| === poolie changed the topic of #bzr to: Launchpad down/read-only from 0800-1100 UTC for a code update | Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: poolie | Release Manager: jam | bzr 2.2.0 is officially out | patches welcome: http://webapps.ubuntu.com/employment/canonical_BSE/ | ||
| poolie | vila what do you think of something like http://paste.ubuntu.com/490797/ | 08:46 |
| bialix | hey vila, poolie, and all all all | 08:47 |
| spiv | poolie: nice /topic update :) | 08:47 |
| poolie | thanks | 08:48 |
| bialix | vila: as you work on conflicts again, I would like to ask: is it worth to extend auto-resolve logic to check whether conflicted path still exists, especially when conflict about inability to delete some dir and if there is no such path anymore just mark conflict as resolved? | 08:48 |
| poolie | :) i think that's exactly what he was just oding | 08:48 |
| poolie | *doing | 08:48 |
| vila | poolie: x and y or z hurts | 08:48 |
| vila | bialix: yes | 08:48 |
| poolie | oh, true | 08:49 |
| bialix | I thought vila working on moving garbage to the trash can | 08:49 |
| lucidfox | "Launchpad will be going offline for maintenance in ten minutes." <--- nnnooooo! | 08:49 |
| poolie | i don't normally use it but in that context it's ok | 08:49 |
| bialix | (joke) | 08:49 |
| poolie | i know | 08:49 |
| vila | bialix: that's related :) | 08:49 |
| bialix | ok, then | 08:49 |
| vila | http://wiki.bazaar.canonical.com/VincentLadeuil/ConflictResolution for a broader view | 08:49 |
| vila | bialix: moving unversioned files to bzr-orphans dir get rid of some conflicts so they don't even have to be resolved | 08:50 |
| bialix | I think my thought is related but has its own benefits | 08:50 |
| vila | bialix: this also avoid requiring a disctinction between precious and junk files by *not* deleting them | 08:51 |
| vila | bialix: see the wiki above, orphaning is a simpler first step | 08:51 |
| bialix | and may help to fix bug 628561 | 08:51 |
| ubot5` | Launchpad bug 628561 in Bazaar Explorer "delete should move files to the trash (affected: 2, heat: 16)" [Low,Confirmed] https://launchpad.net/bugs/628561 | 08:51 |
| * bialix looks | 08:52 | |
| vila | bialix: bug #628561 is yet another variation, the patch I'm working on requires the orphan dir to part of the working tree so far, | 08:53 |
| ubot5` | Launchpad bug 628561 in Bazaar Explorer "delete should move files to the trash (affected: 2, heat: 16)" [Low,Confirmed] https://launchpad.net/bugs/628561 | 08:53 |
| vila | bialix: I have some ideas about how to allow it to be *outside* of the working tree but it requires more work (basically requiring it to be inside the wt guarantees that we rely on TreeTransform including rollbacks) | 08:54 |
| bialix | yes, because system trash can is very system dependent, I can use your orphan dir as poor man emulation | 08:54 |
| poolie | ok https://code.edge.launchpad.net/~mbp/bzr/ui-factory/+merge/34956 posted, with the same diff | 08:54 |
| vila | poolie: isn't it a good place to start implemeting a simple fixture | 08:56 |
| poolie | interesting | 08:56 |
| vila | bah, I should comment on the mp instead | 08:56 |
| * bialix waves at GaryvdM | 08:56 | |
| poolie | for what? the test ui factory? | 08:56 |
| poolie | hi gary | 08:57 |
| poolie | ok, i'm off to take an umbrella to stephane at her office :) | 08:57 |
| GaryvdM | Hi all | 08:57 |
| vila | poolie: make_test_ui_factory | 08:57 |
| poolie | vila, it may be | 08:57 |
| vila | poolie: you've seen my PM ??? | 08:57 |
| poolie | i don't know if it would add much when no cleanup is needed | 08:57 |
| * GaryvdM has been lurking... | 08:58 | |
| vila | poolie: well, it's even more interesting when no cleanup is needed since you don't tie the fixture to the test class | 08:59 |
| vila | or something | 08:59 |
| vila | and the other end, make_test_ui_factory not accepting parameters for stdout and stderr while not hinting about it in its name also itches a bit | 09:00 |
| poolie | well, it was only a tiny change | 09:00 |
| bialix | GaryvdM: any success with your own build host? | 09:01 |
| vila | yeah, no problem, and they can be added later and using a test method also allows for simpler implementations, just mentioning | 09:01 |
| vila | GaryvdM: tell us yes :) | 09:01 |
| vila | poolie: I think my point is more: hey, this goes in the right direction for fixtures, way to go ! | 09:02 |
| * poolie feels better now :) | 09:02 | |
| poolie | i think tearing bits of test base classes into fixtures would be nice too | 09:02 |
| GaryvdM | bialix: I got stuck where it can't find htmlhelp. I've fix this before on the ec2 server, so this time I'll make sure to document what I did :-p | 09:03 |
| vila | yup. defining such test methods is waaaay better than duplicating their content all over the place | 09:03 |
| bialix | GaryvdM: yep | 09:03 |
| GaryvdM | I was very tired last night, so I did not try to hard. | 09:03 |
| vila | GaryvdM: way to go (Did I just said that earlier ?) | 09:03 |
| spiv | Ok, I think I'm done for the day. See you tomorrow! | 09:16 |
| vila | spiv: cu | 09:18 |
| vila | ARGH, lp down... iwbn to be able to setup a bzr branch to fallback to a local mirror for ready-only ops... | 09:18 |
| vila | like in being able to handle 'bzr diff -rsubmit:' without tweaking branch.conf | 09:19 |
| * vila goes filing a bug on .... idiot | 09:19 | |
| === bialix_ is now known as bialix | ||
| voidspace | so I have a locations.conf in ~/.bzr | 12:05 |
| voidspace | should that be ~/.bazaar? | 12:05 |
| GaryvdM | voidspace: Yes | 12:13 |
| voidspace | thanks | 12:13 |
| vila | that makes two questions the same day that could be answered by 'bzr config' or something... | 12:21 |
| vila | voidspace: the closest today is 'bzr version' which mentions 'Bazaar configuration' | 12:21 |
| === Ursinha-afk is now known as Ursinha | ||
| voidspace | vila: thanks | 12:34 |
| mgz | hey all. | 13:35 |
| GaryvdM | Hi mgz | 13:35 |
| vila | mgz: hey ! | 13:50 |
| vila | mgz: reviewing lp:~gz/bzr/selftest_leaked_threads_measuring_633462 is high on my TODO list, many thanks for working on that, I wasn't finding the time myself and that was frustrating | 13:53 |
| mgz | I ended up touching more stuff than I intended to, and thought of a way of doing less moving around of code before I fell asleep last night | 13:54 |
| mgz | but as I'm on a selftest bent I thought I go through and try and knock off all the stuff that has been annoying me for a while | 13:54 |
| mgz | something like ~10 bugs... how fast can I squish 'me | 13:55 |
| mgz | *em | 13:55 |
| vila | mgz: try using a loom for that so you can more easily make several submissions | 13:57 |
| mgz | I was using shelve, but the fix broke some unrelated tests that were doing slightly dodgy things, and can't submit a mp with failing tests... it spiralled a little just when I was trying to get to bed | 13:58 |
| vila | I know the feeling :-/ | 14:04 |
| maxb | Is anyone out there running < lucid any more, who could volunteer to test bzr-svn in the proposed ppa/ | 14:10 |
| maxb | ? | 14:10 |
| Glenjamin | Hi guys, is there any way to force a bzr+https URL to use urllib instead of pycurl? | 14:41 |
| Glenjamin | The certificate is invalid on the server, but i know its fine. | 14:41 |
| bialix | try urllib+bzr+https | 14:42 |
| vila | bzr+https+urllib ? | 14:42 |
| bialix | vila knows better | 14:42 |
| vila | bialix: you were right, but order matters | 14:42 |
| bialix | ok | 14:42 |
| vila | Glenjamin: are you sure you bzr+ in front ? (I don't remember if all combinations are registered) | 14:43 |
| vila | Glenjamin: are you sure you need bzr+ in front ? (I don't remember if all combinations are registered) | 14:43 |
| vila | Glenjamin: we probe for a smart server anyway so this shouldn't be required | 14:43 |
| Glenjamin | it's a writable smart server over https | 14:43 |
| Glenjamin | ah | 14:43 |
| vila | Glenjamin: in fact there is a nosmart+ prefix to *disable* this probe | 14:43 |
| Glenjamin | bzr: ERROR: Transport operation not possible: http does not support mkdir() | 14:44 |
| vila | httpS | 14:44 |
| Glenjamin | bzr push https+urllib://url | 14:44 |
| vila | or is this error message generic ? Ha, seems so | 14:44 |
| vila | ok, try bzr+https+urllib then | 14:45 |
| Glenjamin | not registered | 14:45 |
| GaryvdM | maxb: I have a hardy vm. But I'll only be able to look tommorrow. | 14:45 |
| Glenjamin | is there any way to disable pycurl, or make SSL exceptions? I found a couple of bugs on LP, but they seem to be old | 14:46 |
| vila | Glenjamin: there are several that relates to that, old, yes, lack of time :-/ | 14:46 |
| Glenjamin | i'll just turn on http until i get the cert sorted i guess | 14:47 |
| vila | Glenjamin: there is something weird in your server config that makes the probe fails maybe, to you have a .bzr.log handy ? | 14:47 |
| vila | Glenjamin: I was 99% sure we didn't need to register bzr+https+urllib since urllib is already the default, let me check | 14:50 |
| vila | Glenjamin: argh, yes, urllib is the default for http but pycurl is still the default for https | 14:50 |
| vila | Glenjamin: the idea is that since some people relies on ssl certificate verifications we can't disable it by default | 14:51 |
| vila | Glenjamin: there is more than one client involved right ? | 14:51 |
| Glenjamin | there will be, yes | 14:54 |
| vila | Glenjamin: the best I can offer then is plugin, but it should be installed on all clients... and uninstalled once you fix your certificate :-/ | 14:54 |
| Glenjamin | yeah, i'm planning to put a plugin on anyway for a shortened url scheme | 14:55 |
| Glenjamin | but normally i'd have the plugin in the repo and have users use the full URL once to get the plugin | 14:55 |
| vila | Glenjamin: lp:~vila/+junk/defaultToUrllib a bit dusty, but still working without any updates for... OMG, I never committed it :) | 14:57 |
| vila | Glenjamin: just a sec :) | 14:57 |
| vila | last modification date is 2008-01-22 16:25... | 14:58 |
| Glenjamin | i've just allowed bzr+http access for now | 14:58 |
| Glenjamin | i think we've got a cert for this domain somewhere | 14:58 |
| vila | Glenjamin: which means your passwords are in the clear then (if you use Basic) | 14:59 |
| Glenjamin | its on the same subnet, it'll do for the next few days | 15:00 |
| vila | Glenjamin: ok, np with me :) | 15:00 |
| vila | Glenjamin: I didn't hear anything anyway, I wasn't even there | 15:01 |
| vila | Glenjamin: ok, lp:~vila/+junk/defaultToUrllib is now up-to-date, feel free to copy/paste in your own plugin if you have some deployment policy for it | 15:02 |
| Glenjamin | i'm now getting ('error', "'module' object has no attribute 'ElementTree' back from the server =/ | 15:03 |
| Glenjamin | i'm fairly sure it was working before | 15:03 |
| vila | Glenjamin: this rings a bell, 'bzr version' on the server ? | 15:03 |
| vila | I'm pretty sure we've fixed something there quite recently, mgz ? | 15:03 |
| mgz | yeah, get the latest bzr-xmloutput plugin | 15:04 |
| mgz | or... is that the same error? no, something else. | 15:04 |
| Glenjamin | 2.1.1 | 15:04 |
| mgz | can you get the full traceback from the .bzr.log on the server? | 15:05 |
| Glenjamin | i can, once i figure out how to get the wsgi app to log :) | 15:06 |
| vila | 2.1.1... meh, when did your related modification landed mgz ? | 15:07 |
| vila | Glenjamin: and on the client ? | 15:07 |
| === james_w` is now known as james_w | ||
| Glenjamin | client: http://pastebin.com/MCXszMBS | 15:09 |
| vila | hmm, bzr-xml-output shouldn't be involved there, this is happening in the server, we need its log :-/ | 15:11 |
| vila | Glenjamin: well, we need the traceback, it should be in the log, but if you find it elsewhere, that's good enough :-/ | 15:11 |
| vila | Glenjamin: and that's cetainly worth filing a bug | 15:12 |
| vila | Glenjamin: ...unless you have some hooks installed on the server that could involve xmloutput ? | 15:12 |
| === zyga is now known as zyga-afk | ||
| Glenjamin | vila: the server doesn't even have xmloutput =/ | 15:22 |
| vila | Glenjamin: good, one less possible cause | 15:23 |
| vila | Glenjamin: the weird thing is, I'm pretty sure mgz related change occured only on trunk, not in 2.1 nor 2.2 | 15:23 |
| Glenjamin | managed to get the server log | 15:24 |
| Glenjamin | http://pastebin.com/3gT0Za2B | 15:24 |
| Glenjamin | the wsgi make_app tries to access stdin/out which mod_wsgi doens't allow | 15:25 |
| Glenjamin | ah, it seems to be exactly https://bugs.launchpad.net/bzr/+bug/254278 | 15:29 |
| ubot5` | Launchpad bug 254278 in Bazaar "module object has no attribute ElementTree (affected: 2, heat: 7)" [Low,In progress] | 15:29 |
| vila | Glenjamin: https://code.edge.launchpad.net/~gz/bzr/remove_monkey_patched_elementtree_escaping_614522/+merge/34028 may be relevant too | 15:35 |
| Glenjamin | is that in 2.2? | 15:37 |
| vila | Glenjamin: I don't think so, checking... no | 15:39 |
| Glenjamin | i'll monkeypatch the server then, ta | 15:40 |
| vila | Glenjamin: can you comment on bug #254278 ? With your bzr version and the log, this probably will be just a backport of the above fix but I can't investigate precisely right now | 15:42 |
| ubot5` | Launchpad bug 254278 in Bazaar "module object has no attribute ElementTree (affected: 2, heat: 12)" [Low,Confirmed] https://launchpad.net/bugs/254278 | 15:42 |
| vila | Glenjamin: oh, if you path your bzr on the server, say so in the bug then ! | 15:42 |
| vila | Glenjamin: oh, if you apply the patch to bzr on your server, give some feedback in the bug too ! | 15:43 |
| Glenjamin | done, thanks for the help :) | 15:47 |
| vila | Glenjamin: perfect | 15:51 |
| vila | Glenjamin: thanks to you, knowing that the fix works is a good part of the... work :) | 15:52 |
| mgz | ah, so I actually fixed his bug, rather than creating it? | 15:53 |
| mgz | woho! | 15:53 |
| vila | mgz: yeah :) All you have to do now, is 1) fire an mp for backporting it to 2.1, 2) assign the bug to yourself..... 4) profit ! ;) | 15:54 |
| mgz | I'd better just check a profile under 2.1 as well to make sure it's not using the hack majorly either | 15:55 |
| mgz | :) | 15:55 |
| vila | NOOOOO, ff lost my review :( | 15:58 |
| Glenjamin | oh, out of interest - what workflow do you guys use for conflict resolution? | 16:00 |
| fullermd | I like to use physical intimidation and loud profanity, myself. | 16:03 |
| * bialix is second here | 16:06 | |
| mgz | okay, Toshio's post in that bug is the only thing that could make sense, but I can't repo the problem here so there might also be some wdgi import issue going on | 16:13 |
| mgz | Glenjamin: could you get your wsgi script to give you the module path to bzrlib.xml_serializer.elementtree please? | 16:14 |
| mgz | ...with conflicts I just generally search through for >>> and double check the diff after resolve, but don't take that as best way | 16:22 |
| dash | smerge-mode in emacs is nice. | 16:24 |
| CcxCZ | vimdiff is also nice | 16:24 |
| vila | smerge-mode is emacs is nice | 16:25 |
| vila | Glenjamin: but what do you mean by workflow here ? The way we resolve the conflicts (including the tree-shape ones) or something more high-level ? | 16:26 |
| tedg | Uhm, I got an error that I have no clue on: | 16:27 |
| tedg | bzr: ERROR: An inconsistent delta was supplied involving u'/COPYING', 'copying-20100507105513-ntbj8bqjbsjpuvq7-1' | 16:27 |
| tedg | reason: Attempt to add item at path already occupied by id 'copying-20100505091350-s6ph8iovvrnhwpp9-17' | 16:27 |
| tedg | Can someone translate that for me please? | 16:28 |
| vila | bialix, Gary (offline :-/): where is qbzr today on this topic (conflict resolution) ? | 16:28 |
| vila | tedg: -Derror will give a backtrace | 16:28 |
| tedg | vila, Okay. I have a backtrace, but that doesn't tell me much. | 16:29 |
| * vila fires qblame | 16:30 | |
| === zyga-afk is now known as zyga | ||
| vila | tedg: that's from revno 4553 by lifeless, the comment says: Add checks for inventory deltas which try to ensure that | 16:31 |
| vila | deltas that are not an exact fit are not applied. | 16:31 |
| tedg | vila, Okay, why are my deltas not an exact fit? | 16:32 |
| vila | tedg: I don't fully parse that myself ;) | 16:32 |
| vila | tedg: what was the bzr command ? | 16:32 |
| tedg | vila, merge-upstream | 16:32 |
| vila | I was afraid you'd say something like that :-/ | 16:33 |
| vila | tedg: file a bug | 16:33 |
| tedg | Sure, but I need to figure out how to get my work done as well :) | 16:34 |
| vila | I don't think this can be answered without reproducing and some analysis :-/ | 16:34 |
| vila | tedg: this smells like a parallel import problem though as I don't think COPYING is often renamed | 16:35 |
| vila | tedg: and don't forget to tag the bug UDD | 16:36 |
| tedg | vila, Will do. Doing by hand now to see if I can get more info. | 16:38 |
| vila | tedg: checking the COPYING file-id in both branches should confirm that they are the ones involved | 16:40 |
| vila | james_w: does tedg problem above rings a bell ? | 16:40 |
| bialix | vila: conflict resolutions? qconflicts or qresolve command | 16:40 |
| vila | grr, ring, no s | 16:40 |
| tedg | vila, How do I get the file ID of a file. | 16:40 |
| james_w | vila: yes | 16:40 |
| james_w | tedg: it's fixed in bzr-builddeb trunk | 16:40 |
| vila | tedg: here you go :) | 16:41 |
| bialix | vila: if you're lucky enough you can launch external gui merge tool; then say which conflict is resolved | 16:41 |
| vila | Glenjamin: ^ | 16:41 |
| vila | bialix: thanks, that was for Glenjamin | 16:42 |
| bialix | Glenjamin: what is your question actually? | 16:42 |
| vila | tedg: bzr inventory --show-ids | grep COPYING | 16:43 |
| tedg | james_w, Will that get in Maverick? | 16:43 |
| james_w | tedg: yes | 16:43 |
| Glenjamin | mgz: it was xml.etree iirc | 16:43 |
| tedg | vila, Thanks! | 16:43 |
| tedg | james_w, Woot! If I do the merge-upstream by hand now do you expect that to work? | 16:44 |
| Glenjamin | vila: thats pretty much what i mean - i've been thinking about writing a plugin so you can do "bzr resolve --this FILE" or "bzr resolve --other FILE", which basically does mv on .THIS or .OTHER and resolves | 16:44 |
| Glenjamin | but can't decide if there's any point | 16:44 |
| james_w | tedg: by hand how? | 16:45 |
| vila | Glenjamin: http://wiki.bazaar.canonical.com/VincentLadeuil/ConflictResolution | 16:45 |
| mgz | Glenjamin: thanks, is that first path through the import maze then. would you mind reverting the hack stripping diff, and try a one line addition higher up for me? | 16:45 |
| vila | Glenjamin: that's a work in progress | 16:45 |
| Glenjamin | mgz: sure | 16:46 |
| mgz | vila: thanks for the review, hope it won't upset you too much if I poke the branch a bit further | 16:46 |
| mgz | Glenjamin: after http://bazaar.launchpad.net/~bzr-pqm/bzr/2.1/annotate/head%3A/bzrlib/xml_serializer.py#L33 | 16:46 |
| Glenjamin | oh hang on | 16:47 |
| mgz | add import xml.etree.ElementTree | 16:47 |
| Glenjamin | what's a good way to revert | 16:47 |
| vila | mgz: not at all, but put the mp to wip then | 16:47 |
| Glenjamin | i literally edited the file in dist-packages | 16:47 |
| mgz | vila: not that big a poke | 16:47 |
| vila | mgz: see http://babune.ladeuil.net:24842/job/selftest-windows/161/ and ping again for a refresh | 16:47 |
| mgz | Glenjamin: patch -R with same input? | 16:48 |
| tedg | james_w, bzr branch ubuntu -r upstream-0.0.9 work ; cd work ; tar -xvzf 0.0.10 ; bzr commit ; etc. | 16:48 |
| Glenjamin | i was lazy and just hacked it out with nano D: | 16:49 |
| james_w | tedg: it's not great as it doesn't get the pristine-tar data in | 16:49 |
| james_w | tedg: and it's probably quicker to use a checkout of bzr-builddeb trunk to run that one command | 16:49 |
| tedg | james_w, yes, how do I add that? | 16:49 |
| james_w | tedg: you can't do it from the command line | 16:49 |
| mgz | okay, overwrite with http://bazaar.launchpad.net/~bzr-pqm/bzr/2.1/download/john%40arbash-meinel.com-20100217171116-h7t9223ystbnx5h8/xml.py-20050309040759-57d51586fdec365d/xml_serializer.py then | 16:50 |
| tedg | james_w, Heh, well, I'm at the final step -- so quicker isn't an issue at this point :) | 16:50 |
| mgz | (and make sure the perms don't get mangled) | 16:50 |
| === beuno is now known as beuno-lunch | ||
| mgz | vila: had problems with using result.stream and subunit in the test collection branch, I might need some extra code to make it happy | 16:52 |
| mgz | ...I'll stick this in the mp | 16:53 |
| vila | mgz: does it mean the babune run won't complete ? | 16:54 |
| vila | mgz: no idea is an acceptable answer | 16:54 |
| mgz | I didn't get as far as working out why subunit was unhappy last time, and it was a good thing to remind me about | 16:55 |
| vila | 'remind me about' ? Me ? When ? | 16:55 |
| mgz | you mentioned babune in the mp, and I thought "oh, er..." | 16:55 |
| vila | ah, ok | 16:56 |
| Glenjamin | mgz: that appears to fix the issue as well | 16:56 |
| mgz | this is a slightly different situation so may actually be fine | 16:56 |
| mgz | glenjamin: great, thanks. | 16:56 |
| Glenjamin | is there some sort of weird lazy loading going on in etree? | 16:57 |
| mgz | our code is slightly dodgy and relying on what other people's modules happen to import | 16:57 |
| mgz | vila: I think I might put that one-liner up for 2.1 rather than the monkey-patching strip, it's a less scary diff | 16:57 |
| === dorins_ is now known as dorins | ||
| TresEquis | jelmer: thanks very much for tracking down the KARL3 svn-import issue | 16:58 |
| jelmer | TresEquis: np | 16:59 |
| Glenjamin | heh, conflicts somewhat more complex than my use case :D | 16:59 |
| vila | mgz: sure thing, will ease SRU | 17:03 |
| tedg | james_w: upstream bzr-builddeb does fix it. | 17:03 |
| james_w | great, thanks for testing tedg | 17:04 |
| james_w | it will be uploaded soon, there are just a couple more fixes that I want to include | 17:04 |
| vila | Glenjamin: you mean you were referring to text conflicts only ? | 17:04 |
| Glenjamin | i was referring specifically to the case where i just want to say "use this one" in a text conflict | 17:05 |
| mgz | with newish bzr you can do `bzr resolve --take-this` | 17:06 |
| mgz | or --take-other | 17:06 |
| Glenjamin | ah, thats exactly what i was after | 17:06 |
| Glenjamin | cheers for the help today guys, time to go :) | 17:06 |
| vila | Glenjamin: eerk no, I'm pretty sure --take-{this|other} doesn't work for text conflicts (yet)! | 17:10 |
| vila | argh, too late :( | 17:10 |
| vila | mgz: for the record (and Glenjamin) see 'Provide additional actions for text conflicts' at http://wiki.bazaar.canonical.com/VincentLadeuil/ConflictResolution, Implementing --take-this and --take-other first sounds like a bad idea as people may confuse them with --prefer-this and --prefer-other. | 17:22 |
| mgz | it's bad for real conflicts, quite often people have versioned auto-generated things where you just want the stupid | 17:23 |
| vila | mgz: yeah, we need either versioned properties and file-level config variables to set a default action for these specific files | 17:26 |
| vila | mgz: job 161 finished, but no output related to the leaks, expected ? | 17:43 |
| mgz | yeah, see new comment in the mp | 17:43 |
| vila | ha, let see | 17:44 |
| vila | mgz: hehe, so... add comments :-P | 17:45 |
| mgz | well, there are some things I intend to change but not yet, and it's confusing me :) | 17:46 |
| vila | mgz: I tend to add # FIXME: rumble the wigging -- vila yyyymmdd, even in committed stuff, it's easier to find them back | 17:47 |
| === Ursinha is now known as Ursinha-lunch | ||
| mgz | me too when thinking straight. | 17:49 |
| mgz | gra, and now I rememeber why I did this as well, bt.test_selftest has too many weirdnesses in it | 17:53 |
| vila | mgz: well, be careful there to not reduce the test coverage, otherwise, feel free to rewrite | 17:56 |
| mgz | it's mostly a case of tests taking shortcuts that happen to work, but aren't anything like a real test run | 17:56 |
| vila | mgz: not reduce in test_selftest I meant, but since we have delegated some to testtools... | 17:57 |
| vila | mgz: which one ? | 17:57 |
| mgz | so, passing things that aren't real test cases but just implement the three methods some particular code path happens to use, and so on | 17:57 |
| mgz | or, in this case, doing test runs without doing startTestRun/stopTestRun around it | 17:58 |
| mgz | which is more understandable, and I don't think I want to mess with | 17:58 |
| vila | mgz: ha, this kind, hmm, the easiest is to complete the mockups then | 17:58 |
| vila | mgz: unless there is a way to make the tests more specific... | 17:59 |
| vila | mgz: InstrumentedTestResult ? | 18:00 |
| mgz | yup, which isn't all that evil really. | 18:00 |
| vila | mgz: turn it into module-level class and define daughter classes for tests, will be clearer too | 18:01 |
| mgz | I think my plan A was possibly better, which was, invent report_tests_starting, keep startTestRun, deprecate startingTests | 18:01 |
| mgz | *startTests | 18:02 |
| vila | mgz: I don't know what testtools chose there | 18:02 |
| mgz | well, report_* is a bzrlibism, but one I quite like. | 18:03 |
| mgz | testools adds startTestRun (as per Python 2.7) and that's all. | 18:03 |
| * vila needs to go, bbl | 18:06 | |
| mgz | bye! I think I'm going to stop worrying and just address your review comments instead. | 18:07 |
| === beuno-lunch is now known as beuno | ||
| === deryck is now known as deryck[lunch] | ||
| === zyga is now known as zyga-afk | ||
| jam | mgz: how I learned to stop worrying and just love the review comments... | 18:57 |
| jam | (Dr. Strangelove if you didn't get the reference) | 19:00 |
| jam | spiv: if you get this, IProcessTransport is a load of crap | 19:00 |
| jam | I have been implementing lots of Process attributes because they get used all over the place, which are *not* specified in IProcessTransport | 19:01 |
| === gorozco is now known as p4tux | ||
| mtaylor | bzr: ERROR: An inconsistent delta was supplied involving u'po/POTFILES.in', 'potfiles.in-20100726013555-fcxe3tgefhkh1mxt-1' | 19:10 |
| mtaylor | reason: Attempt to add item at path already occupied by id 'potfiles.in-20100203232321-8hvd3vlf9l7taryv-34' | 19:10 |
| * mtaylor is sad | 19:10 | |
| mgz | okay, done. | 19:11 |
| mgz | jam: a film I really should rewatch at some point. | 19:12 |
| mgz | mtaylor, is that exactly what tedg hit earlier? | 19:12 |
| mgz | in which case, the answer was: | 19:13 |
| mgz | <james_w> tedg: it's fixed in bzr-builddeb trunk | 19:13 |
| mtaylor | mgz: ah - I'll try upgrading to trunk and see if it fixes it | 19:13 |
| mtaylor | mgz: yes. fixed in trunk. thanks! | 19:15 |
| === Ursinha-lunch is now known as Ursinha | ||
| === deryck[lunch] is now known as deryck | ||
| === zyga-afk is now known as zyga | ||
| === oubiwann is now known as oubiwann-away | ||
| === oubiwann-away is now known as oubiwann | ||
| === zyga is now known as zyga-gone | ||
| vila | mgz: seriously, it would have a been a shame to land without those lovely comments ;) | 20:28 |
| jelmer | 'evening vila | 20:33 |
| vila | jelmer: hey ! | 20:33 |
| GaryvdM | Hi all. | 20:51 |
| GaryvdM | I've got an odd problem. When I try run bzr branch lp:subvertpy, I get this error: | 20:52 |
| GaryvdM | bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/%2Bbranch/subvertpy/". | 20:52 |
| GaryvdM | This is at home. If I ssh to a work server, and run from there, it works fine. | 20:53 |
| vila | -Derror ? .bzr.log ? | 20:57 |
| vila | typo ? | 20:58 |
| vila | GaryvdM: meh, same here | 20:59 |
| vila | GaryvdM: ever see this funny %2Bbranch before ? | 21:02 |
| vila | GaryvdM: lp:~jelmer/subvertpy/trunk works, smells like a lp bug to me | 21:03 |
| lifeless | this is new | 21:31 |
| lifeless | its thumpers code to support lp: for private branches | 21:31 |
| lifeless | thats +branch | 21:31 |
| lifeless | please file a bug on launchpad-code | 21:31 |
| GaryvdM | lifeless: Ok | 21:33 |
| GaryvdM | Thanks | 21:33 |
| marienz | is there a way to create a branch with rich-root support that bzr 1.5 can read using bzr 2.1.2? I'm hoping to be able to pull some code onto a debian lenny system. | 22:13 |
| marienz | "bzr help current-formats" and "bzr help other-formats" don't really show anything appropriate, but the 1.5 user reference claims 1.5 did support some rich-root format already. | 22:14 |
| marienz | this is complicated by me not having direct access to a debian lenny system | 22:14 |
| GaryvdM | marienz: Looking at the code, you could use the rich-root-pack format. | 22:19 |
| marienz | GaryvdM: ah, thanks, I was incorrectly assuming the list from "bzr help current-formats" and "bzr help other-formats" would be complete :) | 22:20 |
| GaryvdM | marienz: Yhea - I'm not sure if there is a help topic to see all the old formats. | 22:21 |
| marienz | no worries, this had better not be a common thing to want to do | 22:21 |
| marienz | arguably I should get a newer bzr installed on that box anyway | 22:21 |
| GaryvdM | marienz: The formats are in bzrlib/bzrdev.py | 22:21 |
| marienz | I can figure it out now that I know the list I got from help is incomplete | 22:22 |
| === Ursinha is now known as Ursinha-afk | ||
| poolie | good morning; hi jam | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!