| rockstar | wallyworld_, stick it on devpad. | 00:04 |
|---|---|---|
| rockstar | wallyworld_, and then just link to it on the merge proposal. | 00:04 |
| wallyworld_ | rockstar: thanks | 00:05 |
| thumper | people.canonical.com | 00:05 |
| wallyworld_ | rockstar: links added. ignore the devpad ones. use the people ones | 00:25 |
| rockstar | wallyworld_, cool. | 00:50 |
| rockstar | wallyworld_, sorry it's taking a bit. I'm trying to schedule the planting of trees around the currently inclimate weather. | 00:51 |
| wallyworld_ | rockstar: np at all. thanks for doing the review | 00:51 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews || gmb is RM; for RC reviews please add him as a reviewer | ||
| rockstar | wallyworld_, I'm having a hard time connecting to people.canonical.com... I thought I would just wait, but it's still not connecting. | 02:03 |
| rockstar | Does the link work for you? | 02:04 |
| wallyworld_ | rockstar: i had timeout issues also but thought it was going to be transient. the links to devpad should still work - I haven't removed the files there yet | 02:04 |
| rockstar | wallyworld_, cool. | 02:05 |
| rockstar | wallyworld_, yeah, they don't appear to be transient... | 02:05 |
| wallyworld_ | rockstar: hmmm. i put something there last week and it worked. | 02:06 |
| rockstar | wallyworld_, the project cloud one is approved. | 02:07 |
| rockstar | wallyworld_, as far as moving the linked bugs, I'm -1 on that one. | 02:07 |
| wallyworld_ | rockstar: thanks - yes it was a really trivial change | 02:07 |
| rockstar | wallyworld_, maybe you and I and thumper could have a call. | 02:07 |
| wallyworld_ | rockstar: ok. np. | 02:08 |
| thumper | rockstar: ? | 02:08 |
| rockstar | thumper, I don't like the linked bugs moved up there. | 02:08 |
| thumper | rockstar: what is your reasoning | 02:08 |
| thumper | rockstar: why | 02:08 |
| thumper | ? | 02:08 |
| rockstar | thumper, with our current design, we're saying "we have the most important things at the top." I think that we're putting the linked bugs above things that are much more important. | 02:09 |
| wallyworld_ | the "bug" report indicated that perhaps the linked bugs section is considered important too | 02:10 |
| thumper | rockstar: surely the bugs that are being fixed is pretty important | 02:10 |
| thumper | ? | 02:10 |
| rockstar | I think, to some extent, putting the most relevant things near the top is a good idea, and I think the linked bugs are relevant, but not more than the others. | 02:10 |
| wallyworld_ | and i can see why people would think this to be the case | 02:10 |
| thumper | don't you think? | 02:10 |
| lifeless | rockstar: I think the bulk of the conversation is -much- less interesting than the linked bugs. | 02:10 |
| lifeless | rockstar: because the bulk of the conversation just grows and grows. | 02:11 |
| rockstar | lifeless, the conversation, maybe. Not the votes. | 02:11 |
| thumper | where is the bugs now? | 02:11 |
| lifeless | after the 'add comment' field | 02:11 |
| lifeless | which is after the timeline (comments, new commits) | 02:11 |
| thumper | I think the bugs should go after the description, but before the comments | 02:11 |
| lifeless | that would work for me. | 02:11 |
| thumper | lifeless: sorry, I was asking where they were moved to in wallyworld_'s branch | 02:12 |
| wallyworld_ | thumper: https://devpad.canonical.com/~ianb/linkedbug.png | 02:12 |
| lifeless | thumper: oh, heh :P | 02:12 |
| rockstar | thumper, ah, okay. | 02:12 |
| * lifeless butts out | 02:12 | |
| rockstar | thumper, I think they could go right before the comments, absolutely. | 02:12 |
| thumper | wallyworld_: try moving them after the description, but before the xomments | 02:12 |
| rockstar | lifeless, no, don't ever feel like you can't add your two cents. I (personally) appreciate your two cents. | 02:12 |
| thumper | personally I'd prefer a few dollars chucked my way | 02:13 |
| thumper | rather than just 2c | 02:13 |
| thumper | which you can't even get in NZ now | 02:13 |
| wallyworld_ | thumper: ok, can do | 02:13 |
| thumper | then new pic :) | 02:13 |
| wallyworld_ | of course | 02:13 |
| wallyworld_ | rockstar: i'll ping you tomorrow your time with the ammended layout. thaks for the input | 02:14 |
| rockstar | wallyworld_, I'll be around for a bit tonight. I'm doing homework. | 02:14 |
| lifeless | rockstar: thanks! I didn't mean I would stop commenting, just that on this one I've thrown the 2c in; smart folk are looking at it and I feel happy that whatever you guys do will be good... so I'm off to fight other fires. | 02:14 |
| wallyworld_ | rockstar: ok. you're a glutton for punishment :-) | 02:15 |
| lifeless | like why storm is taking 4 seconds on staging to deserialise 2865 specification objects. | 02:15 |
| rockstar | wallyworld_, tell me about it. I'm currently writing a paper on how we can eliminate the mouse from every day computer use. | 02:15 |
| rockstar | lifeless, I'd like to talk to you about f2e at some point this week (probably tomorrow) | 02:16 |
| thumper | rockstar: replace it with a rat :) | 02:16 |
| wallyworld_ | rockstar: i want me one of those screens where you can just gesture like in Minority Report I think it was | 02:16 |
| lifeless | rockstar: sure | 02:16 |
| rockstar | thumper, if only... | 02:16 |
| lifeless | rockstar: thats front end somethingorother ? | 02:16 |
| rockstar | wallyworld_, yeah, at least then you can eat buffalo wings and still use your computer (my iPad and my favorite foods don't mix) | 02:17 |
| rockstar | lifeless, front end engineering. Basically, I want FASTAR! | 02:17 |
| thumper | wallyworld_: if you get a firefox addin called screengrab you can get an image of the entire rendered page | 02:17 |
| thumper | wallyworld_: even if it doesn't fit on the screen | 02:17 |
| thumper | wallyworld_: very handy for ui reviews | 02:17 |
| wallyworld_ | thumper: np. ksnapshot does that too but i thought I would just cut the actual changed part to show? | 02:18 |
| thumper | wallyworld_: no ksnapshot won't do that | 02:18 |
| thumper | wallyworld_: it can't see the parts of firefox that aren't visible | 02:19 |
| rockstar | thumper, or you can just type "scr" in gnome-do and it'll bring up the gnome screenshot app. | 02:19 |
| thumper | wallyworld_: due to firefox scrolling | 02:19 |
| wallyworld_ | thumper: my bad. sorry, i misremembered what it could do | 02:19 |
| lifeless | rockstar: I want faster too; stats say the backend is the suck today, given that its a necessary condition to fast, I'm focusing there : I'm delighted to help out on fe2 stuff as well, but it is (IMO, based on the data) not a common/dominating issue for us today. | 02:20 |
| rockstar | lifeless, yes, but it will be, and it's where I'm really gaining knowledge currently (due to my classes). | 02:21 |
| rockstar | lifeless, I'm sure you'd like some company on Performance Tuesday, ent? :) | 02:21 |
| lifeless | rockstar: btw the SSL experiment we designed at the epic should be going ahead soon. | 02:21 |
| lifeless | rockstar: absolutely! | 02:21 |
| rockstar | lifeless, for instance, if we kept track of the scope of our variables in javascript, we could double (and in some cases, triple) how fast our javascript executes. | 02:22 |
| lifeless | rockstar: do we have any automated figures on that ? | 02:22 |
| rockstar | lifeless, before I do anything, I'm going to get hudson set up to track it in lazr-js. | 02:23 |
| lifeless | nice | 02:23 |
| wallyworld_ | rockstar: we need to ensure we get the Chuck Norris and Charles Schneider plugins for Hudson :-) | 02:24 |
| rockstar | lifeless, if the API gets faster, I think we could offload many of the expensive things on our pages to be on-demand. | 02:24 |
| lifeless | rockstar: how does that help? | 02:26 |
| lifeless | rockstar: let me rephrase that with some context | 02:27 |
| rockstar | lifeless, well, it doesn't help actual performance, but it at least helps perceived performance. | 02:27 |
| rockstar | (Both should be goals of ours.) | 02:27 |
| lifeless | rockstar: we /should/ be able to deliver a page with 3000 objects in 2 seconds backend time | 02:27 |
| rockstar | lifeless, how close are we to achieving that? | 02:27 |
| lifeless | rockstar: making things that are /always/ shown loaded separately by the browser adds work to the appservers and decreases efficiency | 02:28 |
| lifeless | rockstar: so I have a bit of a kneejerk reaction against it. | 02:28 |
| lifeless | rockstar: we're moving on it; I can't put a dial on completion yet. | 02:28 |
| lifeless | rockstar: storm performance is 4 seconds on staging in a dedicated test of 3000 rows deserialisation; a profile suggested 10 seconds. | 02:28 |
| rockstar | lifeless, well, "always shown" is kinda dynamic, right? | 02:29 |
| lifeless | rockstar: we have to fix it for the appservers to fix it for apis because they are the same thing. | 02:29 |
| lifeless | rockstar: bug subscribers - always shown, loaded in separate transaction. As an example of it done in a way I don't really like. | 02:29 |
| rockstar | I mean, Facebook offloads a lot of its stuff to be done on demand, i.e. when you scroll down halfway, it thinks "oh, the user probably wants to read the newsfeed, so let's give them more of that" | 02:29 |
| lifeless | rockstar: *that* sort of on-demand I love. | 02:30 |
| lifeless | rockstar: should be able to do it today. | 02:30 |
| rockstar | lifeless, okay. thumper and I had already talked a bit about some things like that. | 02:30 |
| lifeless | did you see the google instant announcement ? | 02:30 |
| rockstar | lifeless, I've seen some Twitter traffic, but I don't know much more about it. | 02:31 |
| lifeless | typeahead searching for their main search engine | 02:31 |
| lifeless | refreshing the entire page as you type | 02:31 |
| lifeless | the instant bit is that the last character you type generally won't change the search results | 02:32 |
| lifeless | so by the time you've finished inputting, you've got a full result | 02:32 |
| rockstar | Ah, yeah. I think YUI's had some new changes to value-change that support similar things. | 02:33 |
| wallyworld_ | rockstar: linked bug changes made and committed. see my new comment re: horizontal separator. no hurry. thanks. | 03:23 |
| rockstar | wallyworld_, looking now. | 03:23 |
| wallyworld_ | rockstar: thanks. sorry about the delay. i had some bzr (pbkac) issues | 03:24 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: noodles775 || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews || gmb is RM; for RC reviews please add him as a reviewer | ||
| jtv | oh hi noodles775 :) | 07:56 |
| jtv | Just working on modernizing our template builds as well | 07:56 |
| noodles775 | jtv: Great! | 08:01 |
| jtv | Just trying to get makeJob working. | 08:01 |
| * noodles775 just merged your latest recife changes before we go offline :) | 08:02 | |
| jtv | Ah, almost time for that! | 08:02 |
| jtv | Thanks. | 08:02 |
| jtv | hi henninge | 08:02 |
| henninge | hi jtv! | 08:03 |
| jtv | noodles775: thanks for the review btw… I _would_ point you to my buildfarm work now, but Maintenance. :/ | 09:10 |
| * noodles775 breathes a sigh of relief ;) | 09:10 | |
| noodles775 | jtv: if you can paste your MP (and a diff), I can do that too :) | 09:11 |
| jtv | noodles775: the MP is at https://code.edge.launchpad.net/~jtv/launchpad/translationtemplatesbuild/+merge/34952 | 09:13 |
| noodles775 | jtv: sorry, I meant paste the text of your MP to paste.....com :) | 09:13 |
| jtv | noodles775: yes, I'm otp so a little slow sorry :) | 09:13 |
| jtv | noodles775: my diff is here: http://paste.ubuntu.com/490815/ | 09:22 |
| noodles775 | jtv: Was that a decision to allow both interfaces for TranslationTemplateBuild via ZCML (rather than having ITranslationTemplatesBuild inherit from IBuildFarmJob - like IPackageBuild does)? | 09:31 |
| jtv | noodles775: barely registered. :) I tend to avoid interface hierarchies because they can get a little confusing in combination with class hierarchies, but if that's wrong I'll happily change it. | 09:32 |
| jtv | (not that zcml can't get a little confusing…) | 09:32 |
| noodles775 | I'm not sure if its better or worse... I think of it with the question: Is the interface ITranslationTemplatesBuild also an IBuildFarmJob? I'm not fussed either, I was just surprised. | 09:33 |
| jtv | We're sort of probing the boundaries between is-a and has-a here, aren't we? | 09:34 |
| jtv | I guess in python we're doing inheritance, just not in the db—in which case perhaps I should change this after all. | 09:35 |
| noodles775 | jtv: sheesh, it'll be nice to get rid of the BFJOld stuff (and makeJob). A question, in your makeJob() method, you don't add the TTBJ to the store... am I missing something? I'm wondering if you meant to call TTBJ.create() there? | 10:09 |
| jtv | noodles775: ah good point, thanks | 10:10 |
| jtv | noodles775: ah! Actually I do add it to the store. | 10:11 |
| jtv | noodles775: in terms of db storage, the BranchJob _is_ the TTBJ | 10:11 |
| noodles775 | jtv: ah, so TTBJ isn't a storm class itself. Right. | 10:31 |
| jtv | just one more reason to clean out these stables :) | 10:31 |
| noodles775 | jtv: so r=me, assuming that you won't be landing this without further branches (ie. to ensure BFJ.getSpecificJob() works for TranslationTemplatesBuild. | 10:41 |
| noodles775 | Thanks! | 10:41 |
| jtv | noodles775: that's actually a lot more than I was hoping for, thanks! Any other points I need to cover? | 10:42 |
| noodles775 | jtv: er, you could refactor the code and get rid of IBuildFarmJobOld? ;) | 10:43 |
| noodles775 | I can't think of any other things... the above will make it self apparent when you look at current builders or builder histories after having dispatched TTBs. | 10:44 |
| noodles775 | (sorry, where "the above" is ensuring BFJ.getSpecificJob() works for the translation template builds) | 10:45 |
| jtv | OK, so I'll move on to that next then. | 10:45 |
| jtv | noodles775: since I'm being difficult today, perhaps I can interest you in yet another review? | 10:59 |
| jtv | The diff is 342 lines. It fixes bug 632880. | 11:00 |
| noodles775 | jtv: if it's non-urgent, StevenK is keen for reviews? Otherwise either myself or jelmer can take it. | 11:00 |
| jtv | StevenK: what say you? | 11:00 |
| jtv | (it's non-urgent) | 11:00 |
| StevenK | jtv: I'll take it, but not right now. | 11:01 |
| jtv | Then maybe I'll just wait until I can file a proper MP anyway | 11:01 |
| noodles775 | jtv: I think you can now? (at least, I've updated your previous one already) | 11:02 |
| jtv | oh, good | 11:02 |
| noodles775 | jtv: can you assign it to StevenK so it doesn't get gobbled up by eager reviewers ;) | 11:03 |
| jtv | OK | 11:03 |
| jtv | noodles775: just pushing my getSpecificJob branch now. | 12:22 |
| jtv | StevenK: I assigned that review to you earlier btw | 12:26 |
| jtv | noodles775: you seem to have your "reviewing" state stuck permanently on "jtv" today. I don't know whether that's optimistic, pessimistic, devoted, or simply practical. :) The getSpecificJob branch is here: https://code.edge.launchpad.net/~jtv/launchpad/buildfarmjob-getspecificjob-translationtemplatesbuild/+merge/34965 | 12:28 |
| noodles775 | heh, I just hadn't updated it. | 12:29 |
| === mrevell is now known as mrevell-lunch | ||
| === Ursinha-afk is now known as Ursinha | ||
| === matsubara-afk is now known as matsubara | ||
| === mrevell-lunch is now known as mrevell | ||
| stub | Four line diff to review if anyone is bored - https://code.edge.launchpad.net/~stub/launchpad/trivial/+merge/34948 | 13:22 |
| noodles775 | stub: done. | 14:17 |
| stub | ta | 14:17 |
| === noodles775 changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews || gmb is RM; for RC reviews please add him as a reviewer | ||
| === james_w` is now known as james_w | ||
| === rockstar changed the topic of #launchpad-reviews to: On call: rockstar || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews || gmb is RM; for RC reviews please add him as a reviewer | ||
| allenap | rockstar: Just the man :) Please can you review a very small Tarmac branch? https://code.edge.launchpad.net/~allenap/tarmac/fix-votes-copyright/+merge/34987 | 16:06 |
| rockstar | allenap, great! | 16:06 |
| allenap | rockstar: It's not very interesting though :( | 16:06 |
| rockstar | allenap, by the way, thanks for filing those bugs. | 16:08 |
| allenap | rockstar: No worries. I'll try and fix one or two of them too :) | 16:09 |
| rockstar | allenap, great. | 16:10 |
| allenap | rockstar: Thanks :) | 16:12 |
| rockstar | allenap, you keep not putting a commit message in! | 16:12 |
| allenap | rockstar: Oops, I'll add one. | 16:14 |
| rockstar | allenap, too late, I did it already. | 16:14 |
| allenap | Ah, you've done it. | 16:14 |
| rockstar | :) | 16:14 |
| === matsubara is now known as matsubara-lunch | ||
| === benji is now known as benji-lunch | ||
| bigjools | rockstar: can I grab you for some help please? | 17:29 |
| rockstar | bigjools, absolutely not. :) | 17:29 |
| rockstar | bigjools, what's up? | 17:29 |
| bigjools | http://pastebin.ubuntu.com/491088/ | 17:29 |
| bigjools | test_enabling_enabled_flag is always failing | 17:30 |
| bigjools | and I dunno why :/ | 17:30 |
| bigjools | the assertFalse fails | 17:30 |
| rockstar | bigjools, how does it fail? | 17:30 |
| bigjools | assertionError | 17:30 |
| bigjools | if I test it in launchpad.dev it all works as expected | 17:31 |
| bigjools | which means my test is borkenated | 17:31 |
| rockstar | does on/off actually work? | 17:32 |
| bigjools | yes | 17:32 |
| rockstar | Odd. I would have thought those would be bools. | 17:32 |
| bigjools | well, hmm I just lifted it from aonther test | 17:32 |
| bigjools | I changed them to True/False and it fails in exactly the same way | 17:33 |
| rockstar | bigjools, hm, that's annoying. | 17:33 |
| bigjools | lib/lp/soyuz/browser/tests/test_archive_admin_view.py was my inspiration for this test BTW | 17:33 |
| rockstar | Do DASs default to enabled? | 17:34 |
| bigjools | yes | 17:34 |
| bigjools | I did wonder about that | 17:34 |
| rockstar | bigjools, so I'm suspecting that somehow, the enabled param isn't making any difference at all. | 17:34 |
| bigjools | that's gonna be frustrating if that's the case :/ | 17:35 |
| rockstar | bigjools, what if, for grins, you manually set self.das.enabled before messing with the form values in initialize_admin_view. | 17:36 |
| * bigjools tries to get grins | 17:37 | |
| bigjools | aaand no difference :/ | 17:37 |
| bigjools | well - depending on how I set it affects which test fails :) | 17:38 |
| rockstar | bigjools, can't you say "self.das.enabled = enabled" right before the "if enabled:" | 17:42 |
| rockstar | I suspect that form setting stuff isn't working the way one would expect it to. | 17:42 |
| bigjools | I expect the same | 17:42 |
| bigjools | so obviously that made it pass | 17:43 |
| bigjools | now, wtf is up with the form :/ | 17:44 |
| rockstar | bigjools, yeah, so what we suspected is correct. | 17:44 |
| bigjools | rockstar: I have to finish for the day now, I'll try and grab someone tomorrow to fix it, unless you feel the urge to dive in in my absence | 17:48 |
| === Ursinha is now known as Ursinha-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === benji-lunch is now known as benji | ||
| === matsubara-lunch is now known as matsubara | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === deryck[lunch] is now known as deryck | ||
| thumper | rockstar: https://code.edge.launchpad.net/~thumper/launchpad/deleting-individual-branch-revisions/+merge/34943 | 21:28 |
| * thumper runs kids to school | 21:28 | |
| rockstar | thumper, on the phone with abentley | 21:28 |
| lifeless | rockstar: hi | 22:56 |
| lifeless | rockstar: are you still OCR? | 22:57 |
| lifeless | rockstar: if so, https://code.edge.launchpad.net/~lifeless/launchpad/oops/+merge/35044 | 22:57 |
| === matsubara is now known as matsubara-afk | ||
| lifeless | mwhudson: thumper: ^ its 6 added lines, no mods | 23:07 |
| mwhudson | lifeless: otp | 23:07 |
| thumper | lifeless: chasing critical thingy | 23:07 |
| thumper | lifeless: but I'll look | 23:08 |
| thumper | because I'm awesome | 23:08 |
| === Ursinha is now known as Ursinha-afk | ||
| lifeless | no tests because it would be noddy | 23:10 |
| lifeless | like testing that a for loop iterates | 23:10 |
| thumper | lifeless: done | 23:11 |
| lifeless | thanks | 23:11 |
| sinzui | lifeless, ping | 23:27 |
| sinzui | lifeless, can you review my word press theme hack: https://code.edge.launchpad.net/~sinzui/launchpad-news-wordpress-theme/escape-from-monkeys/+merge/35046 | 23:28 |
| sinzui | thumper, ^ maybe you can take a minute to look at the MP. | 23:30 |
| lifeless | sinzui: done | 23:33 |
| lifeless | sinzui: I know nothing about wp but the method name seems sensible | 23:33 |
| sinzui | lifeless, I spent too many hours remembering how to install moin and wp today. the good news is now that I have working instances, I can fix the styles so that behave more like the main sites | 23:34 |
| lifeless | o/ | 23:35 |
| thumper | https://code.edge.launchpad.net/~thumper/launchpad/scanner-permissions/+merge/35048 | 23:52 |
| mwhudson | thumper: approved | 23:55 |
| thumper | mwhudson: thanks | 23:55 |
| thumper | OH FFS | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
