/srv/irclogs.ubuntu.com/2010/09/12/#launchpad-reviews.txt

=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219, https://code.edge.launchpad.net/~lifeless/launchpad/memcache/+merge/35220] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== wgrant_ is now known as wgrant
=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219, https://code.edge.launchpad.net/~lifeless/launchpad/memcache/+merge/35220, https://code.edge.launchpad.net/~lifeless/launchpad/test/+merge/35224] || This channel is logged: http://irclogs.ubuntu.com/
=== Ursinha is now known as Ursinha-afk
lifelessmorning20:24
lifelessI can has review?20:58
* mwhudson stabs xchat's url-finding 22:27
mwhudsonlifeless: which is the most urgent of the reviews?22:27
lifelessthey're all basically tiny; any of them would be great to have reviewed.22:27
lifelesstest is trivial - bare except -> not bare except22:27
mwhudsonah, so the reviews are not related to the fire?22:28
lifelessno22:28
lifelessI'm just pouncing22:28
mwhudsonheh22:28
mwhudsoni need to persuade someone to fix the ath9k drivers, then my arrival in the morning will be less obvious22:29
lifelessmwhudson: actually, it was saying 'hi' that tipped me off22:30
lifelessthanks for test approval, to make ec2 land happy could you click on 'comment' change to 'approved', click in the text field, click on 'save commnt' ?22:49
mwhudsonlifeless: i did, and it timed out :-)22:50
lifelesshah22:51
lifelessyes, waiting for a gsa/losa to appear22:51
mwhudsoni think it took the second time22:51
lifelesselmo is trained22:51
lifelessby which I mean, a train is messing with his bandwidth22:51
mwhudsonah22:51
mwhudsonlifeless: in https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219 i don't really understand the comment22:57
mwhudson"features have two homes" -> i don't see how the request home matters here?22:57
lifelessif you use LaunchpadTestRequest22:58
lifelessand create_initialized_view22:58
lifelessand the code you are calling calls into getFeatureFlag22:58
lifelessit all goes boom22:58
lifelessbecause nothing glues the two things together.22:58
lifelesswhat needs to happen is:23:01
lifeless - the thread local should die23:02
lifeless - it should be found via participations23:02
lifeless - login() and scripts should set participations up23:02
lifelessits another case of building on mud.23:02
mwhudsoni see23:05
lifelessthe problem is that there are lots of tests that do stuff outside of publication23:05
lifelessor even outside of views23:06
lifelessso using that as the place to set/remove the thread local won't work well23:06
mwhudsonlifeless: would it more appropriate to say something like "feature flags really should live on the request, but currently don't for reasons as stated in bug 623199" ?23:06
lifelessI don't konw.23:06
mwhudsons/request/participation/ i guess23:06
lifelessI think what I've written is correct without specifying /where/ etc : and its easier to change our mind in a bug than in the comments in the code23:07
mwhudsonotoh, it's very likely that the next person to edit this code will be you and you can figure it out then :)23:07
lifelessthats true too23:07
lifelessI'm happy to change it, I don't see that it makes a lot of difference either way.23:07
lifelessI looked at zope.app.testing.functional.FunctionalTestSetup23:08
lifelesszomg23:08
lifelessits -terrible-23:08
mwhudsonlifeless: for the pageid feature thing, i don't see how pageid is ever set to stuff like scoped:thing#type23:11
lifelesscheck out api publication23:11
mwhudsoni am23:11
lifelessservers.py23:13
lifelessno, sec23:14
lifelesshttps://code.edge.launchpad.net/~matsubara/launchpad/bug-606184-pageid-for-collections/+merge/3380123:16
lifelessis what landed23:17
lifeless'FakeContext:FakeCollectionResourceView:#milestone-page-resource'23:17
lifelessis an example23:17
lifelessso its :#23:17
mwhudsonah23:18
lifelesswhich my code will handle because it elides empty segments23:18
lifeless(but I knew there was a good reason)23:18
lifelesssee also https://bugs.edge.launchpad.net/launchpad-foundations/+bug/62702723:18
mwhudsonah ok23:19
mwhudsonthere are no tests of the empty segment handling23:19
lifelessyes23:19
lifelessI shall add one for that example pageid23:19
lifelessactually there are tests of empty segment handling23:20
lifelesspageid:23:20
lifeless-> ['']23:20
lifelesswithout the empty segment code23:20
lifelesse.g. tests will fail if you remove the 'if name' clause23:20
mwhudsoni guess23:20
mwhudsonthat's not very test as documentation though23:20
lifelessyes23:20
lifelessI shall add one23:21
lifelessjust saying :)23:21
mwhudsonok23:21
* mwhudson stares at an ajax spinner thing23:23
mwhudsonthird time lucky, sigh23:27
=== mwhudson changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
lifelessthanks!23:28
mwhudsonhuh, https://code.edge.launchpad.net/launchpad/+activereviews just got truncated on me23:31
lifelessyaup23:32
mwhudsonhuh, googling "truncated haproxy" finds some interesting stuff23:33
mwhudsoni guess you're ahead of me on that game though :-)23:33
lifelessif there were specific ones that would be good23:35
lifelesshowever http/1.0 and truncation is a designed in 'feature' ><23:35
mwhudsonlifeless: well http://www.mail-archive.com/haproxy@formilux.org/msg02145.html23:35
lifelessheh, thats a bug indeed23:37

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!