=== lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219, https://code.edge.launchpad.net/~lifeless/launchpad/memcache/+merge/35220] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === wgrant_ is now known as wgrant === lifeless changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [https://code.edge.launchpad.net/~lifeless/launchpad/features/+merge/35217, https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219, https://code.edge.launchpad.net/~lifeless/launchpad/memcache/+merge/35220, https://code.edge.launchpad.net/~lifeless/launchpad/test/+merge/35224] || This channel is logged: http://irclogs.ubuntu.com/ === Ursinha is now known as Ursinha-afk [20:24] morning [20:58] I can has review? [22:27] * mwhudson stabs xchat's url-finding [22:27] lifeless: which is the most urgent of the reviews? [22:27] they're all basically tiny; any of them would be great to have reviewed. [22:27] test is trivial - bare except -> not bare except [22:28] ah, so the reviews are not related to the fire? [22:28] no [22:28] I'm just pouncing [22:28] heh [22:29] i need to persuade someone to fix the ath9k drivers, then my arrival in the morning will be less obvious [22:30] mwhudson: actually, it was saying 'hi' that tipped me off [22:49] thanks for test approval, to make ec2 land happy could you click on 'comment' change to 'approved', click in the text field, click on 'save commnt' ? [22:50] lifeless: i did, and it timed out :-) [22:51] hah [22:51] yes, waiting for a gsa/losa to appear [22:51] i think it took the second time [22:51] elmo is trained [22:51] by which I mean, a train is messing with his bandwidth [22:51] ah [22:57] lifeless: in https://code.edge.launchpad.net/~lifeless/launchpad/bug-631884/+merge/35219 i don't really understand the comment [22:57] "features have two homes" -> i don't see how the request home matters here? [22:58] if you use LaunchpadTestRequest [22:58] and create_initialized_view [22:58] and the code you are calling calls into getFeatureFlag [22:58] it all goes boom [22:58] because nothing glues the two things together. [23:01] what needs to happen is: [23:02] - the thread local should die [23:02] - it should be found via participations [23:02] - login() and scripts should set participations up [23:02] its another case of building on mud. [23:05] i see [23:05] the problem is that there are lots of tests that do stuff outside of publication [23:06] or even outside of views [23:06] so using that as the place to set/remove the thread local won't work well [23:06] lifeless: would it more appropriate to say something like "feature flags really should live on the request, but currently don't for reasons as stated in bug 623199" ? [23:06] I don't konw. [23:06] s/request/participation/ i guess [23:07] I think what I've written is correct without specifying /where/ etc : and its easier to change our mind in a bug than in the comments in the code [23:07] otoh, it's very likely that the next person to edit this code will be you and you can figure it out then :) [23:07] thats true too [23:07] I'm happy to change it, I don't see that it makes a lot of difference either way. [23:08] I looked at zope.app.testing.functional.FunctionalTestSetup [23:08] zomg [23:08] its -terrible- [23:11] lifeless: for the pageid feature thing, i don't see how pageid is ever set to stuff like scoped:thing#type [23:11] check out api publication [23:11] i am [23:13] servers.py [23:14] no, sec [23:16] https://code.edge.launchpad.net/~matsubara/launchpad/bug-606184-pageid-for-collections/+merge/33801 [23:17] is what landed [23:17] 'FakeContext:FakeCollectionResourceView:#milestone-page-resource' [23:17] is an example [23:17] so its :# [23:18] ah [23:18] which my code will handle because it elides empty segments [23:18] (but I knew there was a good reason) [23:18] see also https://bugs.edge.launchpad.net/launchpad-foundations/+bug/627027 [23:19] ah ok [23:19] there are no tests of the empty segment handling [23:19] yes [23:19] I shall add one for that example pageid [23:20] actually there are tests of empty segment handling [23:20] pageid: [23:20] -> [''] [23:20] without the empty segment code [23:20] e.g. tests will fail if you remove the 'if name' clause [23:20] i guess [23:20] that's not very test as documentation though [23:20] yes [23:21] I shall add one [23:21] just saying :) [23:21] ok [23:23] * mwhudson stares at an ajax spinner thing [23:27] third time lucky, sigh === mwhudson changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ [23:28] thanks! [23:31] huh, https://code.edge.launchpad.net/launchpad/+activereviews just got truncated on me [23:32] yaup [23:33] huh, googling "truncated haproxy" finds some interesting stuff [23:33] i guess you're ahead of me on that game though :-) [23:35] if there were specific ones that would be good [23:35] however http/1.0 and truncation is a designed in 'feature' >< [23:35] lifeless: well http://www.mail-archive.com/haproxy@formilux.org/msg02145.html [23:37] heh, thats a bug indeed