[01:37] <lifeless> anyone up for : https://code.launchpad.net/~lifeless/launchpad/registry/+merge/35354
=== Ursinha-brb is now known as Ursinha-afk
[02:24] <lifeless> thumper: ^
[02:30] <wallyworld_> https://code.edge.launchpad.net/~wallyworld/launchpad/tales-linkify-broken-links/+merge/35268
[02:30] <thumper> lifeless: got a few minutes to chat?
[02:30] <wallyworld_> thumper: ^^^ as requested, for when you have time later
[02:31] <thumper> wallyworld_: ack
[02:33] <lifeless> lib/lp/scripts/utilities/pageperformancereport.py
[02:34] <lifeless> lib/lp/services/timeline/timedaction.py
[02:34] <lifeless> see the _td_to_ms function
[02:35] <lifeless> td.microseconds + (td.seconds + td.days * 24 * 3600) * 10**6) / 10**6)
[02:35] <lifeless> array = numpy.asarray(times, numpy.float32)
[02:35] <lifeless> blah
[02:46] <lifeless> thumper: select * from pg_catalog.pg_locks ;
[05:56] <lifeless> https://code.edge.launchpad.net/~lifeless/launchpad/oops/+merge/35363
[05:56] <lifeless> this will fix an operational issue
[05:57] <lifeless> thumper: ^ I want a release-critical from you please
[05:57] <lifeless> mwhudson: can you perhaps review? its tiny
[05:59] <mwhudson> lifeless: not easy to test this?
[06:00] <lifeless> mwhudson: easy enough but its a noddy test: its structurally unsound and I'm going to fix that in a non-getting-cowboyed branch
[06:00] <mwhudson> ok
[06:00] <lifeless> mwhudson: the structural fix will have tests that any number of tracers stacked always enter-and-exit
[06:01] <mwhudson> lifeless: approved, and i voted and everything
[06:01] <lifeless> thanks!
[06:18] <lifeless> thumper: ping
[06:18] <lifeless> mwhudson: https://code.edge.launchpad.net/~lifeless/launchpad/cp/+merge/35364 - same thing, prod version, if you'd be so kind
[06:19] <lifeless> thumper: ^ thats the one that needs release-critical
[06:24] <mwhudson> heh, missed my chance
[06:24] <lifeless> mwhudson: no, its still open ;P
[06:25] <mwhudson> ok
[06:25] <mwhudson> done
[06:25] <lifeless> thanks
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: bdmurray || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: thumper || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: deryck || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:15] <jtv> gmb: I have a big one—do you think you can take it?
[12:15] <jtv> https://code.edge.launchpad.net/~jtv/launchpad/536819-display/+merge/35085
[12:16] <jtv> I'm so exhausted that I couldn't produce a good cover letter for it; but I can answer questions on IRC.
[12:17] <jtv> (It's sometimes frustrating work)
[12:50] <gmb> jtv, Sure. Give me a couple of minutes and I'll take a look.
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: lunch || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[12:52] <jtv> gmb: great, thanks
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
[13:25] <adeuring> gmb: can I add this branch to your queue: https://code.edge.launchpad.net/~adeuring/launchpad/bug-615763/+merge/35394 ?
[13:25] <gmb> adeuring, Sure
[13:25] <adeuring> gmb: thanks!
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: jtv || queue: [adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:30] <gmb> jtv, code r=me. Nice work :).
[13:30] <jtv> gmb: *blush* thanks  :)
[13:30] <gmb> jtv, This needs a UI review too, doesn't it?
[13:31] <jtv> gmb: hmm I guess… there's not much there, but yes
[13:31] <gmb> Yeah, better safe than sorry.
[13:31] <gmb> Also, I have the UI reviewing skills of a rubber bulldog.
[13:31] <jtv> noodles775: is that something you could do?  UI-review the page for a TranslationTemplatesBuild?
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:32] <noodles775> jtv: I can if henninge doesn't want it?
[13:32] <jtv> that's a thought
[13:32] <jtv> not as familiar with build farm, but he might like the practice
[13:32] <henninge> practice is good
[13:33] <noodles775> Yeah, I'll wait for him to let...
[13:33] <noodles775> :)
[13:33] <jtv> :)
[13:33] <jtv> henninge: hang on, I'll see how to get you a snapshot
[13:33] <henninge> jtv: that would be great
[13:48] <gmb> adeuring, r=me
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[13:52] <jtv> henninge: still putting together that UI snapshot
[13:53] <adeuring> gmb: thanks!
[13:53] <henninge> jtv: I am patient ;)
[14:00] <sinzui> salgado, do you have time fora UI review of https://code.edge.launchpad.net/~brian-murray/launchpad/limited-subscriptions-page/+merge/35177
[14:02] <salgado> sinzui, I was on leave for most of the last 3 days, so I'm still catching up with things. if that's the only UI review I have then I certainly have time, but if I already have others in my queue, then I don't think I will.  let me check
[14:03] <salgado> sinzui, I have another one from deryck, so I'd rather not do this one
[14:03] <deryck> Hi salgado.  Was just about to ping you about that actually.
=== mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:04] <salgado> deryck, I'll get to it soon. :)
[14:05] <deryck> salgado, no worries. :-)  Not in a hurry, just wanted to make sure you saw I requested from you.
[14:08] <mars> gmb, ping, would you be willing to review a branch I have for the qa-tagger project?  It closely follows the LP code conventions
[14:09] <gmb> mars, Sure, in about 20 minutes or so, if that's okay.
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [mars] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:09] <sinzui> salgado, deryck, bdmurray, henninge: I will certainly do UI reviews. We are giving trainees every opportunity to get experience. rockstar and I can do an urgent UI review immediately.
[14:09] <mars> gmb, that sounds great to me, and thanks for taking it.  Here is the MP: https://code.launchpad.net/~mars/qa-tagger/deployment-summaries/+merge/35093
[14:10] <deryck> mine isn't urgent, but thanks for the notice sinzui
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: mars || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:35] <jtv> henninge: here's how to review the TranslationTemplatesBuild page.  Bear in mind that I'm heavily constrained by the architectural possibilities at the moment (not to mention the branch limit).
[14:35] <jtv> http://paste.ubuntu.com/493645/
[14:40] <gmb> mars, On line 324 of the diff you need to indent the ]. Other than that, r=me :)
[14:41] <mars> gmb, cool, thank you very much.
[14:41] <mars> gmb, you wouldn't happen to have time for the follow-up branch to this one?  Another qa-tagger branch that builds on the DeploymentSummary work.
[14:42] <mars> bzr pipeline rocks
[14:42] <mars> split the work into three 500-line branches
[14:42] <mars> beautiful
[14:44] <gmb> mars, Sure.
[14:45] <mars> gmb, thanks!  Here is the branch that builds on it: https://code.launchpad.net/~mars/qa-tagger/report-contents/+merge/35103
[14:46]  * gmb looks
[14:55] <gmb> mars, Is there any reason to define a function in the template? I'm not familiar with qa-tagger so I don't know if that's acceptable.
[14:56] <henninge> jtv: argh!
[14:56] <mars> gmb, in this case it is acceptable.  I use the template function to produce a list of <a> tags - I don't want to write HTML in the Python file
[14:56] <jtv> henninge: argh?
[14:56] <henninge> jtv: I am sorry I cannot run that at the moment ... ;(
[14:56] <gmb> mars, Fair enough. I'm just not familiar with that pattern :)
[14:56] <henninge> I have to fix my LP first ...
[14:56] <jtv> henninge: maverick?
[14:56] <henninge> yup
[14:56] <jtv> maverick
[14:57] <jtv> I knew an Ubuntu release with _two_ animals for a name could be no good
[14:57] <henninge> jtv: actually, it is psycopg and our code
[14:57] <gmb> mars, r=me
[14:58] <jtv> henninge: I'll land what I have then as per procedure, and any UI chances you come up with can go into a separate branch.  These 3 are big enough already, and blocking people.
[14:58] <mars> gmb, great, thank you for the reviews
[14:58] <henninge> jtv: fine by me
[14:58] <gmb> np
=== gmb changed the topic of #launchpad-reviews to: On call: gmb || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[14:58] <henninge> jtv: sorry for the delay
[14:58] <jtv> hi ho, hi ho, to ec2 I go
=== mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:10] <henninge> jtv: your branch is running here now, looking
[15:10] <jtv> cool
=== noodles775 changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: - || queue: [noodles775] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:12] <noodles775> Hi gmb,mars: if either of you have time: https://code.edge.launchpad.net/~michael.nelson/launchpad/635005-difference-details-1/+merge/35408
[15:13] <mars> looking
[15:13] <noodles775> Thanks.
=== mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:14] <noodles775> mars: I just updated the descripton with a link to the LEP and the mockup UI.
[15:14] <mars> ok
[15:19] <mars> noodles775, nice idea for the demo harness script - that is a  neat trick
[15:19] <noodles775> mars: thanks - I usually need to create it for myself anyway, so it's easy to include (when the setup is a bit complicated).
[15:20] <mars> that is a really useful pattern.  I wonder if anyone else uses this trick too?
[15:21] <mars> the script is kind of like "turn on feature FOO and add sample data BAR"
[15:21] <mars> so it is great for acceptance testing
[15:21] <mars> a demo script
[15:22] <noodles775> oh right, I'd forgot about the feature flag - yes, that makes a script useful even when the sample data setup is trivial - until we have a UI for feature flags :) ).
[15:23] <mars> even then, I think it is really useful
[15:24] <mars> there is a switch to Python, and hopefully iharness, that lets you load scripts on startup
[15:24] <noodles775> ah, nice.
[15:25] <mars> so if you have a demo script, you might be able to just do "bin/harness -m demo-feature.py"
[15:25] <jtv> Can someone remind me what the current process for database reviews and patch number assignment was again?
[15:26] <mars> gmb or noodles775, you two hack on models - maybe you would know the answer to jtv's question?
[15:26] <noodles775> jtv: https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess is pretty up to date.
[15:26] <jtv> noodles775: ah great, thanks
[15:27] <noodles775> mars: bin/harness -m `wget http://paste....` or similar would be nice (save the person downloading it etc., given it's not in the branch)
[15:27] <mars> interesting
[15:28] <mars> I think you need to use -s or -c for that
[15:28] <mars> python --help
[16:03] <mars> noodles775, looks great, r=mars
[16:03] <noodles775> Thanks mars
=== mars changed the topic of #launchpad-reviews to: On call: gmb, mars || Reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: lunch || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== benji is now known as benji-lunch
=== matsubara is now known as matsubara-lunch
=== Ursinha is now known as Ursinha-lunch
=== Ursinha-lunch is now known as Ursinha
=== matsubara-lunch is now known as matsubara
=== benji-lunch is now known as benji
=== leonardr is now known as leonardr-away
=== leonardr-away is now known as leonardr
=== mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[20:14] <jcsackett> salgado, sinzui: i've pushed up everything i think needs doing per my active review, along with incrementals and some comments.
[20:14] <sinzui> thank. I will get to in in 45 minutes.
[20:15] <jcsackett> sinzui: sounds good; i need to get lunch anyhow, so there's no huge rush on my part. :-)
[20:31] <bdmurray> mars: https://code.edge.launchpad.net/~brian-murray/launchpad/subscribe-oops-bug-636412/+merge/35459 could use review and it might actually need a ui review
[20:32] <mars> bdmurray, certainly, I can review that
[20:32] <mars> bdmurray, I suggest asking sinzui to suggest an appropriate UI reviewer - a student or himself
=== mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [bdmurray] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: bdmurray || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:16] <mars> bdmurray, ping
[21:17] <bdmurray> mars: heya
[21:17] <mars> Hi bdmurray, I had a question about your branch
[21:18] <mars> You added a storyin bugs/stories
[21:18] <mars> but IIRC the bugs team was working to kill all doctests in their app
[21:18] <mars> it made me wonder if this branch should be using unit tests instead of doctests?
[21:21] <bdmurray> mars: this is the test that deryck pointed me at when we were talking about testing this
[21:21] <bdmurray> 08:39 < deryck> bdmurray, as for tests, see  lp.bugs.stories.structural-subscriptions.xx-bug-subscriptions,txt
[21:21] <mars> ah, ok, that's fine then.  Just wanted to make sure
[21:21] <bdmurray> 08:39 < deryck> I think this will fail with the new change, but if not, the change  should be accounted for there.
[21:22] <mars> bdmurray, thanks
=== mars changed the topic of #launchpad-reviews to: On call: mars || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:44] <bdmurray> sinzui: I've a couple branchs that could use UI review
[21:44] <sinzui> bdmurray I have been giving salgado and henninge a chance to review first. I can review any that really needs to be done now
[21:45] <bdmurray> sinzui: ah, I've one that will end up as a cherry-pick so doing it soon would be great - https://code.edge.launchpad.net/~brian-murray/launchpad/subscribe-oops-bug-636412/+merge/35459
[21:46] <sinzui> I am looking now
=== ajmitch_ is now known as ajmitch
[22:16] <sinzui> bdmurray. I am a bit concerned. I see you changes, but I can subscribe to ubuntu (https://bugs.launchpad.dev/ubuntu/+subscribe) as Sample Person and Foo Bar in dev
[22:16] <sinzui> bdmurray is this because Ubuntu in dev does not have a supervisor?
[22:18] <bdmurray> sinzui: yes that is correct
[22:18]  * sinzui sets supervisor
[22:21] <sinzui> bdmurray r=me , I will approve the mp
[22:22] <bdmurray> sinzui: great, thanks
[22:57] <jcsackett> salgado: ping
[23:07] <jcsackett> nm. i'll try and get in touch tomorrow.
=== mars changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-afk