| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| bac | #startmeeting | 15:01 |
|---|---|---|
| MootBot | Meeting started at 09:01. The chair is bac. | 15:01 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:01 |
| bac | who is here today? | 15:01 |
| sinzui | me | 15:01 |
| sinzui | just me? | 15:01 |
| henninge | me, too | 15:01 |
| bac | me too | 15:01 |
| bac | us | 15:01 |
| abentley | me | 15:01 |
| noodles775 | me | 15:01 |
| mars | me | 15:01 |
| jelmer | me | 15:01 |
| bigjools | me | 15:01 |
| adeuring | me | 15:01 |
| deryck | me | 15:01 |
| leonardr | me | 15:02 |
| danilos | me | 15:02 |
| bac | EdwinGrubbs: ping | 15:02 |
| bac | [topic] agenda | 15:03 |
| MootBot | New Topic: agenda | 15:03 |
| bac | == Agenda == | 15:03 |
| bac | * Roll call | 15:03 |
| bac | * Agenda | 15:03 |
| bac | * Outstanding actions | 15:03 |
| bac | * New topics | 15:03 |
| bac | * Mentat update. | 15:03 |
| bac | * https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? | 15:03 |
| gmb | me | 15:03 |
| bac | * Peanut gallery | 15:03 |
| EdwinGrubbs | me | 15:03 |
| bac | [topic] Outstanding actions | 15:04 |
| MootBot | New Topic: Outstanding actions | 15:04 |
| bac | * bac and lifeless to chat about branch size and (possibly) new metric. | 15:04 |
| bac | this has not happened. i'll start the conversation today. | 15:04 |
| bac | [topic] Mentat update. | 15:05 |
| MootBot | New Topic: Mentat update. | 15:05 |
| sinzui | Be sure to ask henninge and salgado for UI reviews | 15:05 |
| henninge | it's happening | 15:06 |
| bac | stevenk still lacks reviews. his shift is AsiaPac Wednesday, so if you can assign non-urgent reviews to him, please do | 15:06 |
| bac | salgado are you getting any UI reviews | 15:06 |
| mars | bac, leonardr and I can let the queue fill up | 15:06 |
| salgado | yes | 15:07 |
| bac | mars: that is very selfless of you. thanks. :) | 15:07 |
| leonardr | heh | 15:07 |
| bac | salgado, henninge: great | 15:07 |
| bac | note that allenap is back on the reviewer rotation on thursdays. welcome back gavin. | 15:08 |
| allenap | bac: Thank you. Obviously not up on the reviewer meeting schedule just yet. Me :) | 15:08 |
| bac | we've got really good coverage now, fully staffed for eu and americas | 15:09 |
| bac | [topic] https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? | 15:09 |
| MootBot | New Topic: https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? | 15:09 |
| bac | i mentioned this last week at lifeless' request. | 15:10 |
| bac | you'll see that he sent out an email expanding the topic a little more | 15:10 |
| bac | please do read the wiki page and try to think about these issues when giving and receiving a review | 15:10 |
| abentley | bac, Is code review the right time for this? Shouldn't architectural issue be dealt with before implementations? | 15:10 |
| bac | abentley: yes, they should be dealt with before | 15:11 |
| deryck | I think asking about performance in code reviews is useful, though. query counts, impact of adding code, etc. | 15:11 |
| bac | abentley: but they can still be addressed in the review, if issues are seen | 15:12 |
| bac | lifeless is doing a good job of reading all reviews and responding to many. his questions in those follow-up reviews are a good example. | 15:13 |
| abentley | bac, it drives me nuts when he does that. | 15:13 |
| bac | i realize this is all a bit hand-wavy to ask that "the launchpad values for good code" be a part of the review and am stumped as to how to make it more concrete | 15:13 |
| abentley | bac, if you're going to take the trouble of critiquing the code, you should do a review. | 15:13 |
| bac | abentley: yes, it can be frustrating. but i find he often raises good points i or my reviewer missed | 15:14 |
| abentley | bac, I've see lots of cases where he did it before the initial review, and just did it as a comment. | 15:15 |
| bac | abentley: ah, i have not seen that. | 15:15 |
| bac | abentley: in that case you have a good point and i'll bring it up this evening | 15:16 |
| bac | [topic] other stuff. any one? | 15:16 |
| MootBot | New Topic: other stuff. any one? | 15:16 |
| bac | going once | 15:17 |
| bac | going twice | 15:17 |
| bac | #endmeeting | 15:17 |
| MootBot | Meeting finished at 09:17. | 15:17 |
| henninge | thanks bac | 15:17 |
| bac | thanks for coming. | 15:17 |
| === benji is now known as benji-lunch | ||
| === benji-lunch is now known as benji | ||
| benji | leonardr: first thought: use mechanize instead of testbrowser | 16:34 |
| benji | heh | 16:34 |
| === benji is now known as benji-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === Ursinha is now known as Ursinha-lunch | ||
| === benji-lunch is now known as benji | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === salgado-lunch is now known as salgado | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!