=== mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [15:01] #startmeeting [15:01] Meeting started at 09:01. The chair is bac. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] who is here today? [15:01] me [15:01] just me? [15:01] me, too [15:01] me too [15:01] us [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:02] me [15:02] me [15:02] EdwinGrubbs: ping [15:03] [topic] agenda [15:03] New Topic: agenda [15:03] == Agenda == [15:03] * Roll call [15:03] * Agenda [15:03] * Outstanding actions [15:03] * New topics [15:03] * Mentat update. [15:03] * https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? [15:03] me [15:03] * Peanut gallery [15:03] me [15:04] [topic] Outstanding actions [15:04] New Topic: Outstanding actions [15:04] * bac and lifeless to chat about branch size and (possibly) new metric. [15:04] this has not happened. i'll start the conversation today. [15:05] [topic] Mentat update. [15:05] New Topic: Mentat update. [15:05] Be sure to ask henninge and salgado for UI reviews [15:06] it's happening [15:06] stevenk still lacks reviews. his shift is AsiaPac Wednesday, so if you can assign non-urgent reviews to him, please do [15:06] salgado are you getting any UI reviews [15:06] bac, leonardr and I can let the queue fill up [15:07] yes [15:07] mars: that is very selfless of you. thanks. :) [15:07] heh [15:07] salgado, henninge: great [15:08] note that allenap is back on the reviewer rotation on thursdays. welcome back gavin. [15:08] bac: Thank you. Obviously not up on the reviewer meeting schedule just yet. Me :) [15:09] we've got really good coverage now, fully staffed for eu and americas [15:09] [topic] https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? [15:09] New Topic: https://dev.launchpad.net/ArchitectureGuide as per the epic - will reviewers please start discussing the values and metrics during reviews? [15:10] i mentioned this last week at lifeless' request. [15:10] you'll see that he sent out an email expanding the topic a little more [15:10] please do read the wiki page and try to think about these issues when giving and receiving a review [15:10] bac, Is code review the right time for this? Shouldn't architectural issue be dealt with before implementations? [15:11] abentley: yes, they should be dealt with before [15:11] I think asking about performance in code reviews is useful, though. query counts, impact of adding code, etc. [15:12] abentley: but they can still be addressed in the review, if issues are seen [15:13] lifeless is doing a good job of reading all reviews and responding to many. his questions in those follow-up reviews are a good example. [15:13] bac, it drives me nuts when he does that. [15:13] i realize this is all a bit hand-wavy to ask that "the launchpad values for good code" be a part of the review and am stumped as to how to make it more concrete [15:13] bac, if you're going to take the trouble of critiquing the code, you should do a review. [15:14] abentley: yes, it can be frustrating. but i find he often raises good points i or my reviewer missed [15:15] bac, I've see lots of cases where he did it before the initial review, and just did it as a comment. [15:15] abentley: ah, i have not seen that. [15:16] abentley: in that case you have a good point and i'll bring it up this evening [15:16] [topic] other stuff. any one? [15:16] New Topic: other stuff. any one? [15:17] going once [15:17] going twice [15:17] #endmeeting [15:17] Meeting finished at 09:17. [15:17] thanks bac [15:17] thanks for coming. === benji is now known as benji-lunch === benji-lunch is now known as benji [16:34] leonardr: first thought: use mechanize instead of testbrowser [16:34] heh === benji is now known as benji-lunch === salgado is now known as salgado-lunch === Ursinha is now known as Ursinha-lunch === benji-lunch is now known as benji === Ursinha-lunch is now known as Ursinha === salgado-lunch is now known as salgado === Ursinha is now known as Ursinha-afk