[00:34] <kees> ogasawara: looks like -22.32 is missing the guard page change
[00:58] <ogasawara> kees: hrm, were there additional patches besides the one I mentioned earlier?
[02:45] <undriedsea> Hi everyone, I'm having a problem with a kernel module crashing when I attempt to modify the system call table. Which would be expected, except that I have made its page in memory writable before attempting this feat. Any ideas would be very much appreciated :) http://codepad.org/W3ThQbb8
[02:50] <AceLan_> undriedsea: wow, interesting
[02:51] <undriedsea> lol, are you being sarcastic Ace? I know its not terribly complex, but it has me stumped
[02:52] <AceLan_> undriedsea: no, I never thought of you can modify sys_call_table by that way
[02:52] <jk-> undriedsea: are you just trying to catch calls to sys_open?
[02:53] <undriedsea> yes, but this is just a test. I have a bunch of system calls I need to hook into at a low level. LD linking is not good enough for me because apps could call the syscall directly and not use the C lib, and I need to handle that
[02:54] <lifeless> undriedsea: there is a runtime patching system for the kernel some US guys wrote a few years back; they do this sort of thing and much more complex too - have a look into that
[02:54] <jk-> are you looking to modify the syscall's behaviour, or just monitor it?
[02:55] <undriedsea> in this test I am monitoring. I will be changed the behavior
[02:55] <undriedsea> *changing 
[02:55] <undriedsea> I will take a look at that lifeless. I still, for my own sake, would really like to understand why my code does not work
[02:57] <jk-> undriedsea: also, you can still do this in userspace via ptrace()
[02:58] <undriedsea> thanks jk, I thought about that, but for the project the context switch overhead would kill performance
[03:00] <undriedsea> I realize this is the old/dirty way to intercept a syscall, but it is also very fast- and I can't think of why that code does not work. However, I must confess- I have not spent much time with this kernel 
[03:01] <jk-> undriedsea: so what's the oops message you're seeing?
[03:01] <undriedsea> Sep 16 19:51:02 kdev kernel: [  145.012726] BUG: unable to handle kernel paging request at ffffffff81551390
[03:01] <undriedsea> that is the address of the system call table
[03:02] <undriedsea> or actually sys_call_table[__NR_open]
[03:02] <jk-> could you paste the rest of the log?
[03:03] <jk-> err, pastebin, not paste in the chan
[03:03] <undriedsea> sure http://codepad.org/O01qFsdz
[03:04] <undriedsea> Thank you for bothering to take a look :)
[03:05] <jk-> and what's the instruction at init_module+0x51 ?
[03:06] <jk-> (could you pastebin a disassembly of init_module?)
[03:06] <AceLan_> undriedsea: I got BUG: at set_memory_rw() function call
[03:06] <AceLan_> undriedsea: not OOPS
[03:07] <undriedsea> that is interesting, what is your platform? I am amd64
[03:07] <undriedsea> Also, did you change the sys_call_table address to match your own system AceLan?
[03:07] <jk-> AceLan_: yeah, it's probably bugging in change_page_attr_set_clr, because the page address is not page-aligned
[03:08] <AceLan_> undriedsea: a normal i386 kernel
[03:08] <undriedsea> jk, can I use hexdump to do that?
[03:08] <AceLan_> undriedsea: sure, I changed the address
[03:08] <jk-> undriedsea: objdump -d 
[03:08] <jk-> undriedsea: you're probably seeing that WARN_ON_ONCE too
[03:09] <undriedsea> jk: the dump http://codepad.org/FcHuSS0c
[03:10] <undriedsea> jk: do I need to make sure my call to set_memory_rw is 4k aligned?
[03:12] <jk-> undriedsea: it should be, but that's not what's causing the oops
[03:12] <jk-> also, are you sure that this disassembly matches the module that you inserted to cause this oops?
[03:13] <undriedsea> Maybe- I ran that objdump on the .o, should it have been on the .ko ? (n00b sorry...)
[03:13] <jk-> on the .o is fine
[03:14] <jk-> but the oops log reports that your init_module function is 0x70 bytes in size, whereas the disassemly would indicate that it's 0x49 bytes
[03:14] <AceLan_> undriedsea: read this # http://www.downloadpipe.com/forums/linux/Problem-set_memory_rw-ftopict76420.html
[03:14] <AceLan_> system call table is on .rodata section and set_memory_rw() doesn't
[03:14] <AceLan_> allow change attributes on .rodata sections(not .text) 
[03:14] <undriedsea> my .ko dump is much larger
[03:15] <undriedsea> Thanks ace!
[03:15] <undriedsea> I guess I will have to modify the page table directly to accomplish my goal
[03:16] <undriedsea> :(
[03:16] <jk-> or patch sys_open
[03:16] <AceLan_> undriedsea: yes, you have to export sys_call_table 
[03:17] <undriedsea> That would require my end users to install a custom kernel wouldn't it, rather than just install my module?
[03:17] <AceLan_> undriedsea: you have to modify the kernel :(
[03:17] <jk-> but this is all pretty ugly, what are you actually trying to do?
[03:18] <jk-> AceLan_: exporting it will only expose the linkage, will still be able to refer to it by symbol address
[03:19] <undriedsea> I am writing a process live migration module, I need to capture sys_calls and translate file handles, process IDs etc. For example, a process might get moved to a machine where its PID conflicts with an existing PID, so I need to hide this
[03:19] <undriedsea> If I was writing this 6 years ago before all this stop exporting the sys_call_table, make it RO nonsense, it would be much easier :)
[03:20] <AceLan_> wow, sounds so cool, process moves among machines
[03:21] <undriedsea> Well, I hope it is cool when I am done, or I will be working on my masters project a looong time lol :)
[03:21] <AceLan_> undriedsea: how about not real move the process, indtead of recreating the same one on another machine?
[03:22] <undriedsea> Those are the same things, I am doing two things, replicating the process state, and hiding namespace issues (file handle number, PIDs, semphore ids, etc)
[03:23] <undriedsea> I cannot change the PID even after moving becuase the programmer of the application may have made a call eariler to get the PID and their code might now be depending on that value
[03:24] <AceLan_> right, very reasonable
[03:25] <undriedsea> There are other methods besides doing what I am doing, but they are either slow (because the involve kernel/user-mode context switches) or they only capture syscalls made through the standard libraries (which means I could not migrate applications which directly make system calls)
[03:26] <AceLan_> undriedsea: have you to use 2.6 kernel? I think modify sys_call_table in 2.4 kernel is much easier
[03:26] <undriedsea> So I guess I will be directly changing the page table using the low level instructions because the kernel is silly and won't do it
[03:26] <undriedsea> You are correct, however, I want people to be able to do useful things with the result of my project
[03:27] <undriedsea> I could just make my own kernel build that turns the security off in 2.6 too, but ideally, I only want people to need to load a module (if at all possible)
[03:29] <jk-> undriedsea: what are you doing about kernel state - open files, sockets, etc?
[03:30] <undriedsea> replicating it
[03:30] <jk-> how?
[03:32] <undriedsea> By keeping track of kernel state of live migration processes and recreating that state on the new host. The unique identifier might not match, but my namespace translation later takes care of that
[03:33] <undriedsea> or will, I am just getting started
[03:40] <jk-> undriedsea: have you read Eric Roman's survey of Checkpoint/Restart implementations?
[03:40] <jk-> undriedsea: and Zhong and Nieh's CRAK paper?
[03:42] <undriedsea> CRAK and ZAP yes, I will look for Erics
[03:43] <undriedsea> I found the code that is killing me,  832        if (!pgprot_val(mask_set) && !pgprot_val(mask_clr) && !force_split)
[03:43] <undriedsea>  833                return 0;
[03:43] <undriedsea> http://lxr.linux.no/#linux+v2.6.31/arch/x86/mm/pageattr.c#L818
[03:44] <jk-> you can control the fd table, so you don't need to worry about translating FDs
[03:45] <undriedsea> fd, file descriptors?
[03:45] <jk-> yep
[03:45] <undriedsea> cool, that will be nice
[04:09] <undriedsea> When looking at System.map, what do the single character values after the address and before the symbolic name denote?
[04:44] <AceLan_> undriedsea: The "How to get sys_call_table" and "Simple sys_call_table hook" might useful # http://www.slideshare.net/fisher.w.y/rootkit-on-linux-x86-v26
[04:57] <undriedsea> AceLan, that is very interesting, thank you
[08:20] <lag> diwic: Hi
[08:21] <diwic> Hi lag
[08:21] <lag> I'm assuming you have a vast array of test audio files?
[08:21] <lag> Do you have any S32_LE?
[08:22] <diwic> lag, naah, but use the plug layer and it will convert it for you
[08:22] <lag> Okay
[08:22] <lag> Cheers
[08:22] <lag> I'll probably be pestering you a few times today - stay alert ;)
[08:23] <diwic> lag, or if that doesn't work, I can create one in audacity for you
[08:23] <lag> Cool, thanks
[10:28] <diwic> ogasawara, ping
[13:03] <lag> diwic: Can you come into #ubuntu-arm?
[14:55] <bjf> JFo: cranberry is now running lucid
[14:55] <JFo> excellent
[15:01] <diwic> bjf, I talked to takashi about his dailies, he said they were created after midnight, his time. So if you run your script approx UTC+3, that would be optimal
[15:01] <bjf> diwic, thanks, I can make that happen
[15:02] <diwic> bjf, great :-)
[15:03] <bjf> diwic, where does takashi live?
[15:04] <diwic> bjf, in Germany I believe. 
[15:05] <diwic> bjf, which is UTC+1 +DST
[15:05] <bjf> diwic, ok, that puts him 9 hours ahead of me
[15:06] <diwic> bjf, and me as well then - amazing you're up already ;-)
[15:06] <smb> diwic, UTC+2
[15:07] <bjf> diwic, it's 7 a.m. already! where has the day gone?
[15:07] <diwic> smb, UTC+1 in winter and UTC+2 in summer, right?
[15:07] <smb> right
[15:07] <diwic> same as here.
[15:08] <diwic> smb, you are from Germany as well, right?
[15:08] <smb> I am, yes. I am never sure about Takasi thoug. :)
[15:09] <bjf> diwic, so his midnight should be my 15:00 
[15:09] <smb> People tended to believe GregKH to be in Germany, too as he has a suse.de email address as well. 
[15:09] <smb> bjf, Its 4:10pm here if that helps
[15:10] <JFo> brb
[15:11] <bjf> smb, the math still works out :-)
[15:13] <bjf> diwic, time on the cron job has been adjusted
[15:13] <diwic> bjf, thumbs up
[15:14] <cnd> ogasawara, manjo: bug 641320
[15:14] <ubot2> Launchpad bug 641320 in linux (Ubuntu) "Touchpad is not working since last kernel update in maverick (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/641320
[15:15] <cnd> due to the new ALPS patch
[15:15] <cnd> manjo, why did you push the dell patch instead of the patch on LP that had bug fixes in it?
[15:15] <manjo> cnd, I picked the patch from the LP 
[15:16] <manjo> cnd, and jerone tested it at dell 
[15:16] <cnd> oh, someone on the LP bug thought it wasn't that patch
[15:16] <cnd> they thought it was the upstream patch
[15:17] <cnd> either way, we probably need to revert the patch
[15:17] <apw> perhaps one of you could confirm we didn't end up taking the upstream patch
[15:17] <manjo> cnd, :) heh funny coz you recommended that  patch in the 1st place 
[15:17] <cnd> heh, I pointed it out :)
[15:18] <apw> it may have been assumed it was the same and that one cherry-picked instread
[15:18] <cnd> no recommendation
[15:18] <cnd> just that it has some fixes the dell one doesn't
[15:18] <cnd> btw, sorry if I'm a bit curt
[15:18] <cnd> in the middle of xds :)
[15:18] <apw> cnd/manjo, which was the original bug
[15:18] <cnd> apw, I need to dig it out
[15:19] <cnd> http://bugs.launchpad.net/bugs/632884
[15:19] <ubot2> Launchpad bug 632884 in linux (Ubuntu) (and 1 other project) " Add support for Intellimouse Mode in ALPS touchpad on Dell Latitude series Laptops (affects: 1) (heat: 10)" [Undecided,Fix released]
[15:19] <bjf> manjo, cnd, this sounds like the problem davidm is also having
[15:22] <cnd> manjo, apw, the sauce patch in ubuntu doesn't match the LP patch
[15:22] <manjo> cnd which lp patch are you taking about ? 
[15:22] <apw> cnd, seems to match the 'final patch' link
[15:23] <manjo> The final patch can be found here:
[15:23] <manjo> https://patchwork.kernel.org/patch/118834/
[15:23] <manjo> that is what I pushed 
[15:23] <cnd> manjo, which is the upstream submitted dell patch I said not to use :)
[15:24] <manjo> cnd, I don't see any other patch there 
[15:24] <cnd> manjo, it's on the LP bug
[15:24] <Sarvatt> cnd: bug work right so soon after you get done with a talk? you're a machine! :)
[15:24] <cnd> heh
[15:24] <cnd> http://launchpadlibrarian.net/54076279/2.6.35-alps-730264-imps-emulation.patch
[15:24] <apw> dammit this is serious, we have pushed the final maverick kernels
[15:24] <cnd> manjo, that's the patch I pointed to ^
[15:24] <apw> to get this fixed we need to get an exception
[15:25] <cnd> from https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/550625/comments/154
[15:25] <ubot2> Launchpad bug 550625 in linux (Ubuntu Lucid) (and 2 other projects) "Alps touchpad is recognized but synaptics clients and scrolling do not work (affects: 113) (dups: 9) (heat: 576)" [Medium,Incomplete]
[15:25] <apw> bjf, does davidm have a bug also ?
[15:25]  * apw will switch the patch and get some test kernles out to these bugs
[15:26] <bjf> apw, yes, though he's been unable to actually file it due to LP timeouts
[15:26] <manjo> cnd, there is no mention of 550625 in 632884 so when you asked me to help with 632884 I did by picking up the final patch there 
[15:27] <apw> manjo, there is though in comment #1
[15:28] <apw> manjo, anyhow i'll get some kernels together
[15:30] <cnd> apw, might I suggest just pulling the patch?
[15:30] <cnd> git revert
[15:30] <cnd> the patch hasn't been reviewed upstream and we're so late
[15:30] <cnd> and the trackpads still work without the patch, just not with scrolling support
[15:30] <apw> cnd, i thought you needed that in to get multi-touch or some shit
[15:31] <cnd> apw, nope
[15:31] <cnd> it was just a bug I wanted someone to look at
[15:31] <cnd> since I had seen someone in the community had worked on the patch some
[15:31] <cnd> I didn't want it to fall through the cracks
[15:31] <cnd> and disappear forever into LP :)
[15:32] <hallyn> oh goodie, i get to blame manjo for breaking my tp :)
[15:33] <manjo> cnd, so why did you ask me to look at it if it was not important ? 
[15:33]  * hallyn shakes his fist
[15:33] <cnd> I never said it was important :)
[15:33] <cnd> I just said someone should look at it
[15:38] <Sarvatt> there are quite a large number of bugs against synaptics at least regarding the alps scroll situation that i'm moving over to that one right now, I wouldn't say its unimportant. not having touchpad scroll is a pretty crappy user experience
[15:40] <cnd> Sarvatt, it's not whether it's important or not
[15:40] <cnd> it's that we're in kernel freeze
[15:40] <cnd> and we aren't positive that we won't add more regressions with the patch from LP
[15:41] <apw> Sarvatt, right, we really are past the point where we want to make any changes as someone has to respin every CD as a result
[15:41] <apw> and we have no time to get any testing on it, i'll mark the bug for consideration after release
[15:41] <apw> (the original one) and we can then test it more thoroughly
[15:44] <cnd> my hope was that someone would take a look at the LP patch many weeks ago, put it in a development kernel, and then we can work on upstreaming it
[15:45] <cnd> then oem services wanted proper alps support, and manjo and vanhoof looked at it a week or two ago
[15:45] <cnd> timing just wasn't as good as one could hope :(
[15:45] <cnd> and I didn't have enough time to work the bug properly myself...
[15:46] <robbiew> JFo: ping
[16:00] <JFo> robbiew, pong
[16:01] <JFo> s'what I get for working on 2 machines
[16:02] <robbiew> JFo: nevermind...was going to ask you about I bug, but I decided it was easier to just ask the submitter as a comment ;)
[16:03] <JFo> heh
[16:10] <apw> hallyn, hey ... i'm just reverting that patch and will have some test kernels in about 10 mins for testing if you could confirm the revert fixes you
[16:10] <hallyn> apw: cool
[16:13]  * JFo stepping out for a bit. some errands and packing to complete before flying for Taipei tomorrow.
[16:19] <ogasawara> kees: about?  want to check back with you about the stack guard change you said was missing?
[16:20] <ogasawara> kees: I'd only applied the one patch from smb - http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=commit;h=1ccc5359a8f055b153a2e0cfec02a594a8443360
[16:21] <ogasawara> kees: is there additional patches I need to get applied?
[16:24] <ogasawara> jjohansen: re "[PATCH 3/3] UBUNTU: SAUCE: AppArmor: allow newer tools to load policyon older kernels"
[16:24] <ogasawara> jjohansen: is there something you want modified with that patch per tetsuo's comments?
[16:24] <hallyn> apw: actually gotta run for a bit, i'll test when i get back
[16:25] <ogasawara> jjohansen: we might have a chance to get that fixed and squeezed into a last minute upload
[16:25] <kees> ogasawara: let me check if it passes now that I've rebooted
[16:25] <kees> ogasawara: doesn't seem to pass
[16:26] <kees> smb: the test still fails on maverick with that applied ^^
[16:26] <smb> kees, hm...
[16:26] <kees> oh wait
[16:26] <kees> I'm still on the wrong kernel, one sec
[16:27]  * smb holds his breath
[16:27]  * ogasawara crosses fingers the right kernel works
[16:27]  * smb turns slightly purple...
[16:27] <kees> kees@sec-maverick-i386:~/qa-regression-testing/scripts/kernel/guard-page$ cat /proc/version_signature 
[16:27] <kees> Ubuntu 2.6.35-22.32-generic 2.6.35.4
[16:27] <kees> kees@sec-maverick-i386:~/qa-regression-testing/scripts/kernel/guard-page$ ./split-stack stack start changed due to mlock call (0xbfa2c000 != 0xbfa4b000)!
[16:27] <kees> still fails
[16:28] <smb> kees, is there more output to look at?
[16:28] <kees> fails on hardy even. *scratch head*
[16:28] <ogasawara> kees: how critical is this for landing in Maverick's release?
[16:29] <ogasawara> kees: as we've likely got one last shot for an upload
[16:29] <smb> I would say not very critical
[16:29] <ogasawara> smb: so it could potentially be resolved via an SRU post maverick release?
[16:29] <smb> Yes, sounds reasonable
[16:29]  * kees will boot an upstream vanilla kernels
[16:30] <kees> s/s$//
[16:30] <smb> kees, But those addresses seem to be too far apart to be one page...
[16:30] <smb> kees, Thats weird
[16:30] <smb> Do you have the full output of maps somewhere?
[16:30] <kees> smb: it goes from:
[16:30] <kees> bff13000-bff34000 rw-p 00000000 00:00 0          [stack]
[16:31] <kees> to:
[16:31] <kees> bff13000-bff33000 rw-p 00000000 00:00 0 
[16:31] <kees> bff33000-bff34000 rw-p 00000000 00:00 0          [stack]
[16:31] <kees> across the mlock call
[16:31] <smb> kees, There does not seem to be a whole in there to me
[16:31] <smb> err hole
[16:32] <kees> hm? but the thing that got called "stack" got chopped up
[16:32] <kees> maybe I misunderstood the issue?
[16:32] <smb> I suppose
[16:32] <smb> wron would be
[16:32] <smb> bff13000-bff33000 rw-p 00000000 00:00 0
[16:33] <smb> errr what would be bff333000 +4k.
[16:34] <jjohansen> ogasawara: yes, if we can squeeze it in
[16:34] <smb> kees, Seems to be an unfortunate example
[16:34] <ogasawara> jjohansen: yep, just get me a patch to the ml asap
[16:34] <jjohansen> ogasawara: okay
[16:34] <smb> The problem _was_ that you saw a gap between  the vmas
[16:34] <apw> smb, 4k == 1000 hex
[16:35] <smb> apw, ta
[16:35] <kees> 7fff810d6000-7fff810f7000 rw-p 00000000 00:00 0                          [stack]
[16:35] <kees> vs
[16:35] <kees> 7fff810d6000-7fff810f5000 rw-p 00000000 00:00 0 
[16:35] <kees> 7fff810f6000-7fff810f6000 rw-p 00000000 00:00 0                          [stack]
[16:35] <kees> smb: there's a gap between 7fff810f5000 and 7fff810f6000
[16:35] <kees> is that the bug?
[16:35] <kees> my testcase is wrong, I guess.
[16:36]  * smb scratches his head
[16:36] <kees> I thought it was the fact that the stack got misidentified
[16:36] <smb> kees, That looks more broken than anything I saw
[16:36] <ogasawara> jjohansen: if you prefer, just give me two patches, one to revert the original SAUCE patch and then the fixed up version
[16:37] <jjohansen> ogasawara: okay
[16:38] <smb> kees, The problem was that the first page of a stack vma got hidden (start was moved up one page). 
[16:39] <kees> that would seem to be what the "gap between 7fff810f5000 and 7fff810f6000" demonstrates
[16:39] <smb> kees, May be what you posted last. 6000-6000 (basically size 0)
[16:40] <smb> The 6000-5000 looks really weird
[16:40] <apw> smb, thats doesn't say 6000->5000
[16:41] <kees> okay, the kernels before the guard page show:
[16:41] <kees> bfdd1000-bfde6000 rw-p 00000000 00:00 0          [stack]
[16:41] <kees> into
[16:41] <kees> bfdd1000-bfde3000 rw-p 00000000 00:00 0 
[16:41] <kees> bfde3000-bfde4000 rw-p 00000000 00:00 0          [stack]
[16:41] <apw> it says d6000->f5000
[16:41] <kees> so the split is "ok". it's the _gap_ that is bad.
[16:41] <smb> apw, ah ok missed that
[16:42] <kees> I'll fix the test case
[16:42] <smb> kees, But the second exapmple has no gap, right? bfdd1000-bfde3000 and bfde3000-bfde4000
[16:42] <smb> kees, oh ah
[16:42] <smb> kees, yes
[16:43]  * kees nods
[16:43] <smb> kees, the split is ok. but the address range should be connected
[16:43] <kees> I thought the bug was the splitting at all. I didn't realize the gap
[16:43] <kees> right
[16:43] <kees> fixing testcase...
[16:43] <apw> it always has to be split cause the permissions differ after the mlock
[16:44] <kees> apw: though oddly, the state of mlock isn't shown in maps
[16:44] <kees> (nor vma growth direction)
[16:44] <apw> kees, indeed, maps is a little useless
[16:45] <apw> kees, might be more in smaps
[16:45] <tseliot> apw: it seems that the following commit was included after 2.6.35-20:
[16:45] <tseliot> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c41d68a513c71e35a14f66d71782d27a79a81ea6
[16:45] <tseliot> apw: this breaks fglrx
[16:46] <tseliot> compat_alloc_user_space(), that is
[16:46] <apw> tseliot, how does it manifest, what breaks
[16:47] <tseliot> apw: I get error: implicit declaration of function ‘compat_alloc_user_space’
[16:47] <tseliot> apw: when trying to build the kernel module for fglrx
[16:47] <smb> tseliot, ITs likely because they exported thy symbol GPL
[16:47] <apw> tseliot, try converting the call to arch_compat_alloc_user_space()
[16:48] <smb> EXPORT_SYMBOL_GPL(compat_alloc_user_space)
[16:48] <apw> ahh ... doh
[16:48] <tseliot> apw, smb: I could use arch_compat_alloc_user_space() but would this work on previous 2.6.35 kernels?
[16:48] <ogasawara> ogra, mpoirier: bug 630885, is that release critical?  or ok as a post release SRU?
[16:48] <ubot2> Launchpad bug 630885 in linux (Ubuntu) (and 1 other project) "Preinstalled Maverick netbook image has no display on omap3 EVM (no LCD) (affects: 1) (heat: 14)" [Undecided,In progress] https://launchpad.net/bugs/630885
[16:48] <apw> tseliot, nope
[16:49] <tseliot> apw: it was a rhetorical question ;)
[16:49] <ogra> ogasawara, we dont have such HW in the team, probably for linaro 
[16:49] <ogra> ogasawara, but since i expect changes for omap3 anyway it wouldnt do harm to have it too
[16:49] <tseliot> smb: do you mean to say that they did EXPORT_SYMBOL_GPL(compat_alloc_user_space) in the fglrx code?
[16:50] <smb> tseliot, No they made the export like that in kernel/compat.c
[16:50] <smb> Before that it was an inline function
[16:50] <apw> tseliot, no he is saying the kernel has been changed to only export it to GPL stuff
[16:50] <tseliot> smb: ah, I get it now
[16:50] <mpoirier> ogasawara: the request came from a TI guy - is we get it in great, otherwise that's just life.
[16:51] <apw> tseliot, sounds like you have just need to include a header though
[16:51] <apw> as the code you are compiling is GPL right, the shim is GPL
[16:51] <ogasawara> mpoirier: and the patch itself is going upstream?
[16:51] <mpoirier> ogasawara: I wish it could...
[16:52] <mpoirier> but haven't had any luck with all our beagle work.
[16:52] <ogasawara> mpoirier: tgardner had inquired
[16:52] <smb> tseliot, yeah, mabe including <linux/compat.h> works
[16:52] <mpoirier> yes, tgardner and I have talked about it.
[16:53] <tseliot> apw, smb: including <linux/compat.h> works but I can't because it's GPL while the file that should include it is not
[16:53] <mpoirier> ogasawara: I'm thinking about enlisting outside key contributors to help with the push up.
[16:53] <ogasawara> mpoirier: might be good to post the result of the discussion to the mailing list so we're all in the loop
[16:54] <apw> tseliot, add a shim funtion in the gpl file ?
[16:54] <ogasawara> mpoirier: and I assume I should add the additional provenance for the patch?
[16:54] <mpoirier> ogasawara: should we mumble ?
[16:54] <ogasawara> mpoirier: sure
[16:58] <MTecknology> I've been playing with compiling the kernel and trying to figure it out on that level. I got myself stuck though. I'm missing a module (I assume) but I have no idea what module it might be.. My system boots pretty nice. It even loads to TTY7 (only 1 and 7). This is what I wind up seeing. http://pastebin.ubuntu.com/495371/ (Maverick). Any chance I could get a little pointer?
[17:03] <jjohansen> ogasawara: patches should be on the list now
[17:03] <ogasawara> jjohansen: great, thanks
[17:05] <tseliot> apw: ah, so a simple function that calls arch_compat_alloc_user_space() in asm/compat.h?
[17:07] <smb> tseliot, I probably would rather do a simple function that call compat_alloc_userspace (to get the benefit of the additional checks) which is defined in a gpl'ed code
[17:10] <apw> tseliot, indded as smb suggests
[17:10] <apw> fgrlx_alloc_user_space() { compat_aloc_user_space() }
[17:10] <apw> stylee
[17:10] <apw> and that should be compatible either way i think
[17:11] <apw> thus showing how stupid the whole export_gpl stuff really is, as you can comply with the rules
[17:17] <tseliot> apw, smb: ah, so I could add that function in asm/compat.h and the thing would be legal? This would mean adding something like #define ALLOC_COMPAT_LEGACY (or a better name) so that fglrx can see whether it needs to call fgrlx_alloc_user_space() at build time.
[17:18] <smb> No, not changing anything in the normal kernel code. This should go into the fglrx code (the part that is gpl)
[17:21] <tseliot> smb: this is what they currently do in fglrx:
[17:21] <tseliot> void* ATI_API_CALL KCL_IOCTL_AllocUserSpace32(long size)
[17:21] <tseliot> {
[17:21] <tseliot>     return compat_alloc_user_space(size);
[17:21] <tseliot> }
[17:21] <apw> and they do that in non-GPL file right ?
[17:21] <tseliot> yep
[17:21] <apw> but they ahve a GPL file, so change that to fgrlc_alloc....(size)
[17:21] <apw> and add an identicle wrapper to the GPL file
[17:22] <apw> as i say, the separation is pointless
[17:23] <apw> hallyn, kernel for testing is at: http://people.canonical.com/~apw/lp641320-maverick/
[17:24] <apw> tseliot, do u mumble ?
[17:24] <tseliot> apw: yep but I need to connect the microphone
[17:24] <apw> might be easier to talk
[17:27] <tseliot> apw: right but my microphone doesn't seem to be detected...
[17:28]  * tseliot blames it on pulseaudio
[17:30] <MTecknology> Is there a ureadahead module in the ubuntu version of the kernel that's required to boot - even if you don't have ureadahead?
[17:34] <tseliot> apw: ok, it works now, let's talk
[17:37] <tseliot> apw: where shall we talk?
[17:38] <apw> we are in cafinated conversation ... under Kernel
[17:38] <smb> tseliot, kernel teams caffeinated conversation
[17:39] <tseliot> smb, apw: ok, I'm there
[17:43] <tseliot> apw: can you hear me?
[17:43] <smb> He cannot
[17:43] <tseliot> oh
[17:43] <smb> In fact none of us. :)
[17:43] <tseliot> ok, let me reconfigure mumble
[17:47] <tseliot> smb, apw: now it's telling me that my password is wrong. I'll give up on mumble for now.
[17:47] <tseliot> apw, smb: were you suggesting that I define the function in the GPL file and export the function?
[17:48] <tseliot> the fgrlx_alloc_user_space() function that is
[17:48] <smb> Right, you do it in the GPL file and export it (or link) it to the non-gpl file
[17:49] <tseliot> ok, I see what you mean now
[17:49] <tseliot> thanks
[17:56] <tseliot> smb, apw: thanks a lot for your help
[17:56] <smb> np :)
[17:58] <hallyn> apw: that kernel is good
[17:58] <apw> hallyn, thanks can you update the bug pls
[18:00] <hallyn> apw: done, thanks
[18:05] <hallyn> though now, periodically the x display just hange.  right now i'm typing typing typing and not seeing anything, but i'tll suddenly just catch up  maybe
[18:19] <ogasawara> apw: http://pastebin.ubuntu.com/495420/
[18:39] <ogasawara> apw: http://pastebin.ubuntu.com/495429/ - updated revision
[18:54] <Sarvatt> would something like this work for all of these vaio F series that need i8042.nopnp? http://sarvatt.com/downloads/patches/vaio-vpcf-i8042-quirk.patch
[18:56] <Sarvatt> VPCF1290X VPCF126FM VPCF12S1E VPCF12M1E VPCF121FD are the models i've found so far needing it
[18:57] <mjg59> Given that Windows uses pnp to identify i8042 devices, that seems very much like the wrong fix
[19:08] <Sarvatt> mjg59: thanks, it was a shot in the dark. it looks to be all VPCF12xxx devices, VPCF11xxx that hallyn has doesn't need the quirk to have the touchpad working
[19:08] <mjg59> Sarvatt: What's the bug number for this?
[19:08] <mjg59> Sarvatt: And does it have dmesg in both cases?
[19:09] <Sarvatt> there are a whole rack of bugs i'm noticing now that i'm looking and haven't condensed them yet, one sec i'll get you a list. they all have this in dmesg
[19:09] <Sarvatt> [    1.377980] PNP: PS/2 Controller [PNP0303:PS2K] at 0x60,0x64 irq 1
[19:09] <Sarvatt> [    1.377982] PNP: PS/2 appears to have AUX port disabled, if this is incorrect please boot with i8042.nopnp
[19:10] <mjg59> Awesome
[19:10] <mjg59> Sarvatt: Need acpidump as well
[19:10] <Sarvatt> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/636638
[19:10] <ubot2> Ubuntu bug 636638 in linux (Ubuntu) "Touchpad is not detected on Sony VPCF126FM (affects: 1) (heat: 848)" [Undecided,New]
[19:11] <Sarvatt> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/641169
[19:11] <ubot2> Ubuntu bug 641169 in linux (Ubuntu) "alps touchpad sony vaio recognized, but not working (affects: 1) (heat: 6)" [Undecided,New]
[19:11] <Sarvatt> ^ that one has acpidump but no dmesg, he put his dmesg in another bug
[19:11] <Sarvatt> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/638219
[19:11] <ubot2> Ubuntu bug 638219 in linux (Ubuntu) "Touchpad does not work on Sony Vaio VPCF12M1E (affects: 1) (heat: 1692)" [Undecided,New]
[19:11] <Sarvatt> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/636842
[19:11] <ubot2> Ubuntu bug 636842 in linux (Ubuntu) "Touchpad not found on Sony Vaio VPCF12S1E (affects: 1) (heat: 6)" [Undecided,New]
[19:12] <Sarvatt> sorry for the spam
[19:12] <mjg59> Sarvatt: I think 641169 is different
[19:12] <Sarvatt> it is, kind of, we were working through that with him in #ubuntu-devel and he was hitting 2 bugs at once
[19:12] <Sarvatt> he needed the fix for that bug + i8042.nopnp to actually work
[19:13] <mjg59> Which one did you say had acpidump?
[19:13] <Sarvatt> oh shoot, getting my bugs mixed up
[19:14] <Sarvatt> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/641324
[19:14] <ubot2> Ubuntu bug 641324 in linux (Ubuntu) "Sony Vaio touch pad is not working (affects: 1) (heat: 10)" [Undecided,New]
[19:14] <Sarvatt> let me ask these people for acpidumps :)
[19:15] <Sarvatt> http://launchpadlibrarian.net/55810189/vaio_bug.txt 
[19:17] <mjg59> Interesting. That should definitely be picked up.
[19:18] <mjg59> There's a PNP0F13 device.
[19:18] <mjg59> But it's got an invalid _HID
[19:18] <mjg59> Maybe we're ignoring it in that case
[19:20] <mjg59> Sarvatt: My suspicion is that this is an issue in the acpipnp parser
[19:21] <mjg59> Sarvatt: Bet http://fpaste.org/NDs1/ will fix it
[19:21] <mjg59> Or, at least, will result in it crashing in some entertaining way
[19:21] <apw> clap4ham
[19:21] <Sarvatt> i'll try to condense these bugs and submit a bug to b.k.org
[19:22] <mjg59> apw: ...
[19:22] <Sarvatt> oh, nice
[19:22] <apw> heheh ...that poor password 
[19:22] <apw> thats why i have a different screen saver password to anything useful :)
[19:22] <mjg59> Sarvatt: It certainly looks like we stop parsing acpipnp devices if there's an invalid HID, and this HID is certainly invalid
[19:22] <apw> done that twice this week already :)
[19:22] <cking> doh
[19:23] <mjg59> It's supposed to be three letters followed by four hex digits. Instead it's SNYALP0012
[19:23] <mjg59> Thony
[19:23] <apw> its only my screen lock password, thats why it has to be different
[19:36] <mjg59> Sarvatt: http://marc.info/?l=linux-acpi&m=127563868423035&w=2
[19:38] <Sarvatt> mjg59: \o/ thank you for looking at it and the heads up on that patch
[20:11]  * ogasawara lunch
[20:34] <jjohansen> -> lunch
[22:02] <robbiew> ogasawara: regarding the Kernel Freeze Exception, just cut and paste that email into the bug comment...that should be enough
[22:03] <ogasawara> robbiew: you're reading my mind, doing that right now
[22:03] <robbiew> ;)
[22:03] <robbiew> I figured I didn't need to say it, but didn't want you thinking we needed separate bugs for each bugfix or something nuts like that :)
[22:05] <ogasawara> robbiew: bug 641618
[22:05] <ubot2> Launchpad bug 641618 in linux (Ubuntu) "Maverick Kernel Freeze Exception (affects: 1) (heat: 10)" [Undecided,New] https://launchpad.net/bugs/641618
[22:05] <ogasawara> robbiew: will respond with the bug# in email to keep everyone informed
[22:05] <robbiew> ogasawara: cool..thnx