| satellit_ | dfarning:http://wiki.sugarlabs.org/go/Community/Distributions/Ubuntu#VirtualBox_appliance_of_UbuntuSugarRemix it is just finishing uploading now 30 min to go | 00:18 |
|---|---|---|
| satellit_ | defarning: It turns out that it was specifiic to one netbook | 00:19 |
| satellit_ | no booting | 00:19 |
| dfarning | satellit_, Ok thanks. The underlying maverick code is changing pretty fast so I hesitate to did too far into the non sugar specific stuff. | 00:21 |
| satellit_ | virtual box appliance works nicely though | 00:21 |
| satellit_ | dfarning: It is easy to install updates and post them as we go..... | 00:22 |
| satellit_ | dinner....afk | 00:23 |
| satellit_ | dfarning: All files Uploaded | 00:45 |
| satellit_ | dfarning: Did DL of USR appliance and imported it...Works well here | 02:24 |
| dfarning | satellit_, nice | 02:24 |
| satellit_ | http://wiki.sugarlabs.org/go/Emulator_image_files#VirtualBox | 02:24 |
| === manusheel is now known as manusheel_afk | ||
| === dfarning is now known as dfarning_afk | ||
| === dfarning_afk is now known as dfarning | ||
| * dipankar says hi to all | 14:56 | |
| manusheel | dipankar, ishan: Hello. | 14:59 |
| dipankar | ishan, hi | 14:59 |
| ishan_ | manusheel: Hello | 14:59 |
| ishan_ | dipankar, hi | 14:59 |
| manusheel | dipankar: First, can you explain Ishan the steps to merge the patch with the mainline git. As you explain, I'll add the steps in a doc file for future reference. | 15:00 |
| dipankar | ishan_, continuing with last night's bug | 15:00 |
| dipankar | manusheel, ok | 15:00 |
| ishan_ | dipankar, sure | 15:00 |
| dipankar | ishan_, lets first discuss how I make the patch | 15:00 |
| ishan_ | dipankar, sure | 15:01 |
| dipankar | ishan_, First you need to clone the mainline git repo of the package you are targeting to modify | 15:01 |
| ishan_ | dipankar, okay | 15:02 |
| ishan_ | dipankar, by this you mean the folder i which we are making changes | 15:03 |
| dipankar | for e.g to modify the sugar package files: here is the mainline git repository: http://git.sugarlabs.org/projects/sugar/repos/mainline | 15:03 |
| ishan_ | dipankar, okay | 15:03 |
| dipankar | ishan_, patches based on this mainline git repo will be accepted as the patches created from here can be added directly. | 15:04 |
| ishan_ | okay | 15:04 |
| manusheel | dipankar: Team members have this question on the location where you clone the repository. What do you have to recommend in this matter? | 15:05 |
| dipankar | ishan_, I don't know much in detail, but Shascha always wanted the patches based on mainline so that he can apply them. | 15:05 |
| dipankar | manusheel, ok sir. | 15:05 |
| ishan_ | dipankar, okay | 15:05 |
| dipankar | manusheel, ishan_: I generally clone them in a folder named 'test-s' | 15:06 |
| dipankar | in home folder | 15:06 |
| ishan_ | which in home folder | 15:06 |
| dipankar | home folder of Ubuntu | 15:06 |
| ishan_ | dipankar, okay | 15:07 |
| dipankar | its similar to cloning any git repo | 15:07 |
| ishan_ | dipankar, is it same as we had done for Lp | 15:07 |
| dipankar | ishan_, to make things clear. Lets suppose for debian packages, you needed to create a patch, which repo will you use? | 15:08 |
| ishan_ | dipankar, i think the repo for the package present in debian | 15:09 |
| dipankar | ishan_, great | 15:09 |
| dipankar | ishan_, similarly, if you want to contribute directly to Sugar, where would you base your patch? | 15:10 |
| ishan | dipankar, in the suga repo | 15:10 |
| ishan | suga/sugar | 15:10 |
| dipankar | ishan, nice. | 15:10 |
| ishan_ | dipankar, okay i got it | 15:11 |
| dipankar | ishan, I think by now you must have got what I wanted to explain :) | 15:11 |
| ishan_ | dipankar, yes | 15:11 |
| dipankar | remember this hierarchy: | 15:11 |
| dipankar | Sugar | 15:11 |
| dipankar | V | 15:11 |
| dipankar | Debian | 15:11 |
| dipankar | V | 15:11 |
| dipankar | Ubuntu | 15:11 |
| ishan_ | okay | 15:12 |
| ishan_ | dipankar, can you also explain the patch numbering system | 15:12 |
| dipankar | ishan, patch numbering? | 15:12 |
| ishan_ | dipankar, what i meant was V1,V2 ......which you did for your patch | 15:13 |
| dipankar | ishan_, ok the patch versioning | 15:14 |
| ishan_ | dipankar, yep | 15:14 |
| dipankar | ishan_, the first patch you submit is always v1. | 15:14 |
| dipankar | ishan_, if you modify it and upload a new one, then has to indicate that the on you are sending right now is not the first | 15:15 |
| ishan_ | dipankar, okay | 15:15 |
| dipankar | ishan_, in addition to your versions, you also need to mention a snap of previous versions in the changelog, | 15:16 |
| ishan_ | dipankar, can you explain ^^ | 15:16 |
| dipankar | e.g v1 was Reviewed-By Sascha Silbe<email-id> | 15:16 |
| ishan_ | dipankar, okay | 15:16 |
| dipankar | changelog is similar to the one in packages, but these are onliner | 15:16 |
| dipankar | *one liners | 15:16 |
| ishan_ | dipankar, okay | 15:16 |
| dipankar | just to inform the developers that your previous version was reviewed by another developer | 15:18 |
| ishan_ | dipankar, like you submitted your V1 for review and had to make some changes for V2- so do we have to make changes in the V1 file or we have to make changes in the orignal file | 15:18 |
| ishan_ | in order to make V2 patch | 15:18 |
| dipankar | ishan_, ohk, | 15:20 |
| dipankar | for that follow this simple process: | 15:20 |
| dipankar | - first reset the file that you modified | 15:20 |
| dipankar | using , git reset in the repo | 15:20 |
| ishan_ | dipankar, okay | 15:20 |
| dipankar | - after completing the modifications add it for commit | 15:21 |
| dipankar | using git add | 15:21 |
| dipankar | - then run git commit --amend | 15:21 |
| ishan_ | dipankar, okay means we are making the V2 patch also from the original file | 15:21 |
| dipankar | yes | 15:21 |
| dipankar | ishan_, otherwise it will be a very long process | 15:22 |
| dipankar | alsroot, ping | 15:22 |
| ishan_ | dipankar, and for git reset we just run git reset command | 15:22 |
| ishan_ | or there are some attributes to be added | 15:22 |
| dipankar | ishan_, sorry I forgot to add them in quotes. | 15:22 |
| dipankar | git reset | 15:22 |
| dipankar | git add | 15:23 |
| dipankar | git commit --amend | 15:23 |
| ishan_ | dipankar, got it | 15:23 |
| dipankar | no more flags to be sent | 15:23 |
| ishan_ | dipankar, okay | 15:23 |
| manusheel | ishan_: Now, try these steps for the bundle id issue, and send the steps to the team in a documented format. | 15:25 |
| manusheel | ishan_: You can take up any other issue too that you are more comfortable with. The idea is understanding this process. | 15:25 |
| manusheel | dipankar: In reference to your question, which file are you looking at? | 15:30 |
| * dipankar is making patch for : http://bugs.sugarlabs.org/ticket/2180 | 15:30 | |
| dipankar | manusheel, that depends on the patch I want to make | 15:30 |
| manusheel | dipankar: I was referring to your yesterday's query on right click key handler. | 15:31 |
| dipankar | manusheel, like for the above bug I need: jarabe/util/emulator.py | 15:31 |
| ishan | dipankar, while making the patch the normal procedure has to be followed right? | 15:32 |
| dipankar | ishan, yes, git commit -> write the commit message and save-> then git format-patch HEAD^1 | 15:33 |
| manusheel | ishan: yes. | 15:34 |
| manusheel | same steps. | 15:34 |
| ishan_ | dipankar, manusheel: check the mail | 15:47 |
| dipankar | ishan_, nice | 15:49 |
| ishan_ | dipankar, thanks sir | 15:49 |
| * dipankar wonders what [A [B is? | 15:49 | |
| dipankar | ishan_, where did you send the e-mail btw? | 15:49 |
| ishan | dipankar, only to you | 15:49 |
| dipankar | ishan, ohk | 15:50 |
| ishan | dipankar, these [A [B were due to the arrow keys pressed | 15:50 |
| dipankar | ishan, ok | 15:52 |
| * ishan_ is away for 10mins | 15:53 | |
| * ishan_ is back | 16:03 | |
| kandarpk | alsroot: hi | 16:06 |
| kandarpk | around ? | 16:06 |
| dipankar | manusheel_, sir, I am looking for the file containing the key handlers, or in jarabe/view/ dir | 16:07 |
| manusheel_ | dipankar: Ok. Coming to that directory. | 16:08 |
| dipankar | manusheel_, I think this file might be useful: jarabe/journal/objectchooser.py | 16:14 |
| alsroot | kandarpk: pong | 16:14 |
| manusheel_ | dipankar: Why do see this file would be useful? | 16:14 |
| dipankar | manusheel_, sir, it has some statements like : self.tree_view.connect('button-release-event', | 16:15 |
| dipankar | self.__button_release_event_cb) | 16:15 |
| dipankar | not sure though | 16:16 |
| kandarpk | alsroot: can you help me with #2323 | 16:16 |
| ishan_ | kandarpk, sir i am working on bug #1858 | 16:16 |
| alsroot | kandarpk: whats the problem? | 16:16 |
| ubot2 | Launchpad bug 1858 in gajim "gajim look and feel" [Undecided,Fix released] https://launchpad.net/bugs/1858 | 16:16 |
| ishan_ | kandarpk, can you provide me any pointers on that | 16:16 |
| kandarpk | alsroot: I dont know how to work with clpboard | 16:17 |
| dipankar | manusheel_, let kandarpk finish discussing with alsroot, then I will ask him. Meanwhile I will try to dig in more | 16:17 |
| manusheel_ | dipankar: Ok. Yes, those functions seem useful. | 16:17 |
| * alsroot didn't work w/ clipboard as well | 16:19 | |
| kandarpk | ishan, please see http://lists.sugarlabs.org/archive/sugar-devel/2010-September/027094.html | 16:19 |
| kandarpk | it has some replies as well | 16:19 |
| ishan_ | kandarpk, okay | 16:20 |
| alsroot | kandarpk: you can grab some info in gtk docs, http://library.gnome.org/devel/gtk/stable/gtk-Clipboards.html | 16:20 |
| kandarpk | alsroot, ok, thanks. | 16:20 |
| dipankar | alsroot, I am still working on the volume display in journal view | 16:21 |
| dipankar | alsroot, I want to check where I can add a right click option for the journal icon in the journal view | 16:21 |
| alsroot | dipankar: you don't need to code it directly, just add create_palette method to create button palette, the rest will be processed by existed code (invoker created by parent class) | 16:22 |
| dipankar | alsroot, I already added the create_palette(). but it seems that it is not working | 16:23 |
| alsroot | dipankar: did sugar log any errors? | 16:23 |
| dipankar | alsroot, no | 16:24 |
| dipankar | alsroot, let me check once again | 16:24 |
| dipankar | alsroot, today it is showing some error: http://paste.ubuntu.com/500386/ | 16:27 |
| dipankar | alsroot, sorry about my denial to errors first :( | 16:28 |
| alsroot | dipankar: does this error happen after right clicking on journal button? | 16:30 |
| dipankar | alsroot, yes | 16:30 |
| alsroot | dipankar: could you pastebin your patch | 16:32 |
| dipankar | alsroot, the strange thing is, sometimes the error comes and sometimes it doesnt' | 16:32 |
| dipankar | alsroot, just asec | 16:33 |
| dipankar | alsroot, http://paste.ubuntu.com/500389/ | 16:34 |
| dipankar | alsroot, I will back after sometime. Going for dinner | 16:35 |
| * dipankar is off for dinner | 16:35 | |
| * ishan_ is away for dinner | 17:28 | |
| manusheel | mukul: Hi Mukul. | 17:41 |
| manusheel | Around? | 17:41 |
| === dipankar_ is now known as dipankar | ||
| dipankar | alsroot, sorry, I got disconnected. | 17:50 |
| dipankar | dfarning, around? | 17:50 |
| dipankar | manusheel, around? | 17:50 |
| manusheel | dipankar: Hi Dipankar. | 17:50 |
| dfarning | dipankar, yes | 17:51 |
| manusheel | dipankar: Did we send the patch to sugar-devel? | 17:51 |
| dipankar | manusheel, yes sir. The patch for fullscreen bug has already been sent | 17:51 |
| manusheel | dipankar: Great. | 17:52 |
| alsroot | dipankar: could pasterbin your entirely patch (`git diff`) otherwise I dunno how code you posted before is intended to work(there are missed symbols) | 17:52 |
| dipankar | dfarning, just came across your e-mail on tomeu's guidelines | 17:52 |
| dipankar | alsroot, I just added the whole create_palette(). nothing more | 17:53 |
| dipankar | alsroot, the original code is without the whole function | 17:53 |
| alsroot | dipankar: anyway it is more useful practice to pastebin a patch not a piece of code | 17:53 |
| * ishan_ is back | 17:53 | |
| dipankar | alsroot, ok. Will do that from now. | 17:54 |
| alsroot | dipankar: then I dunno why it didn't fail any errors (except you posted) | 17:54 |
| dfarning | dipankar, yes. Bernie set up patchwork a couple of days ago to help keep track of patches. I just wanted to make sure that you guys were keeping track of your patches. | 17:54 |
| dipankar | dfarning, manusheel : Aren't tomeu's guidelines for patches same as Sascha's? | 17:54 |
| alsroot | dipankar: could you add debug logging to create_palette and try to right click on joural button to see if your debug was logged | 17:55 |
| dfarning | dipankar, yes. | 17:55 |
| dipankar | alsroot, you want me to add a debug logging in the func so that if the function is called, a message is sent to log | 17:59 |
| dipankar | ? | 17:59 |
| alsroot | dipankar: yup, just to be sure that your create_palette was called | 18:01 |
| dipankar | alsroot, I added a line: logging.debug('Right Click') | 18:09 |
| dipankar | alsroot, but that message is not appearing in shell.log | 18:09 |
| alsroot | dipankar: is your loglevel DEBUG? | 18:10 |
| dipankar | alsroot, didn't get your question | 18:11 |
| dipankar | alsroot, shall I try changing the Level to info? | 18:11 |
| alsroot | dipankar: did you set log level to debug, I meant, http://wiki.sugarlabs.org/go/BugSquad/Get_Logs#Enabling_Sugar_debug_logging | 18:13 |
| alsroot | dipankar: otherwise you won't see debug() messages | 18:13 |
| dipankar | alsroot, I have already done the settings required | 18:14 |
| dipankar | afair | 18:14 |
| alsroot | dipankar: got it, see where JournalButton is created, code sets palette manually | 18:17 |
| dipankar | alsroot, JournalButton is created? I am unable to get there. please give me two more minutes | 18:23 |
| alsroot | dipankar: just grep for "JournalButton(" | 18:24 |
| dipankar | alsroot, doing | 18:24 |
| dipankar | alsroot, found it | 18:25 |
| dipankar | volumestoolbar.py; line 46 | 18:26 |
| dipankar | alsroot, ? | 18:30 |
| alsroot | dipankar: as you can see, it sets palette manually, thus your create_palette won't be called | 18:30 |
| dipankar | alsroot, as in button.set_palette(Palette(_('Journal'))) right? | 18:31 |
| alsroot | yup | 18:31 |
| dipankar | alsroot, that means i need to change it here, perhaps change the argument. | 18:32 |
| alsroot | dipankar: just remove this line and let create_palette work | 18:32 |
| dipankar | so that it calls the JournalButton.create_palette() | 18:32 |
| dipankar | alsroot, ok | 18:33 |
| dipankar | alsroot, now nothing is showing up | 18:34 |
| alsroot | dipankar: see shell.log | 18:34 |
| dipankar | alsroot, I think we are expecting this: http://paste.ubuntu.com/500460/ | 18:37 |
| alsroot | well, not me :) | 18:38 |
| dipankar | alsroot, I can find create_palette being called. but how come 'global name 'JournalPalette' is not defined' | 18:41 |
| dipankar | ?? | 18:41 |
| alsroot | dipankar: just read error message, python dunno what is "JournalPalette" | 18:42 |
| alsroot | dipankar: did you import this symbol before? | 18:42 |
| dipankar | alsroot, here : from jarabe.view.palettes import VolumePalette | 18:43 |
| dipankar | ^^ JournalPalette is missing | 18:43 |
| alsroot | dipankar: but there is JournalPalette? | 18:43 |
| dipankar | alsroot, how about: from jarabe.view.palettes import VolumePalette, JournalPalette ? | 18:44 |
| alsroot | if jarabe.view.palettes contains JournalPalette then it should work | 18:44 |
| dipankar | alsroot, ^^ yes it is there. crosschecked | 18:46 |
| dipankar | alsroot, now this error : NameError: global name 'home_activity' is not defined | 18:47 |
| alsroot | dipankar: I guess error is obvious :) | 18:47 |
| dipankar | alsroot, shall i pass no argument then? | 18:48 |
| alsroot | dipankar: see JournalPalette sources | 18:48 |
| dipankar | alsroot, I can't leave it blank | 18:54 |
| dipankar | :( | 18:54 |
| dipankar | it takes exactly two arguments | 18:55 |
| alsroot | dipankar: yup, btw do you really need JournalPalette | 19:01 |
| dipankar | alsroot, I tried some argument: self._home_activity -- not working | 19:01 |
| dipankar | alsroot, I guess no | 19:01 |
| alsroot | dipankar: hmm, does JournalButton have self._home_activity? | 19:01 |
| dipankar | alsroot, no.. | 19:02 |
| dipankar | alsroot, How can I pass an argument? :P | 19:05 |
| dipankar | * I mean which argument to pass | 19:05 |
| alsroot | dipankar: just grep source for all JournalPalette objects to know what its argument is | 19:06 |
| alsroot | ..and where you can find this argument | 19:06 |
| alsroot | ..or ask yourself, do you really need JournalPalette and maybe bettert ot implement new palette class w/ just free space progress bar | 19:07 |
| dipankar | alsroot, I would like the second option. | 19:08 |
| dipankar | alsroot, since I need to display only volume, not the other options | 19:08 |
| alsroot | dipankar: so, go ahead :), use JournalPalette as an example of progress bar | 19:09 |
| dipankar | alsroot, but, what was the home_activity about then? | 19:12 |
| alsroot | dipankar: Activity class | 19:13 |
| alsroot | ..object | 19:13 |
| dipankar | alsroot, then I need to send some argument, don't i? | 19:15 |
| dipankar | * I will be making a new palette, but I really want to know what can I pass in the argument..:) | 19:16 |
| alsroot | dipankar: grep for all JournalPalette invocations to see what its argument is | 19:17 |
| dipankar | self._home_activity | 19:17 |
| dipankar | alsroot, ^^ | 19:18 |
| alsroot | dipankar: well, grep for "self._home_activity =" to know where it was set | 19:18 |
| dipankar | ok | 19:19 |
| dipankar | alsroot, | 19:20 |
| dipankar | /usr/share/pyshared/jarabe/frame/activitiestray.py: self._home_activity = home_activity | 19:20 |
| dipankar | /usr/share/pyshared/jarabe/view/palettes.py: self._home_activity = home_activity | 19:20 |
| dipankar | /usr/share/pyshared/jarabe/view/palettes.py: self._home_activity = home_activity | 19:20 |
| dipankar | /usr/share/pyshared/jarabe/desktop/favoritesview.py: self._home_activity = self._home_model.get_active_activity() | 19:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!