[00:18] dfarning:http://wiki.sugarlabs.org/go/Community/Distributions/Ubuntu#VirtualBox_appliance_of_UbuntuSugarRemix it is just finishing uploading now 30 min to go [00:19] defarning: It turns out that it was specifiic to one netbook [00:19] no booting [00:21] satellit_, Ok thanks. The underlying maverick code is changing pretty fast so I hesitate to did too far into the non sugar specific stuff. [00:21] virtual box appliance works nicely though [00:22] dfarning: It is easy to install updates and post them as we go..... [00:23] dinner....afk [00:45] dfarning: All files Uploaded [02:24] dfarning: Did DL of USR appliance and imported it...Works well here [02:24] satellit_, nice [02:24] http://wiki.sugarlabs.org/go/Emulator_image_files#VirtualBox === manusheel is now known as manusheel_afk === dfarning is now known as dfarning_afk === dfarning_afk is now known as dfarning [14:56] * dipankar says hi to all [14:59] dipankar, ishan: Hello. [14:59] ishan, hi [14:59] manusheel: Hello [14:59] dipankar, hi [15:00] dipankar: First, can you explain Ishan the steps to merge the patch with the mainline git. As you explain, I'll add the steps in a doc file for future reference. [15:00] ishan_, continuing with last night's bug [15:00] manusheel, ok [15:00] dipankar, sure [15:00] ishan_, lets first discuss how I make the patch [15:01] dipankar, sure [15:01] ishan_, First you need to clone the mainline git repo of the package you are targeting to modify [15:02] dipankar, okay [15:03] dipankar, by this you mean the folder i which we are making changes [15:03] for e.g to modify the sugar package files: here is the mainline git repository: http://git.sugarlabs.org/projects/sugar/repos/mainline [15:03] dipankar, okay [15:04] ishan_, patches based on this mainline git repo will be accepted as the patches created from here can be added directly. [15:04] okay [15:05] dipankar: Team members have this question on the location where you clone the repository. What do you have to recommend in this matter? [15:05] ishan_, I don't know much in detail, but Shascha always wanted the patches based on mainline so that he can apply them. [15:05] manusheel, ok sir. [15:05] dipankar, okay [15:06] manusheel, ishan_: I generally clone them in a folder named 'test-s' [15:06] in home folder [15:06] which in home folder [15:06] home folder of Ubuntu [15:07] dipankar, okay [15:07] its similar to cloning any git repo [15:07] dipankar, is it same as we had done for Lp [15:08] ishan_, to make things clear. Lets suppose for debian packages, you needed to create a patch, which repo will you use? [15:09] dipankar, i think the repo for the package present in debian [15:09] ishan_, great [15:10] ishan_, similarly, if you want to contribute directly to Sugar, where would you base your patch? [15:10] dipankar, in the suga repo [15:10] suga/sugar [15:10] ishan, nice. [15:11] dipankar, okay i got it [15:11] ishan, I think by now you must have got what I wanted to explain :) [15:11] dipankar, yes [15:11] remember this hierarchy: [15:11] Sugar [15:11] V [15:11] Debian [15:11] V [15:11] Ubuntu [15:12] okay [15:12] dipankar, can you also explain the patch numbering system [15:12] ishan, patch numbering? [15:13] dipankar, what i meant was V1,V2 ......which you did for your patch [15:14] ishan_, ok the patch versioning [15:14] dipankar, yep [15:14] ishan_, the first patch you submit is always v1. [15:15] ishan_, if you modify it and upload a new one, then has to indicate that the on you are sending right now is not the first [15:15] dipankar, okay [15:16] ishan_, in addition to your versions, you also need to mention a snap of previous versions in the changelog, [15:16] dipankar, can you explain ^^ [15:16] e.g v1 was Reviewed-By Sascha Silbe [15:16] dipankar, okay [15:16] changelog is similar to the one in packages, but these are onliner [15:16] *one liners [15:16] dipankar, okay [15:18] just to inform the developers that your previous version was reviewed by another developer [15:18] dipankar, like you submitted your V1 for review and had to make some changes for V2- so do we have to make changes in the V1 file or we have to make changes in the orignal file [15:18] in order to make V2 patch [15:20] ishan_, ohk, [15:20] for that follow this simple process: [15:20] - first reset the file that you modified [15:20] using , git reset in the repo [15:20] dipankar, okay [15:21] - after completing the modifications add it for commit [15:21] using git add [15:21] - then run git commit --amend [15:21] dipankar, okay means we are making the V2 patch also from the original file [15:21] yes [15:22] ishan_, otherwise it will be a very long process [15:22] alsroot, ping [15:22] dipankar, and for git reset we just run git reset command [15:22] or there are some attributes to be added [15:22] ishan_, sorry I forgot to add them in quotes. [15:22] git reset [15:23] git add [15:23] git commit --amend [15:23] dipankar, got it [15:23] no more flags to be sent [15:23] dipankar, okay [15:25] ishan_: Now, try these steps for the bundle id issue, and send the steps to the team in a documented format. [15:25] ishan_: You can take up any other issue too that you are more comfortable with. The idea is understanding this process. [15:30] dipankar: In reference to your question, which file are you looking at? [15:30] * dipankar is making patch for : http://bugs.sugarlabs.org/ticket/2180 [15:30] manusheel, that depends on the patch I want to make [15:31] dipankar: I was referring to your yesterday's query on right click key handler. [15:31] manusheel, like for the above bug I need: jarabe/util/emulator.py [15:32] dipankar, while making the patch the normal procedure has to be followed right? [15:33] ishan, yes, git commit -> write the commit message and save-> then git format-patch HEAD^1 [15:34] ishan: yes. [15:34] same steps. [15:47] dipankar, manusheel: check the mail [15:49] ishan_, nice [15:49] dipankar, thanks sir [15:49] * dipankar wonders what [A [B is? [15:49] ishan_, where did you send the e-mail btw? [15:49] dipankar, only to you [15:50] ishan, ohk [15:50] dipankar, these [A [B were due to the arrow keys pressed [15:52] ishan, ok [15:53] * ishan_ is away for 10mins [16:03] * ishan_ is back [16:06] alsroot: hi [16:06] around ? [16:07] manusheel_, sir, I am looking for the file containing the key handlers, or in jarabe/view/ dir [16:08] dipankar: Ok. Coming to that directory. [16:14] manusheel_, I think this file might be useful: jarabe/journal/objectchooser.py [16:14] kandarpk: pong [16:14] dipankar: Why do see this file would be useful? [16:15] manusheel_, sir, it has some statements like : self.tree_view.connect('button-release-event', [16:15] self.__button_release_event_cb) [16:16] not sure though [16:16] alsroot: can you help me with #2323 [16:16] kandarpk, sir i am working on bug #1858 [16:16] kandarpk: whats the problem? [16:16] Launchpad bug 1858 in gajim "gajim look and feel" [Undecided,Fix released] https://launchpad.net/bugs/1858 [16:16] kandarpk, can you provide me any pointers on that [16:17] alsroot: I dont know how to work with clpboard [16:17] manusheel_, let kandarpk finish discussing with alsroot, then I will ask him. Meanwhile I will try to dig in more [16:17] dipankar: Ok. Yes, those functions seem useful. [16:19] * alsroot didn't work w/ clipboard as well [16:19] ishan, please see http://lists.sugarlabs.org/archive/sugar-devel/2010-September/027094.html [16:19] it has some replies as well [16:20] kandarpk, okay [16:20] kandarpk: you can grab some info in gtk docs, http://library.gnome.org/devel/gtk/stable/gtk-Clipboards.html [16:20] alsroot, ok, thanks. [16:21] alsroot, I am still working on the volume display in journal view [16:21] alsroot, I want to check where I can add a right click option for the journal icon in the journal view [16:22] dipankar: you don't need to code it directly, just add create_palette method to create button palette, the rest will be processed by existed code (invoker created by parent class) [16:23] alsroot, I already added the create_palette(). but it seems that it is not working [16:23] dipankar: did sugar log any errors? [16:24] alsroot, no [16:24] alsroot, let me check once again [16:27] alsroot, today it is showing some error: http://paste.ubuntu.com/500386/ [16:28] alsroot, sorry about my denial to errors first :( [16:30] dipankar: does this error happen after right clicking on journal button? [16:30] alsroot, yes [16:32] dipankar: could you pastebin your patch [16:32] alsroot, the strange thing is, sometimes the error comes and sometimes it doesnt' [16:33] alsroot, just asec [16:34] alsroot, http://paste.ubuntu.com/500389/ [16:35] alsroot, I will back after sometime. Going for dinner [16:35] * dipankar is off for dinner [17:28] * ishan_ is away for dinner [17:41] mukul: Hi Mukul. [17:41] Around? === dipankar_ is now known as dipankar [17:50] alsroot, sorry, I got disconnected. [17:50] dfarning, around? [17:50] manusheel, around? [17:50] dipankar: Hi Dipankar. [17:51] dipankar, yes [17:51] dipankar: Did we send the patch to sugar-devel? [17:51] manusheel, yes sir. The patch for fullscreen bug has already been sent [17:52] dipankar: Great. [17:52] dipankar: could pasterbin your entirely patch (`git diff`) otherwise I dunno how code you posted before is intended to work(there are missed symbols) [17:52] dfarning, just came across your e-mail on tomeu's guidelines [17:53] alsroot, I just added the whole create_palette(). nothing more [17:53] alsroot, the original code is without the whole function [17:53] dipankar: anyway it is more useful practice to pastebin a patch not a piece of code [17:53] * ishan_ is back [17:54] alsroot, ok. Will do that from now. [17:54] dipankar: then I dunno why it didn't fail any errors (except you posted) [17:54] dipankar, yes. Bernie set up patchwork a couple of days ago to help keep track of patches. I just wanted to make sure that you guys were keeping track of your patches. [17:54] dfarning, manusheel : Aren't tomeu's guidelines for patches same as Sascha's? [17:55] dipankar: could you add debug logging to create_palette and try to right click on joural button to see if your debug was logged [17:55] dipankar, yes. [17:59] alsroot, you want me to add a debug logging in the func so that if the function is called, a message is sent to log [17:59] ? [18:01] dipankar: yup, just to be sure that your create_palette was called [18:09] alsroot, I added a line: logging.debug('Right Click') [18:09] alsroot, but that message is not appearing in shell.log [18:10] dipankar: is your loglevel DEBUG? [18:11] alsroot, didn't get your question [18:11] alsroot, shall I try changing the Level to info? [18:13] dipankar: did you set log level to debug, I meant, http://wiki.sugarlabs.org/go/BugSquad/Get_Logs#Enabling_Sugar_debug_logging [18:13] dipankar: otherwise you won't see debug() messages [18:14] alsroot, I have already done the settings required [18:14] afair [18:17] dipankar: got it, see where JournalButton is created, code sets palette manually [18:23] alsroot, JournalButton is created? I am unable to get there. please give me two more minutes [18:24] dipankar: just grep for "JournalButton(" [18:24] alsroot, doing [18:25] alsroot, found it [18:26] volumestoolbar.py; line 46 [18:30] alsroot, ? [18:30] dipankar: as you can see, it sets palette manually, thus your create_palette won't be called [18:31] alsroot, as in button.set_palette(Palette(_('Journal'))) right? [18:31] yup [18:32] alsroot, that means i need to change it here, perhaps change the argument. [18:32] dipankar: just remove this line and let create_palette work [18:32] so that it calls the JournalButton.create_palette() [18:33] alsroot, ok [18:34] alsroot, now nothing is showing up [18:34] dipankar: see shell.log [18:37] alsroot, I think we are expecting this: http://paste.ubuntu.com/500460/ [18:38] well, not me :) [18:41] alsroot, I can find create_palette being called. but how come 'global name 'JournalPalette' is not defined' [18:41] ?? [18:42] dipankar: just read error message, python dunno what is "JournalPalette" [18:42] dipankar: did you import this symbol before? [18:43] alsroot, here : from jarabe.view.palettes import VolumePalette [18:43] ^^ JournalPalette is missing [18:43] dipankar: but there is JournalPalette? [18:44] alsroot, how about: from jarabe.view.palettes import VolumePalette, JournalPalette ? [18:44] if jarabe.view.palettes contains JournalPalette then it should work [18:46] alsroot, ^^ yes it is there. crosschecked [18:47] alsroot, now this error : NameError: global name 'home_activity' is not defined [18:47] dipankar: I guess error is obvious :) [18:48] alsroot, shall i pass no argument then? [18:48] dipankar: see JournalPalette sources [18:54] alsroot, I can't leave it blank [18:54] :( [18:55] it takes exactly two arguments [19:01] dipankar: yup, btw do you really need JournalPalette [19:01] alsroot, I tried some argument: self._home_activity -- not working [19:01] alsroot, I guess no [19:01] dipankar: hmm, does JournalButton have self._home_activity? [19:02] alsroot, no.. [19:05] alsroot, How can I pass an argument? :P [19:05] * I mean which argument to pass [19:06] dipankar: just grep source for all JournalPalette objects to know what its argument is [19:06] ..and where you can find this argument [19:07] ..or ask yourself, do you really need JournalPalette and maybe bettert ot implement new palette class w/ just free space progress bar [19:08] alsroot, I would like the second option. [19:08] alsroot, since I need to display only volume, not the other options [19:09] dipankar: so, go ahead :), use JournalPalette as an example of progress bar [19:12] alsroot, but, what was the home_activity about then? [19:13] dipankar: Activity class [19:13] ..object [19:15] alsroot, then I need to send some argument, don't i? [19:16] * I will be making a new palette, but I really want to know what can I pass in the argument..:) [19:17] dipankar: grep for all JournalPalette invocations to see what its argument is [19:17] self._home_activity [19:18] alsroot, ^^ [19:18] dipankar: well, grep for "self._home_activity =" to know where it was set [19:19] ok [19:20] alsroot, [19:20] /usr/share/pyshared/jarabe/frame/activitiestray.py: self._home_activity = home_activity [19:20] /usr/share/pyshared/jarabe/view/palettes.py: self._home_activity = home_activity [19:20] /usr/share/pyshared/jarabe/view/palettes.py: self._home_activity = home_activity [19:20] /usr/share/pyshared/jarabe/desktop/favoritesview.py: self._home_activity = self._home_model.get_active_activity()