| JanCBorchardt | mpt, godbyk, thorwil, vish: I can't come to the meeting today because I'm in another one. But I found a great article / interview with my current employer in which he talks about the very issues we discussed last week: http://dot.kde.org/2006/12/01/looking-back-three-years-openusability-jan-m%C3%BChlig | 10:35 |
|---|---|---|
| mpt | thanks JanCBorchardt | 10:37 |
| === bilalakhtar_ is now known as bilalakhtar | ||
| === MacSlow is now known as MacSlow|lunch | ||
| === rgreening_ is now known as rgreening | ||
| thorwil | godbyk: ping | 13:15 |
| === MacSlow|lunch is now known as MacSlow | ||
| ronoc | Cimi, got it working | 14:47 |
| ronoc | will be released hopefully later on today | 14:48 |
| Cimi | great | 14:48 |
| Cimi | what did you change? | 14:48 |
| JanCBorchardt | godbyk, thorwil, vish: were you at the meeting today and got a log? | 15:43 |
| vish | JanCBorchardt: oops! not me.. | 15:44 |
| vish | JanCBorchardt: hmm, seems nothing interesting either, only links you gave ;p | 15:45 |
| JanCBorchardt | vish: :D | 15:47 |
| JanCBorchardt | vish: oh and do you have a gitorious account? I made a repo for Ayatana-UX | 15:51 |
| vish | JanCBorchardt: yea, i have an account, when you that discussed, was it last meeting? i seem to have missed that too :( | 15:51 |
| vish | s/you/was | 15:51 |
| JanCBorchardt | vish: no problem, what is it? I'll give you full rights on the repo | 15:52 |
| vish | JanCBorchardt: "vish" | 15:53 |
| thorwil | JanCBorchardt: the meeting pretty much did not happen | 15:56 |
| JanCBorchardt | vish: could have figured that ... ;) | 16:41 |
| JanCBorchardt | vish: you're in | 16:42 |
| Cimi | someone to ping davidbarth :) | 17:16 |
| Cimi | seb128: could you summon david? :) | 17:20 |
| seb128 | he's on this channel | 17:21 |
| Cimi | ok | 17:21 |
| seb128 | davidbarth, ^ | 17:21 |
| Cimi | now he answered :) | 17:21 |
| davidbarth | i'm here, i'm here ;) | 17:21 |
| Cimi | bratsche: super-important-ping | 17:34 |
| bratsche | Cimi: super-duper-ueber-important-pong | 17:35 |
| Cimi | ahah | 17:36 |
| Cimi | bratsche: gtk_widget_set_size_request for icons does take MAX (width, height) and sets the MIN to the max in order to create a "square" | 17:37 |
| Cimi | something like: gint lenght = MAX (width, height); gtk_widget_set_size_request (widget, lenght, lenght) | 17:38 |
| Cimi | this is the reason of the vertical padding in indicator-messages | 17:39 |
| Cimi | we are adding a horizontal padding in order to leave the triangle separated from the icon, but gtk+ adds vertical padding too | 17:39 |
| Cimi | any clue? | 17:39 |
| Cimi | bratsche: | 17:42 |
| bratsche | I guess I don't really understand what the problem is. | 17:44 |
| Cimi | it is ignoring one of the two sizes | 17:45 |
| Cimi | we want width 28 and height 22 | 17:45 |
| Cimi | but we have 28x28 | 17:45 |
| Cimi | bratsche: ^^ | 17:46 |
| bratsche | So I guess we can change the size request to do what we need it to do then. | 17:47 |
| Cimi | exactly dude! | 17:48 |
| Cimi | I don't think it will be difficult | 17:49 |
| bratsche | Cimi: I don't see anything like that in indicator-messages.c, but I guess you have a better idea of what's going on with this than I do. | 17:55 |
| Cimi | bratsche: search for gtk_widget_Set_size_request in new_application_item | 17:58 |
| bratsche | Yeah, I did.. but it's not setting it to [ length, length ] as you described.. it's setting it to [ width + 7, height ] | 18:00 |
| bratsche | Cimi: I'm heading out for lunch right now.. but if you come up with some better values for this, just submit a merge request. | 18:01 |
| Cimi | bratsche: | 18:04 |
| Cimi | but basically it becomes width+7 width +7 | 18:04 |
| Cimi | if you remove the +7 from width you'll see the vertical padding will disappear | 18:05 |
| Cimi | bratsche: in other words the issue is not in indicator-messages but seems gtk+ itself | 18:30 |
| Cimi | super strange | 18:32 |
| bratsche | Is there some mockup somewhere that you can show side-by-side against a screenshot of what's happening? Because I still don't understand. | 18:32 |
| Cimi | if I set gtk_widget_set_size_request (icon, width+20, height); it's like if I did gtk_widget_set_size_request (icon, width+20, width+20); | 18:33 |
| Cimi | (so width = width+20, height=width+20) | 18:33 |
| Cimi | otherwise, if I set gtk_widget_set_size_request (icon, width, height+20); | 18:33 |
| Cimi | it works as it should | 18:34 |
| Cimi | so I have width = width and height=height+20 | 18:34 |
| Cimi | width and height of the new resized widget, of course | 18:34 |
| Cimi | davidbarth: ^^ | 18:34 |
| Cimi | gtk+ bug maybe? | 18:34 |
| bratsche | I don't think that's a bug, that seems like a design choice to me. | 18:35 |
| bratsche | And it seems kind of sensible to me, actually. | 18:35 |
| Cimi | why? | 18:37 |
| Cimi | why this different behaviour for width and height? | 18:37 |
| Cimi | bratsche: ^^ | 18:37 |
| bratsche | It seems like it's trying to enforce some kind of sizing policy on icons within menuitems, which doesn't really strike me as very strange at all. | 18:38 |
| bratsche | Otherwise you have a bunch of icons which are the same width, and then suddenly you have one icon that's three times as wide as the others. | 18:39 |
| Cimi | no | 18:39 |
| Cimi | i don't think it gets resized | 18:39 |
| Cimi | scaled ops | 18:39 |
| Cimi | just add padding | 18:39 |
| bratsche | Okay. | 18:42 |
| bratsche | Either way, if this does require a change at the gtk+ level then I think we shouldn't waste time with it at this stage. Maybe davidbarth should make that call, but my feeling is that seb128 is not likely to accept such a change so late in the cycle so it may be better to defer this work until Natty. | 18:43 |
| Cimi | I can understand | 18:44 |
| Cimi | everything started from Mark | 18:44 |
| Cimi | because he doesn't like icons inside indicator-messages | 18:44 |
| Cimi | but if we increase the size of them, then the triangle on the left touches the icon | 18:45 |
| Cimi | so we need to add padding, and in order to add padding we are changing the size of the icon in the gtk_image_menu_item | 18:45 |
| Cimi | but, as said, we are exposing this gtk+ *bug* or whatever | 18:45 |
| davidbarth | right, i have that working by using PNGs instead of SVGs | 18:46 |
| Cimi | davidbarth: your approach doesn't work man | 18:46 |
| davidbarth | well, why does it work on my system then? | 18:46 |
| davidbarth | can you reproduce it or not? | 18:46 |
| Cimi | no | 18:46 |
| davidbarth | ?! | 18:46 |
| davidbarth | ah | 18:47 |
| Cimi | your icon touches the triangle | 18:47 |
| Cimi | it's like a 22x22 icon without the padding | 18:47 |
| davidbarth | Cimi: but is it larger? | 18:47 |
| Cimi | it is a 22x22 icon without the padding | 18:47 |
| Cimi | don't know why | 18:47 |
| Cimi | but my branch without the padding is exactly the same as yours | 18:47 |
| Cimi | let me sshot it | 18:47 |
| davidbarth | Cimi: can you share the icons i sent you with bratsche and see if he can get a larger mail icon on his own system? | 18:49 |
| davidbarth | i need to pop out | 18:49 |
| davidbarth | later | 18:49 |
| bratsche | Later davidbarth | 18:52 |
| Cimi | http://dl.dropbox.com/u/175266/indicator-messages.png | 18:53 |
| Cimi | davidbarth: ^^ | 18:53 |
| Cimi | 22x22 | 18:53 |
| Cimi | bratsche: show him the sshot later | 18:56 |
| Cimi | I might be at the movie theater :) | 18:57 |
| Cimi | here is 8 pm | 18:57 |
| bratsche | Okay cool. | 18:57 |
| bratsche | Enjoy | 18:57 |
| Cimi | will come back at midnight here in chat | 18:57 |
| Cimi | but my server is always on | 18:57 |
| bratsche | Cimi around still? | 22:23 |
| bratsche | Cimi: Nevermind.. just check your email when you get home. :) | 23:01 |
| Cimi | bratsche: replied | 23:40 |
| bratsche | Cimi: Thanks | 23:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
