| thumper | wallyworld: better to add a comment than edit the description | 02:52 |
|---|---|---|
| thumper | then it becomes part of the conversation | 02:52 |
| wallyworld | thumper: ack | 02:52 |
| * thumper goes to make coffee before attacking error messages | 02:53 | |
| wallyworld | any one up for a review? https://code.edge.launchpad.net/~wallyworld/launchpad/windmill-1.3r1544/+merge/37209 | 03:39 |
| wallyworld | thumper: before you EOD, assuming your branch fixes are done, did you want to look at review-without-reviewer and hopefully approve? | 04:46 |
| * thumper will try | 04:48 | |
| * wallyworld says thanks as he migrates to the coffee machine for a hit | 05:05 | |
| === rockstar changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Hi adeuring, would you mind looking at this branch (it's got a bit of js): https://code.edge.launchpad.net/~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2/+merge/37114 | 09:02 |
| adeuring | noodles775: sure, I'll look | 09:02 |
| noodles775 | Thanks! | 09:02 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: noodles775 || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| noodles775 | adeuring: I've just updated the MP with some details (things I wasn't happy about code-wise, but can't see a way around). | 09:06 |
| adeuring | noodles775: thanks! | 09:06 |
| adeuring | noodles775: r=me; 1 nitpick | 10:00 |
| noodles775 | Great, thanks adeuring | 10:00 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | jelmer: How's the review of lp:~allenap/launchpad/structural-subscriptions-with-filters going? | 11:16 |
| jelmer | allenap: sorry, I suck. I have the review here, just not sent out yet. Let me dig it up. | 11:31 |
| allenap | jelmer: Cool, thanks :) | 11:32 |
| adeuring | allenap: I think the importance/status JOINs in your branch lp:~allenap/launchpad/structural-subscriptions-with-filters-2 are wrong | 11:47 |
| adeuring | see a comment in the MP | 11:48 |
| allenap | adeuring: Cool, thanks. | 11:48 |
| allenap | adeuring: There's some code earlier in getSubscriptionsForBug() that tries to select the relevant bug task. | 11:49 |
| adeuring | allenap: ah, right, I missed that! sorry for the noise | 11:50 |
| allenap | adeuring: No worries, thanks for looking at it. | 11:50 |
| adeuring | allenap: r=me | 12:12 |
| allenap | adeuring: Thanks! | 12:12 |
| === matsubara-afk is now known as matsubara | ||
| sinzui | jml: https://code.launchpad.net/~sinzui/launchpad/move-binaryandsourcepackagename-0/+merge/37258 is an apocalypse branch | 15:17 |
| === sinzui changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| sinzui | adeuring, I have a refactoring to clean the tree ^ | 15:44 |
| adeuring | sinzui: I'll look | 15:44 |
| === deryck is now known as deryck[lunch] | ||
| adeuring | sinzui: r=me | 16:04 |
| === adeuring changed the topic of #launchpad-reviews to: On call: adeuring || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| allenap | adeuring: Fancy a branch? | 16:04 |
| adeuring | allenap: sure | 16:04 |
| allenap | adeuring: https://code.edge.launchpad.net/~allenap/launchpad/structural-subscriptions-with-filters-3/+merge/37270 | 16:04 |
| allenap | Thanks :) | 16:04 |
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| adeuring | allenap: r=me | 16:39 |
| allenap | adeuring: Thank you :) | 16:39 |
| === Ursinha is now known as Ursinha-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| === matsubara-lunch is now known as matsubara | ||
| === Ursinha-lunch is now known as Ursinha | ||
| === salgado-lunch is now known as salgado | ||
| malaria | Hi, I would like a review of this: https://code.launchpad.net/~malaria/launchpad/fixes-bug-608631/+merge/37287 | 18:02 |
| malaria | adeuring, perhaps? | 18:02 |
| adeuring | malaria: its already EOD for me... | 18:04 |
| malaria | adeuring: ok, at least I tried ;) | 18:04 |
| === adeuring changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews abgeändert | ||
| === jcsackett|afk is now known as jcsackett_ | ||
| === salgado_ is now known as salgado | ||
| === You're now known as ubuntulog | ||
| jcsackett_ | anyone available to review this? https://code.edge.launchpad.net/~jcsackett/launchpad/kill-uses-launchpad-for-650648/+merge/37252 | 19:41 |
| jcsackett_ | it's pretty much all deletions; templates, some code, and stories. | 19:42 |
| jcsackett_ | sinzui: any chance you might have time for a review today? i got sidetracked and haven't been able to martial this through in a timely fashion: https://code.edge.launchpad.net/~jcsackett/launchpad/kill-uses-launchpad-for-650648/+merge/37252 | 20:32 |
| sinzui | I can | 21:03 |
| sinzui | let me finish fixing a botched merge first | 21:03 |
| jcsackett_ | sinzui: take your time; i won't be seeing it land till the weekend anyway. thanks! | 21:09 |
| sinzui | jcsackett_, ping | 21:18 |
| jcsackett_ | sinzui: pong. | 21:18 |
| sinzui | i think you can delete more from xx-product-launchpad-usage.txt. I see a check for +edit in th test. Products never use that page. maybe this whole test is not needed since Involvement replaces it | 21:19 |
| jcsackett_ | sinzui: i was actually thinking about that, but wasn't sure. | 21:20 |
| sinzui | well, I see some Involvement tests in it, but this is not a story. I see no mention of who is changing the state and why | 21:20 |
| sinzui | This is a dubious test | 21:20 |
| jcsackett_ | sinzui: i agree. i'm happy to remove it. | 21:21 |
| * jcsackett_ thinks. | 21:21 | |
| jcsackett_ | though i'll need to verify good involvment tests first. | 21:21 |
| sinzui | yes, verify it. This looks like state tests. the tests for the view that changes the state are very complete so we only care about explaining that an owner can enable/disable involvement links from applications using the menu or a link from the application root page. | 21:22 |
| jcsackett_ | sinzui: dig. i'll do that. | 21:23 |
| sinzui | I think project group also showed usages | 21:23 |
| * sinzui looks at lp-project | 21:23 | |
| jcsackett_ | sinzui: I'm not seeing anything like that on the mozilla overview page. | 21:25 |
| sinzui | We really need to remove the bug tracker from project group. you can set it, but it does nothing :( | 21:25 |
| * jcsackett_ nods. | 21:26 | |
| sinzui | jcsackett_, this looks good to land. Please review that test, I think its has lost its raison d'etra | 21:26 |
| jcsackett_ | sinzui: i will. | 21:26 |
| jcsackett_ | thanks. | 21:26 |
| === matsubara is now known as matsubara-afk | ||
| === jcsackett_ is now known as jcsackett | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!