=== Ursinha is now known as Ursinha-afk | ||
=== jtv1 is now known as jtv | ||
=== wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant(bug-653382-domination-series-restriction)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
wgrant | henninge: Thanks. Can you ec2 that? | 13:34 |
---|---|---|
henninge | wgrant: sure ;) | 13:34 |
wgrant | Thanks. | 13:34 |
bac | hi henninge, can you do a review for me? | 14:03 |
henninge | HI bac, sure. | 14:03 |
bac | henninge: cool. it's in the usual place. :) | 14:04 |
henninge | bac: you can help me with one, too. I was just looking at our style guide. | 14:04 |
=== bac changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant,wgrant,bac] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
bac | henninge: i'll try | 14:04 |
henninge | bac: https://code.edge.launchpad.net/~wgrant/launchpad/bug-629921-packages-empty-filter/+merge/37339 | 14:05 |
wgrant | I was wondering about that myself. | 14:07 |
wgrant | The style guide wasn't exactly clear. | 14:07 |
bac | henninge, wgrant: the style guide seems clear to me, though i'm not defending it in this case. | 14:09 |
henninge | bac, wgrant: Sorry, got distracted. Yes, that's exactly what I was about to ask ... ;) | 14:09 |
henninge | bac: I see the use of "any" a similar border case. | 14:10 |
henninge | e.g. I have been writing code lately like this "if translations is not None and any(translations):" to check for empty strings or none in translations. | 14:12 |
bac | wgrant: why do you care if requested_name_filter[0] is None or not? why not just return requested_name_filter[0], after checking that it exists? | 14:19 |
bac | i mean: if len(requested_name_filter) > 0: return requested_name_filter[0] | 14:20 |
bac | you return None when the test fails anyway | 14:20 |
wgrant | bac: I want to return None if it's "". | 14:20 |
wgrant | That's the whole point of the bug. | 14:20 |
bac | wgrant: well, yeah, there is that... :) | 14:21 |
wgrant | Heh. | 14:21 |
bac | wgrant: then i think lifeless' suggestion is the cleanest, PSG be damned | 14:21 |
wgrant | Great, thanks. | 14:21 |
wgrant | Can someone please bless and land that, then? | 14:22 |
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
henninge | wgrant: approved. I'll land both your branches. | 14:26 |
wgrant | Thanks henninge, bac. | 14:27 |
allenap | henninge: Would you be able to review my branch? I can't be here unfortunately, so please say no if that's a problem. | 14:43 |
=== allenap changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bac || queue: [allenap?] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
henninge | allenap: put it in the queue and I'll try. ;) | 14:44 |
bac | mrevell: can you do a text review of https://code.edge.launchpad.net/~bac/launchpad/bug-639703-pg-bugs/+merge/37463 ? | 14:45 |
mrevell | sure bac | 14:46 |
bac | thanks | 14:46 |
henninge | bac: You are creating a view purely to have it aggregate an "official_malone" property? | 15:42 |
henninge | bac: I think this is something the ProjectGroup class should do - and thus the tests should be for that class, too. | 15:43 |
henninge | bac: I mean, thre should be a ProjectGroup.official_malone property that loops through the product, as does the view now. | 15:46 |
henninge | s/product/products/ | 15:46 |
=== deryck is now known as deryck[lunch] | ||
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: allenap, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
=== Ursinha-afk is now known as Ursinha | ||
=== matsubara is now known as matsubara-lunch | ||
=== deryck[lunch] is now known as deryck | ||
=== salgado is now known as salgado-lunch | ||
=== gary_poster is now known as gary-lunch | ||
=== benji is now known as benji-lunch | ||
=== matsubara-lunch is now known as matsubara | ||
henninge | abentley: Hi! | 18:21 |
abentley | henninge: hi! | 18:21 |
henninge | abentley: I ran late and cannot start on Gavin's branch as I had intended. Can you take it, although he's not here? | 18:22 |
abentley | henninge: okay. | 18:22 |
henninge | He said it's ok if we don't do it because he's not here. | 18:22 |
henninge | abentley: thanks! | 18:22 |
=== henninge changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
henninge | abentley: good bye ;) | 18:23 |
abentley | henninge: bye! | 18:23 |
=== salgado-lunch is now known as salgado | ||
=== gary-lunch is now known as gary_poster | ||
=== benji-lunch is now known as benji | ||
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
jcsackett | abentley: do you have time to look at an MP with literally one line change? https://code.edge.launchpad.net/~jcsackett/launchpad/messages-translated-652264/+merge/37508 | 20:17 |
abentley | jcsackett: r=me | 20:21 |
jcsackett | thanks, abentley. | 20:21 |
=== gary_poster is now known as gary-brb | ||
=== matsubara is now known as matsubara-afk | ||
=== gary-brb is now known as gary_poster | ||
=== salgado is now known as salgado-afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!