/srv/irclogs.ubuntu.com/2010/10/04/#launchpad-reviews.txt

=== Ursinha is now known as Ursinha-afk
=== jtv1 is now known as jtv
=== wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant(bug-653382-domination-series-restriction)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== wgrant changed the topic of #launchpad-reviews to: On call: - || Reviewing: - || queue: [wgrant,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant,wgrant] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
wgranthenninge: Thanks. Can you ec2 that?13:34
henningewgrant: sure ;)13:34
wgrantThanks.13:34
bachi henninge, can you do a review for me?14:03
henningeHI bac, sure.14:03
bachenninge: cool.  it's in the usual place.  :)14:04
henningebac: you can help me with one, too. I was just looking at our style guide.14:04
=== bac changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: - || queue: [wgrant,wgrant,bac] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
bachenninge: i'll try14:04
henningebac: https://code.edge.launchpad.net/~wgrant/launchpad/bug-629921-packages-empty-filter/+merge/3733914:05
wgrantI was wondering about that myself.14:07
wgrantThe style guide wasn't exactly clear.14:07
bachenninge, wgrant: the style guide seems clear to me, though i'm not defending it in this case.14:09
henningebac, wgrant: Sorry, got distracted. Yes, that's exactly what I was about to ask ... ;)14:09
henningebac: I see the use of "any" a similar border case.14:10
henningee.g. I have been writing code lately like this "if translations is not None and any(translations):" to check for empty strings or none in translations.14:12
bacwgrant: why do you care if requested_name_filter[0] is None or not?  why not just return requested_name_filter[0], after checking that it exists?14:19
baci mean:  if len(requested_name_filter) > 0: return requested_name_filter[0]14:20
bacyou return None when the test fails anyway14:20
wgrantbac: I want to return None if it's "".14:20
wgrantThat's the whole point of the bug.14:20
bacwgrant: well, yeah, there is that...  :)14:21
wgrantHeh.14:21
bacwgrant: then i think lifeless' suggestion is the cleanest, PSG be damned14:21
wgrantGreat, thanks.14:21
wgrantCan someone please bless and land that, then?14:22
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bac || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningewgrant: approved. I'll land both your branches.14:26
wgrantThanks henninge, bac.14:27
allenaphenninge: Would you be able to review my branch? I can't be here unfortunately, so please say no if that's a problem.14:43
=== allenap changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: bac || queue: [allenap?] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningeallenap: put it in the queue and I'll try. ;)14:44
bacmrevell: can you do a text review of https://code.edge.launchpad.net/~bac/launchpad/bug-639703-pg-bugs/+merge/37463 ?14:45
mrevellsure bac14:46
bacthanks14:46
henningebac: You are creating a view purely to have it aggregate an "official_malone" property?15:42
henningebac: I think this is something the ProjectGroup class should do - and thus the tests should be for that class, too.15:43
henningebac: I mean, thre should be a ProjectGroup.official_malone property that loops through the product, as does the view now.15:46
henninges/product/products/15:46
=== deryck is now known as deryck[lunch]
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to: On call: henninge, abentley || Reviewing: allenap, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== Ursinha-afk is now known as Ursinha
=== matsubara is now known as matsubara-lunch
=== deryck[lunch] is now known as deryck
=== salgado is now known as salgado-lunch
=== gary_poster is now known as gary-lunch
=== benji is now known as benji-lunch
=== matsubara-lunch is now known as matsubara
henningeabentley: Hi!18:21
abentleyhenninge: hi!18:21
henningeabentley: I ran late and cannot start on Gavin's branch as I had intended. Can you take it, although he's not here?18:22
abentleyhenninge: okay.18:22
henningeHe said it's ok if we don't do it because he's not here.18:22
henningeabentley: thanks!18:22
=== henninge changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
henningeabentley: good bye ;)18:23
abentleyhenninge: bye!18:23
=== salgado-lunch is now known as salgado
=== gary-lunch is now known as gary_poster
=== benji-lunch is now known as benji
=== abentley changed the topic of #launchpad-reviews to: On call: abentley || Reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
jcsackettabentley: do you have time to look at an MP with literally one line change? https://code.edge.launchpad.net/~jcsackett/launchpad/messages-translated-652264/+merge/3750820:17
abentleyjcsackett: r=me20:21
jcsackettthanks, abentley.20:21
=== gary_poster is now known as gary-brb
=== matsubara is now known as matsubara-afk
=== gary-brb is now known as gary_poster
=== salgado is now known as salgado-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!